This is to address the Coverity explicit null dereferenced warnings
by NULL returns from amdgpu_mes_ctx_get_offs* but without follow-up
Checks. Meanwhile refactor the code to keep only one *_get_gpu/cpu_addr.
Signed-off-by: Tim Huang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +-
drivers/
From: Dave Airlie
This is a partial revert of drm/amdgpu: Modify the contiguous flags behaviour.
This broke VCN AV1 decoding on radv video on GFX11.
On VCN4 only the first VCN block has AV1 decode support, so the kernel has
a hacky heurisitic to work out from the submitted IB if it's AV1.
YOU C
Am 24.07.24 um 09:02 schrieb Dave Airlie:
From: Dave Airlie
This is a partial revert of drm/amdgpu: Modify the contiguous flags behaviour.
This broke VCN AV1 decoding on radv video on GFX11.
On VCN4 only the first VCN block has AV1 decode support, so the kernel has
a hacky heurisitic to work
Am 24.07.24 um 09:06 schrieb Tim Huang:
This is to address the Coverity explicit null dereferenced warnings
by NULL returns from amdgpu_mes_ctx_get_offs* but without follow-up
Checks. Meanwhile refactor the code to keep only one *_get_gpu/cpu_addr.
Well nice that you are looking into that, but
Otherwise we won't get correct access to the IB.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index ec
[Public]
Hi Christian,
> -Original Message-
> From: Christian König
> Sent: Wednesday, July 24, 2024 3:35 PM
> To: Huang, Tim ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Koenig, Christian
>
> Subject: Re: [PATCH] drm/amdgpu: fix Coverity explicit null dereferenced
> warni
On Thu, 18 Jul 2024, Hans de Goede wrote:
> Hi Thomas,
>
> On 6/24/24 6:15 PM, Thomas Weißschuh wrote:
>> Hi Hans!
>>
>> thanks for your feedback!
>>
>> On 2024-06-24 11:11:40+, Hans de Goede wrote:
>>> On 6/23/24 10:51 AM, Thomas Weißschuh wrote:
The value of "min_input_signal" returne
[AMD Official Use Only - AMD Internal Distribution Only]
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Friday, July 19, 2024 9:40 PM
> To: Friedrich Vock
> Cc: Deucher, Alexander ; amd-
> g...@lists.freedesktop.org
> Subject: Re: [PATCH 00/34] GC per queue rese
On 24/07/2024 02:35, Marek Olšák wrote:
The reason is that our DCC requires 768K alignment in some cases. I
haven't read this patch series, but one way to do that is to align to
256K, overallocate by 512K, and then not use either 0, 256K, or 512K at
the beginning to get to 768K alignment.
Ah,
On 23/07/2024 14:25, Arunpravin Paneer Selvam wrote:
- Add a new start parameter in trim function to specify exact
address from where to start the trimming. This would help us
in situations like if drivers would like to do address alignment
for specific requirements.
- Add a new flag DR
Spurious events are seen, temporarily ignore the events altogether.
Signed-off-by: Lijo Lazar
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/
Am 24.07.24 um 10:16 schrieb Tvrtko Ursulin:
[SNIP]
Absolutely.
Absolutely good and absolutely me, or absolutely you? :)
You, I don't even have time to finish all the stuff I already started :/
These are the TODO points and their opens:
- Adjust amdgpu_ctx_set_entity_
Am 24.07.24 um 11:37 schrieb Matthew Auld:
On 24/07/2024 02:35, Marek Olšák wrote:
The reason is that our DCC requires 768K alignment in some cases. I
haven't read this patch series, but one way to do that is to align to
256K, overallocate by 512K, and then not use either 0, 256K, or 512K
at t
*** BLURB HERE ***
Sunil Khatri (3):
drm/amdgpu: add vcn ip dump ptr in vcn global struct
drm/amdgpu: add vcn_v3_0 ip dump support
drm/amdgpu: add print support for vcn_v3_0 ip dump
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 177 +
Add support for logging the registers in devcoredump
buffer for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 28 ++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm
Add pointer to the vcn ip dump in the vcn global structure
to be accessible for all vcn version via global adev.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/d
Add support of vcn ip dump in the devcoredump
for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 149 +-
1 file changed, 148 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/v
(Mail V2: Send to correct mailing list and CCing relevant people.)
On Tue, 25 Jun 2024 16:29:04 +0200, Greg Kroah-Hartman wrote:
> In the Linux kernel, the following vulnerability has been resolved:
>
> drm/amdgpu: add error handle to avoid out-of-bounds
>
> if the sdma_v4_0_irq_id_to_seq return
On 2024-07-23 20:30:08+, Deucher, Alexander wrote:
> > -Original Message-
> > From: Thomas Weißschuh
> > Sent: Tuesday, July 23, 2024 1:58 PM
> > To: Deucher, Alexander
> > Cc: amd-gfx@lists.freedesktop.org
> > Subject: Re: [PATCH 1/2] drm/amdgpu: properly handle vbios fake edid sizin
On 22/07/2024 16:13, Christian König wrote:
Am 22.07.24 um 16:43 schrieb Tvrtko Ursulin:
On 22/07/2024 15:06, Christian König wrote:
Am 22.07.24 um 15:52 schrieb Tvrtko Ursulin:
On 19/07/2024 16:18, Christian König wrote:
Am 19.07.24 um 15:02 schrieb Christian König:
Am 19.07.24 um 11:4
On 2024-07-23 16:51:21+, Alex Deucher wrote:
> The comment in the vbios structure says:
> // = 128 means EDID length is 128 bytes, otherwise the EDID length =
> ucFakeEDIDLength*128
>
> This fake edid struct has not been used in a long time, so I'm
> not sure if there were actually any boards
Use existing swap() function rather than duplicating its implementation.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30:
WARNING opportunity for swap().
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9573
Signed-off-by: Jiapeng
On 2024-07-23 16:51:20+, Alex Deucher wrote:
> The comment in the vbios structure says:
> // = 128 means EDID length is 128 bytes, otherwise the EDID length =
> ucFakeEDIDLength*128
>
> This fake edid struct has not been used in a long time, so I'm
> not sure if there were actually any boards
On Wed, Jul 24, 2024 at 4:00 AM Christian König
wrote:
>
> Otherwise we won't get correct access to the IB.
>
> Signed-off-by: Christian König
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3501
Fixes: e362b7c8f8c7 ("drm/amdgpu: Modify the contiguous flags behaviour")
Reviewed-by: Alex
There is a spelling mistake in a dml2_printf message. Fix it.
Signed-off-by: Colin Ian King
---
.../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_d
On 7/23/2024 4:02 PM, Philip Yang wrote:
On 2024-07-19 18:17, Xiaogang.Chen wrote:
From: Xiaogang Chen
When app unmap vm ranges(munmap) kfd/svm starts drain pending page fault and
not handle any incoming pages fault of this process until a deferred work item
got executed by default system wq
On Tue, 23 Jul 2024, Arunpravin Paneer Selvam
wrote:
> - Add a new start parameter in trim function to specify exact
> address from where to start the trimming. This would help us
> in situations like if drivers would like to do address alignment
> for specific requirements.
>
> - Add a new
get higher clock than required rather than
lower */
if (divider < DFS_DIVIDER_RANGE_2_START) {
---
base-commit: bd4bea5ab2bda37ddb092a978218c4d9b46927e6
change-id: 20240724-amdgpu-dml2-fix-float-enum-warning-again-647a33789138
Best regards,
--
Nathan Chancellor
On Wed, Jul 24, 2024 at 4:58 AM Jani Nikula wrote:
>
> On Thu, 18 Jul 2024, Hans de Goede wrote:
> > Hi Thomas,
> >
> > On 6/24/24 6:15 PM, Thomas Weißschuh wrote:
> >> Hi Hans!
> >>
> >> thanks for your feedback!
> >>
> >> On 2024-06-24 11:11:40+, Hans de Goede wrote:
> >>> On 6/23/24 10:51
On Wed, Jul 24, 2024 at 7:33 AM Sunil Khatri wrote:
>
> Add support of vcn ip dump in the devcoredump
> for vcn_v3_0.
>
> Signed-off-by: Sunil Khatri
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 149 +-
> 1 file changed, 148 insertions(+), 1 deletion(-)
>
> diff --git
On 7/24/2024 9:33 PM, Alex Deucher wrote:
On Wed, Jul 24, 2024 at 7:33 AM Sunil Khatri wrote:
Add support of vcn ip dump in the devcoredump
for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 149 +-
1 file changed, 148 insertions
Applied. Thanks!
On Wed, Jul 24, 2024 at 9:50 AM Colin Ian King wrote:
>
> There is a spelling mistake in a dml2_printf message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
> .../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
*= 1.0 + margin;
>
> - divider = (unsigned int)(DFS_DIVIDER_RANGE_SCALE_FACTOR *
> (vco_freq_khz / clock_khz));
> + divider = (unsigned int)((int)DFS_DIVIDER_RANGE_SCALE_FACTOR *
> (vco_freq_khz / clock_khz));
>
> /* we want to floor here to get higher clock than
Applied. Thanks!
Alex
On Wed, Jul 24, 2024 at 3:38 AM Jiapeng Chong
wrote:
>
> Use existing swap() function rather than duplicating its implementation.
>
> ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30:
> WARNING opportunity for swap().
>
> Reported-by: Abac
On Tue, Jul 23, 2024 at 2:34 AM Alex Deucher wrote:
> Do either of these patches help?
> https://patchwork.freedesktop.org/patch/605437/
Unfortunately, this patch didn't help. Please see the attached kernel log.
> https://patchwork.freedesktop.org/patch/605201/
For which kernel is this patch int
Add support of vcn ip dump in the devcoredump
for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 149 +-
1 file changed, 148 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/v
Add pointer to the vcn ip dump in the vcn global structure
to be accessible for all vcn version via global adev.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/d
Add macro definition which calculate offset of the
register with index override.
This is useful in case when there is an array of
registers which is common for all instances.
To read registers in that case it is easy to define
registers once and the index value is manually passed
to calculate prop
Add support for logging the registers in devcoredump
buffer for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 28 ++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm
Certain GPUs have better copy performance over xGMI on specific
SDMA engines depending on the source and destination GPU.
Allow users to create SDMA queues on these recommended engines.
Close to 2x overall performance has been observed with this
optimization.
v2: remove unnecessary crat updates an
On 2024-07-24 09:58, Chen, Xiaogang
wrote:
On 7/23/2024 4:02 PM, Philip Yang
wrote:
On 2024-07-19 18:17, Xiaogang.Chen
wrote:
From: Xiaogang Chen
When
On 2024-07-24 13:56, Jonathan Kim wrote:
Certain GPUs have better copy performance over xGMI on specific
SDMA engines depending on the source and destination GPU.
Allow users to create SDMA queues on these recommended engines.
Close to 2x overall performance has been observed with this
optimiza
From: Vitaly Prosyak
In the case of a queue reset, we need the ability to customize the
error code from -ECANCELED to -ENODATA for scenarios where the queue
reset is successful. It was decided to use -ECANCELED for GPU reset cases
and -ENODATA for queue reset cases. This change introduces an erro
From: Vitaly Prosyak
The current implementation of drm_sched_start uses a hardcoded -ECANCELED to
dispose of a job when
the parent/hw fence is NULL. This results in drm_sched_job_done being called
with -ECANCELED for
each job with a NULL parent in the pending list, making it difficult to
disti
MES firmware requires larger log buffer for gfx12. Allocate
proper buffer respectively for gfx11 and gfx12.
Signed-off-by: Michael Chen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 6 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 6 +++---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
On Wed, Jul 24, 2024 at 2:43 PM wrote:
>
> From: Vitaly Prosyak
>
> The current implementation of drm_sched_start uses a hardcoded -ECANCELED to
> dispose of a job when
> the parent/hw fence is NULL. This results in drm_sched_job_done being called
> with -ECANCELED for
> each job with a NULL pa
On 2024-07-19 18:17, Xiaogang.Chen wrote:
From: Xiaogang Chen
When app unmap vm ranges(munmap) kfd/svm starts drain pending page fault and
not handle any incoming pages fault of this process until a deferred work item
got executed by default system wq. The time period of "not handle page faul
On 2024-07-18 13:56, Jonathan Kim wrote:
Support per-queue reset for GFX9. The recommendation is for the driver
to target reset the HW queue via a SPI MMIO register write.
Since this requires pipe and HW queue info and MEC FW is limited to
doorbell reports of hung queues after an unmap failur
On Wed, Jul 24, 2024 at 4:34 PM Felix Kuehling wrote:
>
>
> On 2024-07-18 13:56, Jonathan Kim wrote:
> > Support per-queue reset for GFX9. The recommendation is for the driver
> > to target reset the HW queue via a SPI MMIO register write.
> >
> > Since this requires pipe and HW queue info and ME
On Mon, Jul 22, 2024 at 10:38:16AM +0200, Christian König wrote:
> This was basically just another one of amdgpus hacks. The parameter
> allowed to restart the scheduler without turning fence signaling on
> again.
>
> That this is absolutely not a good idea should be obvious by now since
> the fen
On Wed, 24 Jul 2024 at 23:32, Alex Deucher wrote:
>
> On Wed, Jul 24, 2024 at 4:00 AM Christian König
> wrote:
> >
> > Otherwise we won't get correct access to the IB.
> >
> > Signed-off-by: Christian König
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3501
> Fixes: e362b7c8f8c7 ("
On Thu, 25 Jul 2024 at 09:09, Dave Airlie wrote:
>
> On Wed, 24 Jul 2024 at 23:32, Alex Deucher wrote:
> >
> > On Wed, Jul 24, 2024 at 4:00 AM Christian König
> > wrote:
> > >
> > > Otherwise we won't get correct access to the IB.
> > >
> > > Signed-off-by: Christian König
> >
> > Closes: https
This commit addresses a null pointer dereference issue in the
`dcn20_program_pipe` function. The issue could occur when
`pipe_ctx->plane_state` is null.
The fix adds a check to ensure `pipe_ctx->plane_state` is not null
before accessing. This prevents a null pointer dereference.
Reported by smatc
This commit addresses a null pointer dereference issue in the
`commit_planes_for_stream` function at line 4140. The issue could occur
when `top_pipe_to_program` is null.
The fix adds a check to ensure `top_pipe_to_program` is not null before
accessing its stream_res. This prevents a null pointer d
From: Vitaly Prosyak
The current implementation of drm_sched_start uses a hardcoded -ECANCELED to
dispose of a job when
the parent/hw fence is NULL. This results in drm_sched_job_done being called
with -ECANCELED for
each job with a NULL parent in the pending list, making it difficult to
disti
On Wed, 24 Jul 2024 at 23:32, Alex Deucher wrote:
>
> On Wed, Jul 24, 2024 at 4:00 AM Christian König
> wrote:
> >
> > Otherwise we won't get correct access to the IB.
> >
> > Signed-off-by: Christian König
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3501
> Fixes: e362b7c8f8c7 ("
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Khatri, Sunil
Sent: Wednesday, July 24, 2024 10:00 PM
To: Alex Deucher ; Khatri, Sunil
Cc: Deucher, Alexander ; Liu, Leo ;
Koenig, Christian ; amd-gfx@lists.freedesktop.org
Subject: Re
On 7/25/2024 10:58 AM, Gopalakrishnan, Veerabadhran (Veera) wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Khatri, Sunil
Sent: Wednesday, July 24, 2024 10:00 PM
To: Alex Deucher ; Khatri, Sunil
Cc: Deucher, Alexander ; Li
Add support of vcn ip dump in the devcoredump
for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 149 +-
1 file changed, 148 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/v
Add macro definition which calculate offset of the
register with index override.
This is useful in case when there is an array of
registers which is common for all instances.
To read registers in that case it is easy to define
registers once and the index value is manually passed
to calculate prop
Add support for logging the registers in devcoredump
buffer for vcn_v3_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 28 ++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c
b/drivers/gpu/drm
Add pointer to the vcn ip dump in the vcn global structure
to be accessible for all vcn version via global adev.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/d
Am 24.07.24 um 09:37 schrieb Jiapeng Chong:
Use existing swap() function rather than duplicating its implementation.
./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn3.c:17:29-30:
WARNING opportunity for swap().
Reported-by: Abaci Robot
Closes: https://bugzilla.openanolis.
63 matches
Mail list logo
