[PATCH] drm/amdgpu: skip coredump after job timeout in SRIOV

2024-09-18 Thread ZhenGuo Yin
VF FLR will be triggered by host driver before job timeout, hence the error status of GPU get cleared. Performing a coredump here is unnecessary. Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v6 10/10] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-09-18 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on amd-pstate/linux-next] [also build test ERROR on amd-pstate/bleeding-edge linus/master v6.11] [cannot apply to next-20240918] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v7 01/10] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid

2024-09-18 Thread Mario Limonciello
From: Melissa Wen Replace raw edid handling (struct edid) with the opaque EDID type (struct drm_edid) on amdgpu_dm_connector for consistency. It may also prevent mismatch of approaches in different parts of the driver code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-o

[PATCH v7 02/10] drm/amd/display: switch to setting physical address directly

2024-09-18 Thread Mario Limonciello
From: Melissa Wen Connectors have source physical address available in display info. Use drm_dp_cec_attach() to use it instead of parsing the EDID again. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++--- 1 file change

[PATCH v7 03/10] drm/amd/display: always call connector_update when parsing freesync_caps

2024-09-18 Thread Mario Limonciello
From: Melissa Wen Update connector caps with drm_edid data before parsing info for freesync. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v7 10/10] drm/amd/display: Fetch the EDID from _DDC if available for eDP

2024-09-18 Thread Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. If a user prefers to use the EDID from the panel, offer a DC debugging parameter that wo

[PATCH v7 07/10] drm/amd/display: get SAD from drm_eld when parsing EDID caps

2024-09-18 Thread Mario Limonciello
From: Melissa Wen drm_edid_connector_update() updates display info, filling ELD with audio info from Short-Audio Descriptors in the last step of update_dislay_info(). Our goal is stopping using raw edid, so we can extract SAD from drm_eld instead of access raw edid to get audio caps. Signed-off-

[PATCH v7 09/10] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps

2024-09-18 Thread Mario Limonciello
From: Melissa Wen We can parse edid caps from drm_edid and drm_eld and any calls of dm_helpers_parse_edid_caps is made in a state that we have drm_edid set to amdgpu connector. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/

[PATCH v7 08/10] drm/amd/display: get SADB from drm_eld when parsing EDID caps

2024-09-18 Thread Mario Limonciello
From: Melissa Wen drm_edid_connector_update() updates display info, filling ELD with speaker allocation data in the last step of update_dislay_info(). Our goal is stopping using raw edid, so we can extract SADB from drm_eld instead of access raw edid to get audio caps. Signed-off-by: Melissa Wen

[PATCH v7 05/10] drm/amd/display: use drm_edid_product_id for parsing EDID product info

2024-09-18 Thread Mario Limonciello
From: Melissa Wen Since [1], we can use drm_edid_product_id to get debug info from drm_edid instead of directly parsing EDID. Link: https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/ [1] Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello Signed-off-by: M

[PATCH v7 06/10] drm/amd/display: parse display name from drm_eld

2024-09-18 Thread Mario Limonciello
From: Melissa Wen We don't need to parse dc_edid to get the display name since it's already set in drm_eld which in turn had it values updated when updating connector with the opaque drm_edid. Signed-off-by: Melissa Wen Signed-off-by: Mario Limonciello --- .../gpu/drm/amd/display/amdgpu_dm/am

[PATCH v7 00/10] drm/amd/display: Use drm_edid for more code

2024-09-18 Thread Mario Limonciello
This is the successor of Melissa's v5 series that was posted [1] as well as my series that was posted [2]. Melissa's patches are mostly unmodified from v5, but the series has been rebase on the new 6.10 based amd-staging-drm-next. As were both touching similar code for fetching the EDID, I've mer

[PATCH v7 04/10] drm/amd/display: remove redundant freesync parser for DP

2024-09-18 Thread Mario Limonciello
From: Melissa Wen When updating connector under drm_edid infrastructure, many calculations and validations are already done and become redundant inside AMD driver. Remove those driver-specific code in favor of the DRM common code. Signed-off-by: Melissa Wen Co-developed-by: Mario Limonciello S

[pull] amdgpu, amdkfd drm-fixes-6.12

2024-09-18 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.12. The following changes since commit ae2c6d8b3b88c176dff92028941a4023f1b4cb91: Merge tag 'drm-xe-next-fixes-2024-09-12' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next (2024-09-17 14:53:34 +1000) are available in the Git repository at: https:/

Re: [PATCH] drm/amd/display: Fix unnecessary cast warnings from checkpatch

2024-09-18 Thread Alex Deucher
Acked-by: Alex Deucher Applied. Thanks! On Tue, Sep 17, 2024 at 5:58 PM Rohit Chavan wrote: > > This patch addresses warnings produced by the checkpatch script > related to unnecessary casts that could potentially hide bugs. > > The specific warnings are as follows: > - Warning at drivers/gpu/

Re: [PATCH 2/2] drm/amdgpu/mes12: reduce timeout

2024-09-18 Thread Christian König
Am 18.09.24 um 15:39 schrieb Alex Deucher: The firmware timeout is 2s. Reduce the driver timeout to 2.1 seconds to avoid back pressure on queue submissions. Fixes: 94b51a3d01ed ("drm/amdgpu/mes12: increase mes submission timeout") Signed-off-by: Alex Deucher We should probably move that to a

Re: [PATCH 1/2] drm/amdgpu/mes11: reduce timeout

2024-09-18 Thread Christian König
Am 18.09.24 um 15:39 schrieb Alex Deucher: The firmware timeout is 2s. Reduce the driver timeout to 2.1 seconds to avoid back pressure on queue submissions. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/3627 Fixes: f7c161a4c250 ("drm/amdgpu: increase mes submission timeout") Signed-off-b

[PATCH 2/2] drm/amdgpu/mes12: reduce timeout

2024-09-18 Thread Alex Deucher
The firmware timeout is 2s. Reduce the driver timeout to 2.1 seconds to avoid back pressure on queue submissions. Fixes: 94b51a3d01ed ("drm/amdgpu/mes12: increase mes submission timeout") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 2 +- 1 file changed, 1 insertion(

[PATCH 1/2] drm/amdgpu/mes11: reduce timeout

2024-09-18 Thread Alex Deucher
The firmware timeout is 2s. Reduce the driver timeout to 2.1 seconds to avoid back pressure on queue submissions. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/3627 Fixes: f7c161a4c250 ("drm/amdgpu: increase mes submission timeout") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amd

[PATCH 6.1] drm/amdkfd: Skip handle mapping SVM range with no GPU access

2024-09-18 Thread Murad Masimov
From: Philip Yang commit 8c45b31909b730f9c7b146588e038f9c6553394d upstream. If the SVM range has no GPU access nor access-in-place attribute, validate and map to GPU should skip the range. Add NULL pointer check if find_first_bit(ctx->bitmap, MAX_GPU_INSTANCE) returns MAX_GPU_INSTANCE as gpuidx

Re: [PATCH] drm/amdgpu: fix OLAND card ip_init failed during kdump caputrue kernel boot

2024-09-18 Thread Liu, Yongxin
On 8/29/2024 16:11, Lu Yao wrote: On 2024/8/22 22:05, Mario Limonciello wrote: On 7/23/2024 04:42, Lu Yao wrote: [Why] When running kdump test on a machine with R7340 card, a hang is caused due to the failure of 'amdgpu_device_ip_init()', error message as follows: '[drm:amdgpu_device_ip_

Re: Kernel hang when amdgpu driver is loaded on old radeon card

2024-09-18 Thread Sitsofe Wheeler
Hi, On Tue, 17 Sept 2024 at 22:43, Alex Deucher wrote: > > Do you have secureboot enabled? If so, perhaps this is relevant: > https://bugzilla.kernel.org/show_bug.cgi?id=219229 The system is an old HP MicroServer N36L with no UEFI support so there's no secureboot. -- Sitsofe

RE: [PATCH] drm/amdgpu/mes12: set enable_level_process_quantum_check

2024-09-18 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Jack Xiao Sent: Wednesday, September 18, 2024 17:31 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Huang, JinHui

[PATCH] drm/amdgpu/mes12: set enable_level_process_quantum_check

2024-09-18 Thread Jack Xiao
enable_level_process_quantum_check is requried to enable process quantum based scheduling. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c inde

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-09-18 Thread Lu Yao
On 2024/9/17 21:21, Alex Deucher wrote: On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao Patch looks good to me. Any chance you want to co

[PATCH] drm/amd/display: Fix unnecessary cast warnings from checkpatch

2024-09-18 Thread Rohit Chavan
This patch addresses warnings produced by the checkpatch script related to unnecessary casts that could potentially hide bugs. The specific warnings are as follows: - Warning at drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c:16 - Warning at drivers/gpu/drm/amd/display/dc/dml2/dml21/dml2

[PATCH AUTOSEL 6.10 3/3] drm/amd/pm: fix the pp_dpm_pcie issue on smu v14.0.2/3

2024-09-18 Thread Sasha Levin
From: Kenneth Feng [ Upstream commit 7a0982523cf3ff00f35b210fc3405c528a2ce7af ] fix the pp_dpm_pcie issue on smu v14.0.2/3 as below: 0: 2.5GT/s, x4 250Mhz 1: 8.0GT/s, x4 616Mhz * 2: 8.0GT/s, x4 1143Mhz * the middle level can be removed since it is always skipped on smu v14.0.2/3 Signed-off-by: