Re: [PATCH] drm/amd/display: fix hibernate entry for DCN35+

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 4:49 PM Hamza Mahfooz wrote: > > On 10/4/24 16:44, Alex Deucher wrote: > > On Fri, Oct 4, 2024 at 4:43 PM Hamza Mahfooz wrote: > >> > >> Since, two suspend-resume cycles are required to enter hibernate and, > >> since we only need to enable idle optimizations in the first c

Re: [PATCH] drm/amd/display: fix hibernate entry for DCN35+

2024-10-04 Thread Hamza Mahfooz
On 10/4/24 16:44, Alex Deucher wrote: On Fri, Oct 4, 2024 at 4:43 PM Hamza Mahfooz wrote: Since, two suspend-resume cycles are required to enter hibernate and, since we only need to enable idle optimizations in the first cycle (which is pretty much equivalent to s2idle). We can check in_s0ix,

Re: [PATCH] drm/amd/display: fix hibernate entry for DCN35+

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 4:43 PM Hamza Mahfooz wrote: > > Since, two suspend-resume cycles are required to enter hibernate and, > since we only need to enable idle optimizations in the first cycle > (which is pretty much equivalent to s2idle). We can check in_s0ix, to > prevent the system from enter

[PATCH] drm/amd/display: fix hibernate entry for DCN35+

2024-10-04 Thread Hamza Mahfooz
Since, two suspend-resume cycles are required to enter hibernate and, since we only need to enable idle optimizations in the first cycle (which is pretty much equivalent to s2idle). We can check in_s0ix, to prevent the system from entering idle optimizations before it actually enters hibernate (fro

[PATCH] drm/amdkfd: Accounting pdd vram_usage for svm

2024-10-04 Thread Philip Yang
Per process device data pdd->vram_usage is used by rocm-smi to report VRAM usage, this is currently missing the svm_bo usage accounting, so "rocm-smi --showpids" per process report is incorrect. Add pdd->vram_usage accounting for svm_bo and change type to atomic64_t because it is updated outside p

Re: [PATCH 11/18] drm/amdgpu: power vcn 2_5 by instance

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 2:53 PM wrote: > > From: Boyuan Zhang > > For vcn 2_5, add ip_block for each vcn instance during discovery stage. > > And only powering on/off one of the vcn instance using the > instance value stored in ip_block, instead of powering on/off all > vcn instances. Modify the e

Re: [PATCH 09/18] drm/amdgpu: add set_powergating_state_instance

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 2:45 PM wrote: > > From: Boyuan Zhang > > Add a new function to allow setting requested powergating state for the > given instance. If the instance value doesn't match with the one inside > ip_block, then do nothing since this request is for other instances with > the same

Re: [PATCH 09/18] drm/amdgpu: pass ip_block in set_powergating_state

2024-10-04 Thread Boyuan Zhang
On 2024-10-02 07:41, Christian König wrote: Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Pass ip_block instead of adev in set_powergating_state callback function. Modify set_powergating_state ip functions for all correspoding ip blocks. Signed-off-by: Boyuan Zhan

Re: [PATCH 04/18] drm/amd/pm: add inst to set_powergating_by_smu

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 2:45 PM wrote: > > From: Boyuan Zhang > > Add an instance parameter to set_powergating_by_smu() function, and > re-write all amd_pm functions accordingly. Then use the instance to > call smu_dpm_set_vcn_enable(). > > v2: remove duplicated functions. > > remove for-loop in s

Re: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-04 Thread Jay Cornwall
On 10/4/2024 04:42, Lancelot SIX wrote: + * Copyright 2024 Advanced Micro Devices, Inc. I am not really sure bout the year policy in the kernel, but all the content here is dated from before 2024.  The vast majority is taken form the cwsr_trap_handler_gfx10.asm file (copyright started in 201

[PATCH 17/18] drm/amdgpu/vcn: separate idle work by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Previously idle working handling is for all VCN instances. As a result, when one of the instance finishes its job, the idle work can't be triggered if the other instance is still busy. Now, move the idle_work from amdgpu_vcn to amdgpu_vcn_inst, in order to track work by vcn in

[PATCH 13/18] drm/amdgpu: power vcn 4_0 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 06/18] add inst to amdgpu_dpm_enable_vcn

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to amdgpu_dpm_enable_vcn() function, and change all calls from vcn ip functions to add instance argument. vcn generations with only one instance (v1.0, v2.0) always use 0 as instance number. vcn generations with multiple instances (v2.5, v3.0, v4.0, v4

[PATCH 18/18] drm/amdgpu: set powergating state by vcn instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Set powergating state by vcn instance in idle_work_handler() and ring_begin_use() functions for vcn with multiple instances. Signed-off-by: Boyuan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[PATCH 15/18] drm/amdgpu: power vcn 4_0_5 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0_5, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 12/18] drm/amdgpu: power vcn 3_0 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 3_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 14/18] drm/amdgpu: power vcn 4_0_3 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 4_0_3, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 11/18] drm/amdgpu: power vcn 2_5 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 2_5, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_blo

[PATCH 10/18] drm/amdgpu/vcn: separate gating state by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang vcn gating state should now be based on instance. For example, instance 0 can be gated while instance 1 is ungated, or vice versa. Therefore, change the cur_state to be an array, so that it can track the gating status for each vcn instance now. v2: remove redundant codes in v

[PATCH 16/18] drm/amdgpu: power vcn 5_0_0 by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For vcn 5_0_0, add ip_block for each vcn instance during discovery stage. And only powering on/off one of the vcn instance using the instance value stored in ip_block, instead of powering on/off all vcn instances. Modify the existing functions to use the instance value in ip_b

[PATCH 07/18] drm/amdgpu: pass ip_block in set_powergating_state

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Pass ip_block instead of adev in set_powergating_state callback function. Modify set_powergating_state ip functions for all correspoding ip blocks. v2: fix a ip block index error. Signed-off-by: Boyuan Zhang Suggested-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdg

[PATCH 04/18] drm/amd/pm: add inst to set_powergating_by_smu

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to set_powergating_by_smu() function, and re-write all amd_pm functions accordingly. Then use the instance to call smu_dpm_set_vcn_enable(). v2: remove duplicated functions. remove for-loop in smu_dpm_set_power_gate(), and temporarily move it to to a

[PATCH 05/18] drm/amd/pm: add inst to amdgpu_dpm_set_powergating_by_smu

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to amdgpu_dpm_set_powergating_by_smu() function, and use the instance to call set_powergating_by_smu(). v2: remove duplicated functions. remove for-loop in amdgpu_dpm_set_powergating_by_smu(), and temporarily move it to amdgpu_dpm_enable_vcn(), in or

[PATCH 09/18] drm/amdgpu: add set_powergating_state_instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add a new function to allow setting requested powergating state for the given instance. If the instance value doesn't match with the one inside ip_block, then do nothing since this request is for other instances with the same block type. Signed-off-by: Boyuan Zhang --- drive

[PATCH 03/18] drm/amd/pm: add inst to smu_dpm_set_vcn_enable

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang First, add an instance parameter to smu_dpm_set_vcn_enable() function, and calling dpm_set_vcn_enable() with this given instance. Second, modify vcn_gated to be an array, to track the gating status for each vcn instance separately. With these 2 changes, smu_dpm_set_vcn_enable

[PATCH 08/18] drm/amdgpu: track instances of the same IP block

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add a new function to count the number of instance of the same IP block in the current ip_block list, then use the returned count value to set the newly defined instance variable in ip_block, to track the instance number of each ip_block. Signed-off-by: Boyuan Zhang Signed-of

[PATCH 02/18] drm/amd/pm: power up or down vcn by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang For smu ip with multiple vcn instances (smu 11/13/14), remove all the for loop in dpm_set_vcn_enable() functions. And use the instance argument to power up/down vcn for the given instance only, instead of powering up/down for all vcn instances. v2: remove all duplicated functi

[PATCH 01/18] drm/amd/pm: add inst to dpm_set_vcn_enable

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Add an instance parameter to the existing function dpm_set_vcn_enable() for future implementation. Re-write all pptable functions accordingly. v2: Remove duplicated dpm_set_vcn_enable() functions in v1. Instead, adding instance parameter to existing functions. Signed-off-by:

[PATCH 00/18] Separating vcn power management by instance

2024-10-04 Thread boyuan.zhang
From: Boyuan Zhang Previously, all vcn instance will be powered on/off at the same time even only one of the instance requests power status change. This patch set enables vcn to ONLY power on/off the instance that requires power status change. Other vcn instances will remain the original power st

Re: [PATCH 10/18] drm/amdgpu: add ip block with instance

2024-10-04 Thread Boyuan Zhang
On 2024-10-02 13:32, Alex Deucher wrote: On Wed, Oct 2, 2024 at 12:39 AM wrote: From: Boyuan Zhang Add instance number to ip block to track which instance the ip block belongs to. Also, add a new function to allow ip block to save the instance number along with other ip block driver inform

Re: [PATCH 07/18] drm/amdgpu/vcn: separate gating state by instance

2024-10-04 Thread Boyuan Zhang
On 2024-10-02 07:28, Christian König wrote: Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang vcn gating state should now be based on instance. For example, instance 0 can be gated while instance 1 is ungated, or vice versa. Therefore, change the cur_state to be an arr

Re: [PATCH 05/18] drm/amd/pm: set vcn enable by instance

2024-10-04 Thread Boyuan Zhang
On 2024-10-02 07:19, Christian König wrote: Am 02.10.24 um 06:36 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang The new function smu_dpm_set_vcn_enable_instance() will be used to enable or disable vcn engine dynamic power for the given vcn instance only. The original function smu_dpm_se

Re: [PATCH 01/18] drm/amd/pm: add new vcn enable function pointer

2024-10-04 Thread Boyuan Zhang
On 2024-10-02 13:10, Alex Deucher wrote: On Wed, Oct 2, 2024 at 12:38 AM wrote: From: Boyuan Zhang The new function dpm_set_vcn_enable_instance() will be used to enable or disable vcn engine dynamic power for the given vcn instance. The original function dpm_set_vcn_enable() will still be

[PATCH AUTOSEL 5.10 25/26] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

Re: [PATCH v2 03/11] drm/fbdev: Select fbdev I/O helpers from modules that require them

2024-10-04 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on next-20241002] [also build test ERROR on v6.12-rc1] [cannot apply to drm-xe/drm-xe-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-nex

[PATCH AUTOSEL 5.15 30/31] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.1 40/42] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.6 55/58] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.10 67/70] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.10 66/70] drm/amdgpu: nuke the VM PD/PT shadow handling

2024-10-04 Thread Sasha Levin
From: Christian König [ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ] This was only used as workaround for recovering the page tables after VRAM was lost and is no longer necessary after the function amdgpu_vm_bo_reset_state_machine() started to do the same. Compute never used shad

[PATCH AUTOSEL 6.11 73/76] drm/amd/display: Check null pointer before dereferencing se

2024-10-04 Thread Sasha Levin
From: Alex Hung [ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ] [WHAT & HOW] se is null checked previously in the same function, indicating it might be null; therefore, it must be checked when used again. This fixes 1 FORWARD_NULL issue reported by Coverity. Acked-by: Alex Hung R

[PATCH AUTOSEL 6.11 72/76] drm/amdgpu: nuke the VM PD/PT shadow handling

2024-10-04 Thread Sasha Levin
From: Christian König [ Upstream commit 7181faaa4703705939580abffaf9cb5d6b50dbb7 ] This was only used as workaround for recovering the page tables after VRAM was lost and is no longer necessary after the function amdgpu_vm_bo_reset_state_machine() started to do the same. Compute never used shad

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Alex Deucher
On Fri, Oct 4, 2024 at 5:15 AM Sundararaju, Sathishkumar wrote: > > > All occurrences of this error fix should have been together in a single patch > both in _get and _set callbacks corresponding to f0b19b84d391, please avoid > separate patch for each occurrence. > > Sorry Alex, I missed to note

Re: [PATCH] drm/amd/display: disable SG displays on cyan skillfish

2024-10-04 Thread Harry Wentland
On 2024-10-04 10:30, Alex Deucher wrote: > These parts were mainly for compute workloads, but they have > a display that was available for the console. These chips > should support SG display, but I don't know that the support > was ever validated on Linux so disable it by default. It can > sti

Re: [PATCH v8 0/5] drm/amd/display: Use drm_edid for more code

2024-10-04 Thread Alex Hung
No regressed found on this patchset series. Reviewed-by: Alex Hung On 9/27/24 17:05, Mario Limonciello wrote: From: Mario Limonciello This is the successor of Melissa's v5 series that was posted [1] as well as my series that was posted [2]. Melissa's patches are mostly unmodified from v5, b

[PATCH] drm/amdkfd: add/remove kfd queues through on stop/start KFD scheduling

2024-10-04 Thread shaoyunl
Add back kfd queues in start scheduling that originally been removed on stop scheduling. Signed-off-by: shaoyunl --- .../drm/amd/amdkfd/kfd_device_queue_manager.c | 36 +-- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_

[PATCH 3/4] drm/amdgpu/swsmu: default to fullscreen 3D profile for dGPUs

2024-10-04 Thread Alex Deucher
This uses more aggressive hueristics than the the bootup default profile. On windows the OS has a special fullscreen 3D mode where this is used. Since we don't have the equivalent on Linux default to this profile for dGPUs. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3618 Closes: htt

[PATCH 4/4] drm/amdgpu/swsmu: add automatic parameter to set_soft_freq_range

2024-10-04 Thread Alex Deucher
On chips that support it, you can specificy 0 and 0x for min and max and the PMFW will use that to determine the optimal min and max. This enables optimal performance when the user manually switches between performance levels using sysfs. Previously we'd set soft min/max which could limit perf

[PATCH 2/4] drm/amdgpu/swsmu: Only force workload setup on init

2024-10-04 Thread Alex Deucher
Needed to set the workload type at init time so that we can apply the navi3x margin optimization. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3618 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3131 Fixes: c50fe289ed7207 ("drm/amdgpu/swsmu: always force a state reprogram on ini

[PATCH 1/4] drm/amdgpu/smu13: always apply the powersave optimization

2024-10-04 Thread Alex Deucher
It can avoid margin issues in some very demanding applications. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3618 Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3131 Fixes: c50fe289ed7207 ("drm/amdgpu/swsmu: always force a state reprogram on init") Signed-off-by: Alex Deucher -

[PATCH v2] drm/amdkfd: Not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Xiaogang . Chen
From: Xiaogang Chen When kfd process has been terminated not restore userptr buffer after mmu notifier invalidates a range. Signed-off-by: Xiaogang Chen --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/

RE: [PATCH 00/26] DC Patches October 3rd, 2024

2024-10-04 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types. APU * Single Display eDP -> 1080p 60hz, 2560x1600 120hz, 1920x1200 165hz * Single Display DP -> 4k144hz, 4k240hz * Multi

[PATCH 1/2] drm/amd/pm: Update SMUv13.0.6 PMFW headers

2024-10-04 Thread Asad Kamal
Update pmfw headers for smuv13.0.6 to version 0xE Signed-off-by: Asad Kamal --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h b/drivers/gpu/drm/amd/p

[PATCH 2/2] drm/amd/pm: Fill pcie recov cntr to metrics 1.6

2024-10-04 Thread Asad Kamal
Fill pcie other end recovery counter to metrics 1.6 Signed-off-by: Asad Kamal --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c| 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/s

Re: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Chen, Xiaogang
On 10/4/2024 9:46 AM, Felix Kuehling wrote: On 2024-10-04 10:39, Russell, Kent wrote: [Public] My mistake. -Original Message- From: amd-gfx On Behalf Of Russell, Kent Sent: Friday, October 4, 2024 9:53 AM To: Chen, Xiaogang ; Kuehling, Felix ; amd-gfx@lists.freedesktop.org Cc: Yan

Re: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Felix Kuehling
On 2024-10-04 10:39, Russell, Kent wrote: > [Public] > > My mistake. > >> -Original Message- >> From: amd-gfx On Behalf Of Russell, >> Kent >> Sent: Friday, October 4, 2024 9:53 AM >> To: Chen, Xiaogang ; Kuehling, Felix >> ; amd-gfx@lists.freedesktop.org >> Cc: Yang, Philip >> Subje

RE: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Russell, Kent
[Public] My mistake. > -Original Message- > From: amd-gfx On Behalf Of Russell, > Kent > Sent: Friday, October 4, 2024 9:53 AM > To: Chen, Xiaogang ; Kuehling, Felix > ; amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: RE: [PATCH v2] drm/amdkfd: not restore userptr buffer if

Re: [PATCH] drm/amdgpu: partially revert powerplay `__counted_by` changes

2024-10-04 Thread Lazar, Lijo
On 10/3/2024 7:36 PM, Alex Deucher wrote: > Partially revert > commit 0ca9f757a0e2 ("drm/amd/pm: powerplay: Add `__counted_by` attribute for > flexible arrays") > > The count attribute for these arrays does not get set until > after the arrays are allocated and populated leading to false > UBS

[PATCH] drm/amd/display: disable SG displays on cyan skillfish

2024-10-04 Thread Alex Deucher
These parts were mainly for compute workloads, but they have a display that was available for the console. These chips should support SG display, but I don't know that the support was ever validated on Linux so disable it by default. It can still be enabled by setting sg_display=1 for those that w

Re: [PATCH] drm/amdgpu: partially revert powerplay `__counted_by` changes

2024-10-04 Thread Alex Deucher
Ping? On Thu, Oct 3, 2024 at 10:06 AM Alex Deucher wrote: > > Partially revert > commit 0ca9f757a0e2 ("drm/amd/pm: powerplay: Add `__counted_by` attribute for > flexible arrays") > > The count attribute for these arrays does not get set until > after the arrays are allocated and populated leadin

Re: [PATCH 3/3] drm/amdgpu: Remove the while loop from amdgpu_job_prepare_job

2024-10-04 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Oct 4, 2024 at 3:28 AM Tvrtko Ursulin wrote: > > > On 24/09/2024 13:06, Christian König wrote: > > Am 24.09.24 um 11:51 schrieb Tvrtko Ursulin: > >> From: Tvrtko Ursulin > >> > >> While loop makes it sound like amdgpu_vmid_grab() potentially needs to be > >> calle

Re: [PATCH v2] drm/radeon: add late_register for connector

2024-10-04 Thread Alex Deucher
On Thu, Oct 3, 2024 at 9:18 PM Wu Hoi Pok wrote: > > The patch is to solve null dereference in 'aux.dev', which is > introduced in recent radeon rework. By having 'late_register', > the connector should be registered after 'drm_dev_register' > automatically, where in before it is the opposite. > >

RE: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Chen, > Xiaogang > Sent: Thursday, October 3, 2024 6:11 PM > To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: Re: [PATCH v2] drm/amdkfd: not restore

Re: [PATCH 13/26] drm/amd/display: Clear update flags after update has been applied

2024-10-04 Thread Melissa Wen
On 03/10/2024 20:33, Rodrigo Siqueira wrote: From: Josip Pavic [Why] Since the surface/stream update flags aren't cleared after applying updates, those same updates may be applied again in a future call to update surfaces/streams for surfaces/streams that aren't actually part of that update

Re: [PATCH v6 15/44] drm/vkms: Add kunit tests for linear and sRGB LUTs

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: checkpatch: commit description - Add an appropriate one > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/vkms/tests/vkms_color_test.c | 38 +++- > drivers/gpu/drm/vkms/vkms_composer.c | 15 ++-- > drivers/gpu/drm/vkms

Re: [PATCH v6 03/44] drm/vkms: Add kunit tests for VKMS LUT handling

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: > Debugging LUT math is much easier when we can unit test > it. Add kunit functionality to VKMS and add tests for > - get_lut_index > - lerp_u16 > > Signed-off-by: Harry Wentland > Cc: Arthur Grillo > --- > v6: > - Eliminate need to include test as .

Re: [PATCH v6 19/44] drm/vkms: add 3x4 matrix in color pipeline

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > We add two 3x4 matrices into the VKMS color pipeline. The reason > we're adding matrices is so that we can test that application > of a matrix and its inverse yields an output equal to the input > image. > > One complication with the matrix implementati

Re: [PATCH v6 20/44] drm/tests: Add a few tests around drm_fixed.h

2024-10-04 Thread Louis Chauvet
Few checkpatch warnings: - line length of 103 exceeds 100 columns - Blank lines aren't necessary before a close brace '}' - adding a line without newline at end of file With those fixed: Reviewd-by: Louis Chauvet On 03/10/24 - 16:01, Harry Wentland wrote: > While working on the CTM implementatio

Re: [PATCH v6 18/44] drm/vkms: Use s32 for internal color pipeline precision

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > Certain operations require us to preserve values below 0.0 and > above 1.0 (0x0 and 0x respectively in 16 bpc unorm). One > such operation is a BT709 encoding operation followed by its > decoding operation, or the reverse. > > We'll use s32 values a

Re: [PATCH v6 14/44] drm/vkms: Add enumerated 1D curve colorop

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:00, Harry Wentland wrote: > This patch introduces a VKMS color pipeline that includes two > drm_colorops for named transfer functions. For now the only ones > supported are sRGB EOTF, sRGB Inverse EOTF, and a Linear TF. > We will expand this in the future but I don't want to do so

Re: [PATCH v6 21/44] drm/vkms: Add tests for CTM handling

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > A whole slew of tests for CTM handling that greatly helped in > debugging the CTM code. The extent of tests might seem a bit > silly but they're fast and might someday help save someone > else's day when debugging this. > > Signed-off-by: Harry Wentland

Re: [PATCH v6 41/44] drm/colorop: allow non-bypass colorops

2024-10-04 Thread Louis Chauvet
On 03/10/24 - 16:01, Harry Wentland wrote: > Not all HW will be able to do bypass on all color > operations. Introduce an 'allow_bypass' boolean for > all colorop init functions and only create the BYPASS > property when it's true. > > Signed-off-by: Harry Wentland > --- > .../amd/display/amdgpu

Re: [PATCH-next v2] Fix unintentional integer overflow

2024-10-04 Thread Lazar, Lijo
On 10/3/2024 3:56 PM, Advait Dhamorikar wrote: > Fix shift-count-overflow in JPEG instance > multiplication. The expression's value may not be > what the programmer intended, because the expression > is evaluated using a narrower integer type. > > Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jp

Re: [PATCH] drm/amdkfd: Move gfx12 trap handler to separate file

2024-10-04 Thread Lancelot SIX
Hi Jay, Thanks for doing this. I have minor comments inlined below. Overall, this new version assembles to the same binary, so no functional change expected. Best, Lancelot. On 03/10/2024 20:31, Jay Cornwall wrote: gfx12 derivatives will have substantially different trap handler implement

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Sundararaju, Sathishkumar
All occurrences of this error fix should have been together in a single patch both in _get and _set callbacks corresponding to f0b19b84d391, please avoid separate patch for each occurrence. Sorry Alex, I missed to note this yesterday. Regards, Sathish On 10/4/2024 1:46 PM, Advait Dhamorik

[PATCH] drm/amdgpu: Add dcn30 drm_panic support

2024-10-04 Thread Jocelyn Falempe
Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. It should work on all readeon using amdgpu_dm_plane.c, when the framebuffer is linear (like when in a VT). For tiled framebuffer, it will only work on radeon with dcn

Re: [REGRESSION][BISECTED] 58a261bfc967: choppy GPU performance

2024-10-04 Thread Christopher Snowhill
On Wed Oct 2, 2024 at 5:34 AM PDT, John Rowley wrote: > If you're referring to the Freedesktop DRM issue then sinatosk a separate > poster. I'm not involved in that thread. 🙂 > Oh, sorry, my mistake. I thought you had popped over to the issue tracker as we

Re: [PATCH 3/3] drm/amdgpu: Remove the while loop from amdgpu_job_prepare_job

2024-10-04 Thread Tvrtko Ursulin
On 24/09/2024 13:06, Christian König wrote: Am 24.09.24 um 11:51 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin While loop makes it sound like amdgpu_vmid_grab() potentially needs to be called multiple times to produce a fence, while in reality all code paths either return an error, assign a v

[PATCH 6.12 regression fix 0/2] drm/radeon regression fixes

2024-10-04 Thread Hans de Goede
Hi All, My main workstation still uses a good old R7 250E card. After dogfooding 6.12-rc1 my system would first hang at boot and after fixing that GDM would not show. After identifying the problematic commits I have gone for the easy solution of reverting both, which was straight forward in both

[PATCH 6.12 regression fix 1/2] drm/radeon: Revert: "remove load callback from kms_driver"

2024-10-04 Thread Hans de Goede
Commit 90985660ba48 ("drm/radeon: remove load callback from kms_driver") causes my system with a R7 250E card to hang at boot, reporting the following (abbreviated) oops captured by serial console: [7.512157] BUG: kernel NULL pointer dereference, address: 0050 [7.519149] #PF: s

[PATCH v2] drm/radeon: add late_register for connector

2024-10-04 Thread Wu Hoi Pok
The patch is to solve null dereference in 'aux.dev', which is introduced in recent radeon rework. By having 'late_register', the connector should be registered after 'drm_dev_register' automatically, where in before it is the opposite. Fixes: 90985660ba48 ("drm/radeon: remove load callback from km

Re: [PATCH v5 79/80] drm/omapdrm: Remove struct drm_fb_helper from struct omap_fbdev.

2024-10-04 Thread Tomi Valkeinen
Hi, On 27/09/2024 17:46, Thomas Zimmermann wrote: Hi Am 26.09.24 um 15:07 schrieb Tomi Valkeinen: Hi, On 24/09/2024 10:13, Thomas Zimmermann wrote: Store instances of drm_fb_helper and struct omap_fbdev separately. This will allow omapdrm to use the common fbdev client, which allocates its o

Re: [lvc-project] [PATCH v2] drm/amd/pm: check return value of amdgpu_irq_add_id()

2024-10-04 Thread Fedor Pchelkin
On Wed, 02. Oct 16:01, Igor Artemiev wrote: > amdgpu_irq_ad_id() may fail and the irq handlers will not be registered. > This patch adds error code check. > > Found by Linux Verification Center (linuxtesting.org) with static > analysis tool SVACE. > > Signed-off-by: Igor Artemiev > --- > v2: Rem

[PATCH 6.12 regression fix 2/2] drm/radeon: Revert: "use GEM references instead of TTMs"

2024-10-04 Thread Hans de Goede
Commit fd69ef05029f ("drm/radeon: use GEM references instead of TTMs") causes a black screen at boot instead of showing the GDM login screen (the system is still alive). dmesg shows the following oops (abbreviated) when this happens: [ 29.315203] BUG: kernel NULL pointer dereference, address: 0

Re: [PATCH] drm/radeon: add late_register for connector

2024-10-04 Thread Hans de Goede
Hi, On 3-Oct-24 5:54 PM, Alex Deucher wrote: > + Hans > > On Thu, Oct 3, 2024 at 2:33 AM Wu Hoi Pok wrote: >> >> This is a fix patch not tested yet, >> for a bug I introduce in previous rework of radeon driver. >> The bug is a null dereference in 'aux.dev', which is the >> 'device' not registere

[PATCH-next v2] Fix unintentional integer overflow

2024-10-04 Thread Advait Dhamorikar
Fix shift-count-overflow in JPEG instance multiplication. The expression's value may not be what the programmer intended, because the expression is evaluated using a narrower integer type. Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs") Signed-off-by: Advait Dhamorikar ---

Re: [PATCH v4] docs/gpu: ci: update flake tests requirements

2024-10-04 Thread Helen Mae Koike Fornazier
On Mon, 30 Sep 2024 06:52:47 -0300 Vignesh Raman wrote --- > Update the documentation to specify linking to a relevant GitLab > issue or email report for each new flake entry. Added specific > GitLab issue urls for amdgpu, i915, msm and xe driver. > > Acked-by: Maxime Ripard m