Re: [PATCH] drm/amdgpu: Add DPG pause for VCN v5.0.1

2025-04-24 Thread Lazar, Lijo
On 4/24/2025 10:43 PM, Sonny Jiang wrote: > For vcn5.0.1 only, enable DPG PAUSE to avoid DPG resets. > > Signed-off-by: Sonny Jiang > --- > drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 55 + > 1 file changed, 55 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/v

Re: [PATCH v9 10/10] drm/amdgpu: update trace format to match gpu_scheduler_trace

2025-04-24 Thread Yadav, Arvind
Reviewed-by: Arvind Yadav On 4/24/2025 2:08 PM, Pierre-Eric Pelloux-Prayer wrote: Log fences using the same format for coherency. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++ 1 file change

Re: [PATCH v9 08/10] drm: get rid of drm_sched_job::id

2025-04-24 Thread Yadav, Arvind
Reviewed-by: Arvind Yadav On 4/24/2025 2:08 PM, Pierre-Eric Pelloux-Prayer wrote: Its only purpose was for trace events, but jobs can already be uniquely identified using their fence. The downside of using the fence is that it's only available after 'drm_sched_job_arm' was called which is true

[PATCH 2/2] amd/amdkfd: Trigger segfault for early userptr unmmapping

2025-04-24 Thread Shane Xiao
If applications unmap the memory before destroying the userptr, it needs trigger a segfault to notify user space to correct the free sequence in VM debug mode. v2: Send GPU access fault to user space v3: Report gpu address to user space, remove unnecessary params Signed-off-by: Shane Xiao --- .

[PATCH 1/2] drm/amdgpu: Add debug bit for userptr usage

2025-04-24 Thread Shane Xiao
In VM debug mode, it is desirable to notify the application to correct the freeing sequence by unmapping the memory before destroying the userptr in the old userptr path. Add a bitmask to decide whether to send gpu vm fault to the applition. Signed-off-by: Shane Xiao --- drivers/gpu/drm/amd/amdg

RE: [PATCH 2/2] amd/amdkfd: Trigger segfault for early userptr unmmapping

2025-04-24 Thread Xiao, Shane
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Thursday, April 24, 2025 9:56 PM > To: Xiao, Shane ; amd-gfx@lists.freedesktop.org; > Koenig, Christian ; Yang, Philip > > Subject: Re: [PATCH 2/2] amd/amdkfd: Trigger segfault for early userptr > unmmapping > > > On 2025-04-2

[PATCH v3 05/20] drm/amd/pm: Avoid open-coded use of ratelimit_state structure's internals

2025-04-24 Thread Paul E. McKenney
The amdgpu_set_thermal_throttling_logging() function directly accesses the ratelimit_state structure's ->missed field, which work, but which also makes it more difficult to change this field. Therefore, make use of the ratelimit_state_reset_miss() function instead of directly accessing the ->misse

Re: [PATCH] drm/amdkfd: add pasid debugfs entries

2025-04-24 Thread Chen, Xiaogang
On 4/24/2025 3:04 PM, Eric Huang wrote: the entries will be appearing at /sys/kernel/debug/kfd/proc//pasid_. why need move pasid from sysfs to debugfs? debugfs is not always available and does not hide pasid from users either. Regards Xiaogang Signed-off-by: Eric Huang --- drivers/g

[PATCH] drm/amdkfd: add pasid debugfs entries

2025-04-24 Thread Eric Huang
the entries will be appearing at /sys/kernel/debug/kfd/proc//pasid_. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c | 77 drivers/gpu/drm/amd/amdkfd/kfd_priv.h| 5 ++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 + 3 files changed, 85 insert

Re: [PATCH] Revert "drm/amd/display: Hardware cursor changes color when switched to software cursor"

2025-04-24 Thread Harry Wentland
On 2025-04-22 10:58, Melissa Wen wrote: > This reverts commit 272e6aab14bbf98d7a06b2b1cd6308a02d4a10a1. > > Applying degamma curve to the cursor by default breaks Linux userspace > expectation. > > On Linux, AMD display manager enables cursor degamma ROM just for > implict sRGB on HW versions

Re: [PATCH] SWDEV-513979 - Fix for BSOD on Hyper-V host side

2025-04-24 Thread Alex Deucher
On Thu, Apr 3, 2025 at 6:58 AM Nikola Petrovic wrote: Please fix the patch title. It should say something like: drm/amdgpu: fix reset handling with Hyper-V You also need a patch description describing why the change is needed. And finally, your patch is missing your Signed-off-by. Alex > > -

[PATCH] drm/amdgpu: only remap HDP registers on X86_64

2025-04-24 Thread Alex Deucher
We remap the HDP registers to an open part of the MMIO aperture. This doesn't seem to work properly on non-X86 systems, so only remap on X86_64. Fixes: c9b8dcabb52a ("drm/amdgpu/hdp4.0: do a posting read when flushing HDP") Fixes: cf424020e040 ("drm/amdgpu/hdp5.0: do a posting read when flushing

[PATCH] drm/amdgpu: Add DPG pause for VCN v5.0.1

2025-04-24 Thread Sonny Jiang
For vcn5.0.1 only, enable DPG PAUSE to avoid DPG resets. Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 55 + 1 file changed, 55 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c index

Re: 回复: [REGRESSION] amdgpu: async system error exception from hdp_v5_0_flush_hdp()

2025-04-24 Thread Alex Deucher
On Tue, Apr 22, 2025 at 11:59 AM Alexey Klimov wrote: > > On Tue Apr 22, 2025 at 2:00 PM BST, Alex Deucher wrote: > > On Mon, Apr 21, 2025 at 10:21 PM Alexey Klimov > > wrote: > >> > >> On Thu Apr 17, 2025 at 2:08 PM BST, Alex Deucher wrote: > >> > On Wed, Apr 16, 2025 at 8:43 PM Fugang Duan >

Re: [PATCH 2/2] amd/amdkfd: Trigger segfault for early userptr unmmapping

2025-04-24 Thread Felix Kuehling
On 2025-04-24 0:54, Shane Xiao wrote: > If applications unmap the memory before destroying the userptr, it needs > trigger a segfault to notify user space to correct the free sequence in > VM debug mode. > > v2: Send GPU access fault to user space See some comments inline. > > Signed-off-by: S

Re: [PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-24 Thread Alex Deucher
On Wed, Apr 23, 2025 at 10:29 AM Christian König wrote: > > On 4/22/25 18:26, Deucher, Alexander wrote: > > [Public] > > > >> -Original Message- > >> From: Alex Deucher > >> Sent: Tuesday, April 22, 2025 9:46 AM > >> To: Koenig, Christian > >> Cc: Denis Arefev ; Deucher, Alexander > >> ;

Re: amdgpu_dm_connector_mode_valid regression

2025-04-24 Thread Alex Deucher
On Thu, Apr 24, 2025 at 4:49 AM Marek Marczykowski-Górecki wrote: > > On Fri, Apr 11, 2025 at 12:01:28PM +0200, Marek Marczykowski-Górecki wrote: > > > > Hi, > > > > On Wed, Apr 02, 2025 at 04:35:05PM +0200, Gergo Koteles wrote: > > > Hi Dmitry, > > > > > > But the code would start to become quite

RE: [PATCH v3 1/7] drm/amd/pm: Add ip version check for smu_v13_0_12 functions

2025-04-24 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Thursday, April 24, 2025 19:39 To: amd-gfx@lists.freedesktop.org; Lazar, Lijo Cc: Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Kamal,

[PATCH v3 6/7] drm/amd/pm: Add voltage caps for smu_v13_0_6

2025-04-24 Thread Asad Kamal
Add & enable board voltage caps for smu_v13_0_6 v3: Update version check for board voltage support Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.h | 1 + 2 files changed, 4

[PATCH v3 5/7] drm/amd/pm: Fill static metrics data

2025-04-24 Thread Asad Kamal
Fill static metrics data for smu_v13_0_6 v2: Proceed with driver load just with warning even if board voltage reads invalid value Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 1 + .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c |

[PATCH v3 3/7] drm/amd/pn: Fetch static metrics table

2025-04-24 Thread Asad Kamal
Fetch static metrics table for smu_v13_0_6 v2: Add static metrics caps check to fetch static metrics table v3: Update version having all fixes for static metrics support Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 28 ++

[PATCH v3 7/7] drm/amd/pm: Add board voltage node to hwmon

2025-04-24 Thread Asad Kamal
Add and expose board voltage node as vddboard to hwmon for smu_v13_0_6 v2: Replace ip check with supported sensor attribute(Lijo) Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../gpu/drm/amd/include/kgd_pp_interface.h| 1 + drivers/gpu/drm/amd/pm/amdgpu_pm.c| 34 +

[PATCH v3 1/7] drm/amd/pm: Add ip version check for smu_v13_0_12 functions

2025-04-24 Thread Asad Kamal
Add ip version check to use smu_v13_0_12 specific functions Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.

[PATCH v3 2/7] drm/amd/pm: Update pmfw headers for smu_v_13_0_6

2025-04-24 Thread Asad Kamal
Update pmfw headers for smu_v_13_0_6 to include static metrics table Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h| 7 +++ .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h | 3 ++- 2 files changed, 9 insertions(+)

[PATCH v3 4/7] drm/amd/pm: Use common function to fetch static metrics table

2025-04-24 Thread Asad Kamal
Use common function to fetch static metrics table for smu_v13_0_12 Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 22 +-- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.h |

[PATCH v9 10/10] drm/amdgpu: update trace format to match gpu_scheduler_trace

2025-04-24 Thread Pierre-Eric Pelloux-Prayer
Log fences using the same format for coherency. Signed-off-by: Pierre-Eric Pelloux-Prayer Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_tra

[PATCH v9 08/10] drm: get rid of drm_sched_job::id

2025-04-24 Thread Pierre-Eric Pelloux-Prayer
Its only purpose was for trace events, but jobs can already be uniquely identified using their fence. The downside of using the fence is that it's only available after 'drm_sched_job_arm' was called which is true for all trace events that used job.id so they can safely switch to using it. Suggest

[PATCH v9 02/10] drm/sched: store the drm client_id in drm_sched_fence

2025-04-24 Thread Pierre-Eric Pelloux-Prayer
This will be used in a later commit to trace the drm client_id in some of the gpu_scheduler trace events. This requires changing all the users of drm_sched_job_init to add an extra parameter. The newly added drm_client_id field in the drm_sched_fence is a bit of a duplicate of the owner one. One

[PATCH v9 00/10] Improve gpu_scheduler trace events + UAPI

2025-04-24 Thread Pierre-Eric Pelloux-Prayer
Hi, The initial goal of this series was to improve the drm and amdgpu trace events to be able to expose more of the inner workings of the scheduler and drivers to developers via tools. Then, the series evolved to become focused only on gpu_scheduler. The changes around vblank events will be part

[PATCH 6.12 170/223] drm/amdgpu/dma_buf: fix page_link check

2025-04-24 Thread Greg Kroah-Hartman
6.12-stable review patch. If anyone has any objections, please let me know. -- From: Matthew Auld commit c0dd8a9253fadfb8e5357217d085f1989da4ef0a upstream. The page_link lower bits of the first sg could contain something like SG_END, if we are mapping a single VRAM page or con

[lvc-project] [PATCH] drm/radeon: fix possible NULL pointer dereference in atombios_set_encoder_crtc_source()

2025-04-24 Thread Igor Artemiev
The function radeon_get_connector_for_encoder() can return NULL and its result is checked before dereference in all functions except atombios_set_encoder_crtc_source(). Add a NULL pointer check before dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a4863ca93

[PATCH 6.6 355/393] drm/amdgpu/dma_buf: fix page_link check

2025-04-24 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Matthew Auld commit c0dd8a9253fadfb8e5357217d085f1989da4ef0a upstream. The page_link lower bits of the first sg could contain something like SG_END, if we are mapping a single VRAM page or cont

Re: [PATCH v2] drm/amdgpu: Add NULL check for 'bo_va' in update_bo_mapping v2

2025-04-24 Thread Dan Carpenter
On Wed, Apr 23, 2025 at 02:52:22PM +0200, Christian König wrote: > On 4/22/25 16:15, Dan Carpenter wrote: > > On Tue, Apr 22, 2025 at 03:34:58PM +0200, Christian König wrote: > >> Am 22.04.25 um 15:17 schrieb Srinivasan Shanmugam: > >>> This change adds a check to ensure that 'bo_va' is not null be

[PATCH 6.1 240/291] drm/amdgpu/dma_buf: fix page_link check

2025-04-24 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Matthew Auld commit c0dd8a9253fadfb8e5357217d085f1989da4ef0a upstream. The page_link lower bits of the first sg could contain something like SG_END, if we are mapping a single VRAM page or cont

[PATCH 6.14 196/241] drm/amdgpu/dma_buf: fix page_link check

2025-04-24 Thread Greg Kroah-Hartman
6.14-stable review patch. If anyone has any objections, please let me know. -- From: Matthew Auld commit c0dd8a9253fadfb8e5357217d085f1989da4ef0a upstream. The page_link lower bits of the first sg could contain something like SG_END, if we are mapping a single VRAM page or con

[bug report] drm/amd/display: DCN42 RMCM and MCM 3DLUT support

2025-04-24 Thread Dan Carpenter
Hello Yihan Zhu, Commit 652968d996d7 ("drm/amd/display: DCN42 RMCM and MCM 3DLUT support") from Apr 1, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn401/dcn401_hwseq.c:720 dcn401_populate_mcm_luts() error

Announcement: 2025 X.Org Foundation Election Candidates

2025-04-24 Thread Mark Filion
To all X.Org Foundation Members: The election for the X.Org Foundation Board of Directors will begin on 30 April 2025. We have five candidates who are running for four seats. They are (in alphabetical order): * Andres Gomez * Arkadiusz Hiler * Megan Knight * Lyude Paul * Harry Wentland Atta

[PATCH] drm/amd/display: Adjust prefix of dcn31_apg construct function name

2025-04-24 Thread Leonardo Gomes
From: Leonardo da Silva Gomes Adjust the dcn31_apg construct function name from 'apg31_construct' to 'dcn31_apg_construct'. This helps the ftrace to detect the file by the function name. Signed-off-by: Leonardo da Silva Gomes Co-developed-by: Derick Frias Signed-off-by: Derick Frias --- driv