Re: [PATCH v1 5/7] drm/ci: uprev IGT

2025-07-20 Thread Vignesh Raman
Hi, On 18/07/25 18:24, Dmitry Baryshkov wrote: On Fri, Jul 18, 2025 at 04:23:57PM +0530, Vignesh Raman wrote: Uprev IGT to the latest version and update expectation files. Signed-off-by: Vignesh Raman --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- .../gpu/drm/ci/xfails/amdgpu-

Re: [REGRESSION] [PATCH v2] drm/amd/display: fix initial backlight brightness calculation

2025-07-20 Thread Mario Limonciello
On 7/20/25 7:59 PM, Lauri Tirkkonen wrote: DIV_ROUND_CLOSEST(x, 100) returns either 0 or 1 if 0 Cc: sta...@vger.kernel.org Thanks so much! Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH 3/3] tests/amdgpu: Add support for testing compositor control of ABM

2025-07-20 Thread Mario Limonciello
From: Mario Limonciello The compositor can directly control ABM, but sysfs should be blocked when this happens. Ensure that sysfs writes fail at that time. To avoid potential test failures, ensure that sysfs control is enabled at the start of all other tests. Signed-off-by: Mario Limonciello

[PATCH 1/3] tests/amdgpu: Remove unneeded includes

2025-07-20 Thread Mario Limonciello
From: Mario Limonciello Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c index 97813d80f..f55b055f9 100644 --- a/tests/amdgpu/amd_abm.c +++ b/tests/amdgpu/amd_abm.c @@ -20,7 +20,6 @@

[PATCH 2/3] tests/amdgpu: Rename set_abm_level to set_abm_level_sysfs

2025-07-20 Thread Mario Limonciello
From: Mario Limonciello The compositor can set the ABM level directly, so rename the function to clarify which method is being used. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/amdg

[PATCH 0/3] Add IGT test for compositor control of ABM

2025-07-20 Thread Mario Limonciello
From: Mario Limonciello After the Display Next 2025 hackfest a patch series was introduced to allow the compositor to control ABM. sysfs writes are blocked when set. Add support for testing that the writes really are blocked. Link: https://lore.kernel.org/amd-gfx/20250718192045.2091650-1-supe.

Re: Regression: DDC I2C Display Freezing for internal displays

2025-07-20 Thread Alex Deucher
On Sat, Jul 19, 2025 at 1:38 PM Felix Richter wrote: > > On 7/19/25 14:23, Mario Limonciello wrote: > > > > On 7/19/25 5:10 AM, Felix Richter wrote: > >> Thanks for the reply. > >> > >> I am aware that i can read and `edid` via sysfs from the drm device. > >> I did not know about `drm_info` but fr

Re: Regression: DDC I2C Display Freezing for internal displays

2025-07-20 Thread Felix Richter
On 7/19/25 14:23, Mario Limonciello wrote: On 7/19/25 5:10 AM, Felix Richter wrote: Thanks for the reply. I am aware that i can read and `edid` via sysfs from the drm device. I did not know about `drm_info` but from a quick look at it I don't think it provides the information I need. The p

Re: [REGRESSION] drm/amd/display: backlight brightness set to 0 at amdgpu initialization

2025-07-20 Thread Lauri Tirkkonen
On Fri, Jul 18 2025 20:14:08 -0500, Mario Limonciello wrote: > OK, I think we need to do two things to figure out what's going on. > > 1) Let's shift over to 6.16-rc6. Once we've got a handle on the situation > there we can iron out if there are other patches missing or this is also > broken for

Re: [PATCH v10 2/4] drm: add debugfs support on per client-id basis

2025-07-20 Thread Jeff Hugo
On 7/4/2025 1:55 AM, Sunil Khatri wrote: add support to add a directory for each client-id Nitpick. This is the start of a sentence, and therefore proper grammar would have the first letter capitalized. So, "add support" should be "Add support". -Jeff

[REGRESSION] [PATCH] drm/amd/display: fix initial backlight brightness calculation

2025-07-20 Thread Lauri Tirkkonen
DIV_ROUND_CLOSEST(x, 100) returns either 0 or 1 if 0 --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index f58fa5da7f

Re: [PATCH v10 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-20 Thread Jeff Hugo
On 7/4/2025 1:55 AM, Sunil Khatri wrote: Requirement is to create per client-id based directories to hold key debugging information and for that access to root debugfs dentry is need which is not in one place and that information cannot be stored in drm_device. Move the debugfs functionality fro

Re: [PATCH v6 1/1] drm/amd: Re-introduce property to control adaptive backlight modulation

2025-07-20 Thread Xaver Hugl
Looks like a reasonable approach to me. Thanks for following up on it! I'll look into a KWin implementation soon. - Xaver

Re: [REGRESSION] [PATCH] drm/amd/display: fix initial backlight brightness calculation

2025-07-20 Thread Greg Kroah-Hartman
On Sun, Jul 20, 2025 at 06:36:54PM +0900, Lauri Tirkkonen wrote: > DIV_ROUND_CLOSEST(x, 100) returns either 0 or 1 if 0 division needs to be performed after the multiplication and not the > other way around, to properly scale the value. > > Fixes: 6c56c8ec6f97 ("drm/amd/display: Fix default DC and

Re: [REGRESSION] drm/amd/display: backlight brightness set to 0 at amdgpu initialization

2025-07-20 Thread Lauri Tirkkonen
On Sat, Jul 19 2025 12:39:45 -0500, Mario Limonciello wrote: > On 7/19/25 10:25 AM, Mario Limonciello wrote: > > > > > > On 7/18/25 9:12 PM, Lauri Tirkkonen wrote: > > > On Fri, Jul 18 2025 20:14:08 -0500, Mario Limonciello wrote: > > > > OK, I think we need to do two things to figure out what's

Re: [REGRESSION] drm/amd/display: backlight brightness set to 0 at amdgpu initialization

2025-07-20 Thread Lauri Tirkkonen
On Fri, Jul 18 2025 12:13:30 -0500, Mario Limonciello wrote: > On 7/18/2025 9:36 AM, Lauri Tirkkonen wrote: > > On Fri, Jul 18 2025 08:10:06 -0500, Mario Limonciello wrote: > > > Do you by chance have an OLED panel? I believe what's going on is that > > > userspace is writing zero or near zero and

Re: [REGRESSION] drm/amd/display: backlight brightness set to 0 at amdgpu initialization

2025-07-20 Thread Lauri Tirkkonen
On Fri, Jul 18 2025 08:10:06 -0500, Mario Limonciello wrote: > Do you by chance have an OLED panel? I believe what's going on is that > userspace is writing zero or near zero and on OLED panels with older kernels > this means non-visible. Yes, this is an OLED panel. But I don't believe it's users

Re: [PATCH i-g-t] tests/amdgpu: Add test for native cursor fallback to overlay

2025-07-20 Thread Kamil Konieczny
Hi IVAN.LIPSKI, On 2025-07-17 at 16:41:46 -0400, ivan.lip...@amd.com wrote: > From: Ivan Lipski > > [Why & How] > The AMD display hardware does not use dedicated cursor planes. > Instead, the cursor is rendered either using the primary plane > or an available overlay plane. This test verifies tha

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-20 Thread Brian Geffon
On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: > > On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > > > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote: > > > > > > On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote: > > > > > > > > On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher

Re: Regression: DDC I2C Display Freezing for internal displays

2025-07-20 Thread Felix Richter
Thanks for the reply. I am aware that i can read and `edid` via sysfs from the drm device. I did not know about `drm_info` but from a quick look at it I don't think it provides the information I need. The problem is not that I need more information about the attached display. The problem is

Need help to dig into X11 display freezing (Renoir, Xen/QubesOS)

2025-07-20 Thread Yann Dirson
Hello there, For a few months I've been experiencing occasional freezes of the X11 display on my QubesOS RENOIR laptop. The setup is pretty much standard for QubesOS, with both GPUs attached to dom0 and XFCE running there (and the dGPU being mostly not used). Kernel is QubesOS' kernel-latest-6.1

[PATCH 3/3] Documentation/amdgpu: add a few acronyms to glossary

2025-07-20 Thread Yann Dirson
Signed-off-by: Yann Dirson --- Notes (patch): test patch note Documentation/gpu/amdgpu/amdgpu-glossary.rst | 3 +++ Documentation/gpu/amdgpu/display/dc-glossary.rst | 3 +++ 2 files changed, 6 insertions(+) diff --git a/Documentation/gpu/amdgpu/amdgpu-glossary.rst b/Documentation/gpu/

[PATCH 1/3] Documentation/amdgpu: fix 'in the amdgfx' formulation

2025-07-20 Thread Yann Dirson
Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/display/dc-glossary.rst | 2 +- Documentation/gpu/amdgpu/display/display-contributing.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/amdgpu/display/dc-glossary.rst b/Documentation/gpu/a

[PATCH 2/3] drm/amdgpu: fix module parameter description

2025-07-20 Thread Yann Dirson
Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 4db92e0a60da..f940068caf72 100644 --- a/drivers/gpu/drm/amd/amdgpu/am

[PATCH 0/3] Minor documentation updates

2025-07-20 Thread Yann Dirson
This series fixes a few small things I stumbled upon while reading the amdgpu doc. Yann Dirson (3): Documentation/amdgpu: fix 'in the amdgfx' formulation drm/amdgpu: fix module parameter description Documentation/amdgpu: add a few acronyms to glossary Documentation/gpu/amdgpu/amdgpu-glossa

Re: [REGRESSION] [PATCH] drm/amd/display: fix initial backlight brightness calculation

2025-07-20 Thread Mario Limonciello
On 7/20/25 4:36 AM, Lauri Tirkkonen wrote: DIV_ROUND_CLOSEST(x, 100) returns either 0 or 1 if 0 --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/

Re: A few more items for the glossary, and understanding GPU switching

2025-07-20 Thread Yann Dirson
Adding to the list: * ACA, mentionned in debug_mask flags - digging the source shows it seems to be "Accelerator Check Architecture", but maybe some additional details could be added? * DPIA (likely for dc-glossary): listed in DC_DEBUG_MASK values, source code in several places shows "Displa