Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

2018-10-25 Thread Agrawal, Akshu
On 10/26/2018 8:34 AM, Alex Deucher wrote: > On Thu, Oct 25, 2018 at 10:52 PM Agrawal, Akshu wrote: >> >> >> >> On 10/26/2018 8:09 AM, Alex Deucher wrote: >>> On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: >>>> >>>>

Re: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

2018-10-25 Thread Agrawal, Akshu
On 10/26/2018 8:09 AM, Alex Deucher wrote: > On Thu, Oct 25, 2018 at 12:27 PM S, Shirish wrote: >> >> This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. >> >> Reason for revert: >> This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) >> in wrong of sequence to SMU which is

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

2018-07-09 Thread Agrawal, Akshu
Was this patch ever picked up? I can't find it in agd5f/linux. >>> >>> >>> It wasn't applied. I don't see 51f7415039d4 ("drm/amd/amdgpu: >>> creating two I2S instances for stoney/cz") upstream yet either. >>> Daniel, Vijendar, which ones do you want applied? Can you send me the >>>

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

2018-04-15 Thread Agrawal, Akshu
On 4/13/2018 9:45 PM, Daniel Kurtz wrote: Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz") added support for the "BT_I2S" ACP i2s channel. As part of this change, one additional acp resource was added, but the "num_resource" count was accidentally incremented

Re: [PATCH v2 2/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2

2017-11-09 Thread Agrawal, Akshu
On 11/8/2017 11:39 PM, Mark Brown wrote: On Wed, Nov 08, 2017 at 12:24:03PM -0500, Alex Deucher wrote: regmap_read(regmap, RT5645_VENDOR_ID2, ); + /* +* Read after 400msec, as it is the interval required between +* read and power On. +*/ +

Re: [PATCH 1/3] ASoC: amd: Report accurate hw_ptr during dma

2017-11-07 Thread Agrawal, Akshu
On 11/7/2017 5:07 PM, Mark Brown wrote: On Tue, Nov 07, 2017 at 07:26:03PM +0530, Mukunda,Vijendar wrote: Removing URL links and commit-ready description in v2. This doesn't really answer my question: These two URLs are different, what was being reviewed here? What is Commit-Ready

Re: [PATCH 3/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2

2017-11-07 Thread Agrawal, Akshu
On 11/6/2017 9:54 PM, Mark Brown wrote: On Fri, Nov 03, 2017 at 04:35:45PM -0400, Alex Deucher wrote: Minimum time required between power On of codec and read of RT5645_VENDOR_ID2 is 400msec. We should wait and attempt before erroring out. So the description says we have to wait 400ms

Re: [PATCH 6/6 v3] ASoC: AMD: Add machine driver for cz rt5650

2017-09-01 Thread Agrawal, Akshu
On 8/31/2017 5:08 PM, Mark Brown wrote: > On Fri, Aug 18, 2017 at 02:10:30PM -0400, Alex Deucher wrote: > >> +++ b/sound/soc/amd/Kconfig >> @@ -2,3 +2,10 @@ config SND_SOC_AMD_ACP >> tristate "AMD Audio Coprocessor support" >> help >> This option enables ACP DMA support on AMD