Awesome, thanks!
Rodrigo Siqueira Jordao schrieb am Do. 3. Nov.
2022 um 15:21:
>
>
> On 2022-11-01 12:31, Nathan Chancellor wrote:
> > On Tue, Nov 01, 2022 at 10:36:08AM -0400, Rodrigo Siqueira Jordao wrote:
> >>
> >>
> >> On 2022-10-31 15:37, Ao Zhong
CONFIG_DRM_AMD_DC_DCN check for the per-file
cflags list entirely
Change Since V1:
- replace $(dml_rcflags_arm64) with $(dml_rcflags) in dml/Makefile
Ao Zhong (1):
drm/amd/display: add DCN support for ARM64
drivers/gpu/drm/amd/display/Kconfig | 3 ++-
.../gpu/drm/amd/display/amdgpu_dm
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display
Am 28.10.22 um 17:09 schrieb Nathan Chancellor:
> Additionally, I see the following errors with GCC 12.2.1 from Fedora
> when building allmodconfig. Seems like some $(dml_rcflags) might be
> missing.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c: In
> function ‘dcn10_resou
Am 28.10.22 um 17:09 schrieb Nathan Chancellor:
> Additionally, I see the following errors with GCC 12.2.1 from Fedora
> when building allmodconfig. Seems like some $(dml_rcflags) might be
> missing.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_resource.c: In
> function ‘dcn10_resour
Ao,
>
> Could you share a link that describe your workstation?
>
> Thanks
>
> On 10/26/22 17:17, Ao Zhong wrote:
>> Hi Rodrigo,
>>
>> Thanks for your review! This is my first time submitting a patch to the
>> kernel.
>>
>> I'm not very g
run this command, you should see the TTY.
>
> 4. Try to run this IGT test
>
> sudo ./build/tests/kms_flip
>
> And let me know if this test looks ok for you.
>
> On 10/27/22 06:52, Arnd Bergmann wrote:
>> On Thu, Oct 27, 2022, at 02:25, Ao Zhong wrote:
>>>
$(dml_rcflags) in dml/Makefile
Ao Zhong (1):
drm/amd/display: add DCN support for ARM64
drivers/gpu/drm/amd/display/Kconfig | 2 +-
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 6 ++
drivers/gpu/drm/amd/display/dc/dml/Makefile | 20 +++
3 files changed, 23
Here is the output from kms_flip:
IGT-Version: 1.26-NO-GIT (aarch64) (Linux: 6.0.5-gentoo-arm64 aarch64)
Using monotonic timestamps
Starting subtest: nonblocking-read
Subtest nonblocking-read: SUCCESS (0.000s)
Starting subtest: wf_vblank-ts-check
Starting dynamic subtest: A-DP1
3440x1440 50 3440
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display
>
> sudo systemctl isolate multi-user.target
>
> After run this command, you should see the TTY.
>
> 4. Try to run this IGT test
>
> sudo ./build/tests/kms_flip
>
> And let me know if this test looks ok for you.
>
> On 10/27/22 06:52, Arnd Bergmann wrote:
>> On
describe your workstation?
>
> Thanks
>
> On 10/26/22 17:17, Ao Zhong wrote:
> > Hi Rodrigo,
> >
> > Thanks for your review! This is my first time submitting a patch to the
> > kernel.
> >
> > I'm not very good at using these tools yet. 😂
>
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display
a control mechanism in
amdgpu_dm/dc_fpu.c for ARM Neon.
Change Since V1:
replace $(dml_rcflags_arm64) with $(dml_rcflags) in dml/Makefile
Ao Zhong (1):
drm/amd/display: add DCN support for ARM64
drivers/gpu/drm/amd/display/Kconfig | 2 +-
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
OK, I'll replace $(dml_rcflags_arm64) with $(dml_rcflags).
Am Do., 27. Okt. 2022 um 15:45 Uhr schrieb Arnd Bergmann :
>
> On Thu, Oct 27, 2022, at 15:38, Ao Zhong wrote:
> > Am Do., 27. Okt. 2022 um 12:52 Uhr schrieb Arnd Bergmann :
> >
> >> Why do you
Am Do., 27. Okt. 2022 um 12:52 Uhr schrieb Arnd Bergmann :
>
> On Thu, Oct 27, 2022, at 02:25, Ao Zhong wrote:
> > After moving all FPU code to the DML folder, we can enable DCN support
> > for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the
> > code in t
h.
Link: https://browser.geekbench.com/v5/cpu/18237269
Ao
Am 26.10.22 um 18:12 schrieb Rodrigo Siqueira:
>
>
> On 10/26/22 07:13, Ao Zhong wrote:
>> pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_luma = 0;
>> pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_chroma = 0;
>> these two operatio
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display
a control mechanism in
amdgpu_dm/dc_fpu.c for ARM Neon.
Ao Zhong (1):
drm/amd/display: add DCN support for ARM64
drivers/gpu/drm/amd/display/Kconfig | 2 +-
.../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c| 6 ++
drivers/gpu/drm/amd/display/dc/dml/Makefile | 64
disable the hardware FPU.
Therefore, imitate the dcn31_zero_pipe_dcc_fraction function in
dml/dcn31/dcn31_fpu.c, declare the dcn32_zero_pipe_dcc_fraction function
in dcn32_fpu.c, and move above two operations into this function.
Acked-by: Christian König
Signed-off-by: Ao Zhong
---
drivers/gpu
dcn10_resource_construct_fp from dcn10 folder to
dml/dcn10 folder to enable hardware FPU for that function.
Acked-by: Christian König
Signed-off-by: Ao Zhong
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 44 +--
.../drm/amd/display/dc/dml/dcn10/dcn10_fpu.c | 37
Am 25.10.22 um 23:17 schrieb Ao Zhong:
>> In the process of enabling DCN support for arm64, I found that the
>> dcn10_resource_construct_fp function in dcn10/dcn10_resource.c still
>> needs to use FPU. This will cause compilation to fail on ARM64 platforms
>> because -mgeneral-re
dcn10_resource_construct_fp from dcn10 folder to
dml/dcn10 folder to enable hardware FPU for that function.
Acked-by: Christian König
Signed-off-by: Ao Zhong
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 44 +--
.../drm/amd/display/dc/dml/dcn10/dcn10_fpu.c | 37
disable the hardware FPU.
Therefore, imitate the dcn31_zero_pipe_dcc_fraction function in
dml/dcn31/dcn31_fpu.c, declare the dcn32_zero_pipe_dcc_fraction function
in dcn32_fpu.c, and move above two operations into this function.
Acked-by: Christian König
Signed-off-by: Ao Zhong
---
drivers/gpu
disable the hardware FPU.
Therefore, imitate the dcn31_zero_pipe_dcc_fraction function in
dml/dcn31/dcn31_fpu.c, declare the dcn32_zero_pipe_dcc_fraction function
in dcn32_fpu.c, and move above two operations into this function.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display/dc/dcn32
dcn10_resource_construct_fp from dcn10 folder to
dml/dcn10 folder to enable hardware FPU for that function.
Signed-off-by: Ao Zhong
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 44 +--
.../drm/amd/display/dc/dml/dcn10/dcn10_fpu.c | 38
.../drm/amd/display/dc
Move remaining FPU code to dml folder
in preparation for enabling aarch64 support.
Signed-off-by: Ao Zhong
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 44 +--
.../drm/amd/display/dc/dcn32/dcn32_resource.c | 5 ++-
.../drm/amd/display/dc/dml/dcn10/dcn10_fpu.c | 40
Subject: [PATCH] drm/amd/display: move remaining FPU code to dml folder
Move remaining FPU code to dml folder
in preparation for enabling aarch64 support.
Signed-off-by: Ao Zhong
---
.../drm/amd/display/dc/dcn10/dcn10_resource.c | 44 +--
.../drm/amd/display/dc/dcn32
After moving all FPU code to the DML folder, we can enable DCN support
for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG form the
code in the DML folder that needs to use hardware FPU, and add a control
mechanism for ARM Neon.
Signed-off-by: Ao Zhong
---
drivers/gpu/drm/amd/display
29 matches
Mail list logo
