Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Ard Biesheuvel
(cc Arnd) On Thu, 11 Apr 2024 at 03:11, Samuel Holland wrote: > > Hi Thiago, > > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > > Samuel Holland writes: > >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: > >>> > >>> Unfortunately this patch causes build failures on arm with allyesco

[PATCH -stable] drm/amdgpu/display: drop DCN support for aarch64

2021-01-21 Thread Ard Biesheuvel
cked-by: Will Deacon Reported-by: Ard Biesheuvel Signed-off-by: Alex Deucher [ardb: backport to v5.10 by reverting c38d444e44badc55 instead] Acked-by: Alex Deucher # v5.10 backport Signed-off-by: Ard Biesheuvel --- The original commit does not apply cleanly to v5.10, as it reverts a combinati

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-20 Thread Ard Biesheuvel
On Tue, 5 Jan 2021 at 17:23, Alex Deucher wrote: > > On Tue, Jan 5, 2021 at 8:05 AM Will Deacon wrote: > > > > On Mon, Jan 04, 2021 at 11:27:24AM -0500, Alex Deucher wrote: > > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > > > >

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-04 Thread Ard Biesheuvel
On Mon, 4 Jan 2021 at 17:27, Alex Deucher wrote: > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > &g

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2020-12-29 Thread Ard Biesheuvel
On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa. > > &g

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2020-12-16 Thread Ard Biesheuvel
On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > > > This reverts commit c38d444e44badc557cf29fdfdfb823604890ccfa. > > > > Simply disabling -mgeneral-regs-only left and right is risky, given that > &

[PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2020-12-14 Thread Ard Biesheuvel
Martin Cc: Rob Herring Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Daniel Kolesa Cc: amd-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ard Biesheuvel --- drivers/gpu/drm/amd/display/Kconfig

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-02-07 Thread Ard Biesheuvel
On Thu, 7 Feb 2019 at 16:33, Alex Deucher wrote: > > On Thu, Feb 7, 2019 at 10:20 AM Ard Biesheuvel > wrote: > > > > On Wed, 6 Feb 2019 at 19:38, Christian König > > wrote: > > > > > > Am 06.02.19 um 18:23 schrieb Ard Biesheuvel: > &g

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-02-07 Thread Ard Biesheuvel
On Wed, 6 Feb 2019 at 19:38, Christian König wrote: > > Am 06.02.19 um 18:23 schrieb Ard Biesheuvel: > > On Fri, 25 Jan 2019 at 11:35, Ard Biesheuvel > > wrote: > >> On Fri, 25 Jan 2019 at 12:30, Christian König > >> wrote: > >>> Am 25.01.19 um

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-02-06 Thread Ard Biesheuvel
On Fri, 25 Jan 2019 at 11:35, Ard Biesheuvel wrote: > > On Fri, 25 Jan 2019 at 12:30, Christian König > wrote: > > > > Am 25.01.19 um 09:43 schrieb Ard Biesheuvel: > > > On Thu, 24 Jan 2019 at 15:01, Alex Deucher wrote: > > >> On Thu, Jan 24, 20

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-01-25 Thread Ard Biesheuvel
On Fri, 25 Jan 2019 at 12:30, Christian König wrote: > > Am 25.01.19 um 09:43 schrieb Ard Biesheuvel: > > On Thu, 24 Jan 2019 at 15:01, Alex Deucher wrote: > >> On Thu, Jan 24, 2019 at 9:00 AM Ard Biesheuvel > >> wrote: > >>> On Thu, 24 Jan 201

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-01-25 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 15:01, Alex Deucher wrote: > > On Thu, Jan 24, 2019 at 9:00 AM Ard Biesheuvel > wrote: > > > > On Thu, 24 Jan 2019 at 13:31, Koenig, Christian > > wrote: > > > > > > Am 24.01.19 um 13:06 schrieb Ard Biesheuvel: > > >

[PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-01-24 Thread Ard Biesheuvel
Reported-by: Carsten Haitzler Signed-off-by: Ard Biesheuvel --- include/drm/drm_cache.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h index bfe1639df02d..97fc498dc767 100644 --- a/include/drm/drm_cache.h +++ b/include/drm

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 12:23, Koenig, Christian wrote: > > Am 24.01.19 um 10:59 schrieb Ard Biesheuvel: > > [SNIP] > > This is *exactly* my point the whole time. > > > > The current code has > > > > static inline bool drm_arch_can_wc_memory(void) >

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 12:37, Koenig, Christian wrote: > > Am 24.01.19 um 12:26 schrieb Ard Biesheuvel: > > On Thu, 24 Jan 2019 at 12:23, Koenig, Christian > > wrote: > >> Am 24.01.19 um 10:59 schrieb Ard Biesheuvel: > >>> [SNIP] > >>> This is

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 10:31, Michel Dänzer wrote: > > On 2019-01-23 5:52 p.m., Ard Biesheuvel wrote: > > On Wed, 23 Jan 2019 at 17:44, Christoph Hellwig wrote: > >> > >> I think we just want a driver-local check for those combinations > >> where we know

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 14:54, Alex Deucher wrote: > > On Thu, Jan 24, 2019 at 6:45 AM Ard Biesheuvel > wrote: > > > > On Thu, 24 Jan 2019 at 12:37, Koenig, Christian > > wrote: > > > > > > Am 24.01.19 um 12:26 schrieb Ard Biesheuvel: > >

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 10:45, Koenig, Christian wrote: > > Am 24.01.19 um 10:28 schrieb Ard Biesheuvel: > > On Thu, 24 Jan 2019 at 10:25, Koenig, Christian > > wrote: > >> Am 24.01.19 um 10:13 schrieb Christoph Hellwig: > >>> On Wed, Jan 23, 2019 at

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 10:25, Koenig, Christian wrote: > > Am 24.01.19 um 10:13 schrieb Christoph Hellwig: > > On Wed, Jan 23, 2019 at 05:52:50PM +0100, Ard Biesheuvel wrote: > >> But my concern is that it seems likely that non-cache coherent > >> implementations ar

Re: [PATCH] drm: enable uncached DMA optimization for ARM and arm64

2019-01-24 Thread Ard Biesheuvel
On Thu, 24 Jan 2019 at 13:31, Koenig, Christian wrote: > > Am 24.01.19 um 13:06 schrieb Ard Biesheuvel: > > The DRM driver stack is designed to work with cache coherent devices > > only, but permits an optimization to be enabled in some cases, where > > for some buffers,

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 17:44, Christoph Hellwig wrote: > > I think we just want a driver-local check for those combinations > where we know this hack actually works, which really just seems > to be x86-64 with PAT. Something like the patch below, but maybe with > even more strong warnings to not d

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 08:15, Christoph Hellwig wrote: > > On Tue, Jan 22, 2019 at 10:07:07PM +0100, Ard Biesheuvel wrote: > > Yes, so much was clear. And the reason this breaks on some arm64 > > systems is because > > a) non-snooped PCIe TLP attributes may be ignored, an

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-22 Thread Ard Biesheuvel
On Tue, 22 Jan 2019 at 21:56, Alex Deucher wrote: > > On Tue, Jan 22, 2019 at 4:19 AM Ard Biesheuvel > wrote: > > > > On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > > > > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > > >

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-22 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > >> On 2019-01-21 7:20 p.m., Ard Biesheuvel wrote: > >>> On Mon, 21 Jan 2019 at 19:04, Michel Dänzer wro

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > >> On 2019-01-21 7:20 p.m., Ard Biesheuvel wrote: > >>> On Mon, 21 Jan 2019 at 19:04, Michel Dänzer wro

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > > On 2019-01-21 7:20 p.m., Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 19:04, Michel Dänzer wrote: > >> > >> On 2019-01-21 6:59 p.m., Ard Biesheuvel wrote: > >>> On Mon, 21 Jan 2019 at 18:55, Mich

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 19:04, Michel Dänzer wrote: > > On 2019-01-21 6:59 p.m., Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 18:55, Michel Dänzer wrote: > >> > >> On 2019-01-21 5:30 p.m., Ard Biesheuvel wrote: > >>> On Mon, 21 Jan 2019

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 17:35, Christoph Hellwig wrote: > > On Mon, Jan 21, 2019 at 05:30:00PM +0100, Ard Biesheuvel wrote: > > > Until that happens we should just change the driver ifdefs to default > > > the hacks to off and only enable them on setups where we 100% &g

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 18:55, Michel Dänzer wrote: > > On 2019-01-21 5:30 p.m., Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 17:22, Christoph Hellwig wrote: > > > >> Until that happens we should just change the driver ifdefs to default > >> the hacks t

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 17:22, Christoph Hellwig wrote: > > On Mon, Jan 21, 2019 at 05:14:37PM +0100, Ard Biesheuvel wrote: > > > I'll add big fat comments. But the fact that nothing is exported > > > there should be a fairly big hint. > > > > > &

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 16:59, Christoph Hellwig wrote: > > On Mon, Jan 21, 2019 at 04:33:27PM +0100, Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 16:07, Christoph Hellwig wrote: > > > > > > > +#include > > > > > > This header is not fo

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 16:07, Christoph Hellwig wrote: > > > +#include > > This header is not for usage in device drivers, but purely for > dma-mapping implementations! > Is that documented anywhere? > > +static inline bool drm_device_can_wc_memory(struct drm_device *ddev) > > { > > + if (

[RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-21 Thread Ard Biesheuvel
stian Koenig Cc: Alex Deucher Cc: David Zhou Cc: Huang Rui Cc: Junwei Zhang Cc: Michel Daenzer Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Will Deacon Reported-by: Carsten Haitzler Signed-off-by