[PATCH] Revert "drm/amd/display: avoid large on-stack structures"

This reverts commit 44069f0f9b1fe577c5d4f05fa9eb02db8c618adc since the code path is called from FPU context, and triggers error like: [ 26.924055] BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306 [ 26.924060] in_atomic(): 1, irqs_disabled(): 0, non_block: 0,

Re: [PATCH] drm/amd/display: Add null checks for 'stream' and 'plane' before dereferencing

line 922) Cc: Tom Chung Cc: Nicholas Kazlauskas Cc: Bhawanpreet Lakha Cc: Rodrigo Siqueira Cc: Roman Li Cc: Hersen Wu Cc: Alex Hung Cc: Aurabindo Pillai Cc: Harry Wentland Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c | 3 +++ 1 file

[PATCH 10/13] drm/amd/display: Add missing registers for DCN401

From: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira --- .../include/asic_reg/dcn/dcn_4_1_0_offset.h | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_4_1_0_offset.h

[PATCH 11/13] drm/amd/display: Move some init routines to dm_sw_init()

Move creation of CGS device node and the DAL allocation list from amdgpu_dm_init() to dm_sw_init() which runs before dmub's sw init hook. This is required for communicating with the VBIOS DMUB image from the VBIOS that was loaded for early pre-os boot. Signed-off-by: Aurabindo Pillai

[PATCH 13/13] drm/amd/display: Enable copying of bounding box data from VBIOS DMUB

Allocate some memory, send the address in chunks to dmub, and finally ask it to copy the bounding box data into the newly allocated memory. Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 121 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h

[PATCH 12/13] drm/amd/display: Add new GPINT command definitions

New commands for enabling copy of DC bounding box values from VBIOS DMUB Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm

[PATCH 08/13] drm/amd/display: Remove incorrect FP context start

All the DC_FP_START/END should be used before call anything from DML2, for this reason, the use of those guards inside DML it is not correct. This commit removes two unnecessary DC_FP_START/END from a dml2 function. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu

[PATCH 09/13] drm/amd/display: Fix null pointer dereference for dcn401

When ODM slice happens on DCN401, there is a null pointer exception caused by that. This commit address this issue by checking if the required data structures are initialized. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c

[PATCH 07/13] drm/amd/display: Use DCN 410 includes for DCN401

DCN401 is using DCN 320 headers, which does not have all the right registers for DCN401. This commit just replace DCN320 includes with the one from DCN410. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c| 4

[PATCH 06/13] drm/amd/display: Remove unnecessary HPD entry for DCN401

Drop the extra HPD irq entry for DCN401. Reviewed-by: Rodrigo Siqueira Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn401/irq_service_dcn401.c b

[PATCH 04/13] drm/amd/display: Refactor HUBP into component folder.

From: Pinninti [why] cleaning up the code refactor requires hubp to be in its own component. [how] move all files under newly created hubp folder and fixing the makefiles. Reviewed-by: Rodrigo Siqueira Signed-off-by: Pinninti --- drivers/gpu/drm/amd/display/dc/dcn401/Makefile | 1

[PATCH 03/13] drm/amd/display: Remove unused code

From: Rodrigo Siqueira This commit removes some unused code with the required adjustments. Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp.h | 2 +-

[PATCH 02/13] drm/amd/display: Enable ISHARP support for DCN401

From: Samson Tam [Why] Enable sharpener support for DCN401 [How] - Removed memcmp check that was preventing ISHARP from being enabled. - Add missing ISHARP register defines, masks, and writes. - Add programming of Blur and Scale coefficients. - Program FMT_MODE and NLDELTA registers based on

[PATCH 01/13] drm/amd/display: Fix incorrect cursor position for dcn401

From: "Arvindekar, Sridevi" [Why] Incorrect cursor position calculation in some scenarios. Also for mirror and rotation cases. [How] Fix for incorrect cursor position. Added new test scenarios for diags cursor test. Updated CRC for few of the diags cursor test scenarios. Reviewed-by:

Re: [PATCH 23/24] drm/amd/display: Fix POWERPC_64 compilation

Reviewed-by: Aurabindo Pillai On 5/16/24 3:26 PM, roman...@amd.com wrote: From: Roman Li [Why] Compilation errors while compiling without CONFIG_DRM_AMD_DC_FP: "undefined reference to `dc_bandwidth_in_kbps_from_timing'" [How] Fix Makefile to move dsc files out of DC_FP gua

Re: [PATCH] drm/amd/display: Remove redundant NULL check in dce110_set_input_transfer_func

Reviewed-by: Aurabindo Pillai On 4/23/24 9:29 PM, Srinivasan Shanmugam wrote: This commit removes a redundant NULL check in the `dce110_set_input_transfer_func` function in the `dce110_hwseq.c` file. The variable `tf` is assigned the address of `plane_state->in_transfer_func` unconditiona

[PATCH v2 1/2] drm/amd/display: Enable DCN410 init

Enable initializing Display Manager for DCN410 IP Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index

[PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b

[PATCH] drm/amd/display: Override DCN410 IP version

Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

Patch has been merged to amd-staging-drm-next. On 4/28/24 12:09 PM, Aurabindo Pillai wrote: Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be.  I went a bit crazy re-indenting

Re: [PATCH] drm/amd/display: re-indent dpp401_dscl_program_isharp()

Thanks for the fix! Reviewed-by: Aurabindo Pillai On 4/28/24 8:42 AM, Dan Carpenter wrote: Smatch complains because some lines are indented more than they should be. I went a bit crazy re-indenting this. ;) The comments were not useful except as a marker of things which are left

[PATCH 37/37] drm/amd/display: 3.2.282

From: Aric Cyr Summary: * Changes across DSC, MST, DMCUB, Panel Replay and misc fixes. * Fixes to cursor programming sequence * Add some missing register defs * Formatting/Sytle fixes Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd

[PATCH 36/37] drm/amd/display: [FW Promotion] Release 0.0.214.0

From: Anthony Koo - Adjust the dmub_fw_boot_options reserved bits to be correct Acked-by: Aurabindo Pillai Signed-off-by: Anthony Koo Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 35/37] drm/amd/display: Replace uint8_t with u8 for dp_hdmi_dongle_signature_str

From: Rodrigo Siqueira The string dp_hdmi_dongle_signature_str already uses u8 but the string dp_hdmi_dongle_signature_str does not. Just replace uint8_t with u8 for dp_hdmi_dongle_signature_str. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested

[PATCH 33/37] drm/amd/display: Keep VBios pixel rate div setting util next mode set

mode set. Reviewed-by: Jun Lei Acked-by: Aurabindo Pillai Signed-off-by: yi-lchen Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++ .../drm/amd/display/dc/dcn314/dcn314_dccg.c | 12 ++--- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 13 +++--- .../

[PATCH 34/37] drm/amd/display: Update dcn351 debug flags and function pointers

From: Sung Joon Kim [why & how] There are potential issues with Z8 and IPS that need to be addressed and need to add in missing function pointers. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Daniel Wheeler --- drivers/gpu/drm

[PATCH 32/37] drm/amd/display: Disable error correction if it's not supported

From: Cruise [Why] Error correction was enabled in a monitor which doesn't support. [How] Disable error correction if it's not supported Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Cruise Tested-by: Daniel Wheeler --- .../display/dc/link/protocols/link_dp_phy.c

[PATCH 31/37] drm/amd/display: Fix recout calculation for stereo side-by-side

From: Sung Joon Kim [why & how] The recout x offset was incorrect which led to wrong viewport calculation. For stereo side-by-side case, the slice index should be 0 for both split pipes. Reviewed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Da

[PATCH 30/37] drm/amd/display: Set cursor attributes before position

to ensure hubp has the right attributes to be programmed. Reviewed-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c | 2 +- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 2

[PATCH 29/37] drm/amd/display: Separate setting and programming of cursor

-by: Agustin Gutierrez Acked-by: Aurabindo Pillai Signed-off-by: Harry Wentland Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 6 +- .../gpu/drm/amd/display/dc/core/dc_stream.c | 87 +-- drivers/gpu

[PATCH 28/37] Revert "drm/amd/display: Fix incorrect pointer assignment"

-by: Chaitanya Dhere Acked-by: Aurabindo Pillai Signed-off-by: Joshua Aberback Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/core/dc_state.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_state.c b/drivers

[PATCH 27/37] drm/amd/display: Add condition for dp_set_dsc_config call

From: Ilya Bakoulin Not every ASIC implements dp_set_dsc_config. Add condition to prevent calls to unimplemented function. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Ilya Bakoulin Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 16

[PATCH 26/37] drm/amd/display: Allocate zero bw after bw alloc enable

, this causes bw allocation failure when allocation greater than estimated bw. [How] Do zero alloc to make the CM to release preallocation and update estimated BW correctly for all DPIAs per host router. Reviewed-by: PeiChen Huang Acked-by: Aurabindo Pillai Signed-off-by: Meenakshikumar

[PATCH 25/37] drm/amd/display: Fix incorrect DSC instance for MST

tor->sink check to find pipe_ctx. CC: sta...@vger.kernel.org Reviewed-by: Aurabindo Pillai Signed-off-by: Hersen Wu Tested-by: Daniel Wheeler --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 48 ++- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/g

[PATCH 24/37] drm/amd/display: Force flush after write to IPS driver signals

From: Nicholas Kazlauskas [Why] It's possible that the write hasn't fully completed by the time we send (and flush) a command to DMCUB to notify idle to request IPS2 exit. [How] Perform a readback of the volatile structure into dc_dmub_srv state. Reviewed-by: Charlene Liu Acked-by: Aurabindo

[PATCH 23/37] drm/amd/display: Block FPO According to Luminance Delta

will flicker. - Generalized increase/reduce dependent functions to reduce code clutter and allow for easier use. - Added a debug option to enable the feature. Disabled by default. Co-authored-by: Ethan Bitnun Reviewed-by: Dillon Varone Acked-by: Aurabindo Pillai Signed-off-by: Ethan Bitnun

[PATCH 22/37] drm/amd/display: Skip SST ACT polling when sink_count is 0

uld be skipped when clearing the payload allocation table. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: George Shen Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 21/37] drm/amd/display: Atom Integrated System Info v2_2 for DCN35

w BIOS version 2.3. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Gabe Teeger Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/d

[PATCH 20/37] drm/amd/display: Add delay to improve LTTPR UHBR interop

From: Michael Strauss [WHY] Avoid race condition which puts LTTPR into bad state during UHBR LT. [HOW] Delay 30ms between starting UHBR TPS1 PHY output and sending TPS1 via DPCD. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss Tested-by: Daniel Wheeler

[PATCH 19/37] drm/amd/display: Handle HPD_IRQ for internal link

-by: Aurabindo Pillai Signed-off-by: Sung-huai Wang Tested-by: Daniel Wheeler --- .../dc/link/protocols/link_dp_irq_handler.c | 25 --- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c b/drivers/gpu

[PATCH 18/37] drm/amd/display: Reuse the modified power sequence

From: Sung Joon Kim [why & how] Need to update the function pointers that perform the power up and down sequence to reuse the modified sequence as a requirement. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim Tested-by: Daniel Wheeler --- dri

[PATCH 17/37] drm/amd/display: Add dtbclk access to dcn315

wed-by: Dmytro Laktyushkin Acked-by: Aurabindo Pillai Signed-off-by: Swapnil Patel Tested-by: Daniel Wheeler --- .../drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c b/drive

[PATCH 16/37] drm/amd/display: Add null check in resource_log_pipe_topology_update

eck in dc_resource.c/resource_log_pipe_topology_update. CC: sta...@vger.kernel.org Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Natanel Roizenman Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 15/37] drm/amd/display: Fix Replay Desync Error Test

From: Dennis Chan When PHY power off, the DP_SEC_CNTL cannot be configured and cause disable Adaptive sync SDP failed. Regarding the issue, the driver will disabled AS-SDP in replay state machine. Reviewed-by: ChunTao Tso Acked-by: Aurabindo Pillai Signed-off-by: Dennis Chan Tested

[PATCH 14/37] drm/amd/display: Drop unnecessary semicolon

From: Rodrigo Siqueira Drop unnecessary semicolon that can create a problem of double semicolon in some compilers. Reviewed-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: Rodrigo Siqueira Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_opp.h | 3

[PATCH 13/37] drm/amd/display: Add missing IRQ types

From: Rodrigo Siqueira This commit add some DPCX IRQ types. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/irq_types.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 11/37] drm/amd/display: Update comments in DC

From: Rodrigo Siqueira This commit adds, updates, and removes some of the comments used in the DC code. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h| 2 +- .../gpu/drm/amd/display/dc/dpp/dcn201

[PATCH 12/37] drm/amd/display: Ensure that dmcub support flag is set for DCN20

From: Rodrigo Siqueira In the DCN20 resource initialization, ensure that DMCUB support starts configured as true. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/resource/dcn20/dcn20_resource.c | 1 + 1 file changed, 1

[PATCH 10/37] drm/amd/display: Add some HDCP registers DCN35 list

From: Rodrigo Siqueira Add some missing HDCP registers to be used in DCN35. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../amd/display/dc/dcn35/dcn35_dio_link_encoder.h| 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff

[PATCH 09/37] drm/amd/display: Code style adjustments

From: Rodrigo Siqueira This commit address some small code style issues in DC. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dcn321/dcn321_dio_link_encoder.c| 3 +-- drivers/gpu/drm/amd/display/dc/dm_helpers.h

[PATCH 08/37] drm/amd/display: Adjust registers sequence in the DIO list

From: Rodrigo Siqueira This commit reorganizes the order in which some control registers are presented to make it easier to identify the operations based on the hardware doc. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc

[PATCH 06/37] drm/amd/display: Handle Y carry-over in VCP X.Y calculation

From: George Shen Theoretically rare corner case where ceil(Y) results in rounding up to an integer. If this happens, the 1 should be carried over to the X value. CC: sta...@vger.kernel.org Reviewed-by: Rodrigo Siqueira Signed-off-by: George Shen Tested-by: Daniel Wheeler ---

[PATCH 07/37] drm/amd/display: Clean up code in DC

From: Rodrigo Siqueira This commit removes some unnecessary code and makes the required adjustments to replace other parts of the code with a short option. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dce

[PATCH 05/37] drm/amd/display: Increase SAT_UPDATE_PENDING timeout

From: Dmytro Laktyushkin Headless dp 2.0 will take longer to update. Reviewed-by: Rodrigo Siqueira Signed-off-by: Dmytro Laktyushkin Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/dcn31/dcn31_hpo_dp_link_encoder.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 04/37] drm/amd/display: Add some missing HDMI registers for DCN3x

From: Rodrigo Siqueira This commit add some missing HDMI control registers to DCN3x. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dccg.h | 3 +++ drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dccg.h

[PATCH 03/37] drm/amd/display: Add TMDS DC balancer control

From: Rodrigo Siqueira Add TMDS balancer control to the list of available encoder registers for DCN 30. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dio_link_encoder.h | 3 ++- 1 file changed, 2

[PATCH 02/37] drm/amd/display: Add missing dwb registers

From: Rodrigo Siqueira DCN3.0 supports some specific DWB debug registers that are not exposed yet. This commit just adds the missing registers. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb.h | 14

[PATCH 01/37] drm/amd/display: Add missing debug registers for DCN2/3/3.1

From: Rodrigo Siqueira This commit add some missing debug registers for DPCS and RDPC debug. Signed-off-by: Rodrigo Siqueira Acked-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- .../amd/display/dc/dcn20/dcn20_link_encoder.h | 5 +++- .../display/dc/dcn31/dcn31_dio_link_encoder.h | 2

[PATCH 00/37] DC Patches April 22, 2024

Summary: * Changes across DSC, MST, DMCUB, Panel Replay and misc fixes. * Fixes to cursor programming sequence * Add some missing register defs * Formatting/Sytle fixes == Anthony Koo (1): drm/amd/display: [FW Promotion] Release 0.0.214.0 Aric Cyr (1):

[PATCH] drm/amd: Update atomfirmware.h for DCN401

Add new firmware header definitions reqiured for DCN401 Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/include/atomfirmware.h | 33 ++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include

[PATCH 13/15] drm/amd/display: Increase ips2_eval delay for DCN35

From: Nicholas Kazlauskas [Why] New worst-case measurement observed at 1897us. [How] Increase to 2000us to cover the new worst case + margin. Reviewed-by: Ovidiu Bunea Acked-by: Aurabindo Pillai Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/resource/dcn35

[PATCH 15/15] drm/amd/display: 3.2.272

. * HDMI compliance test fixes and other improvements Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 10/15] drm/amd/display: Add shared firmware state for DMUB IPS handshake

-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 83 +++-- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 6 +- .../gpu/drm/amd/display/dmub/inc

[PATCH 11/15] drm/amd/display: allow psr-su/replay for z8

From: Charlene Liu [why] allow psr-su/replay for z8 Reviewed-by: Muhammad Ahmed Reviewed-by: Sung joon Kim Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_smu.c | 12 ++-- drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c

[PATCH 06/15] drm/amd/display: enable fgcg by default

From: Charlene Liu [why] sw has most of the fgcg enabled which is the same as HW default. but driver disabled some due to enable flag not initialized. comparing HW state, we still need to enable dpp and dio. Reviewed-by: Muhammad Ahmed Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu

[PATCH 14/15] Revert "drm/amd/display: Add left edge pixel for YCbCr422/420 + ODM pipe split"

From: George Shen [Why/How] A regression was identified with the change to add left edge pixel for YCbCr422/420 + ODM combine cases. This reverts commit 8d09500a33f6a0e0df9cf17822fe51520d0df002 Reviewed-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: George Shen --- drivers/gpu

[PATCH 08/15] drm/amd/display: Fix array-index-out-of-bounds in dcn35_clkmgr

From: Roman Li [Why] There is a potential memory access violation while iterating through array of dcn35 clks. [How] Limit iteration per array size. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Roman Li --- .../amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c

[PATCH 12/15] drm/amd/display: should support dmub hw lock on Replay

-by: Aurabindo Pillai Signed-off-by: Martin Tsai --- drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c index ba1fec3016d5

[PATCH 09/15] drm/amd/display: fixed integer types and null check locations

From: Sohaib Nadeem [why]: issues fixed: - comparison with wider integer type in loop condition which can cause infinite loops - pointer dereference before null check Reviewed-by: Josip Pavic Acked-by: Aurabindo Pillai Signed-off-by: Sohaib Nadeem --- .../gpu/drm/amd/display/dc/bios

[PATCH 04/15] Revert "drm/amd/display: Send DTBCLK disable message on first commit"

From: Gabe Teeger This reverts commit 3fda240dc2f6a4a9a3965b80cfb83d0ddfbf489c. System hang observed, this commit is thought to be the regression point. Reviewed-by: Ovidiu Bunea Acked-by: Aurabindo Pillai Signed-off-by: Gabe Teeger --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35

[PATCH 07/15] drm/amd/display: Update FIXED_VS Retimer HWSS Test Pattern Sequences

when performing test pattern overrides. Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/dc.h | 12 + .../display/dc/link/accessories/link_dp_cts.c | 27 +++--- .../hwss/link_hwss_dio_fixed_vs_pe_retimer.c

[PATCH 03/15] drm/amd/display: Preserve original aspect ratio in create stream

during create the stream. Reviewed-by: Aurabindo Pillai Acked-by: Aurabindo Pillai Signed-off-by: Tom Chung --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display

[PATCH 05/15] drm/amd/display: treat plane clip size change as MED update type

params in next program pipe. Reviewed-by: Aric Cyr Acked-by: Aurabindo Pillai Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c| 7 ++- drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers/gpu/drm/amd/display/dc/hwss/dcn20

[PATCH 02/15] Revert "drm/amd/display: increased min_dcfclk_mhz and min_fclk_mhz"

From: Sohaib Nadeem [why]: This reverts commit 5abbfa320b88da6034fd4121fa68c2b0e15e97ac. The commit caused corruption when running some applications in fullscreen Reviewed-by: Alvin Lee Acked-by: Aurabindo Pillai Signed-off-by: Sohaib Nadeem --- drivers/gpu/drm/amd/display/dc/dml/dcn32

[PATCH 01/15] drm/amd/display: Add align done check

From: Zhikai Zhai [WHY] We Double-check link status if training successful, but miss the lane align status. [HOW] Add the lane align status check Reviewed-by: Wenjing Liu Acked-by: Aurabindo Pillai Signed-off-by: Zhikai Zhai --- .../gpu/drm/amd/display/dc/link/protocols/link_dp_training.c

[PATCH 00/15] DC Patches for 12 Feb 2024

Summary: * Revert some changes related to pixel encoding and clocks that cause corruption * IPS hang fix and FGCG enable by default for DCN35 * PSR-SU/Replay fixes * Plane clip size change treated as medium update * Fix for checking link alignment done during link

Re: [PATCH v2] drm/amd/display: Fix late derefrence 'dsc' check in 'link_set_dsc_pps_packet()'

.c:905 link_set_dsc_pps_packet() warn: variable dereferenced before check 'dsc' (see line 903) Cc: sta...@vger.kernel.org Cc: Aurabindo Pillai Cc: Rodrigo Siqueira Cc: Hamza Mahfooz Cc: Wenjing Liu Cc: Qingqing Zhuo Signed-off-by: Srinivasan Shanmugam --- v2: - Corrected the logic when !pi

Re: [PATCH] drm/amd/display: Fix variable deferencing before NULL check in edp_setup_replay()

ol.c:947 edp_setup_replay() warn: variable dereferenced before check 'link' (see line 933) Cc: Bhawanpreet Lakha Cc: Harry Wentland Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam --- .../dc/link/protocols/link_edp_panel_control.c

Re: [PATCH v2] drm/amd/display: Address function parameter 'context' not described in 'dc_state_rem_all_planes_for_stream' & 'populate_subvp_cmd_drr_info'

Lei Cc: Hamza Mahfooz Cc: Aurabindo Pillai Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: Srinath Rao Signed-off-by: Srinivasan Shanmugam --- drivers/gpu/drm/amd/display/dc/core/dc_state.c | 2 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 3 ++- 2 files changed, 3 insertions(+), 2

[PATCH 13/13] drm/amd/display: 3.2.264

From: Aric Cyr Summary: Bug fixes for: * DCN35 power gating * P-state change, & prefetch logic * ABM * DP 2.1 Acked-by: Aurabindo Pillai Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 10/13] drm/amd/display: For prefetch mode > 0, extend prefetch if possible

-by: Jun Lei Acked-by: Aurabindo Pillai Signed-off-by: Alvin Lee --- .../dc/dml/dcn32/display_mode_vba_32.c| 3 ++ .../dc/dml/dcn32/display_mode_vba_util_32.c | 33 +++ .../dc/dml/dcn32/display_mode_vba_util_32.h | 1 + 3 files changed, 31 insertions(+), 6 deletions

[PATCH 08/13] drm/amd/display: Disable OPTC pg to match DC Hubp/dpp pg

From: Allen [Why] To match the hardware sequence Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Allen --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35

[PATCH 04/13] drm/amd/display: Revert "Fix conversions between bytes and KB"

From: Taimur Hassan [Why & How] HostVMMinPageSize is expected to be in KB according to spec, the checks later down the line reflect this as well. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Taimur Hassan --- .../drm/amd/display/dc/dml2/display_mode_co

[PATCH 12/13] drm/amd/display: fix HW block PG sequence

From: Charlene Liu [why] Power up and power down has reverted programming order. also make sure disable root clock last. Reviewed-by: Muhammad Ahmed Acked-by: Aurabindo Pillai Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc/dcn35/dcn35_init.c | 3 +- .../amd/display/dc/hwss

[PATCH 07/13] drm/amd/display: Populate dtbclk from bounding box

From: Fangzhi Zuo dtbclk is unavaliable from pmfw. Try to grab the value from bounding box Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c | 14 +- .../amd/display/dc/dml2

[PATCH 11/13] drm/amd/display: Force p-state disallow if leaving no plane config

in underflow - To fix this issue, force p-state disallow and unforce after the transition from no planes case -> one or more planes active Reviewed-by: Samson Tam Acked-by: Aurabindo Pillai Signed-off-by: Alvin Lee --- .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 20 +++

[PATCH 06/13] drm/amd/display: Revert DP2 MST hub triple display fix

From: Michael Strauss [WHY] Introduces regression with DP2 native displays [HOW] Revert commit 311ba210d Reviewed-by: Charlene Liu Acked-by: Aurabindo Pillai Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 7 --- 1 file changed, 7 deletions

[PATCH 09/13] drm/amd/display: Exit from idle state before accessing HW data

From: Sung Joon Kim [why & how] User interface cannot guarantee system is in idle state, so need to ensure we exit idle state before accessing any HW data. Reviewed-by: Nicholas Kazlauskas Acked-by: Aurabindo Pillai Signed-off-by: Sung Joon Kim --- drivers/gpu/drm/amd/display/dc

[PATCH 01/13] drm/amd/display: Remove minor revision 5 until proper parser is ready

From: Joshua Aberback Reviewed-by: Dillon Varone Acked-by: Aurabindo Pillai Signed-off-by: Joshua Aberback --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd

[PATCH 05/13] drm/amd/display: trivial comment change

FP guard is valid for all recent asics, not just RV, so fix the comment. Reviewed-by: Chaitanya Dhere Acked-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 03/13] drm/amd/display: allow DP40 cables to do UHBR13.5

From: Ran Shi why: With DP2.1a expansion we are allowing DP40 cables to do UHBR13.5 how: Assume UHBR10 means UHBR13.5 also for unknown cable type and passive cable type. Reviewed-by: George Shen Acked-by: Aurabindo Pillai Signed-off-by: Ran Shi --- .../display/dc/link/protocols

[PATCH 00/13] DC Patches for Dec 11, 2023

/amd/display: For prefetch mode > 0, extend prefetch if possible drm/amd/display: Force p-state disallow if leaving no plane config Aric Cyr (1): drm/amd/display: 3.2.264 Aurabindo Pillai (2): drm/amd/display: Use explicit size for types in DCCG's struct dp_dto_params drm/amd/display:

[PATCH 02/13] drm/amd/display: Use explicit size for types in DCCG's struct dp_dto_params

Reviewed-by: Alvin Lee Acked-by: Aurabindo Pillai Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/dccg.h b/drivers/gpu/drm/amd/display/dc/inc/hw

[PATCH] drm/amd: Add a DC debug mask for DML2

[Why] To enable testing/development of DML2, expose a new debug mask for future use. Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include

Re: [PATCH v2] drm/amd/display: add a debugfs interface for the DMUB trace mask

T__GET_TRACE_BUFFER_MASK_WORD2 = 118, + + /** +* DESC: Updates the trace buffer mask bit32~bit63. + */ + DMUB_GPINT__GET_TRACE_BUFFER_MASK_WORD3 = 119, }; /** Reviewed-by: Aurabindo Pillai

Re: [PATCH] drm/amd/display: add a debugfs interface for the DMUB trace mask

On 2023-11-10 12:18, Hamza Mahfooz wrote: For features that are implemented primarily in DMUB (e.g. PSR), it is useful to be able to trace them at a DMUB level from the kernel, especially when debugging issues. So, introduce a debugfs interface that is able to read and set the DMUB trace mask

Re: [PATCH] drm/amd/display: remove duplicated argument

On 2023-10-29 05:39, José Pekkarinen wrote: Spotted by coccicheck, there is a redundant check for v->SourcePixelFormat[k] != dm_444_16. This patch will remove it. The corresponding output follows. drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated

Re: [PATCH] drm/amdgpu: Refactor 'amdgpu_connector_dvi_detect' in amdgpu_connectors.c

: "Pan, Xinhui" Cc: Rodrigo Siqueira Cc: Aurabindo Pillai Signed-off-by: Srinivasan Shanmugam --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 69 +++ 1 file changed, 42 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b

Re: [PATCH] drm/amd/display: remove redundant check

On 2023-10-30 12:26, José Pekkarinen wrote: On 2023-10-30 15:52, Aurabindo Pillai wrote: On 10/29/2023 8:44 AM, José Pekkarinen wrote: This patch addresses the following warning spotted by using coccinelle where the case checked does the same than the else case. drivers/gpu/drm/amd/display

Re: [PATCH] drm/amd/display: remove duplicated argument

wportWidthChroma[k] > v->SurfaceWidthC[k] || v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) { ViewportExceedsSurface = true; } Thanks for catching. Reviewed-by: Aurabindo Pillai

  1   2   3   4   5   6   >