On Mon, Aug 10, 2020 at 08:41:14PM +0200, Marion & Christophe JAILLET wrote:
>
> Le 10/08/2020 à 17:42, Dan Carpenter a écrit :
> > On Sun, Aug 09, 2020 at 10:34:06PM +0200, Christophe JAILLET wrote:
> > > When '*sgt' is allocated, we must allocated 'sizeo
/* number of mapped entries */
45 unsigned int orig_nents; /* original size of list */
46 };
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
The if statement wasn't indented so it's confusing.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
b/drivers/gpu/drm/amd/displ
The other debugfs functions should probably be updated as well... I
just did this one as an example of how these functions are normally
implemented.
There are some other warnings we could look at as well.
regards,
dan carpenter
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm
the strlen() and in fact is beyond
the end of the buffer.
4) This code re-implements the simple_read_from_buffer() function.
This code can be cleaned up by removing the allocation and using the
simple_read_from_buffer() function.
Fixes: c06e09b76639 ("drm/amd/display: Add DSC parameters
These tables have _COUNT number of elements so the comparisons should be
>= instead of > to prevent reading one element beyond the end of the
array.
Fixes: 8264ee69f0d8 ("drm/amd/powerplay: drop unused code")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerpla
The "stream" pointer can't be NULL and it's dereferenced on the line
before so the check doesn't make sense.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/am
lock_doublebuffer_disable) {
4091 if (pipe_ctx->stream &&
should_use_dmub_lock(pipe_ctx->stream->link)) {
The patch adds a new dereference, is it really required?
4092 union dmub_hw
uot;drm/amdgpu: Add unique_id and serial_number for Arcturus
v3")
Signed-off-by: Dan Carpenter
---
v2: Change adev->serial. The original patch would have just moved the
overflow until amdgpu_device_get_serial_number() is called.
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 ins
On Mon, Jun 08, 2020 at 10:16:27AM -0700, Joe Perches wrote:
> On Mon, 2020-06-08 at 17:16 +0300, Dan Carpenter wrote:
> > These lines are a part of the if statement and they are supposed to
> > be indented one more tab.
> >
> > Signed-off-by: Dan Carpenter
>
The comments say that the "sn" buffer is used to hold a 16-digit HEX
string so the buffer needs to be at least 17 characters to hold the
NUL terminator.
Fixes: 81a16241114b ("drm/amdgpu: Add unique_id and serial_number for Arcturus
v3")
Signed-off-by: Dan Carpenter
---
These lines are a part of the if statement and they are supposed to
be indented one more tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn30
abms[i]->funcs->abm_init(abms[i], backlight);
604 }
605
606 /* power AFMT HDMI memory TODO: may move to dis/en output save
power*/
607 REG_WRITE(DIO_MEM_PWR_CTRL, 0);
608
609 if (!dc->debug.disable_clock_gate) {
ctx->dce_environment)) {
463 if (res_pool->dccg && res_pool->hubbub)
{
^^
This check is too late.
464
465
(res_pool->dccg->funcs->get_dccg_ref_freq)(res_pool->dccg,
regards,
dan carpen
sibly be NULL.
110 return;
111
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code")
Signed-off-by: Dan Carpenter
---
v2: style change
v3: Fix embarrassing typo in the subject
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/d
847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code")
Signed-off-by: Dan Carpenter
---
v2: style change
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/
On Wed, May 20, 2020 at 02:05:19PM +0200, Christian König wrote:
> Am 20.05.20 um 14:00 schrieb Dan Carpenter:
> > This loop in the error handling code should start a "i - 1" and end at
> > "i == 0". Currently it starts a "i" and ends at "i == 1&
847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index
how it tracks ras->supported.
I will fix this.
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
ever we want. Premusably
there is a trusted app which knows how to write the correct values.
But if it has a bug that will cause a crash and we'll have to find a
way to disable it in the kernel for kernel lock down mode etc so either
way we'll need to do a bit of work.
210
rolled) shift '(((1))) << (head->block)'
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
return -EAGAIN;
624 return -EINVAL;
625 }
626 }
627
628 /* setup the obj */
629 __amdgpu_ras_feature_enable(adev, head, enable);
630
631 return 0;
632 }
regards,
dan carpenter
_
ce_lock_adev()
will only return false when "hive" is NULL.
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
gpu reset for XGMI setup V2".
>
> Change-Id: I9c22b57abc9f512114112f93fb035f1fecf26beb
> Signed-off-by: Evan Quan
> Reported-by: Dan Carpenter
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/driv
mutex_unlock(&hive->hive_lock);
NULL dereference.
4200 return 0;
4201 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
oed
for now*/
136 { 0 }
137 };
138
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Mon, Apr 06, 2020 at 12:22:51PM -0400, Kazlauskas, Nicholas wrote:
> On 2020-04-06 5:19 a.m., Dan Carpenter wrote:
> > This TODO stub originally had curly braces but we deleted them as part
> > of a clean up. Unfortunately that changes the behavior of the code
> > b
And it also adds NULL checking on dmcu.
665 return true;
666
667 memset(&ram_table, 0, sizeof(ram_table));
668
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
mdgpu/../display/dc/core/dc_link.c:425
link_detect_sink() warn: if statement not indented
Also I changed "ZAZTODO" to just "TODO". The ZAZ isn't used anywhere
else.
Fixes: 621514aa4140 ("drm/amd/display: codestyle cleanup on dc_link file until
detect_dp func")
S
t;drm/amdgpu: revise RLCG access path")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 7bc2486167e7..affbff76758c 100
am) {
> + dc_stream_release(new_stream);
> + new_stream = NULL;
> + }
>
>
> dc_stream_release() is NULL-checked, so the if can be dropped.
>
> re,
> wh
Walter, it's really hard to separate your reply from the quoted
can't be NULL. For
"res_ctx->pipe_ctx[i].stream->link" we know that it is equal to "link"
and "link" is non-NULL.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions
sprintf(fs_info.debugfs_name, "%s_err_inject",
1138 ras_block_str(obj->head.block));
1139 fs_info.head = obj->head;
1140 amdgpu_ras_debugfs_create(adev, &fs_info);
1141 }
1142
On Tue, Nov 28, 2017 at 09:37:44AM -0500, Tom St Denis wrote:
> On 28/11/17 09:29 AM, Dan Carpenter wrote:
> > Hello Tom St Denis,
> >
> > The patch c5a60ce81b49: "drm/amd/amdgpu: Add debugfs support for
> > reading GPRs (v2)" from Dec 5, 2016, leads to the
This is freeing the wrong variable so it will crash. It should be
freeing "*dmub" instead of "dmub".
Fixes: 4c1a1335dfe0 ("drm/amd/display: Driverside changes to support PSR in
DMCUB")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/dce/dmub_p
On Fri, Feb 28, 2020 at 11:05:11AM +0100, Michel Dänzer wrote:
> On 2020-02-28 9:22 a.m., Dan Carpenter wrote:
> > These lines need to be re-ordered so that we don't dereference "dmub"
> > after we just freed it.
> >
> > Fixes: 4c1a1335dfe0 ("drm/am
These lines need to be re-ordered so that we don't dereference "dmub"
after we just freed it.
Fixes: 4c1a1335dfe0 ("drm/amd/display: Driverside changes to support PSR in
DMCUB")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 +-
1
These lines were accidentally indented 4 spaces more than they should
be.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers
The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return a negative error code to the user.
Fixes: 030d5b97a54b ("drm/amdgpu: use amdgpu_device_vram_access in
amdgpu_ttm_vram_read")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/
Fixes: 9aeb8a134a0a ("drm/amd/display: Add sysfs interface for set/get srm")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_
66 ("drm/amdgpu: use kernel is_power_of_2 rather than
> > local version")
>
> Aside: This bisect line is complete nonsense ... I'm kinda at the
> point where I'm assuming that syzbot bisect results are garbage, which
> is maybe not what we want. I guess
On Sat, Feb 01, 2020 at 05:02:47PM +0800, Hillf Danton wrote:
>
> On Sat, 1 Feb 2020 09:17:57 +0300 Dan Carpenter wrote:
> > On Sat, Feb 01, 2020 at 12:32:09PM +0800, Hillf Danton wrote:
> > >
> > > Release obj in error path.
> > >
> > > --- a/dri
;88809fa67900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> > ^
> > 88809fa67980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> > 88809fa67a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
> > ====
R_PTR(ret);
202
203 return &obj->base;
204 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
If "speed" is zero then we use it as a divisor to find "prescale". It's
better to move the check for zero to the very start of the function.
Fixes: 9eeec26a1339 ("drm/amd/display: Refine i2c frequency calculating
sequence")
Signed-off-by: Dan Carpenter
---
RITE_CLEAN_RAW_MASK;
1090 SOC15_WAIT_ON_RREG(VCN, 0, mmUVD_LMI_STATUS, tmp, tmp, r);
1091 if (r)
1092 return r;
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Originally the last WREG32_SOC15() was a part of the if statement block
but the curly braces are on the wrong line.
Fixes: bb0db70f3f75 ("drm/amdgpu: separate JPEG1.0 code out from VCN1.0")
Signed-off-by: Dan Carpenter
---
From static analysis (Smatch). Not tested.
drivers/gpu/drm/
have to unreserve this?
215 }
216
217 radeon_bo_unreserve(rdev->uvd.vcpu_bo);
218
219 for (i = 0; i < rdev->uvd.max_handles; ++i) {
220 atomic_set(&rdev->uvd.handles[i], 0);
221 rdev->uvd.filp[i] =
There is a typo so this unreserves "sobj" instead of "dobj".
Fixes: bb812f1ea87d ("drm/amdgpu: allocate gart memory when it's required (v3)")
Signed-off-by: Dan Carpenter
---
From static analysis. Not tested.
drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c
destroy DAL */
1049 if (adev->dm.dc)
^^^^^^^
Check
1050 dc_destroy(&adev->dm.dc);
1051 /*
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
ailed finding vcpi slots: %d\n",
(int)dm_new_connector_state->vcpi_slots);
4872 return dm_new_connector_state->vcpi_slots;
4873 }
4874 return 0;
4875 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
N clock gating */
1299 REG_WRITE(DCCG_GATE_DISABLE_CNTL, 0);
1300
1301 REG_WRITE(DCCG_GATE_DISABLE_CNTL2, 0);
1302
1303 REG_UPDATE(DCFCLK_CNTL, DCFCLK_GATE_DIS, 0);
1304 }
1305
1306 dc->hwss.en
fence = sched->ops->run_job(s_job);
/* FIXME: Oct 2019: Remove this code when fence can't be NULL. */
if (!fence)
fence = ERR_PTR(-EINVAL);
if (IS_ERR(fence)) {
...
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
:
- if (IS_ERR(fence))
- return PTR_ERR(fence);
- return 0;
+ return PTR_ERR_OR_ZERO(fence);
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
ialized
symbol 'baco_reset'.
Fixes: 425db2553e43 ("drm/amdgpu: expose BACO interfaces to upper level from
PP")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/powerplay/amd
This function needs to drop the mutex before returning.
Fixes: f7e3a5776fa6 ("drm/amd/powerplay: check SMU engine readiness before
proceeding on S3 resume")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
d make "i" signed int for the error handling to work, so I just
updated "ret" as well as a clean up.
Fixes: f96357a991b9 ("drm/amd/powerplay: implement
smu_init(fini)_fb_allocations function")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 5 +
In the current code if "device_info" is ever NULL then the kernel will
Oops so probably || was intended instead of &&.
Fixes: e392c887df97 ("drm/amdkfd: Use array to probe kfd2kgd_calls")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_device
X_CHANNEL_OPERATION_FAILED_TIMEOUT:
119 result = -ETIMEDOUT;
120 break;
121 }
122
123 return result;
124 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
The navi10_message_map[] array has SMU_MSG_MAX_COUNT elements so the ">"
has to be changed to ">=" to prevent reading one element beyond the end
of the array.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +-
1 file changed, 1 inserti
ay_table = table;
398 if (!smu->smu_table.power_play_table_size)
399 smu->smu_table.power_play_table_size = size;
400
401 return 0;
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
3229
3230 if (!dc->clk_mgr->funcs->get_clock)
^
This will oops if ->clk_mgr is NULL
3231 return DC_FAIL_UNSUPPORTED_1;
3232
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
be NULL. I'm mostly pointing this out because that NULL
check is written so higgledy-piggledy. At first I thought this was
staging code so I was planning to ignore the patch. :P
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
clarify that with comments. I'll try to address this in
> a coming patch.
>
Part of the reason for error handling is just to silence static checker
warnings because otherwise everyone has to review it to see if the
resource leaks are important. It's easier in the long ru
pr_warn("Creating pasid for pid %d failed",
316 (int)process->lead_thread->pid);
Error handling and error code missing.
317 }
318 out:
319 mutex_unlock(&kfd_processes_mutex);
320
On Mon, Jun 24, 2019 at 05:29:33PM +0800, maowenan wrote:
>
>
> On 2019/6/24 16:39, Dan Carpenter wrote:
> > On Mon, Jun 24, 2019 at 11:45:32AM +0800, Mao Wenan wrote:
> >> There is one warning:
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c: In function ‘amdgpu_pm
uld be. If
we were to remove the "ret = " then we'd have to pull the arguments back
as well. I think this fix that Julia suggested is really the right so
leave the indenting alone.
It looks like you've right aligned the arguments. That's not the right
way, the original was correct.
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Sat, Jun 22, 2019 at 01:43:19PM +0300, Dan Carpenter wrote:
> On Sat, Jun 22, 2019 at 11:03:14AM +0800, Mao Wenan wrote:
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> > index 0e6dba9..0bf4dd9 100644
> > --- a
MAX_COUNTERS);
You're resending this for other reasons, but don't forget to update the
indenting on the arguments so they still line up with the '('.
regards,
dan carpenter
eal life, because debugfs is
generally root only.
Fixes: 36ea1bd2d084 ("drm/amdgpu: add debugfs ctrl node")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
b/drivers/gp
n readers, because people naturally assume it
is not dead.
GCC has a feature to warn about uninitialized variables and we're
randomly initializing status to a bogus value to disable static
analysis...
regards,
dan carpenter
f)
^
Can link_stream be NULL?
2927 return;
2928
2929 if (link_stream)
^^^
We check here so maybe?
2930 decide_link_settings(link_stream, &store_settings);
2931
regard
There is a typo so the code unlocks twice instead of taking the lock and
then releasing it.
Fixes: f14a323db5b0 ("drm/amd/powerplay: implement update enabled feature state
to smc for smu11")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +-
1 file
gt; - if (ret)
> - return ret;
> + return -EINVAL;
From a naive reading of the code without knowing the hardware spec then
you would probably think that lo_base_addr can also be uninitialized.
regards,
dan carpenter
_
DRM_ERROR("failed to reserve buffer before
flip\n");
5350
5351 amdgpu_bo_get_tiling_flags(abo, &tiling_flags);
5352
5353 amdgpu_bo_unreserve(abo);
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Tue, Apr 23, 2019 at 02:16:53PM +, Kazlauskas, Nicholas wrote:
> On 4/23/19 10:10 AM, Dan Carpenter wrote:
> > Hello David Francis,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch c238bfe0be9e: "drm/a
XEL_FORMAT_GRPH_BEGIN;
1489
1490 if (u->plane_info)
1491 format = u->plane_info->format;
1492 else if (u->surface)
^^
But the old code assumed it could be NULL
1493
^^
New check
551 return;
552
553 if (link_stream)
^^^
The old code used to check for NULL
554 decide_link_settings(link_stream, &store_settings);
555
regards,
dan carpenter
___
update = vupdate_line - vpos;
221 us_to_vupdate = lines_to_vupdate * us_per_line;
222
223 /* 70 us is a conservative estimate of cursor update
time*/
224 if (us_to_vupdate < 70)
225 udelay(us_to_vupdat
The > should be >= so that we don't read one element beyond the end of
the vega20_message_map[] array.
Fixes: 3ec3c931489f ("drm/amd/powerplay: implement smu vega20_message_map for
vega20")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 3 +
On Thu, Mar 21, 2019 at 09:20:38AM +0100, Julia Lawall wrote:
>
>
> On Thu, 21 Mar 2019, Huang, Ray wrote:
>
> > > -Original Message-
> > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> > > Sent: Thursday, March 21, 2019 2:28 PM
> >
We already unlocked a few lines earlier so this code unlocks twice on
the success path.
Fixes: 5809d7420f97 ("drm/amd/powerplay: implement sysfs of pp_table for smu11
(v2)")
Signed-off-by: Dan Carpenter
---
I'm not sure what this bug looks like at runtime, but it's slight
The "size" variable is unsigned. We never pass invalid sizes to this
function and we already used it as an array offset earlier so it's
too late to check here.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 3 ---
1 file changed, 3 deletions(-
on || !data || !bps || pages <= 0)
Check
1216 return 0;
1217
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amdgpu_lockup_timeout is an int and I'm not sure if that's what you
want to test. MAX_SCHEDULE_TIMEOUT is LONG_MAX.
271 amdgpu_device_gpu_recover(adev, NULL);
272 }
regards,
dan carpenter
dc_state);
4851 mutex_unlock(&dm->dc_lock);
4852 }
4853
4854 if (planes_count) {
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi David,
url:
https://github.com/0day-ci/linux/commits/David-Francis/Make-DRM-DSC-helpers-more-generally-usable/20190214-052541
smatch warnings:
drivers/gpu/drm/drm_dsc.c:306 drm_dsc_compute_rc_parameters() warn: impossible
condition '(vdsc_cfg->nfl_bpg_offset > 65535) => (0-u16max > u16max
ine) - 1;
154 else
155 *start_line = vsync_line - req_delta_lines;
156
157 *end_line = *start_line + 2;
158
159 if (*end_line >= dc_crtc_timing->v_total)
160 *end
am(
4765 dm,
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
quot;dc->current_state" gets dereferenced inside the function. This style
of one function cleans up everything error handling is always buggy...
:/
https://plus.google.com/u/0/106378716002406849458/posts/1Ud9JbaYnPr
755 return false;
756 }
regards,
dan carpenter
___
_topology(hive, tmp_adev);
141 if (ret)
142 break;
143 }
144
145 exit:
146 mutex_unlock(&xgmi_mutex);
147 return ret;
148 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
(struct kgd_mem **)&mem,
&size,
1646NULL);
1647 if (r)
1648 goto err_unlock;
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amdgpu_dm_update_connector_after_detect(aconnector);
1793
1794 } else if (dc_link_detect(link, DETECT_REASON_BOOT)) {
1795
amdgpu_dm_update_connector_after_detect(aconnector);
1796 register_backli
NULL || fs_params->max_content == 0 ||
^
Too late.
827 fs_params->max_display == 0)
828 return false;
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.free
if amdgpu_bo_create_kernel() fails.
50 return 0;
51 }
regards,
dan carpenter
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
init_params->asic_id);
676 if (!dc->res_pool)
677 goto fail;
678
679 dc_resource_state_construct(dc, dc->current_state);
680
681 if (!create_links(dc, init_params->num_virtual_links))
682
updates[num_plane].surface->dst_rect =
5196
new_dm_plane_state->dc_state->dst_rect;
5197
updates[num_plane].surface->rotation =
regards,
dan carpenter
___
amd-gfx mailing l
The debugfs_create_file() returns error pointers if DEBUGFS isn't
enabled. But here, we know that it is enabled so it returns NULL on
error which could lead to a NULL dereference a few lines later.
Signed-off-by: Dan Carpenter
---
If someone wanted to delete the error handling as well
^
The old code didn't check.
1464 // if otg funcs defined check
if blanked before programming
1465 if
(!pipe_ctx->stream_r
201 - 300 of 369 matches
Mail list logo
