On Wed, May 16, 2018 at 2:11 PM, Grazvydas Ignotas wrote:
> On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
>> From: Shaoyun Liu
>>
>> v2: cleanups (Alex)
>> v3: make it vega20 only (Alex)
>>
>> Signed-off-by: Shaoyun Liu
>> Acked-by:
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Shaoyun Liu
>
> v2: cleanups (Alex)
> v3: make it vega20 only (Alex)
>
> Signed-off-by: Shaoyun Liu
> Acked-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/emu_soc.c | 10091
> +
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Feifei Xu
>
> Signed-off-by: Feifei Xu
> Reviewed-by: Alex Deucher
> Reviewed-by: Hawking Zhang
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Tue, May 15, 2018 at 5:59 PM, Alex Deucher wrote:
> From: Roman Li
>
> Updating dce12 register headers by adding dc registers
> required for potential DP LTTPR support.
>
> Signed-off-by: Roman Li
> Acked-by: Alex Deucher
> Signed-off-by: Alex Deucher
> ---
> .../drm/amd/include/asic_reg/d
On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu wrote:
> when this bit was set on module load,
> driver will allow the user over/under gpu
> clock and voltage through sysfs.
>
> by default, this bit was not set.
>
> Reviewed-by: Alex Deucher
> Signed-off-by: Rex Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/
On Wed, Jan 10, 2018 at 1:01 PM, Rex Zhu wrote:
> Change-Id: I0a554cb6a7a56db63a8fc5af60d5c63f65e021d1
> Signed-off-by: Rex Zhu
> ---
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 39 +++
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 78
> ++
> driv
On Tue, Nov 7, 2017 at 9:26 AM, Pixel Ding wrote:
> From: pding
>
> ...
>
> Signed-off-by: pding
You need to fix your git config user.name.
Gražvydas
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
On Tue, May 30, 2017 at 6:30 AM, Michel Dänzer wrote:
> On 29/05/17 06:20 PM, Michel Dänzer wrote:
>> From: Michel Dänzer
>>
>> Even if CONFIG_DRM_AMDGPU_CIK is enabled.
>>
>> There is no feature parity yet for CIK, in particular amdgpu doesn't
>> support HDMI/DisplayPort without DC.
>>
>> Signed
e version.
Libraries can't print to stdout as it will break all programs that
parse the output, apitrace is one such example.
>
> Thanks,
> Sam
>
> -Original Message-
> From: Grazvydas Ignotas [mailto:nota...@gmail.com]
> Sent: Friday, May 12, 2017 8:16 AM
> To
On Fri, May 12, 2017 at 12:19 AM, Samuel Li wrote:
> From: Xiaojie Yuan
>
> v2: fix an off by one error and leading white spaces
>
> Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9
> Reviewed-by: Junwei Zhang
> Signed-off-by: Samuel Li
> ---
> amdgpu/Makefile.am | 2 +
> amdgpu/Ma
On Mon, Apr 10, 2017 at 12:37 PM, Huang Rui wrote:
> ASIC_INIT_COMPLETE bit must be cleared during S3 resuming phase,
> because VBIOS will check the bit to decide if execute ASIC_Init
> posting via kernel driver.
>
> Signed-off-by: Huang Rui
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c
On Tue, Mar 21, 2017 at 9:44 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> also adjust the comments
>
> Signed-off-by: Marek Olšák
> ---
> include/uapi/drm/amdgpu_drm.h | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi
From: Alex Xie
vamgr_32 is an integral part of amdgpu_device. We don't need to calloc and free
it.
This can save CPU time, reduce heap fragmentation.
Signed-off-by: Alex Xie
Reviewed-by: Christian König
[Grazvydas Ignotas: rebase, correct a typo in commit message]
---
amdgpu/amdgpu_dev
From: Alex Xie
vamgr is an integral part of amdgpu_device. We don't need to calloc and free it.
This can save CPU time, reduce heap fragmentation.
Signed-off-by: Alex Xie
Reviewed-by: Christian König
[Grazvydas Ignotas: rebase, correct a typo in commit message]
---
amdgpu/amdgpu_dev
From: Alex Xie
vamgr_32 is an integral part of amdgpu_device. We don't need to calloc and free
it.
This can save CPU time, reduce heap fragmentation.
Signed-off-by: Alex Xie
Reviewed-by: Christian König
[Grazvydas Ignotas: rebase, correct a typo in commit message]
---
amdgpu/amdgpu_dev
From: Alex Xie
vamgr_32 is a region inside general VAM range. It is better to free and
deinitialize it before general VAM range.
Signed-off-by: Alex Xie
Reviewed-by: Christian König
---
amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/amdgpu/amdgp
I've taken several patches from amdgpu-pro libdrm that look useful
to me and I think can be applied already. The only things I did was
rebasing, fixing some typos and dropping Change-Id.
Alex Xie (3):
amdgpu: Free/uninit vamgr_32 in theoretically correct order
amdgpu: vamgr can be a struct ins
On Thu, Jan 19, 2017 at 4:32 PM, Christian König
wrote:
> Am 19.01.2017 um 14:51 schrieb Grazvydas Ignotas:
>>
>> On Thu, Jan 19, 2017 at 11:10 AM, Christian König
>> wrote:
>>>
>>> Am 18.01.2017 um 12:42 schrieb Monk Liu:
>>>>
>>>&g
On Thu, Jan 19, 2017 at 11:10 AM, Christian König
wrote:
> Am 18.01.2017 um 12:42 schrieb Monk Liu:
>> @@ -6743,6 +6741,15 @@ static void gfx_v8_ring_emit_cntxcntl(struct
>> amdgpu_ring *ring, uint32_t flags)
>> if (amdgpu_sriov_vf(ring->adev))
>> gfx_v8_0_ring_emit_de_meta
On Thu, Dec 15, 2016 at 4:12 PM, Christian König
wrote:
>
> Regarding which error code to return I think that Emil has the right idea
> here.
>
> Returning -EINVAL usually means that userspace provided an invalid value,
> but in this case it doesn't matter which value the UMD provide all of them
>
On Thu, Dec 15, 2016 at 1:47 PM, Nath, Arindam wrote:
>>-Original Message-
>>From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
>>Sent: Thursday, December 15, 2016 5:01 PM
>>To: Nath, Arindam
>>Cc: David Airlie; Deucher, Alexander; amd-gfx mailing list; ML dri-devel;
>>Koenig, Christian
On Thu, Dec 8, 2016 at 11:50 AM, Huang Rui wrote:
> On Thu, Dec 08, 2016 at 05:27:30PM +0800, Christian König wrote:
>> Am 08.12.2016 um 10:02 schrieb Huang Rui:
>> > On Thu, Dec 08, 2016 at 04:41:04PM +0800, Koenig, Christian wrote:
>> >> Sorry, but that just sounds like OS abstraction code which
On Wed, Nov 2, 2016 at 12:27 PM, Rex Zhu wrote:
> Change-Id: I3288a5a4bbca122d59b81e7635be5e5aeda8abeb
> Signed-off-by: Rex Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 6 +--
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 51
> +--
> drivers/gpu/d
Hi,
On Sun, Oct 30, 2016 at 7:10 AM, Edward O'Callaghan
wrote:
> Howdy,
>
> On 10/30/2016 07:28 AM, Grazvydas Ignotas wrote:
>> Powerplay hwmgr already has an implementation, all we need to do is to call
>> it.
>>
>> Signed-off-by: Grazvydas Ignotas
&g
Otherwise callers end up using uninitialized data.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c
b/drivers/gpu/drm/amd
Only for cards that are supported by powerplay.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 21 +
2 files changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h
b
Powerplay hwmgr already has an implementation, all we need to do is to call it.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++
drivers/gpu/drm/amd/powerplay/inc/amd_powerplay.h | 1 +
2 files changed, 19 insertions(+)
diff --git
the module
> init/finfi functions just like we do it for hw fences.
>
> Reported-by: Grazvydas Ignotas
> Signed-off-by: Christian König
> ---
...
> diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.h
> b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.h
> index 7cbbb
On Mon, Oct 24, 2016 at 12:13 PM, Christian König
wrote:
> Am 24.10.2016 um 04:25 schrieb zhoucm1:
>>
>>
>>
>> On 2016年10月24日 02:31, Grazvydas Ignotas wrote:
>>>
>>> It's done in amd_sched_hw_job_reset(), but not in normal job processing.
>>
On Mon, Oct 24, 2016 at 6:35 AM, Qu, Jim wrote:
> I did observed the issue when replace kernel module use DKMS, and it maybe
> get error at reboot, got calltrace:
>
> [ 3529.525360]
> =
> [ 3529.525361] BUG amd_sched_fen
The names were wrong.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/scheduler/sched_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/scheduler/sched_fence.c
b/drivers/gpu/drm/amd/scheduler/sched_fence.c
index 6b63bea..3653b5a 100644
get a crash in one of rcu threads because callback
is called after amdgpu has already been unloaded.
Fix it with a rcu_barrier().
Fixes: 189e0fb76304 ("drm/amdgpu: RCU protected amd_sched_fence_release")
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/scheduler/gpu_scheduler.
Looks like .last_flush reference is left at teardown.
Leak reported by CONFIG_SLUB_DEBUG.
Fixes: 41d9eb2c5a2a ("drm/amdgpu: add a fence after the VM flush")
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
1 file changed, 1 insertion(+)
diff --git
a crash in one of rcu threads because callback
is called after amdgpu has already been unloaded.
Fix it with a rcu_barrier().
Fixes: b44135351a3a ("drm/amdgpu: RCU protected amdgpu_fence_release")
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1
It's done in amd_sched_hw_job_reset(), but not in normal job processing.
Leak reported by CONFIG_SLUB_DEBUG.
Signed-off-by: Grazvydas Ignotas
---
CONFIG_SLUB_DEBUG reports more leaks related to ioctls,
but I was unable to track them down...
drivers/gpu/drm/amd/scheduler/gpu_scheduler.
Hi,
On Thu, Oct 13, 2016 at 10:45 AM, Zhu, Rex wrote:
>
> The attached patches were also for this issue.
> Disable dpm when rmmod amdgpu.
It works for modprobe-rmmod-modprobe test, thanks.
However with GPU passthrough (giving control of the GPU to a Windows
virtual machine using iommu, then shu
On Wed, Oct 12, 2016 at 2:48 AM, Andy Furniss wrote:
>
> I still can't shutdown/reboot
> as in https://bugs.freedesktop.org/show_bug.cgi?id=98200
> which is fixed for radeon, but apparently not (for me at least) with amdgpu.
You probably need a951ed85abd46 that went to 4.8-fixes and is not part
o
ice_init+0x1aeb/0x2490 [amdgpu]
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
index f
7;i2c-12'
To fix it, we can use the .early_unregister hook to unregister the i2c
adapter before drm_connector's sysfs is torn down.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
On Thu, Sep 29, 2016 at 10:52 AM, Christian König
wrote:
> From: Christian König
>
> It's completely pointsless to have two pointers to the
> device in the same structur.
Several typos here...
Gražvydas
___
amd-gfx mailing list
amd-gfx@lists.freedeskt
Hi,
this patch causes failure on my polaris10 card:
[drm:gfx_v8_0_ring_test_ring] *ERROR* amdgpu: ring 0 test failed
(scratch(0xC040)=0xCAFEDEAD)
[drm:amdgpu_init] *ERROR* hw_init of IP block failed -22
amdgpu :01:00.0: amdgpu_init failed
Gražvydas
On Wed, Sep 28, 2016 at 11:36 AM, Monk Liu
All other amdgpu/dce_v* files have this call, it's only mysteriously
missing from dce_v11_0.c since the file was added and causes leaks.
Fixes: aaa36a976bbb ("drm/amdgpu: Add initial VI support")
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 1 +
Successful sw_init() and hw_init() states are tracked, but not
late_init(). Various error paths may result in amdgpu_fini() being
called before .late init is done, so late_init needs to be tracked
to avoid unexpected or multiple .late_fini() calls.
Signed-off-by: Grazvydas Ignotas
---
drivers
t and warn early.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 4 +++-
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c| 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
b/drivers/gpu/drm/amd/a
On Mon, Sep 26, 2016 at 8:29 PM, Lukas Wunner wrote:
> On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote:
>> Some code called by drm_crtc_force_disable_all() wants to wait for all
>> fences, so only do fence teardown after CRTCs are disabled.
>
> Ugh, how e
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 14 +++---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.h | 14 +++---
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
b/drivers/gpu/drm/amd/amdgpu
We can use .num_rings for that.
Fixes: 6f0359ff7307 ("vce3: add support for third vce ring")
Cc: Alex Deucher
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/
This is in symmetry to setup done in amdgpu_ring_init.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
index 777f11b..e1fa873
it's
better to clear them and get NULL dereference so that it's obvious what's
going wrong.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers
Some code called by drm_crtc_force_disable_all() wants to wait for all
fences, so only do fence teardown after CRTCs are disabled.
Signed-off-by: Grazvydas Ignotas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
50 matches
Mail list logo