Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-27 Thread Guenter Roeck
On 5/24/24 06:43, Guenter Roeck wrote: On 5/24/24 06:18, Alex Deucher wrote: On Fri, May 24, 2024 at 9:17 AM Alex Deucher wrote: On Fri, May 24, 2024 at 5:16 AM Guenter Roeck wrote: Hi, On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: Now that all previously-supported

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-27 Thread Guenter Roeck
On 5/24/24 06:18, Alex Deucher wrote: On Fri, May 24, 2024 at 9:17 AM Alex Deucher wrote: On Fri, May 24, 2024 at 5:16 AM Guenter Roeck wrote: Hi, On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: Now that all previously-supported architectures select

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-27 Thread Guenter Roeck
On 5/24/24 06:18, Alex Deucher wrote: On Fri, May 24, 2024 at 9:17 AM Alex Deucher wrote: On Fri, May 24, 2024 at 5:16 AM Guenter Roeck wrote: Hi, On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: Now that all previously-supported architectures select

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-05-24 Thread Guenter Roeck
Hi, On Fri, Mar 29, 2024 at 12:18:28AM -0700, Samuel Holland wrote: > Now that all previously-supported architectures select > ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead > of the existing list of architectures. It can also take advantage of the > common kernel-mode FP

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On Thu, May 16, 2024 at 01:34:54PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.10 and submit it then. Hoping >to keep the conflicts that it will

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419, from include/trace/define_trace.h:102

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-19 Thread Guenter Roeck
On 5/17/24 11:00, Guenter Roeck wrote: On 5/17/24 10:48, Steven Rostedt wrote: On Fri, 17 May 2024 10:36:37 -0700 Guenter Roeck wrote: Building csky:allmodconfig (and others) ... failed -- Error log: In file included from include/trace/trace_events.h:419,   from

Re: [PATCH v2 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-18 Thread Guenter Roeck
On Wed, Feb 14, 2024 at 06:48:53PM +0530, Arunpravin Paneer Selvam wrote: > From: Matthew Auld > > Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. > > v2: Fix checkpatch warnings. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 > Signed-off-by: Matthew Auld > Cc: Arunpravin Pane

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread Guenter Roeck
On 11/7/23 09:26, José Pekkarinen wrote: On 2023-11-07 16:08, Guenter Roeck wrote: On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative

Re: [PATCH] drm/amd/pm: clean up redundant comparisons with 0

2023-11-07 Thread Guenter Roeck
On 11/7/23 00:29, José Pekkarinen wrote: There is a couple of function return checks of functions that return unsigned values, and local variables to hold them are also unsigned, so checking if they are negative will always return false. This patch will remove them, as well as the never reached c

Re: [PATCH 2/2] drm/amd/display: Fix stack size issue on DML2

2023-11-06 Thread Guenter Roeck
On Mon, Oct 16, 2023 at 08:19:18AM -0600, Rodrigo Siqueira wrote: > This commit is the last part of the fix that reduces the stack size in > the DML2 code. > That does not really help when trying to build allmodconfig or allyesconfig with gcc 11.4 or 12.3. drivers/gpu/drm/amd/amdgpu/../display/d

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
On 1/20/23 10:39, Limonciello, Mario wrote: [ ... ] Wayne is OOO for CNY, but let me update you. Harry has sent out this series which is a collection of proper fixes. https://patchwork.freedesktop.org/series/113125/ Once that's reviewed and accepted, 4 of them are applicable for 6.1. Thanks

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
Hi Mario, On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: > On 1/20/2023 11:46, Guenter Roeck wrote: > > On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > > > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > > >

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-20 Thread Guenter Roeck
On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > [Why] > Changes cause regression on amdgpu mst. > E.g. > In fill_dc_mst_payload_table_from_drm(), amdgpu expects to add/remove payload > one by one and call fill_dc_mst_pa

Re: [PATCH] drm/amd/display: Fix vblank refcount in vrr transition

2022-10-17 Thread Guenter Roeck
On Fri, Oct 14, 2022 at 02:27:35PM +, Li, Yunxiang (Teddy) wrote: > [AMD Official Use Only - General] > > > This patch results in a large number of compile errors if > > CONFIG_DEBUG_FS=n. Reverting it fixes the problem. > > > > This is an architecture independent problem. > > > > Guenter >

Re: [PATCH] drm/amd/display: Fix vblank refcount in vrr transition

2022-10-17 Thread Guenter Roeck
On Wed, Sep 21, 2022 at 05:20:19PM -0400, Yunxiang Li wrote: > manage_dm_interrupts disable/enable vblank using drm_crtc_vblank_off/on > which causes drm_crtc_vblank_get in vrr_transition to fail, and later > when drm_crtc_vblank_put is called the refcount on vblank will be messed > up. Therefore m

[PATCH] drm/amd/display: Increase frame size limit for display_mode_vba_util_32.o

2022-10-13 Thread Guenter Roeck
8, similar to other files in the same directory, to enable 32-bit build tests with affected compilers. Fixes: dda4fb85e433 ("drm/amd/display: DML changes for DCN32/321") Cc: Aurabindo Pillai Reported-by: Łukasz Bartosik Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/dc/dm

[PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback() [take 2]

2022-10-10 Thread Guenter Roeck
not solve the problem. Cc: Aurabindo Pillai Cc: Hamza Mahfooz Fixes: 5d8c3e836fc2 ("drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()") Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()

2022-10-06 Thread Guenter Roeck
On Wed, Oct 05, 2022 at 11:46:15PM -0700, Guenter Roeck wrote: > On Tue, Sep 27, 2022 at 03:12:00PM -0400, Hamza Mahfooz wrote: > > Address the following error: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function > > ‘dc_stream_remove_writeback’: &g

Re: [PATCH] drm/amd/display: fix array-bounds error in dc_stream_remove_writeback()

2022-10-06 Thread Guenter Roeck
On Tue, Sep 27, 2022 at 03:12:00PM -0400, Hamza Mahfooz wrote: > Address the following error: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c: In function > ‘dc_stream_remove_writeback’: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:527:55: error: > array subscript [0, 0

Re: Stack-frame warnings in display_mode_vba_32.c

2022-07-30 Thread Guenter Roeck
On 7/29/22 22:12, Paul E. McKenney wrote: On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote: Hi Paul, Às 23:25 de 29/07/22, Paul E. McKenney escreveu: Hello! I am seeing the following in allmodconfig builds of recent -next on x86: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn3

Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc

2022-07-26 Thread Guenter Roeck
On 7/25/22 13:42, Segher Boessenkool wrote: On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote: Further digging shows that the build failures only occur with compilers that default to 64-bit long double. Where the heck do we have 'long double' things anywhere in the kernel? I tri

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-14 Thread Guenter Roeck
On 7/14/22 11:49, Melissa Wen wrote: O 07/13, Alex Deucher wrote: On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote: On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: The problem is not the FPU operations, but the fact that soft-float and hard-float compiled code is linked

Re: Linux 5.19-rc6

2022-07-14 Thread Guenter Roeck
On 7/14/22 09:48, Linus Torvalds wrote: On Thu, Jul 14, 2022 at 12:23 AM Geert Uytterhoeven wrote: Oh, it's not just this one. The lists of build regressions between v5.18 and v5.19-rc1 [1] resp. v5.19-rc6 [2] look surprisingly similar :-( [1] https://lore.kernel.org/all/20220606082201.279214

Re: [PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-14 Thread Guenter Roeck
On 7/14/22 09:29, Alex Deucher wrote: Applied. Thanks! On Wed, Jul 13, 2022 at 4:03 PM Harry Wentland wrote: On 2022-07-12 18:42, Guenter Roeck wrote: The new display engine uses floating point math, which is not supported by KCOV. Commit 9d1d02ff3678 ("drm/amd/display: Don't

Re: Linux 5.19-rc6

2022-07-14 Thread Guenter Roeck
On 7/14/22 00:23, Geert Uytterhoeven wrote: Hi Linus, On Wed, Jul 13, 2022 at 11:51 PM Linus Torvalds wrote: On Wed, Jul 13, 2022 at 2:01 PM Alex Deucher wrote: If you want to apply Guenter's patch original patch: https://patchwork.freedesktop.org/patch/490184/ That's fine with me. Honestl

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: > > > > The problem is not the FPU operations, but the fact that soft-float > > and hard-float compiled code is linked together. The soft-float and > > hard-float ABIs on powerpc are not compatible, so one ends up with > > an object file

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote: > On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds > wrote: > > > > On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee > > wrote: > > > > > > > > > > > > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/ >

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On Thu, Jul 14, 2022 at 12:26:27AM +0100, Sudip Mukherjee wrote: > On Thu, Jul 14, 2022 at 12:12 AM Guenter Roeck wrote: > > > > On Thu, Jul 14, 2022 at 12:09:24AM +0100, Sudip Mukherjee wrote: > > > On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote: > > > >

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On Thu, Jul 14, 2022 at 12:09:24AM +0100, Sudip Mukherjee wrote: > On Wed, Jul 13, 2022 at 11:56 PM Guenter Roeck wrote: > > > > On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote: > > > On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds > > > wrot

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 10:50:06PM +0100, Sudip Mukherjee wrote: > On Wed, Jul 13, 2022 at 10:45 PM Linus Torvalds > wrote: > > > > On Wed, Jul 13, 2022 at 2:36 PM Sudip Mukherjee > > wrote: > > > > > > > > > > > > > https://lore.kernel.org/all/20220524025139.40212-1-wangkefeng.w...@huawei.com/ >

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: [ ... ] > > The problem is not the FPU operations, but the fact that soft-float > > and hard-float compiled code is linked together. The soft-float and > > hard-float ABIs on powerpc are not compatible, so one ends up with > > an object

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On 7/13/22 13:57, Alex Deucher wrote: On Thu, Jun 30, 2022 at 5:01 PM Rodrigo Siqueira Jordao wrote: On 2022-06-18 19:27, Guenter Roeck wrote: ppc:allmodconfig builds fail with the following error. powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On 7/13/22 12:36, Linus Torvalds wrote: On Tue, Jul 12, 2022 at 10:07 PM Guenter Roeck wrote: Same problems as every week. Building powerpc:allmodconfig ... failed Ok, this has been going on since -rc1, which is much too long. From your patch submission that that was rejected: The

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
On 7/13/22 13:22, Linus Torvalds wrote: On Wed, Jul 13, 2022 at 12:53 PM Alex Deucher wrote: Does this patch fix it? https://patchwork.freedesktop.org/patch/493799/ Guenter? Willing to check this one too for your setup, and we can hopefully close down both issues? No, that fixes a differe

Re: Linux 5.19-rc6

2022-07-13 Thread Guenter Roeck
looks sane to me, but I guess Guenter would need to check ... Guenter? That patch is (and has been) in linux-next for a long time, as commit d2ca1fd2bc70, and with the following tags. Fixes: 7719a68b2fa4 ("ARM: 9192/1: amba: fix memory leak in amba_device_try_add()") Reported-by

[PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-12 Thread Guenter Roeck
ay: Don't build DCN1 when kcov is enabled") Cc: Arnd Bergmann Cc: Leo Li Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/Kconfig | 2 +- drivers/gpu/drm/amd/display/dc/Makefile | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Guenter Roeck
On Thu, Jul 07, 2022 at 10:08:33AM +0200, Greg KH wrote: [ ... ] > > > > Unverified Error/Warning (likely false positive, please contact us if > > interested): > > > > arch/x86/events/core.c:2114 init_hw_perf_events() warn: missing error code > > 'err' > > drivers/android/binder.c:1481:19-23:

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-01 Thread Guenter Roeck
On Thu, Jun 30, 2022 at 05:01:01PM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-06-18 19:27, Guenter Roeck wrote: > > ppc:allmodconfig builds fail with the following error. > > > > powerpc64-linux-ld: > > drivers/gpu/drm/amd/amdgpu/../

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-30 Thread Guenter Roeck
On 6/30/22 14:01, Rodrigo Siqueira Jordao wrote: On 2022-06-18 19:27, Guenter Roeck wrote: ppc:allmodconfig builds fail with the following error. powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o     uses hard float, drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-22 Thread Guenter Roeck
On Mon, Jun 20, 2022 at 05:51:04PM -0400, Alex Deucher wrote: > On Sat, Jun 18, 2022 at 7:27 PM Guenter Roeck wrote: > > > > ppc:allmodconfig builds fail with the following error. > > > > powerpc64-linux-ld: > > drivers/gpu/drm/amd/amdgpu/../

[PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-20 Thread Guenter Roeck
h lack the selection of hard-float. Fixes: 41b7a347bf14 ("powerpc: Book3S 64-bit outline-only KASAN support") Cc: Michael Ellerman Cc: Daniel Axtens Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 4 drivers/gpu/drm/amd/display/dc/dcn315/Makefile |

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-19 Thread Guenter Roeck
On 5/18/22 17:55, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next specific files for 20220518 Error/Warning reports: https://lore.kernel.org/linux-mm/20220429

Re: [PATCH] drm/amdgpu: fix out of bounds write

2021-10-27 Thread Guenter Roeck
On 10/27/21 8:22 AM, Harry Wentland wrote: On 2021-10-27 10:39, Guenter Roeck wrote: On Wed, Oct 13, 2021 at 04:04:13PM -0400, Thelford Williams wrote: Size can be any value and is user controlled resulting in overwriting the 40 byte array wr_buf with an arbitrary length of data from buf

Re: [PATCH] drm/amdgpu: fix out of bounds write

2021-10-27 Thread Guenter Roeck
On Wed, Oct 13, 2021 at 04:04:13PM -0400, Thelford Williams wrote: > Size can be any value and is user controlled resulting in overwriting the > 40 byte array wr_buf with an arbitrary length of data from buf. > > Signed-off-by: Thelford Williams > Signed-off-by: Alex Deucher The fix works, but

Re: [PATCH] Enable '-Werror' by default for all kernel builds

2021-09-09 Thread Guenter Roeck
On 9/9/21 12:30 AM, Christian König wrote: Am 09.09.21 um 08:07 schrieb Guenter Roeck: On 9/8/21 10:58 PM, Christoph Hellwig wrote: On Wed, Sep 08, 2021 at 11:58:56PM +0200, Marco Elver wrote: It'd be good to avoid. It has helped uncover build issues with KASAN in the past. Or at least

Re: [PATCH] Enable '-Werror' by default for all kernel builds

2021-09-09 Thread Guenter Roeck
On 9/8/21 10:58 PM, Christoph Hellwig wrote: On Wed, Sep 08, 2021 at 11:58:56PM +0200, Marco Elver wrote: It'd be good to avoid. It has helped uncover build issues with KASAN in the past. Or at least make it dependent on the problematic architecture. For example if arm is a problem, something li

[PATCH] drm/amd/amdkfd: Drop unnecessary NULL check after container_of

2021-05-21 Thread Guenter Roeck
. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drive

[PATCH] drm/amd/display: Fix build warnings

2021-04-21 Thread Guenter Roeck
other iterators which don't require the unused variables. Fixes: 8ad278062de4e ("drm/amd/display: Disable cursors before disabling planes") Fixes: 29b9ba74f6384 ("drm/amd/display: Recalculate VCPI slots for new DSC connectors") Signed-off-by: Guenter Roeck --- drivers/gpu/

Re: [PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE

2021-01-26 Thread Guenter Roeck
s.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- > drivers/hwmon/acpi_power_meter.c | 4 ++-- Acked-by: Guenter Roeck > drivers/platform/x86/asus-laptop.c | 6 +++--- > drivers/spi/spi.c| 2 +- > sound/pci/hda/hda_intel.c

Re: drm/amdgpu: replace readq/writeq with atomic64 operations

2019-08-08 Thread Guenter Roeck
On Wed, Aug 07, 2019 at 10:56:40AM +0800, Tao Zhou wrote: > readq/writeq are not supported on all architectures > > Signed-off-by: Tao Zhou > Reviewed-by: Alex Deucher Regarding the claim that this would work for 32-bit x86 builds: make ARCH=i386 allmodconfig make ARCH=i386 drivers/gpu/drm/amd

Re: next/master build: 230 builds: 5 failed, 225 passed, 6 errors, 1344 warnings (next-20190805)

2019-08-08 Thread Guenter Roeck
On 8/8/19 11:53 AM, Alex Deucher wrote: On Thu, Aug 8, 2019 at 2:53 PM Guenter Roeck wrote: On Mon, Aug 05, 2019 at 12:12:05PM +0100, Mark Brown wrote: On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote: Today's -next fails to build an arm allmodconfig due to: allmodc

Re: next/master build: 230 builds: 5 failed, 225 passed, 6 errors, 1344 warnings (next-20190805)

2019-08-08 Thread Guenter Roeck
On Mon, Aug 05, 2019 at 12:12:05PM +0100, Mark Brown wrote: > On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote: > > Today's -next fails to build an arm allmodconfig due to: > > > allmodconfig (arm, gcc-8) — FAIL, 2 errors, 16 warnings, 0 section > > mismatches > > > > Errors: >

Re: [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-08-07 Thread Guenter Roeck
On Fri, Jul 26, 2019 at 07:23:13PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Neil Armstrong This patch results in a crash when running qemu:versatilepb. Unable to handle kernel NULL point

Re: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-29 Thread Guenter Roeck
; > Reported-by: Matthias Kaehlcke > > > Suggested-by: James Y Knight > > > Suggested-by: Nathan Chancellor > > > Signed-off-by: Nick Desaulniers > > > Tested-by: Guenter Roeck > > > > Reviewed-by: Harry Wentland > > > > and app

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-19 Thread Guenter Roeck
On 10/19/2018 01:53 AM, Daniel Vetter wrote: On Mon, Oct 08, 2018 at 06:13:56PM +, Koenig, Christian wrote: Am 08.10.2018 um 19:46 schrieb Guenter Roeck: On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: One thing I

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 03:57:07PM +, Deucher, Alexander wrote: > > -Original Message- > > From: Guenter Roeck On Behalf Of Guenter Roeck > > Sent: Monday, October 8, 2018 10:11 AM > > To: Koenig, Christian ; Peng Hao > > > > Cc: airl...@linux.i

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On Mon, Oct 08, 2018 at 05:22:24PM +, Koenig, Christian wrote: > Am 08.10.2018 um 17:57 schrieb Deucher, Alexander: > One thing I found missing in the discussion was the reference to the > C standard. > The C99 standard states in section 6.7.8 (Initialization) clause 19: > "

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/08/2018 01:00 AM, Christian König wrote: Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/08/2018 06:47 AM, Koenig, Christian wrote: Am 08.10.2018 um 15:33 schrieb Guenter Roeck: On 10/08/2018 01:00 AM, Christian König wrote: Am 05.10.2018 um 10:38 schrieb Guenter Roeck: On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-08 Thread Guenter Roeck
On 10/05/2018 01:14 AM, Koenig, Christian wrote: Am 04.10.2018 um 20:52 schrieb Guenter Roeck: Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function ‘gmc_v8_0_process_interrupt’: drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10

Re: [PATCH] amdgpu/gmc : fix compile warning

2018-10-05 Thread Guenter Roeck
Hi, On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote: > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: > In function ‘gmc_v8_0_process_interrupt’: > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10: > warning: missing braces around initializer [-Wmissing-braces] > > Signed-off-by: Peng Hao

Re: [PATCH] drm/radeon/mkregtable: Delete unused list functions and macros

2018-03-01 Thread Guenter Roeck
On Wed, Feb 28, 2018 at 2:17 PM, Matthias Kaehlcke wrote: > The util mkregtable includes a copy of the kernel API for linked lists, > only a small subset of it is used. Delete the unused functions and macros. > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck > ---

Re: [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq()

2018-02-10 Thread Guenter Roeck
rivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26: > error: implicit conversion from enumeration type 'enum ddc_result' > to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion] > enum dc_status result = DDC_RESULT_UNKNOWN; > > S

Re: [PATCH v2 2/2] amdgpu/dc/dml: Support clang option for stack alignment

2018-02-07 Thread Guenter Roeck
of two like -mpreferred-stack-boundary. > > Probe for both compiler options and use the correct one, similar to > what is done in arch/x86/Makefile. > > Reported-by: Guenter Roeck > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck Guenter > --- > Changes

Re: [PATCH 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

2018-02-07 Thread Guenter Roeck
On Wed, Feb 7, 2018 at 5:21 PM, Matthias Kaehlcke wrote: > Use subdir-ccflags instead of specifying the same flags for every source > file. > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck > --- > drivers/gpu/drm/amd/display/dc/dml/Makefile | 10 +- &g

Re: [PATCH 2/2] amdgpu/dc/dml: Support clang option for stack alignment

2018-02-07 Thread Guenter Roeck
of two like -mpreferred-stack-boundary. > > Probe for both compiler options and use the correct one, similar to > what is done in arch/x86/Makefile. > > Reported-by: Guenter Roeck > Signed-off-by: Matthias Kaehlcke > --- > drivers/gpu/drm/amd/display/dc/dml/Makefile | 8

Re: [PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c

2018-02-07 Thread Guenter Roeck
with extraneous parentheses > [-Werror,-Wparentheses-equality] > if ((data->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) { > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 22

Re: [PATCH] drm/amd/powerplay: Remove extra pair of parentheses

2018-02-07 Thread Guenter Roeck
ous parentheses > [-Werror,-Wparentheses-equality] > if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) { > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck > --- > drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +- > 1 file changed,

Re: [PATCH] drm/amd/powerplay: Fix enum mismatch

2018-02-07 Thread Guenter Roeck
conversion from enumeration type 'enum > amd_powergating_state' to different enumeration type 'enum > amd_clockgating_state' [-Werror,-Wenum-conversion] > AMD_PG_STATE_UNGATE); > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Guenter Roeck > --- > drivers/gpu/

Re: [PATCH] ASoC: amd: fix report accurate hw_ptr during dma

2017-11-08 Thread Guenter Roeck
On Wed, Nov 8, 2017 at 11:35 AM, Alex Deucher wrote: > On Wed, Nov 8, 2017 at 2:30 PM, Guenter Roeck wrote: > > On Wed, Nov 8, 2017 at 11:18 AM, Deucher, Alexander > > wrote: > >> > >> > -Original Message- > >> > From: Mark Brown [m

[PATCH] drm/amdgpu: Use less generic enum definitions

2017-05-04 Thread Guenter Roeck
n of NGG_BUF_MAX but PARAM, which happens to be defined differently for alpha and a couple of other architectures. Use less generic defines for NGG enums to solve the problem. Fixes: bce23e00f3369 ("drm/amdgpu: add NGG parameters") Cc: Christian König Cc: Alex Deucher Signed-off-