Re: [Nouveau] [PATCH v4 02/17] drm/nouveau/kms/nv50-: Move AUX adapter reg to connector late register/early unregister

2021-04-23 Thread Ilia Mirkin
Some trivia, no comment on the real logic of the changes: On Fri, Apr 23, 2021 at 2:43 PM Lyude Paul wrote: > > Since AUX adapters on nouveau have their respective DRM connectors as > parents, we need to make sure that we register then after their connectors. then -> them > > Signed-off-by: Lyu

Re: [PATCH 4/4] PCI: add a REBAR size quirk for Sapphire RX 5600 XT Pulse.

2021-01-05 Thread Ilia Mirkin
On Tue, Jan 5, 2021 at 8:44 AM Christian König wrote: > > Otherwise the CPU can't fully access the BAR. > > Signed-off-by: Christian König > --- > drivers/pci/pci.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 1621

Re: [PATCH] drm/amd/display: Fix pageflipping for XOrg in Linux 5.11+

2021-01-02 Thread Ilia Mirkin
On Sat, Jan 2, 2021 at 1:35 PM Mario Kleiner wrote: > I'm less sure about nouveau. It uses modifiers, but has atomic support > only on nv50+ and that atomic support is off by default -- needs a > nouveau.nouveau_atomic=1 boot parameter to switch it on. It seems to > enable modifier support uncondi

Re: [PATCH 1/2] drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions

2019-11-07 Thread Ilia Mirkin
On Thu, Nov 7, 2019 at 5:21 PM Bjorn Helgaas wrote: > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 29d6e93fd15e..03446be8a7be 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -673,6 +673,8 @@ > #define PCI_EXP_LNKCTL2_T

Re: [Nouveau] [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

2019-09-07 Thread Ilia Mirkin
On Wed, Aug 21, 2019 at 7:55 AM Thierry Reding wrote: > > On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs wrote: > > On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > Changing the order doesn't look hard. Patch attached (untested, have > > > > > no > > >

Re: [PATCH v2 1/2] drm/ttm: Only allocate huge pages with new flag TTM_PAGE_FLAG_TRANSHUGE

2018-04-28 Thread Ilia Mirkin
On Sat, Apr 28, 2018 at 7:02 PM, Michel Dänzer wrote: > On 2018-04-28 06:30 PM, Ilia Mirkin wrote: >> On Fri, Apr 27, 2018 at 9:08 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Previously, TTM would always (with CONFIG_TRANSPARENT_HUGEPAGE ena

Re: [PATCH v2 1/2] drm/ttm: Only allocate huge pages with new flag TTM_PAGE_FLAG_TRANSHUGE

2018-04-28 Thread Ilia Mirkin
On Fri, Apr 27, 2018 at 9:08 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Previously, TTM would always (with CONFIG_TRANSPARENT_HUGEPAGE enabled) > try to allocate huge pages. However, not all drivers can take advantage > of huge pages, but they would incur the overhead for allocating and >

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: > On 2018-04-03 03:26 PM, Ilia Mirkin wrote: >> On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: >>> On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >>>> Am 01.04.2018 um 20:21 schrieb Taka

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: > On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >> Am 01.04.2018 um 20:21 schrieb Takashi Iwai: >> > On Sun, 01 Apr 2018 19:58:11 +0200, >> > Christian K6nig wrote: >> > > Am

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-01 Thread Ilia Mirkin
On Sun, Apr 1, 2018 at 1:39 PM, Christian König wrote: > Am 30.03.2018 um 22:45 schrieb Takashi Iwai: >> >> amdgpu driver lacks of modeset module option other drm drivers provide >> for enforcing or disabling the driver load. Interestingly, the >> amdgpu_mode variable declaration is already found

Re: [PATCH 1/3] drm: fourcc byteorder: drop DRM_FORMAT_BIG_ENDIAN

2017-05-02 Thread Ilia Mirkin
On Tue, May 2, 2017 at 11:06 AM, Gerd Hoffmann wrote: > Radeon and nvidia (nv40) cards where mentioned. I'll try to summarize > (feel free to correct me if I'm wrong). > > nvidia has support for 8 bit-per-color formats only on bigendian hosts. > Not sure whenever this is a driver or hardware limi

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-22 Thread Ilia Mirkin
On Sat, Apr 22, 2017 at 9:48 AM, Ilia Mirkin wrote: > On Sat, Apr 22, 2017 at 9:40 AM, Ilia Mirkin wrote: >> On Sat, Apr 22, 2017 at 5:50 AM, Ville Syrjälä >> wrote: >>> On Sat, Apr 22, 2017 at 01:07:57AM -0400, Ilia Mirkin wrote: >>>> On Fri, Apr 21, 2017 at

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-22 Thread Ilia Mirkin
On Sat, Apr 22, 2017 at 9:40 AM, Ilia Mirkin wrote: > On Sat, Apr 22, 2017 at 5:50 AM, Ville Syrjälä > wrote: >> On Sat, Apr 22, 2017 at 01:07:57AM -0400, Ilia Mirkin wrote: >>> On Fri, Apr 21, 2017 at 12:59 PM, Ville Syrjälä >>> wrote: >>> > On F

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-22 Thread Ilia Mirkin
On Sat, Apr 22, 2017 at 5:50 AM, Ville Syrjälä wrote: > On Sat, Apr 22, 2017 at 01:07:57AM -0400, Ilia Mirkin wrote: >> On Fri, Apr 21, 2017 at 12:59 PM, Ville Syrjälä >> wrote: >> > On Fri, Apr 21, 2017 at 10:49:49AM -0400, Ilia Mirkin wrote: >> >> On Fri, Ap

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-21 Thread Ilia Mirkin
On Fri, Apr 21, 2017 at 12:59 PM, Ville Syrjälä wrote: > On Fri, Apr 21, 2017 at 10:49:49AM -0400, Ilia Mirkin wrote: >> On Fri, Apr 21, 2017 at 3:58 AM, Gerd Hoffmann wrote: >> > While working on graphics support for virtual machines on ppc64 (which >> > exists in

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-21 Thread Ilia Mirkin
t know whether they're broken, and comments we're pretty sure are at least somewhat wrong. Furthermore the hardware is relatively rare and developers with time to work on improving it are even rarer. I'd like to reiterate that the status quo does end up in a functioning system. Let's t

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-18 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 11:19 PM, Ilia Mirkin wrote: > On Tue, Apr 18, 2017 at 9:01 PM, Michel Dänzer wrote: >> On 18/04/17 07:14 PM, Gerd Hoffmann wrote: >>> Hi, >>> >>>>> Quite true that this proves nothing. However one should note that >&

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-18 Thread Ilia Mirkin
On Tue, Apr 18, 2017 at 9:01 PM, Michel Dänzer wrote: > On 18/04/17 07:14 PM, Gerd Hoffmann wrote: >> Hi, >> Quite true that this proves nothing. However one should note that fbcon -> fbdev works, >>> >>> BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses >>> e.g.

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-17 Thread Ilia Mirkin
On Mon, Apr 17, 2017 at 10:53 PM, Michel Dänzer wrote: > On 17/04/17 03:43 PM, Ilia Mirkin wrote: >> On Tue, Apr 11, 2017 at 10:18 AM, Ilia Mirkin wrote: >>>> However, I totally agree with Alex that someone with a BE machine >>>> should review the whole stack

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-17 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 10:18 AM, Ilia Mirkin wrote: >> However, I totally agree with Alex that someone with a BE machine >> should review the whole stack before we could be confident with anything. > > Here's what I'm confident about: xf86-video-nouveau worked just fi

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-11 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 3:31 AM, Pekka Paalanen wrote: > On Mon, 10 Apr 2017 12:10:14 -0400 > Ilia Mirkin wrote: > >> On Mon, Apr 10, 2017 at 11:09 AM, Pekka Paalanen wrote: > >> > I also wonder if a real BE machine could have different results than >> > the

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-10 Thread Ilia Mirkin
On Mon, Apr 10, 2017 at 11:09 AM, Pekka Paalanen wrote: > On Mon, 10 Apr 2017 16:17:27 +0200 > Gerd Hoffmann wrote: > >> Hi, >> >> > which software have you used as representative of "reality"? >> >> ppc64 (big endian) virtual machine, running with qemu stdvga & bochs-drm >> driver. Xorg with

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-10 Thread Ilia Mirkin
On Mon, Apr 10, 2017 at 10:17 AM, Gerd Hoffmann wrote: > Hi, > >> which software have you used as representative of "reality"? > > ppc64 (big endian) virtual machine, running with qemu stdvga & bochs-drm > driver. Xorg with modesetting driver uses DRM_FORMAT_XRGB (one and > only format supp

Re: [PATCH] Re: Mullins support in xf86-video-amdgpu

2016-08-22 Thread Ilia Mirkin
On Mon, Aug 22, 2016 at 10:57 PM, Reid Hekman wrote: > On 08/22/2016 08:27 PM, Michel Dänzer wrote: >> >> On 23/08/16 10:18 AM, Reid Hekman wrote: >>> >>> >>> I was encouraged by a commit I saw today to add Sea Islands PCI ids to >>> xf86-video-amdgpu. However I did not see MULLINS included. Are