Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2)

2020-04-11 Thread Johannes Hirte
MD_CG_STATE_UNGATE); > + > amdgpu_amdkfd_suspend(adev, !fbcon); > > amdgpu_ras_suspend(adev); This breaks shutdown/reboot on my system (Dell latitude 5495). -- Regards, Johannes Hirte ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v2] drm/amdgpu: fix gfx hang during suspend with video playback (v2)

2020-04-12 Thread Johannes Hirte
device: Advanced Micro Devices, Inc. [AMD] Raven/Raven2/Renoir Non-Sensor Fusion Hub KMDF driver 05:00.0 SATA controller: Advanced Micro Devices, Inc. [AMD] FCH SATA Controller [AHCI mode] (rev 61) -- Regards, Johannes Hirte ___ amd-g

Re: [PATCH] drm/amdgpu: fix the hw hang during perform system reboot and reset

2020-04-13 Thread Johannes Hirte
if (!adev->ip_blocks[i].status.valid) > -- > 2.7.4 > I can confirm that this fixes the shutdown/reboot hang on my raven. -- Regards, Johannes Hirte ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[drm-next-4.9-wip] this function not implement on Carizzo

2016-08-15 Thread Johannes Hirte
With commit fad2af195f1abaada473f4f9e9a554c1e4db768b PowerPlay was enabled by default for Carizzo, so I assumed this as complete and tested again. But I still get in dmesg this: [ powerplay ] this function not implement! [ powerplay ] min_core_set_clock not set There are multiple entries on start

[BUG] X broken on Carrizo when GFX_PG enabled

2017-08-22 Thread Johannes Hirte
Because nobody reacted on the bug report, I'm trying this way. As mentioned in https://bugzilla.kernel.org/show_bug.cgi?id=196337, my system gets unusable with GFX_PG enabled, cause X doesn't start anymore. ___ amd-gfx mailing list amd-gfx@lists.freedes

Re: Fixes for 4.15-rc1

2017-11-28 Thread Johannes Hirte
On 2017 Nov 28, Harry Wentland wrote: > Hi Alex, > > I cherry-picked a bunch of fixes for 4.15. These can be found at > hwentlan/4.15-rc1-fixes. > > Of the changes the highlighted ones (with *) in particular are highly > recommended, but even the other ones are probably good to have. > > * af5

BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-03 Thread Johannes Hirte
I still get a use-after-free with linux-4.15-rc6: [ 16.788943] == [ 16.788968] BUG: KASAN: use-after-free in amdgpu_job_free_cb+0x140/0x150 [ 16.788975] Read of size 8 at addr 8803dfe4b3c8 by task kworker/0:2/1355 [ 16.7

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-03 Thread Johannes Hirte
On 2018 Jan 03, Johannes Hirte wrote: > This should be fixed already with > https://lists.freedesktop.org/archives/amd-gfx/2017-October/014932.html > but's still missing upstream. > With this patch, the use-after-free in amdgpu_job_free_cb seems to be gone. But now I get an

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-09 Thread Johannes Hirte
On 2018 Jan 03, Johannes Hirte wrote: > On 2018 Jan 03, Johannes Hirte wrote: > > This should be fixed already with > > https://lists.freedesktop.org/archives/amd-gfx/2017-October/014932.html > > but's still missing upstream. > > > > With this patch, th

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-11 Thread Johannes Hirte
On 2018 Jan 10, Andrey Grodzovsky wrote: > > Hi, is there a particular scenario when this happens , Unfortunately no, I still search for a reproducer. Sometimes it takes several days until the next use-after-free. > can you add dmesg with echo 0x10 > /sys/module/drm/parameters/debug? I assume

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-12 Thread Johannes Hirte
On 2018 Jan 11, Andrey Grodzovsky wrote: > Thanks for the dmesg, unfortunately nothing suspicious from there. > > Looking again at KASAN it hints at a race between cursor update and non > blocking part of flip with regard to accessing CRTC states, maybe cursor > update is not properly synchroniz

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-12 Thread Johannes Hirte
On 2018 Jan 12, Andrey Grodzovsky wrote: > Hi, looks to me  like a different issue (not related) then the one  > Johannes, reports, your issue was already reported by some one (can't > remember the thread of hand) and looks like in shader hang or GPU > scheduler synchronization issue while  Joha

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-13 Thread Johannes Hirte
On 2018 Jan 12, Andrey Grodzovsky wrote: > Yea, I know , just dumped diff of one file into it, please search in > code for > > "ret = do_aquire_global_lock(dev, state);" it appears only in one place > in entire code base, and manually apply the one line change. > with patch applied: [ 6887.679

Re: BUG: KASAN: use-after-free in amdgpu_job_free_cb

2018-01-14 Thread Johannes Hirte
On 2018 Jan 14, Grodzovsky, Andrey wrote: > To be sure it was inserted at the correct place please send me output of git > diff on your modified branch. > > Thanks, > Andrey > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c ind

Re: [PATCH xf86-video-amdgpu] Store FB for each CRTC in drmmode_flipdata_rec

2018-08-10 Thread Johannes Hirte
On 2018 Jul 27, Michel Dänzer wrote: > From: Michel Dänzer > > We were only storing the FB provided by the client, but on CRTCs with > TearFree enabled, we use a separate FB. This could cause > drmmode_flip_handler to fail to clear drmmode_crtc->flip_pending, which > could result in a hang when w

Re: [PATCH xf86-video-amdgpu] Store FB for each CRTC in drmmode_flipdata_rec

2018-08-17 Thread Johannes Hirte
On 2018 Aug 16, Michel Dänzer wrote: > On 2018-08-10 09:06 AM, Johannes Hirte wrote: > > On 2018 Jul 27, Michel Dänzer wrote: > >> From: Michel Dänzer > >> > >> We were only storing the FB provided by the client, but on CRTCs with > >> TearFree en

Re: Kernel crash/Null pointer dereference on vblank

2017-11-22 Thread Johannes Hirte
On 2017 Nov 22, Martin Babutzka wrote: >Dear AMD Developers, >At first congratulations for the DC code submission to the 4.15 kernel. >Unfortunately the major regression which I reported on 29.09., 06.10., >02.11. and 05.11. still exists. But this time I got additional >debugging information maybe

Re: Kernel crash/Null pointer dereference on vblank

2017-11-22 Thread Johannes Hirte
Ok, now I have more use-after-free report, this time without dc. I don't know if this is related, but I didn't have runtime errors without dc for now. kasan report: [22697.845475] == [22697.845495] BUG: KASAN: use-after-free in amd

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Chunming Zhou wrote: > Which driver are you using? > > I guess your driver is a bit old, the issue should be fixed before. > This was with git master from Linus. But even with the latest changes from agd5f/drm-next-4.15 both use-after-free still persist. If there are fixes for th

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Chunming Zhou wrote: > See the attached email, they fixed same issue, each of them is ok to fix > your issue, your calltrace is  same as the second. > > We should already push the first patch in early time, could you check if > the first patch is in your branch? > This patch (se

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Leo Li wrote: > Hi Johannes, > > The s3 resume issue looks to be a problem with amdgpu/display. Could you > give the attached patch a try? > > Thanks, > Leo > > On 2017-11-23 07:27 AM, Johannes Hirte wrote: > > On 2017 Nov 23, Chunming Zhou w