RE: [PATCH] drm/amdgpu: drop MES 10.1 support v3

2024-05-24 Thread Kasiviswanathan, Harish
Ah yes. Missed it. Reviewed-by: Harish Kasiviswanathan -Original Message- From: Alex Deucher Sent: Friday, May 24, 2024 9:22 AM To: Kasiviswanathan, Harish Cc: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: drop MES 10.1 support v3 On Thu, May 23

RE: [PATCH] drm/amdgpu: drop MES 10.1 support v3

2024-05-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - AMD Internal Distribution Only] I had one more comment. With that fixed this patch is Reviewed-by: Harish Kasiviswanathan static gfx_v10_0_ring_invalidate_tlbs() function can be removed since it is no longer used. Best Regards, Harish -Original Message-

RE: [PATCH] drm/amdgpu: drop MES 10.1 support v2

2024-05-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - AMD Internal Distribution Only] File mes_api_def.h can also be removed. This is defined for gfx10. One minor comment inline. -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, May 23, 2024 2:46 PM To: Deucher, Alexander Cc:

RE: [PATCH] drm/amdgpu: Add CRC16 selection in config

2024-05-21 Thread Kasiviswanathan, Harish
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Zhang, Hawking Sent: Tuesday, May 21, 2024 3:55 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kuehling, Felix ; Kasiviswanathan, Harish

RE: [PATCH] drm/amdkfd: Fix CU Masking for GFX 9.4.3

2024-05-10 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Mukul Joshi Sent: Thursday, May 9, 2024 6:05 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Joshi, Mukul Subject: [PATCH] drm/amdkfd: Fix CU Masking for GFX

RE: [PATCH v9 08/14] drm/amdgpu: map wptr BO into GART

2024-05-02 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Sharma, Shashank Sent: Thursday, May 2, 2024 1:32 AM To: Alex Deucher Cc: amd-gfx@lists.freedesktop.org; Yadav, Arvind ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH v9 08/14] drm/amdgpu:

RE: [PATCH 1/3] drm/amdgpu/mes11: print MES opcodes rather than numbers

2024-04-17 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Horace Chen Sent: Wednesday, April 17, 2024 7:30 AM To: amd-gfx@lists.freedesktop.org Cc: Andrey Grodzovsky ; Kuehling, Felix ; Chen, Horace ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang,

RE: [PATCH] drm/amdkfd: Fix memory leak in create_process failure

2024-04-10 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Tested-by: Harish Kasiviswanthan -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Wednesday, April 10, 2024 4:05 PM To: amd-gfx@lists.freedesktop.org Cc: Chen, Xiaogang Subject: [PATCH] drm/amdkfd: Fix memory leak in create_process

RE: [PATCH] drm/amdgpu: always force full reset for SOC21

2024-03-26 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, March 25, 2024 11:01 AM To: Friedrich Vock Cc: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: always

RE: [PATCH] drm/amdkfd: fix TLB flush after unmap for GFX9.4.2

2024-03-20 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Eric Huang Sent: Wednesday, March 20, 2024 4:25 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] drm/amdkfd: fix TLB flush after unmap for

RE: [PATCH] amd/amdkfd: remove unused parameter

2024-02-28 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Eric Huang Sent: Wednesday, February 28, 2024 10:17 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] amd/amdkfd: remove unused parameter The

RE: [PATCH] drm/amdgpu: Only create mes event log debugfs when mes is enabled

2024-02-01 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Liu, Shaoyun Sent: Thursday, February 1, 2024 10:58 AM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Only create mes event log debugfs when mes is

RE: [PATCH] drm/amdkfd: Use correct drm device for cgroup permission check

2024-01-26 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Mukul Joshi Sent: Friday, January 26, 2024 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Joshi, Mukul ; Kuehling, Felix Subject: [PATCH] drm/amdkfd: Use correct drm

RE: [PATCH v5] drm/amdgpu: Enable GFXOFF for Compute on GFX11

2024-01-16 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ori Messinger Sent: Tuesday, January 16, 2024 5:15 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Messinger, Ori Subject: [PATCH v5] drm/amdgpu: Enable

RE: [PATCH] drm/amdkfd: Use common function for IP version check

2023-11-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Mukul Joshi Sent: Wednesday, November 22, 2023 3:29 PM To: amd-gfx@lists.freedesktop.org Cc: Joshi, Mukul ; Kuehling, Felix Subject: [PATCH] drm/amdkfd: Use common

RE: [PATCH] drm/amdgpu: Improve MES responsiveness during oversubscription

2023-10-04 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Jay Cornwall Sent: Wednesday, October 4, 2023 12:00 PM To: amd-gfx@lists.freedesktop.org Cc: Cornwall, Jay ; Tudor, Alexandru Subject: [PATCH] drm/amdgpu: Improve MES

RE: [PATCH] drm/amdkfd: Fix EXT_COHERENT memory allocation crash

2023-10-03 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Acked-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Philip Yang Sent: Tuesday, October 3, 2023 12:57 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip ; Kuehling, Felix Subject: [PATCH] drm/amdkfd: Fix EXT_COHERENT

RE: [PATCH] drm/amdkfd: Checkpoint and restore queues on GFX11

2023-08-28 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of David Francis Sent: Friday, August 25, 2023 3:14 PM To: amd-gfx@lists.freedesktop.org Cc: Francis, David ; Kuehling, Felix Subject: [PATCH] drm/amdkfd: Checkpoint and

RE: [PATCH] drm/amdgpu: Report Missing MES Firmware Versions with Sysfs

2023-07-31 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ori Messinger Sent: Friday, July 28, 2023 2:04 PM To: amd-gfx@lists.freedesktop.org Cc: Messinger, Ori Subject: [PATCH] drm/amdgpu: Report Missing MES Firmware Versions

RE: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, July 27, 2023 9:30 AM To: Feng, Kenneth ; amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: Re: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

RE: [PATCHv2] drm/amdkfd: Use KIQ to unmap HIQ

2023-06-29 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Mukul Joshi Sent: Thursday, June 29, 2023 12:35 PM To: amd-gfx@lists.freedesktop.org Cc: Lin, Amber ; Joshi, Mukul ; Kuehling, Felix Subject: [PATCHv2] drm/amdkfd: Use

RE: [PATCH v2] drm/amdkfd: Expose proc sysfs folder contents after permission check

2023-05-03 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] One minor comment inline. -Original Message- From: amd-gfx On Behalf Of Sreekant Somasekharan Sent: Friday, April 28, 2023 3:12 PM To: amd-gfx@lists.freedesktop.org Cc: Somasekharan, Sreekant Subject: [PATCH v2] drm/amdkfd: Expose proc sysfs folder

RE: [PATCH] drm/amdgpu: Enable GFX11 SDMA context empty interrupt

2023-04-10 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Graham Sider Sent: Wednesday, April 5, 2023 11:42 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Stanley ; Sider, Graham Subject: [PATCH] drm/amdgpu: Enable GFX11 SDMA

RE: [PATCH 1/2] drm/amdgpu: Fix incorrect filenames in sysfs comments

2023-02-06 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] This series Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of kent.russ...@amd.com Sent: Monday, February 6, 2023 12:26 PM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 1/2] drm/amdgpu: Fix

RE: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11

2022-10-27 Thread Kasiviswanathan, Harish
[Public] Reviewed-by: Harish Kasiviswanathan From: Deucher, Alexander Sent: Thursday, October 27, 2022 9:56 AM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish Subject: Re: [PATCH] drm/amdgpu: disable GFXOFF during compute for GFX11 [Public] Acked-by: Alex

RE: [PATCH] drm/amdkfd: update GFX11 CWSR trap handler

2022-10-27 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Acked-by: Harish Kasiviswanathan -Original Message- From: Sider, Graham Sent: Wednesday, October 26, 2022 5:05 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kasiviswanathan, Harish ; Cornwall, Jay ; Sider, Graham Subject: [PATCH] drm

RE: [PATCH] drm/amdkfd: fix dropped interrupt in kfd_int_process_v11

2022-09-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Graham Sider Sent: Friday, September 23, 2022 10:27 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan ; Sider, Graham Subject: [PATCH]

RE: [PATCH] drm/amdgpu: Update mes_v11_api_def.h

2022-08-24 Thread Kasiviswanathan, Harish
[AMD Official Use Only - General] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Graham Sider Sent: Wednesday, August 17, 2022 9:44 AM To: amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Kuehling, Felix ; Sider, Graham ; Zhang, Hawking Subject:

RE: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-03-17 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Few comments inline. -Original Message- From: amd-gfx On Behalf Of Elena Sakhnovitch Sent: Thursday, March 17, 2022 12:45 PM To: amd-gfx@lists.freedesktop.org Cc: Sakhnovitch, Elena (Elen) Subject: [PATCH v2] drm/amd/pm: Disable fan control if not supported On

RE: [PATCH] amdgpu/pm: Disable managing hwmon sysfs attributes for ONEVF mode

2022-02-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Kasiviswanathan, Harish Sent: Thursday, February 17, 2022 2:17 PM To: Slivka, Danijel ; amd-gfx@lists.freedesktop.org Cc: Slivka, Danijel Subject: RE: [PATCH] amdgpu/pm: Disable

RE: [PATCH] drm/amdgpu: config HDP_MISC_CNTL.READ_BUFFER_WATERMARK to fix applications running across multiple GPU config hang.

2022-02-22 Thread Kasiviswanathan, Harish
[Public] I think is safer only to set it for IP_VERSION(4, 4, 0): which is Aldebaran. From: amd-gfx On Behalf Of Deucher, Alexander Sent: Tuesday, February 22, 2022 8:55 AM To: Chen, Xiaogang ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: config

RE: [PATCH] amdgpu/pm: Disable managing hwmon sysfs attributes for ONEVF mode

2022-02-17 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Acked-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Danijel Slivka Sent: Thursday, February 10, 2022 8:24 PM To: amd-gfx@lists.freedesktop.org Cc: Slivka, Danijel Subject: [PATCH] amdgpu/pm: Disable managing hwmon sysfs attributes

RE: [PATCH v1 3/3] drm/amdgpu: Prevent random memory access in FRU code

2022-02-04 Thread Kasiviswanathan, Harish
[AMD Official Use Only] This series acked-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Luben Tuikov Sent: Friday, February 4, 2022 12:27 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Tuikov, Luben ; Russell, Kent Subject: [PATCH v1 3/3]

RE: [PATCH 1/1] drm/amdkfd: Fix variable set but not used warning

2022-01-28 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Philip Yang Sent: Friday, January 28, 2022 9:39 AM To: amd-gfx@lists.freedesktop.org Cc: Yang, Philip Subject: [PATCH 1/1] drm/amdkfd: Fix variable set but not used warning All

RE: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

2021-12-13 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Some comment inline. -Original Message- From: amd-gfx On Behalf Of Marina Nikolic Sent: Friday, December 10, 2021 10:06 AM To: amd-gfx@lists.freedesktop.org Cc: Nikolic, Marina Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission

RE: [PATCH] drm/amdkfd: CWSR with software scheduler

2021-08-11 Thread Kasiviswanathan, Harish
[AMD Official Use Only] -Original Message- From: Joshi, Mukul Sent: Wednesday, August 11, 2021 10:57 AM To: Kasiviswanathan, Harish ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Cornwall, Jay Subject: RE: [PATCH] drm/amdkfd: CWSR with software scheduler [AMD Official Use

RE: [PATCH] drm/amdkfd: CWSR with software scheduler

2021-08-10 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Just few comments inline. With that acknowledged Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Mukul Joshi Sent: Monday, August 9, 2021 4:41 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Cornwall, Jay ; Joshi,

RE: [PATCH] drm/amdkfd: Update SMI throttle event bitmask

2021-07-20 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Sider, Graham Sent: Thursday, July 8, 2021 1:39 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Sider, Graham Subject: [PATCH] drm/amdkfd: Update SMI throttle event bitmask

RE: [PATCH 4/4] drm/amdkfd: add direct link flag to link properties

2021-07-09 Thread Kasiviswanathan, Harish
[AMD Official Use Only] This series Acked-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Monday, June 21, 2021 3:24 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan ; Zhang, Hawking Subject: [PATCH 4/4] drm/amdkfd:

RE: [PATCH V2] drm/amd/pm: correct the power limits reporting on OOB supported

2021-06-08 Thread Kasiviswanathan, Harish
[AMD Official Use Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: Quan, Evan Sent: Monday, June 7, 2021 10:09 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Kasiviswanathan, Harish ; Quan, Evan Subject: [PATCH V2] drm/amd/pm: correct

RE: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation

2021-05-21 Thread Kasiviswanathan, Harish
top.org Cc: Kasiviswanathan, Harish ; Sakhnovitch, Elena (Elen) ; Sider, Graham Subject: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation Perform dependent to independent throttle status translation for arcturus. --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 62 --- 1 file c

RE: [PATCH] drm/amdgpu: Enable TCP channel hashing for Aldebaran

2021-05-06 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Joshi, Mukul Sent: Thursday, May 6, 2021 3:47 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Joshi, Mukul ; Zeng, Oak Subject: [PATCH] drm/amdgpu

RE: [PATCH 2/2] drm/amd/pm: expose pmfw attached timestamp on Aldebaran

2021-05-05 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Quan, Evan Sent: Tuesday, April 27, 2021 9:43 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kasiviswanathan, Harish ; Quan, Evan Subject: [PATCH 2/2] drm

RE: [PATCH 2/2] drm/amd/pm: expose pmfw attached timestamp on Aldebaran

2021-04-28 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Acked-by: Harish Kasiviswanathan -Original Message- From: Quan, Evan Sent: Tuesday, April 27, 2021 9:43 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kasiviswanathan, Harish ; Quan, Evan Subject: [PATCH 2/2] drm

RE: [PATCH 4/4] Revert "drm/amdgpu: workaround the TMR MC address issue (v2)"

2021-04-19 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Oak Zeng Sent: Thursday, April 1, 2021 3:42 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Lazar, Lijo ; Koenig, Christian ; Zeng, Oak ;

RE: [PATCH] drm/amd/pm: Show updated clocks on aldebaran

2021-04-12 Thread Kasiviswanathan, Harish
[AMD Public Use] Reviewed-by: Harish Kasiviswanathan From: amd-gfx On Behalf Of Lazar, Lijo Sent: Friday, April 9, 2021 10:53 AM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Wang, Kevin(Yang) ; Feng, Kenneth ; Zhang, Hawking Subject: [PATCH] drm/amd/pm: Show updated clocks on aldebaran

RE: [PATCH 1/2] drm/amdkfd: change MTYPEs for Aldebaran's HW requirement

2021-04-12 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Eric Huang Sent: Friday, April 9, 2021 4:05 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric ; Greathouse, Joseph Subject: [PATCH 1/2]

RE: [PATCH 3/4] drm/amdgpu: Introduce new SETUP_TMR interface

2021-04-09 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Minor typo. See below. With that fixed Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Oak Zeng Sent: Thursday, April 1, 2021 3:37 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Lazar,

RE: [PATCH] drm/amdgpu: add missing df counter disable write

2021-03-01 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Alex Deucher Sent: Thursday, February 25, 2021 4:27 PM To: Kim, Jonathan Cc: amd-gfx list ; Kasiviswanathan, Harish Subject: Re: [PATCH] drm/amdgpu: add missing df

RE: [PATCH] drm/amd/amdgpu: Import amdgpu_amdkfd_gfx_v9 header file into implementation

2020-11-06 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Friday, November 6, 2020 2:05 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH] drm/amd/amdgpu: Import

RE: [PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-10-05 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] This patch series Reviewed-By: Harish Kasiviswanathan -Original Message- From: Kim, Jonathan Sent: Friday, October 2, 2020 4:19 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan Subject: [PATCH 3/3

RE: [PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-10-02 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] This series Acked-by: Harish Kasiviswanathan -Original Message- From: Kim, Jonathan Sent: Friday, October 2, 2020 4:19 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan Subject: [PATCH 3/3] drm

RE: [PATCH 4/4] drm/amd/amdkfd: Surface files in Sysfs to allow users to get number of compute units that are in use.

2020-09-30 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Tuesday, September 29, 2020 1:27 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH 4/4] drm/amd/amdkfd:

RE: [PATCH 3/4] drm/amd/amdgpu: Define and implement a function that collects number of waves that are in flight.

2020-09-30 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Minor typo. See below. With that fixed this patch is Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Tuesday, September 29, 2020 1:26 PM To: amd-gfx@lists.freedesktop.org Cc:

RE: [PATCH 2/4] drm/amd/amdgpu: Prepare implementation to support reporting of CU usage

2020-09-29 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Minor correction in the commit message. I think you are planning to report CU occupancy and not CU usage. -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Tuesday, September 29, 2020 2:00 PM To:

RE: [PATCH 1/3] drm/amd/amdgpu: Prepare implementation to support reporting of CU usage

2020-09-23 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-By: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Ramesh Errabolu Sent: Thursday, September 17, 2020 1:10 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh Subject: [PATCH 1/3]

RE: [PATCH 2/3] drm/amdgpu: add per device user friendly xgmi events for vega20

2020-09-21 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Few comments inline. -Original Message- From: Kim, Jonathan Sent: Thursday, September 17, 2020 2:15 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 2/3] drm/amdgpu

RE: [PATCH 3/3] drm/amdgpu: add xgmi perfmons for arcturus

2020-09-15 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: Kim, Jonathan Sent: Tuesday, September 15, 2020 6:00 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 3/3

RE: [PATCH 2/3] drm/amdgpu: add per device user friendly xgmi events for vega20

2020-09-15 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Some comments and a question -Original Message- From: Kim, Jonathan Sent: Tuesday, September 15, 2020 6:00 PM To: amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH 2/3] drm

RE: [PATCH 2/4] drm/amdgpu: fix xgmi perfmon a-b-a problem

2020-09-14 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Few minor comments. -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Tuesday, September 8, 2020 9:06 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan Subject: [PATCH 2/4] drm/amdgpu: fix xgmi

RE: [PATCH 1/4] drm/amdgpu: stop resetting xgmi perfmons on disable

2020-09-14 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Harish Kasiviswanathan -Original Message- From: amd-gfx On Behalf Of Jonathan Kim Sent: Tuesday, September 8, 2020 9:06 AM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kim, Jonathan Subject: [PATCH 1/4]

RE: [PATCH] drm/amdkfd: Add queue information to sysfs

2020-01-30 Thread Kasiviswanathan, Harish
[AMD Official Use Only - Internal Distribution Only] One minor comment. -Original Message- From: amd-gfx On Behalf Of Amber Lin Sent: Thursday, January 30, 2020 12:46 AM To: amd-gfx@lists.freedesktop.org Cc: Lin, Amber Subject: [PATCH] drm/amdkfd: Add queue information to sysfs

RE: [PATCH] drm/amdkfd: fix kgd2kfd_device_init() definition conflict error

2019-09-27 Thread Kasiviswanathan, Harish
Sorry missed it too. Thanks for fixing it. Best Regards, Harish -Original Message- From: Kuehling, Felix Sent: Friday, September 27, 2019 10:19 AM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Huang, Ray Subject: Re: [PATCH] drm/amdkfd: fix

RE: [PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-09-24 Thread Kasiviswanathan, Harish
Hi Tejun, Can you please review this? You and Roman acked this patch before. It will be great if I can Reviewed-by, so that I can upstream this through Alex Deucher's amd-staging-drm-next and Dave Airlie's drm-next trees Thanks, Harish -Original Message- From: Kasiviswanathan, Harish

[PATCH v2 2/4] drm/amd: Pass drm_device to kfd

2019-09-16 Thread Kasiviswanathan, Harish
kfd needs drm_device to call into drm_cgroup functions Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c| 2 ++

[PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-09-16 Thread Kasiviswanathan, Harish
For AMD compute (amdkfd) driver. All AMD compute devices are exported via single device node /dev/kfd. As a result devices cannot be controlled individually using device cgroup. AMD compute devices will rely on its graphics counterpart that exposes /dev/dri/renderN node for each device. For each

[PATCH v2 4/4] drm/amdkfd: Check against device cgroup

2019-09-16 Thread Kasiviswanathan, Harish
Participate in device cgroup. All kfd devices are exposed via /dev/kfd. So use /dev/dri/renderN node. Before exposing the device to a task check if it has permission to access it. If the task (based on its cgroup) can access /dev/dri/renderN then expose the device via kfd node. If the task

[PATCH v2 1/4] drm/amdkfd: Store kfd_dev in iolink and cache properties

2019-09-16 Thread Kasiviswanathan, Harish
This is required to check against cgroup permissions. Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 3 +++ 2 files changed, 13 insertions(+) diff --git

AMDKFD (AMD GPU compute) support for device cgroup.

2019-09-16 Thread Kasiviswanathan, Harish
Hi Tejun, Sorry. Resending these patches as I got distracted with other stuff and couldn't follow through. As per our previous discussion the plan was to upstream these changes (mainly patch 3 "Export devcgroup_check_permission") through Alex Deucher's amd-staging-drm-next and Dave Airlie's

Re: [PATCH] drm/amdkfd: Fill amdgpu_task_info for KFD VMs

2019-08-14 Thread Kasiviswanathan, Harish
Reviewed-by: Harish Kasiviswanathan On 2019-08-14 4:13 a.m., Christian König wrote: > Am 13.08.19 um 21:20 schrieb Zhao, Yong: >> The amdgpu_task_info will be used when printing VM page fault for KFD >> processes. >> >> Change-Id: Ifd983db5dceb1d477e7287e4893f80565a7a6b06 >> Signed-off-by: Yong

Re: [PATCH v2 0/4] AMDKFD (AMD GPU compute) support for device cgroup.

2019-05-17 Thread Kasiviswanathan, Harish
to be exported or 3) something else totally that I missed. Best Regards, Harish From: Tejun Heo on behalf of Tejun Heo Sent: Friday, May 17, 2019 12:49 PM To: Kasiviswanathan, Harish Cc: cgro...@vger.kernel.org; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 0/4] AMDKFD (AMD GPU compute

[PATCH v2 4/4] drm/amdkfd: Check against device cgroup

2019-05-17 Thread Kasiviswanathan, Harish
Participate in device cgroup. All kfd devices are exposed via /dev/kfd. So use /dev/dri/renderN node. Before exposing the device to a task check if it has permission to access it. If the task (based on its cgroup) can access /dev/dri/renderN then expose the device via kfd node. If the task

[PATCH v2 3/4] device_cgroup: Export devcgroup_check_permission

2019-05-17 Thread Kasiviswanathan, Harish
For AMD compute (amdkfd) driver. All AMD compute devices are exported via single device node /dev/kfd. As a result devices cannot be controlled individually using device cgroup. AMD compute devices will rely on its graphics counterpart that exposes /dev/dri/renderN node for each device. For each

[PATCH v2 1/4] drm/amdkfd: Store kfd_dev in iolink and cache properties

2019-05-17 Thread Kasiviswanathan, Harish
This is required to check against cgroup permissions. Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 3 +++ 2 files changed, 13 insertions(+) diff --git

[PATCH v2 2/4] drm/amd: Pass drm_device to kfd

2019-05-17 Thread Kasiviswanathan, Harish
kfd needs drm_device to call into drm_cgroup functions Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c| 2 ++

[PATCH v2 0/4] AMDKFD (AMD GPU compute) support for device cgroup.

2019-05-17 Thread Kasiviswanathan, Harish
amdkfd (part of amdgpu) driver supports the AMD GPU compute stack. amdkfd exposes only a single device /dev/kfd even if multiple AMD GPU (compute) devices exist in a system. However, amdgpu drvier exposes a separate render device file /dev/dri/renderDN for each device. To participate in device

Re: [PATCH 4/4] drm/amdkfd: Check against device cgroup

2019-05-14 Thread Kasiviswanathan, Harish
Hi Roman, Thanks for your feedback. I will rework and send new patch soon. Best Regards, Harish From: Roman Gushchin Sent: Tuesday, May 14, 2019 1:37 PM To: Kasiviswanathan, Harish Cc: cgro...@vger.kernel.org; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amdkfd: Check

Re: [PATCH 3/4] device_cgroup: Export __devcgroup_check_permission

2019-05-13 Thread Kasiviswanathan, Harish
Hello Everyone, Could you please review this patch? Best Regards, Harish On 2019-05-01 10:59 a.m., Kasiviswanathan, Harish wrote: > For AMD compute (amdkfd) driver. > > All AMD compute devices are exported via single device node /dev/kfd. As > a result devices cannot b

Re: [PATCH 1/1] drm/amdgpu: Reserve shared fence for eviction fence

2019-05-07 Thread Kasiviswanathan, Harish
Reviewed-by: Harish Kasiviswanathan On 2019-05-06 4:23 p.m., Kuehling, Felix wrote: > [CAUTION: External Email] > > Need to reserve space for the shared eviction fence when initializing > a KFD VM. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4

[PATCH 4/4] drm/amdkfd: Check against device cgroup

2019-05-01 Thread Kasiviswanathan, Harish
Participate in device cgroup. All kfd devices are exposed via /dev/kfd. So use /dev/dri/renderN node. Before exposing the device to a task check if it has permission to access it. If the task (based on its cgroup) can access /dev/dri/renderN then expose the device via kfd node. If the task

[PATCH 1/4] drm/amdkfd: Store kfd_dev in iolink and cache properties

2019-05-01 Thread Kasiviswanathan, Harish
This is required to check against cgroup permissions. Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 10 ++ drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 3 +++ 2 files changed, 13 insertions(+) diff --git

[PATCH 3/4] device_cgroup: Export __devcgroup_check_permission

2019-05-01 Thread Kasiviswanathan, Harish
For AMD compute (amdkfd) driver. All AMD compute devices are exported via single device node /dev/kfd. As a result devices cannot be controlled individually using device cgroup. AMD compute devices will rely on its graphics counterpart that exposes /dev/dri/renderN node for each device. For each

[PATCH 2/4] drm/amd: Pass drm_device to kfd

2019-05-01 Thread Kasiviswanathan, Harish
kfd needs drm_device to call into drm_cgroup functions Signed-off-by: Harish Kasiviswanathan Reviewed-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_device.c| 2 ++

[PATCH 0/4] AMDKFD (AMD GPU compute) support for device cgroup.

2019-05-01 Thread Kasiviswanathan, Harish
amdkfd (part of amdgpu) driver supports the AMD GPU compute stack. amdkfd exposes only a single device /dev/kfd even if multiple AMD GPU (compute) devices exist in a system. However, amdgpu drvier exposes a separate render device file /dev/dri/renderDN for each device. To participate in device

Re: [PATCH v2 4/4] drm/amdgpu: Simplify eviction fence handling

2019-02-08 Thread Kasiviswanathan, Harish
Reviewed By: Harish Kasiviswanathan On 2019-02-08 4:21 p.m., Kuehling, Felix wrote: > Temporarily removing eviction fences to avoid triggering them by > accident is no longer necessary due to the fence_owner logic in > amdgpu_sync_resv. > > As a result the ef_list usage of

[PATCH v2 1/2] drm/amdgpu: Fix pci platform speed and width

2019-02-05 Thread Kasiviswanathan, Harish
The new Vega series GPU cards have in-built bridges. To get the pcie speed and width supported by the platform walk the hierarchy and get the slowest link. Change-Id: I3196d158b0c614cbb5d7a34c793a58cb95322d32 Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c |

[PATCH v2 2/2] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-05 Thread Kasiviswanathan, Harish
v2: Fix SMU message format Send override message after SMU enable features Change-Id: Ib880c83bc7aa12be370cf6619acfe66e12664c9c Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 45 +- 1 file changed, 27 insertions(+), 18

Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-04 Thread Kasiviswanathan, Harish
g is not the issue here. SMU (or rather PPTable) has to be updated with highest PCI Gen supported by the system. Best Regards, Harish From: Alex Deucher Sent: Monday, February 4, 2019 1:53 PM To: Kasiviswanathan, Harish Cc: Li, Colin; Xi, Sheldon; amd-gfx@lists.freedesktop.org Subject: Re:

Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-04 Thread Kasiviswanathan, Harish
From: Alex Deucher Sent: Friday, February 1, 2019 5:53 PM To: Kasiviswanathan, Harish Cc: Li, Colin; Xi, Sheldon; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)   Right.  we have the max gen and width supported

Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-01 Thread Kasiviswanathan, Harish
rish From: Alex Deucher Sent: Friday, February 1, 2019 5:34 PM To: Kasiviswanathan, Harish Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2) Do we actually need the current status? We have the caps of the plat

Re: [PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-01 Thread Kasiviswanathan, Harish
e_info() to read "PCI_EXP_LINKSTA" and store that information for future use. Best Regards, Harish From: Alex Deucher Sent: Friday, February 1, 2019 5:09 PM To: Kasiviswanathan, Harish Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerpl

[PATCH] v2 Override DPM1 PCIe parameters

2019-02-01 Thread Kasiviswanathan, Harish
Due to misunderstanding with the SMU team, the previous patch "1f33704431a" is incorrect. This patch is verified on Vega20 with X99 (Intel) PCI Gen3 machine. Harish Kasiviswanathan (1): drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

[PATCH] drm/amd/powerplay: add override pcie parameters for Vega20 (v2)

2019-02-01 Thread Kasiviswanathan, Harish
v2: Use PCIe link status instead of link capability Send override message after SMU enable features Change-Id: Iea2a1ac595cf63a9528ff1e9a6955d14d8c3a6d5 Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 93 +++--- 1 file changed,

Re: [PATCH 2/2] drm/amdgpu/nbio7.4: add hw bug workaround for vega20

2018-12-20 Thread Kasiviswanathan, Harish
This patch set Reviewed-by: Harish Kasiviswanathan On 2018-12-19 6:09 p.m., Alex Deucher wrote: > Configure PCIE_CI_CNTL to work around a hw bug that affects > some multi-GPU compute workloads. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 7 +++ > 1

Re: [PATCH RFC 2/5] cgroup: Add mechanism to register vendor specific DRM devices

2018-11-26 Thread Kasiviswanathan, Harish
Thanks Tejun,Eric and Christian for your replies. We want GPUs resource management to work seamlessly with containers and container orchestration. With the Intel / bpf based approach this is not possible. From your response we gather the following. GPU resources need to be abstracted. We

RE: [PATCH 06/25] drm/amdgpu: Add KFD eviction fence

2018-01-30 Thread Kasiviswanathan, Harish
>> [+Harish, forgot to acknowledge him in the commit description, will fix >> that in v2] >> >> Harish, please see Christian's question below in amd_kfd_fence_signal. >> Did I understand this correctly? [HK]: Yes the lifetime of eviction fences is tied to the lifetime of the process associated

RE: [PATCH v2] drm/amdgpu: Sync KFD fence only for move/evict

2017-10-20 Thread Kasiviswanathan, Harish
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Friday, October 20, 2017 2:38 PM To: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2] drm/amdgpu: Sync KFD fence only for move

RE: [PATCH] drm/amdgpu: Sync KFD fence only for move/evict

2017-10-20 Thread Kasiviswanathan, Harish
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Friday, October 20, 2017 3:13 AM To: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Sync KFD fence only for move/evi

RE: [PATCH v2 2/2] drm/amdgpu: Add amdgpu_find_mm_node()

2017-10-10 Thread Kasiviswanathan, Harish
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Monday, October 09, 2017 5:11 AM To: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add amdgpu_find_mm_node

RE: [PATCH v2 1/2] drm/amdgpu: Refactor amdgpu_move_blit

2017-10-10 Thread Kasiviswanathan, Harish
-Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Monday, October 09, 2017 5:08 AM To: Kasiviswanathan, Harish <harish.kasiviswanat...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2 1/2] drm/

  1   2   >