[PATCH] drm/amd/display: fix missing cleanup for remove s3_debug in dm_early_fini()

Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 8837259215d9..2c12385e0e4f 100644 --- a/drivers

[PATCH v2 2/2] drm/amd/pm: change return value in aldebaran_get_power_limit()

v1: 1. change return value to avoid smu driver probe fails when FEATURE_PPT is not enabled. 2. if FEATURE_PPT is not enabled, set power limit value to 0. v2: instead dev_err with dev_warn Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 15 +-- 1

[PATCH v2 1/2] drm/amd/pm: skip to load smu microcode on sriov for aldebaran

v1: 1. skip to load smu firmware in sriov mode for aldebaran chip 2. using vbios pptable if in sriov mode. v2: clean up smu driver code in sriov code path Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 102 -- 1 file changed, 70 insertions(+), 32

[PATCH v2 1/2] drm/amd/pm: skip to load smu microcode on sriov for aldebaran

v1: 1. skip to load smu firmware in sriov mode for aldebaran chip 2. using vbios pptable if in sriov mode. v2: clean up smu driver code in sriov code path Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 41 +++ 1 file changed, 25 insertions(+), 16

[PATCH v2 2/2] drm/amd/pm: change return value in aldebaran_get_power_limit()

v1: 1. change return value to avoid smu driver probe fails when FEATURE_PPT is not enabled. 2. if FEATURE_PPT is not enabled, set power limit value to 0. v2: instead dev_err with dev_warn Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 15 +-- 1

[PATCH 4/5] drm/amd/pm: change return value in aldebaran_get_power_limit()

1. change return value to avoid smu driver probe fails when FEATURE_PPT is not enabled. 2. if FEATURE_PPT is not enabled, set power limit value to 0. Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 15 +-- 1 file changed, 13 insertions(+), 2

[PATCH 5/5] drm/amd/pm: change pp_dpm_sclk/mclk/fclk attribute is RO for aldebaran

the following clock is only support voltage DPM, change attribute to RO: 1. pp_dpm_sclk 2. pp_dpm_mclk 3. pp_dpm_fclk Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c

[PATCH 3/5] drm/amd/pm: change smu msg's attribute to allow working under sriov

the following message is allowed in sriov mode: 1. GetEnabledSmuFeaturesLow 2. GetEnabledSmuFeaturesHigh Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13

[PATCH 2/5] drm/amd/pm: skip to load smu microcode on sriov for aldebaran

1. skip to load smu firmware in sriov mode for aldebaran chip 2. using vbios pptable if in sriov mode. Signed-off-by: Kevin Wang --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 66 ++- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/pm

[PATCH 1/5] drm/amd/pm: correct DPM_XGMI/VCN_DPM feature name

the following feature is wrong, it will cause sysnode of pp_features show error: 1. DPM_XGMI 2. VCN_DPM Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 - .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c| 16 .../gpu/drm/amd/pm/swsmu/smu13

[PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS

correct smu feature mapping: FEATURE_DATA_CALCULATIONS Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 + drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc

[PATCH v3 2/3] drm/amdgpu/ttm: replace duplicate code with exiting function

using exiting function to replace duplicate code blocks in amdgpu_ttm_vram_write(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd

[PATCH v3 1/3] drm/amdgpu: split amdgpu_device_access_vram() into two small parts

split amdgpu_device_access_vram() 1. amdgpu_device_mm_access(): using MM_INDEX/MM_DATA to access vram 2. amdgpu_device_aper_access(): using vram aperature to access vram (option) Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- drivers/gpu/drm/amd/amdgpu

[PATCH v3 3/3] drm/amdgpu/ttm: optimize vram access in amdgpu_ttm_access_memory()

1. using vram aper to access vram if possible 2. avoid MM_INDEX/MM_DATA is not working when mmio protect feature is enabled. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 84 ++--- 1 file changed, 49 insertions(+), 35 deletions(-) diff --git

[RFC PATCH v2 2/3] drm/amdgpu/ttm: replace duplicate code with exiting function

using exiting function to replace duplicate code blocks in amdgpu_ttm_vram_write(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd

[RFC PATCH v2 1/3] drm/amdgpu: split amdgpu_device_access_vram() into two small parts

split amdgpu_device_access_vram() 1. amdgpu_device_mm_access(): using MM_INDEX/MM_DATA to access vram 2. amdgpu_device_aper_access(): using vram aperature to access vram (option) Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- drivers/gpu/drm/amd/amdgpu

[RFC PATCH v2 3/3] drm/amdgpu/ttm: optimize vram access in amdgpu_ttm_access_memory()

1. using vram aper to access vram if possible 2. avoid MM_INDEX/MM_DATA is not working when mmio protect feature is enabled. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 91 +++-- 1 file changed, 54 insertions(+), 37 deletions(-) diff --git

[RFC PATCH 3/3] drm/amdgpu/ttm: optimize vram access in amdgpu_ttm_access_memory()

1. using vram aper to access vram if possible 2. avoid MM_INDEX/MM_DATA is not working when mmio protect feature is enabled. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 95 +++-- 1 file changed, 58 insertions(+), 37 deletions(-) diff --git

[RFC PATCH 1/3] drm/amdgpu: split amdgpu_device_access_vram() into two small parts

split amdgpu_device_access_vram() 1. amdgpu_device_mm_access(): using MM_INDEX/MM_DATA to access vram 2. amdgpu_device_aper_access(): using vram aperature to access vram (option) Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 7 +- drivers/gpu/drm/amd/amdgpu

[RFC PATCH 2/3] drm/amdgpu/ttm: replace duplicate code with exiting function

using exiting function to replace duplicate code blocks in amdgpu_ttm_vram_write(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd

[RFC PATCH v2] drm/amdgpu/ttm: optimize vram access in amdgpu_ttm_access_memory()

1. using vram aper to access vram if possible 2. avoid MM_INDEX/MM_DATA is not working when mmio protect feature is enabled. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 126 +--- 1 file changed, 89 insertions(+), 37 deletions(-) diff --git

[PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

}/MM_DATA to access rest vram memroy. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 69 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 42 ++--- 3 files changed, 58 insertions(+), 55 deletions

[PATCH] drm/amdgpu: fix sdma firmware version error in sriov

Re-adjust the function return order to avoid empty sdma version in the sriov environment. (read amdgpu_firmware_info) Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: optimize code about format string in gfx_v10_0_init_microcode()

the memset() and snprintf() is not necessary. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 80729ea8416a

[PATCH] drm/amdkfd: correct sienna_cichlid SDMA RLC register offset error

on sienna_cichlid chip. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10_3.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10_3.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10_3.c

[PATCH v2] drm/amdkfd: disable kfd debugfs node of hang_hws on vf mode

2kfd_probe() function. 2. disable "hang_hws" debugfs node on vf mode. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c | 7 --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 3 +++ drivers/gpu/drm/amd/amdkfd/kfd_module.c | 3 --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h

[PATCH] drm/amdkfd: disable kfd debugfs node of hang_hws on vf mode

the kfd debugfs node is rely on kgd2kfd probe success, if not, the kfd_debugfs should not be created, and the node of "hang_hws" should be disabled on vf mode. 1. move kfd_debugfs_init() function into kgd2kfd_probe() function. 2. disable "hang_hws" debugfs node on vf mode.

[PATCH] drm/amdgpu: correction of ucode fw_size calculation errors

correct big and little endian problems on different platforms. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 8 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 2 +- drivers/gpu/drm/amd/pm/swsmu

[PATCH] Revert "drm/amdgpu: add psp RAP L0 check support"

This reverts commit a77e3752c319e479c538a84c3b0f6d87f6fa4bc7. Disable PSP RAP L0 self test until to RAP feature ready. --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

[PATCH] drm/amd/pm: remove duplicate XGMI feature mask

replace SMU feature XGMI with XGMI_DPM. it will cause show to be incorrect in pp_features node. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h| 1 - drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] drm/amdgpu: fix parameter error of RREG32_PCIE() in amdgpu_regs_pcie

the register offset isn't needed division by 4 to pass RREG32_PCIE() Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: add pci BDF info in trace amdgpu_device_r[w]reg()

add pci BDF info in amdgpu_device_r[w]reg trace event to support muti-device in one host. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 53 +- 2 files changed, 33 insertions(+), 24 deletions

[PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs

refine PSP TA firmware info print in amdgpu_firmware_info(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 50 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 2/2] drm/amdgpu: add SECURE DISPLAY TA firmware info in debugfs

add SECUREDISPLAY TA firmware info in amdgpu_fimrware_info() Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index 1a27673271b0

[PATCH] drm/amdgpu: correct TA RAP firmware information print error

miss RAP TA in loop ( when i == 4) Fix: drm/amdgpu: add RAP TA version print in amdgpu_firmware_info Signed-off-by: Kevin Wang Reported-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

clean up unsued variable in amdgpu_dma_buf_unmap(). Fixes: drm/amdgpu: Remove amdgpu_device arg from free_sgt api Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b

[PATCH] drm/amdgpu: add RAP TA version print in amdgpu_firmware_info

add RAP TA version print in amdgpu_firmware_info. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c index ce031a77cda5..a5ed9530f542

[PATCH] drm/amdgpu: optimize list operation in amdgpu_xgmi

simplify the list opertion. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index 541ef6be390f..659b385b27b5

[PATCH] drm/amd/pm/swsmu: unify the init soft gpu metrics function

the soft gpu metrics is not asic related data structure. unify them to reduce duplicate code. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 4 --- drivers/gpu/drm/amd/pm/inc/smu_v12_0.h| 2 -- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4

[RFC PATCH 3/3] drm/ttm: add ttm mem trace event support

add ttm memory related trace event support trace events: ttm:ttm_shrink ttm:ttm_mem_global_reserve ttm:ttm_mem_global_free Signed-off-by: Kevin Wang --- drivers/gpu/drm/ttm/ttm_memory.c | 7 drivers/gpu/drm/ttm/ttm_trace.h | 70 2 files changed, 77

[RFC PATCH 2/3] drm/ttm: add ttm vm bo trace event support

add ttm bo VM related trace event support trace events: ttm:ttm_bo_mmap ttm:ttm_bo_vm_fault ttm:ttm_bo_vm_access Signed-off-by: Kevin Wang --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 12 - drivers/gpu/drm/ttm/ttm_trace.h | 78 + 2 files changed, 88 insertions

[RFC PATCH 1/3] drm/ttm: add ttm bo trace event support

-off-by: Kevin Wang --- drivers/gpu/drm/ttm/ttm_bo.c | 23 +++ drivers/gpu/drm/ttm/ttm_module.c | 3 + drivers/gpu/drm/ttm/ttm_trace.h | 321 +++ 3 files changed, 347 insertions(+) create mode 100644 drivers/gpu/drm/ttm/ttm_trace.h diff --git a/drivers/gpu/drm

[RFC PATCH 0/3] add ttm trace event support

ttm:ttm_bo_device_release ttm:ttm_bo_init_reserved ttm:ttm_bo_validate ttm:ttm_bo_release ttm:ttm_bo_mmap ttm:ttm_bo_vm_fault ttm:ttm_bo_vm_access ttm:ttm_shrink ttm:ttm_mem_global_reserve ttm:ttm_mem_global_free Kevin Wang (3): drm/ttm: add ttm bo trace event support drm/ttm: add ttm vm bo trace event support

[PATCH] drm/amd/pm: remove unused message SMU_MSG_SpareX

the SpareX is reserved by SMU firmwared, the driver never use it. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 2 -- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 -- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 2 -- 3 files changed, 6 deletions

[PATCH] drm/amd/display: fix sysfs amdgpu_current_backlight_pwm NULL pointer issue

00 48 8b 88 88 03 00 00 48 8d 81 e8 01 Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c

[PATCH] drm/amdgpu: change trace event parameter name from 'driect' to 'immediate'

s/direct/immediate/g amdgpu vm has renamed parameter name from 'direct' to 'immedate'. however, the trace event is not updated yet. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 24 +++ 1 file changed, 12 insertions(+), 12 deletions(-) diff

[PATCH] drm/amdgpu/pm: add smc v2_1 printer in amdgpu_ucode_print_smc_hdr()

the smc v2_0 printer is not compatible with the smc v2_1 . 1. add smc v2_1 printer. 2. cleanup code Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 29 +++ 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: add missing clock gating info in amdgpu_pm_info

add missing clock gating informations in amdgpu_pm_info 1. AMD_CG_SUPPORT_VCN_MGCG 2. AMD_CG_SUPPORT_HDP_DS 3. AMD_CG_SUPPORT_HDP_SD 4. AMD_CG_SUPPORT_IH_CG 5. AMD_CG_SUPPORT_JPEG_MGCG Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 + 1 file changed, 5 insertions

[PATCH] drm/amdgpu: cleanup debug information in amdgpu_set_pp_features()

Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index e57153d1fa24..a33b1cc50008 100644 --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c +++ b/drivers/gpu/drm

[PATCH] drm/amdgpu: cleanup debug log in amdgpu_set_pp_features()

Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c index e57153d1fa24..a33b1cc50008 100644 --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c +++ b/drivers/gpu/drm

[PATCH] drm/amd/swsmu: correct wrong feature bit mapping

1. when smc feature bit isn't mapped, the feature state isn't showed on sysfs node of pp_features. 2. add pp_features table title Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 -- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[PATCH] drm/amdgpu: update module paramter doc of amdgpu_dpm

the vega20 isn't supported swsmu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 03f4aab1fe99..9d28054b8aae 100644

[PATCH] drm/amd/swsmu: correct wrong feature bit mapping

1. when smc feature bit isn't mapped, the feature state isn't showed on sysfs node of pp_features. 2. add pp_features table title Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 -- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git

[PATCH] drm/amd/swsmu: Add missing feature map for sienna_cichlid

it will cause smu sysfs node of "pp_features" show error. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/pm/inc/smu_types.h | 1 + drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH] drm/amdgpu: remove gfxhub_v1_1_funcs set

remove duplicate gfxhub v1.1 function set. put function of gfxhub_v1_1_get_xgmi_info to gfxhub v1_0 function set. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.c | 13 + drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.h

[PATCH v2] drm/amdgpu: add condition check for trace_amdgpu_cs()

v1: add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. v2: add a new wrapper function to trace all amdgpu cs ibs. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 16 +--- 1 file changed, 13 insertions(+), 3

[PATCH] drm/amdgpu: add condition check for trace_amdgpu_cs()

add trace event enabled check to avoid nop loop when submit multi ibs in amdgpu_cs_ioctl() function. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers

[PATCH] drm/amdgpu: fix amdgpu_bo_release_notify() comment error

fix amdgpu_bo_release_notify() comment error. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c index 3d95b3edb635

Re: [PATCH] drm/amdgpu: drop log message in amdgpu_dpm_baco_reset()

Reviewed-by: Kevin Wang Best Regards, Kevin On 8/13/20 12:25 PM, Alex Deucher wrote: The caller does this now for all reset types. This is now a duplicate call. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH] drm/amdgpu: don't create entity when use cpu to update page table

the entity isn't needed when vm use cpu to update page table. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 45 ++ 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: fix uninit-value in arcturus_log_thermal_throttling_event()

zed] 2268 | if (throttler_status & logging_label[throttler_idx].feature_mask) { Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm

[PATCH 1/2] drm/amd/swsmu: allow asic to handle sensor type by itself

1. allow asic to handle sensor type by itself. 2. if not, use smu common sensor to handle it. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b

[PATCH 2/2] drm/amd/swsmu: correct smu lock type on smu_read_sensor()

instead "mutex" with "sensor_lock" on smu_read_sensor(). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 4 ++-- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 -- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 -- drivers/g

[PATCH v2] drm/amd/smu: unify smu ppt callback marcos

v1: add the new macro "smu_ppt_xxx()" to unify smu callback interfaces v2: rename the macro smu_ppt_xxx to smu_ppt_funcs. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/smu_internal.h | 267 ++- 1 file changed, 82 insertions(+), 185 deletions(-)

[PATCH] drm/amd/smu: unify pptable_func{} callback interface

the pptable_func callback sets should be has unify interface, so use "smu" as the pptable_func interface first parameter. fix interfaces: 1. i2c_eeprom_init 2. i2c_eeprom_fini Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++-- drivers/gpu/drm/amd

[PATCH 1/2] drm/amd/smu: unify pptable_func{} callback interface

the pptable_func callback sets should be has unify interface, so use "smu" as the pptable_func interface first parameter. fix interfaces: 1. i2c_eeprom_init 2. i2c_eeprom_fini Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 ++-- drivers/gpu/drm/amd

[PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos

add the new macro "smu_ppt_xxx()" to unify smu callback interfaces Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/smu_internal.h | 266 ++- 1 file changed, 82 insertions(+), 184 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smu_internal.h b/d

[PATCH v2] drm/amdgpu: fix device attribute node create failed with multi gpu

. move "attr_list" into amdgpu_pm and rename to "pm_attr_list". 2. refine create & remove device node functions parameter. fix: drm/amdgpu: optimize amdgpu device attribute code Signed-off-by: Kevin Wang Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_d

[PATCH] drm/amdgpu: fix device attribute node create failed with multi gpu

er gpu device create attribute node faild. 1. add member attr_list into amdgpu_device to link supported device attribute node. 2. add new structure "struct amdgpu_device_attr_entry{}" to track device attribute state. fix: drm/amdgpu: optimize amdgpu device attribute code Si

[PATCH 2/2] drm/amd/powerplay: remove the support of vega20 from swsmu

by default, vega20 will use legacy powerplay driver. in order to maintain the code conveniently in the future, remove the support of vega20 from swsmu. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c|9 +- drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h |1

[PATCH 1/2] drm/amd/powerplay: remove the support of xgmi pstate on vega20 from swsmu

the vega20 asic uses legacy powerplay driver by default. 1. cleanup is_support_sw_smu_xgmi() function. (ony use for vega20 xgmi pstate check) 2. by default, the vega20 set xgmi pstate by legacy powerplay routine. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c| 4

[PATCH 3/4] drm/amdgpu: cleanup unnecessary virt sriov check in amdgpu attribute

the amdgpu device attribute node will be created accordding to sriov vf mode at runtime. cleanup unnecessary sriov check in attribute operation function. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 105 - 1 file changed, 105 deletions(-) diff

[PATCH 2/4] drm/amdgpu: optimize amdgpu device attribute code

enum. 2. rename callback function perform to attr_update. 3. modify some variable names Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 494 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 46 +++ 2 files changed, 262 insertions(+), 278 deletions(-) diff

[PATCH 4/4] drm/amdgpu: cleanup sriov mode check in internal swsmu driver

cleanup unnecessary check in internal swsmu driver: 1. cleanup amdgpu_sriov_is_pp_one_vf() check logic. 2. cleanup amdgpu_sriov_vf() check logic. 3. add sw smu ip block according to different vf mode. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/nv.c | 29 +++- drivers

[PATCH 1/4] drm/amdgpu: add amdgpu_virt_get_vf_mode helper function

: the driver work on guest OS with multi VF Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 8 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd

[PATCH 3/3] drm/amdgpu: cleanup sriov mode check in internal swsmu driver

cleanup unnecessary check in internal swsmu driver: 1. cleanup amdgpu_sriov_is_pp_one_vf() check logic. 2. cleanup amdgpu_sriov_vf() check logic. 3. add sw smu ip block according to different vf mode. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/nv.c | 29 +++- drivers

[PATCH 2/3] drm/amdgpu: optimize amdgpu device attribute code

functions (xxx_show, xxx_store). Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 577 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 48 ++ 2 files changed, 271 insertions(+), 354 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b

[PATCH 1/3] drm/amdgpu: add amdgpu_virt_get_vf_mode helper function

: the driver work on guest OS with multi VF Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 8 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: cleanup not_vf & pp_not_vf in powerplay

Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 14 +++--- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 +++--- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: clean up unused variable about ring lru

clean up unused variable: 1. ring_lru_list 2. ring_lru_list_lock related-commit: drm/amdgpu: remove ring lru handling Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 --- 2 files changed, 6 deletions(-) diff

[PATCH] drm/amdgpu: fix hpd bo size calculation error

the HPD bo size calculation error. the "mem.size" can't present actual BO size all time. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH] drm/amdgpu/swsmu: clean up unused header in swsmu

clean up unused header in swsmu driver stack: 1. pp_debug.h 2. amd_pcie.h 3. soc15_common.h Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 3 --- drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 -- drivers/gpu

Re: [PATCH] drm/amdgpu/swSMU/navi: add feature toggles for more things

Reviewed-by: Kevin Wang Best Regards, Kevin On 10/9/19 9:17 PM, Alex Deucher wrote: > Add toggles for more power features. Helpful in debugging. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 24 -- > 1 file chan

Re: [PATCH] drm/amdgpu: fix null pointer deref in firmware header printing

On 9/5/19 5:41 PM, Yuan, Xiaojie wrote: > When CE's ucode_id(8) is used to get sdma_hdr, we will be accessing an > unallocated amdgpu_firmware_info instance. > > This issue appears on rhel7.7 with gcc 4.8.5. Newer compilers might have > optimized out such 'defined but not referenced' variable. >

Re: [PATCH] drm/amd/powerplay: fix 'unusedd variable' compile warning

Reviewed-by: Kevin Wang On 9/5/19 5:30 PM, Quan, Evan wrote: > Reviewed-by: Evan Quan > >> -Original Message- >> From: Yuan, Xiaojie >> Sent: 2019年9月5日 17:26 >> To: amd-gfx@lists.freedesktop.org >> Cc: Feng, Kenneth ; Quan, Evan >> ; Wang,

Re: [PATCH] drm/amd/powerplay: update cached feature enablement status

Hi Evan, this is know issue for me. i think we should add update feature mask cached operation into smu_feature_update_enable_state function. Best Regards, Kevin On 8/21/19 5:24 PM, Evan Quan wrote: > Need to update in cache feature enablement status after pp_feature > settings. Another fix

Re: [PATCH 2/4] drm/amd/powerplay: expose supported clock domains only through sysfs

-by: Kevin Wang <mailto:kevin1.w...@amd.com> Best Regards, Kevin On 8/16/19 3:52 PM, Quan, Evan wrote: Bascially, we should not expose the sysfs interface for those features not supported by the ASIC. As, there are some tools/tests which judges whether the feature is supported by the exi

Re: [PATCH 1/2] drm/amd/powerplay: remove redundancy debug log about smu unsupported features

Reviewed-by: Kevin Wang On 8/12/19 4:22 PM, Chengming Gui wrote: > remove redundancy debug log about smu unsupported features > > Signed-off-by: Chengming Gui > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --g

Re: [PATCH 2/2] drm/amd/powerplay: add arcturus_is_dpm_running function for arcturus

Reviewed-by: Kevin Wang On 8/12/19 4:22 PM, Chengming Gui wrote: > add arcturus_is_dpm_running function > > Signed-off-by: Chengming Gui > --- > drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 21 + > 1 file changed, 21 insertions(+) > > diff --g

Re: [PATCH 24/26] drm/amdgpu: add RAS callback for gfx

On 8/1/19 1:58 AM, Alex Deucher wrote: > From: Dennis Li > > Add functions for RAS error inject and query error counter > > Signed-off-by: Dennis Li > Reviewed-by: Tao Zhou > Reviewed-by: Hawking Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 + >

Re: [PATCH] drm/amd/powerplay: sort feature status index by asic feature id for smu

( 9) : enabeld > 10. DS_GFXCLK(10) : enabeld > 11. DS_SOCCLK(11) : enabeld > 12. DS_LCLK (12) : disabled > 13. DS_DCEFCLK (13) : enabeld > .. > > Signed-off-by: Kevin Wang > --- > drivers/gpu/drm/amd/powerplay/amd

Re: [PATCH 1/2] drm/amd/powerplay: support power profile retrieval and setting on arcturus

mode); > + if (workload_type < 0) { > + pr_err("Unsupported power profile mode %d on arcturus\n", > profile_mode); > + return -EINVAL; > + } > + > + smu_send_smc_msg_with_param(smu, > +

Re: [PATCH 2/2] drm/amd/powerplay: enable SW SMU power profile switch support in KFD

Reviewed-by: Kevin Wang BR Kevin On 7/31/19 11:39 AM, Evan Quan wrote: > Hook up the SW SMU power profile switch in KFD routine. > > Change-Id: I41e53762cdc7504285de89f30e3e6e2bb396b953 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 8

Re: [PATCH v2] drm/amdgpu/powerplay: provide the interface to disable uclk switch for DAL

It's looks fine for me. Reviewed-by: Kevin Wang Best Regards, Kevin On 7/30/19 2:01 PM, Kenneth Feng wrote: > provide the interface for DAL to disable uclk switch on navi10. > in this case, the uclk will be fixed to maximum. > this is a workaround when display configuration causes

Re: [PATCH] drm/amdgpu/powerplay: provide the interface to disable uclk switch for DAL

On 7/30/19 12:09 PM, Kenneth Feng wrote: > provide the interface for DAL to disable uclk switch on navi10. > in this case, the uclk will be fixed to maximum. > this is a workaround when display configuration causes underflow issue. > > Signed-off-by: Kenneth Feng > --- >

Re: [PATCH 18/30] drm/amd/powerplay: init arcturus SMU metrics table on bootup

On 7/30/19 4:14 AM, Alex Deucher wrote: > From: Evan Quan > > Initialize arcturus SMU metrics table. > > Signed-off-by: Evan Quan > Reviewed-by: Kevin Wang > Reviewed-by: Alex Deucher > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/arcturu

Re: [PATCH 16/30] drm/amd/powerplay: correct Navi10 VCN powergate control

On 7/30/19 4:14 AM, Alex Deucher wrote: > From: Evan Quan > > No VCN DPM bit check as that's different from VCN PG. Also > no extra check for possible double enablement/disablement > as that's already done by VCN. > > Signed-off-by: Evan Quan > Reviewed-by: Kenneth Feng > Signed-off-by: Alex

Re: [PATCH] drm/amd/powerplay: fix temperature granularity error in smu11

> in this patch, >> drm/amd/powerplay: add callback function of >> get_thermal_temperature_range the driver missed temperature granularity >> change on other temperature. >> >> Signed-off-by: Kevin Wang >> --- >> drivers/gpu/drm/amd/powerplay/smu_v11_0.c |

Re: [PATCH 6/9] drm/amdgpu: add reset_method asic callback for navi

Reviewed-by: Kevin Wang On 7/24/19 1:00 PM, Alex Deucher wrote: > Navi uses either mode1 or baco depending on various > conditions. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 15 ++- > 1 file changed, 14 insertions(+), 1 delet

Re: [PATCH] drm/amd/powerplay: fix deadlock around smu_handle_task V2

Reviewed-by: Kevin Wang Best Regards, Kevin On 7/16/19 11:01 AM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan >> Sent: Friday, July 12, 2019 1:51 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Wang, Kevin(Yang) ; Quan,

  1   2   >