Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-21 Thread Kurt Kartaltepe
t least this shared pci code should be solid. > I'm not sure yet what's going wrong with the Thunderbold controller, but > completely re-assigning bus numbers is certainly the wrong approach. I agree, it is just what is currently available in the kernel. A less disruptive approach seems needed. --Kurt Kartaltepe

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-20 Thread Kurt Kartaltepe
On Tue, Mar 19, 2024 at 2:54 AM Christian König wrote: > > > Well what problems do you run into? The ACPI and BIOS assignments > usually work much better than whatever the Linux PCI subsystem comes up > with. Perhaps its easier to show the lspci output for the BIOS assignment and we can agree it'

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 8:42 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 10:19 AM Kurt Kartaltepe > wrote: > > > > On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > > > > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe > > > w

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
i'm considering it may be better, though not upstreamable, to implement renumbering only for specified devices like this pci bridge or investigate runtime management of the pci bus addresses. The current assign-busses implementation is quite the big hammer admittedly. --Kurt Kartaltepe

Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-19 Thread Kurt Kartaltepe
On Mon, Mar 18, 2024 at 6:37 AM Alex Deucher wrote: > > On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe wrote: > > > > These checks prevent using amdgpu with the pcie=assign-busses parameter > > which will re-address devices from their acpi values. > > >

[PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

2024-03-18 Thread Kurt Kartaltepe
These checks prevent using amdgpu with the pcie=assign-busses parameter which will re-address devices from their acpi values. Signed-off-by: Kurt Kartaltepe --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu