RE: [PATCH] drm/amdgpu: add kernel DOC for ioctls in amdgpu_cs.c file

2018-06-01 Thread Li, Samuel
I can see them now. Sam > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Samuel Li > Sent: Friday, June 01, 2018 5:10 PM > To: Michel Dänzer ; Liu, Leo > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add kernel DOC

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-21 Thread Li, Samuel
eucher, Alexander <alexander.deuc...@amd.com>; Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <mic...@daenzer.net>; amd-gfx list <amd-gfx@lists.freedesktop.org>; Li, Samuel <samuel...@amd.com> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display sup

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Li, Samuel
Also, the change here is only for display buffer, so it is not really a "big" waste. Regards, Samuel Li From: Li, Samuel Sent: Tuesday, March 20, 2018 4:38 PM To: Deucher, Alexander <alexander.deuc...@amd.com> Cc: Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-20 Thread Li, Samuel
com>; Marek Olšák <mar...@gmail.com> Cc: Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <mic...@daenzer.net>; Li, Samuel <samuel...@amd.com>; amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display supp

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
rch 19, 2018 4:27 PM To: Deucher, Alexander <alexander.deuc...@amd.com> Cc: Li, Samuel <samuel...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <mic...@daenzer.net>; amd-gfx list <amd-gfx@lists.freedesktop.o

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
, March 19, 2018 3:54 PM To: Li, Samuel <samuel...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Marek Olšák <mar...@gmail.com> Cc: Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <mic...@daenzer.net>; amd-gfx list <amd-gfx@lists.freedesktop.org> Subject

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
m: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Monday, March 19, 2018 3:45 PM To: Li, Samuel <samuel...@amd.com>; Marek Olšák <mar...@gmail.com>; Koenig, Christian <christian.koe...@amd.com> Cc: Alex Deucher <alexdeuc...@gmail.com>; Michel Dänzer <mic.

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
istian <christian.koe...@amd.com> Cc: Li, Samuel <samuel...@amd.com>; Michel Dänzer <mic...@daenzer.net>; Alex Deucher <alexdeuc...@gmail.com>; amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support On Mon

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-19 Thread Li, Samuel
I agree with Marek/Michel: since kernel sets the domain before scanning out, it shall update the preferred domain here too. Regards, Samuel Li > -Original Message- > From: Koenig, Christian > Sent: Thursday, March 08, 2018 4:07 AM > To: Michel Dänzer <mic...@daenzer.n

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-07 Thread Li, Samuel
For display buffer, this case seems not really attractive. When display buffer > changes between GTT and VRAM dynamically, our driver needs to adpat too, > which is hard to see the benefits and not really worth the effort. > > Sam > > > > On 2018-03-07 01:27 PM, Alex Deucher

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
m: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Tuesday, March 06, 2018 1:02 PM > To: Michel Dänzer <mic...@daenzer.net>; Koenig, Christian > <christian.koe...@amd.com>; Li, Samuel <samuel...@amd.com>; Alex > Deucher <alexdeuc...@gmail.com> &

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
ptions for all kinds of use cases. All amd drivers so far provides options, and the default configuration is actually to allocate everything from GTT when possible. Regards, Samuel Li > -Original Message- > From: Koenig, Christian > Sent: Tuesday, March 06, 2018 12:12 PM &

RE: [PATCH 1/2] drm/amdgpu: Enable scatter gather display support

2018-03-06 Thread Li, Samuel
This information is kind of important, and it only prints once typically when module is loaded. Regards, Samuel Li > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, March 06, 2018 12:04 PM > To: Li, Samuel <samuel...@amd.co

RE: [PATCH v2 1/1] drm: add kernel doc for exported gem dmabuf_ops

2018-02-20 Thread Li, Samuel
OK, I can do that. Regards, Samuel Li > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, February 20, 2018 11:23 AM > To: Li, Samuel <samuel...@amd.com> > Cc: Daniel Vetter <dan...@f

RE: [PATCH v2 1/1] drm: add kernel doc for exported gem dmabuf_ops

2018-02-20 Thread Li, Samuel
t...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, February 20, 2018 10:13 AM > To: Li, Samuel <samuel...@amd.com> > Cc: Daniel Vetter <dan...@ffwll.ch>; Koenig, Christian > <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freed

RE: [PATCH v2 1/1] drm: add kernel doc for exported gem dmabuf_ops

2018-01-30 Thread Li, Samuel
ent: Tuesday, January 30, 2018 4:33 AM > To: Koenig, Christian <christian.koe...@amd.com> > Cc: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH v2 1/1] drm: add kernel doc for exported gem > dmabuf_ops

RE: [PATCH] drm/amdgpu: only allow scatter/gather display with DC

2018-01-12 Thread Li, Samuel
Somehow my test case seems working although DC not enabled? Regards, Samuel Li > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, January 12, 2018 4:03 PM > To: Alex Deucher ; amd- >

RE: [PATCH 3/3] drm/amdgpu: Move to gtt before cpu accesses dma buf.

2018-01-11 Thread Li, Samuel
A good catch. I'll fix that. Regards, Samuel Li > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, January 11, 2018 1:43 AM > To: kbu...@01.org; Li, Samuel <samuel...@amd.com> > Cc: kbuild-...@01.org; dri-de...@lists.free

RE: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-10 Thread Li, Samuel
OK. I'll do it. Samuel Li > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Wednesday, January 10, 2018 3:17 AM > To: Alex Deucher <alexdeuc...@gmail.com> > Cc: Deucher, Alexander <alexander.d

RE: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

2018-01-09 Thread Li, Samuel
Yes, please hush this for me. Regards, Samuel Li > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Tuesday, January 09, 2018 4:22 AM > To: Koenig, Christian <christian.koe...@amd.com> > Cc: Li, Samuel

RE: [PATCH 1/3] drm/prime: forward begin_cpu_access callback to drivers

2017-12-20 Thread Li, Samuel
Ping... can someone please review this patch? Samuel Li > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Samuel Li > Sent: Friday, December 15, 2017 11:28 AM > To: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org > Cc:

RE: FW: [PATCH v2 2/2] drm/amdgpu: Move to gtt before cpu accesses dma buf.

2017-12-13 Thread Li, Samuel
Will do after some basic testing. Sam From: Deucher, Alexander Sent: Wednesday, December 13, 2017 2:49 PM To: Li, Samuel <samuel...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: FW: [PATCH v2 2/2] drm/amdgpu: Move to gtt before

RE: [PATCH 1/1] drm/amdgpu: Pin to gtt before cpu accesses dma buf.

2017-11-29 Thread Li, Samuel
-Original Message- > From: Koenig, Christian > Sent: Wednesday, November 29, 2017 10:01 AM > To: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/1] drm/amdgpu: Pin to gtt before cpu accesses dma > buf. > > > What is the concern fo

RE: [PATCH 1/1] drm/amdgpu: Pin to gtt before cpu accesses dma buf.

2017-11-29 Thread Li, Samuel
One major purpose of the ChromeOS mmap_test is to avoid buffer copying. What is the concern for scanning out from GTT on APUs? Sam > -Original Message- > From: Koenig, Christian > Sent: Wednesday, November 29, 2017 9:54 AM > To: Li, Samuel <samuel...@am

RE: [PATCH v2 1/1] drm/amdgpu: Add gem_prime_mmap support

2017-09-20 Thread Li, Samuel
Sent: Wednesday, September 20, 2017 12:21 PM > To: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2 1/1] drm/amdgpu: Add gem_prime_mmap support > > Am 20.09.2017 um 17:44 schrieb Li, Samuel: > >> What happens when another

RE: [PATCH v2 1/1] drm/amdgpu: Add gem_prime_mmap support

2017-09-20 Thread Li, Samuel
ptember 20, 2017 2:58 AM > To: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2 1/1] drm/amdgpu: Add gem_prime_mmap support > > > What do you mean "This isn't race free"? > > Take a look at the code again: > > +dma_buf =

RE: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-05 Thread Li, Samuel
7 7:03 AM > To: Li, Samuel <samuel...@amd.com> > Cc: amd-gfx mailing list <amd-gfx@lists.freedesktop.org>; ML dri-devel de...@lists.freedesktop.org> > Subject: Re: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name > > Hi Samuel, > > On 30 June 2017 at

RE: [PATCH libdrm 2/2] radeon: use asic id table to get chipset name

2017-07-04 Thread Li, Samuel
and statements. OK. Sam > -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Tuesday, July 04, 2017 5:43 AM > To: Li, Samuel <samuel...@amd.com> > Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [PATC

RE: [PATCH] drm/amdgpu/psp: upper_32_bits/lower_32_bits for address setup

2017-06-23 Thread Li, Samuel
Reviewed-by: Samuel Li <samuel...@amd.com> Sam > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Deucher > Sent: Thursday, June 22, 2017 6:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander &l

RE: [PATCH libdrm v6 1/1] amdgpu: move asic id table to a separate file

2017-06-05 Thread Li, Samuel
> what is the purpose of the file version The initial purpose is to act like a version tag, not necessarily format related. Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Sunday, June 04, 2017 10:10 PM To: Li, Samuel <samuel...@amd.com> Cc

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-02 Thread Li, Samuel
mes. Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Thursday, June 01, 2017 11:06 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1] amdgpu: move asic i

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-06-01 Thread Li, Samuel
much time you would like to spend in auditing the names :) Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Thursday, June 01, 2017 2:09 AM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com&g

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-31 Thread Li, Samuel
Please see comments incline, -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, May 31, 2017 1:15 AM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1]

RE: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Li, Samuel
Please see comments inline. -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Monday, May 29, 2017 9:26 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v4 1/1]

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-30 Thread Li, Samuel
ntries sounds like a step in the wrong > direction. Check the vendor's entries in pci.ids, and you might have some better idea. Sam -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Tuesday, May 30, 2017 7:01 AM To: Li, Samuel <samuel...@amd.com> Cc: Alex De

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Li, Samuel
Recently there are some changes internally, I can integrate them into this one. There are still discussions on going regarding the format. Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Sunday, May 28, 2017 10:11 PM To: Li, Samuel <samuel...@amd.com&

RE: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate file

2017-05-29 Thread Li, Samuel
- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Friday, May 26, 2017 3:27 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v3 1/1] amdgpu: move asic id table to a separate

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-24 Thread Li, Samuel
y need to automate the upstream update to save sometime for ourselves. Sam -Original Message- From: Deucher, Alexander Sent: Tuesday, May 23, 2017 8:12 AM To: 'Michel Dänzer' <mic...@daenzer.net>; Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan,

RE: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file

2017-05-16 Thread Li, Samuel
nday, May 14, 2017 1:46 PM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file On Sat, May 13, 2017 at 12:50 AM, Li, Samuel <samuel...@amd.com> wrote

RE: [PATCH libdrm v2 1/1] amdgpu: move asic id table to a separate file

2017-05-12 Thread Li, Samuel
to print out the ids file version. Thanks, Sam -Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Friday, May 12, 2017 8:16 AM To: Li, Samuel <samuel...@amd.com> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [P

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-12 Thread Li, Samuel
My understanding is this is actually a data file. Similar to amdgpu firmware, which is also separate from the kernel source code. Sam -Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Thursday, May 11, 2017 8:50 PM To: Li, Samuel <samuel...@amd.com> Cc: a

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Li, Samuel
The bugzilla id is actually here, https://bugs.freedesktop.org/show_bug.cgi?id=101013 Sam -Original Message- From: Li, Samuel Sent: Thursday, May 11, 2017 5:13 PM To: 'Michel Dänzer' <mic...@daenzer.net> Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Li, Samuel
Good catch! Sam From: Yuan, Xiaojie Sent: Thursday, May 11, 2017 6:51 AM To: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/1] amdgpu: move asic id table to a separate file Hi Samuel, Here's an off-by-one error: +

RE: [PATCH 2/3] drm/radeon: Make SI support in Radeon conditional

2017-04-12 Thread Li, Samuel
My understanding is that SI support in AMDGPU is limited. So maybe here it can be the other way around, that by default SI support in AMDGPU shall be disabled. Sam -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Felix Kuehling Sent:

RE: [PATCH] Revert "drm/amd/amdgpu: Disable GFX_PG on Carrizo until compute issues solved"

2017-03-17 Thread Li, Samuel
Patches is: Reviewed-by: Samuel Li <samuel...@amd.com> -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Friday, March 17, 2017 3:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexander.deuc..