nused-const-variable) \
> > + $(call cc-option, -Wstringop-truncation) \
> > + $(call cc-option, -Wpacked-not-aligned)
> > +subdir-ccflags-y += $(cond-flags)
> > subdir-ccflags-y += -Wno-unused-parameter
> > subdir-ccflags-y += -Wno-type-limits
> > subdir-ccflags-y += -Wno-sign-compare
> > --
> > 2.40.1
> >
--
Best Regards
Masahiro Yamada
h/s390/kernel/vdso64/Makefile| 4 +--
> arch/s390/purgatory/Makefile| 2 +-
> arch/x86/boot/compressed/Makefile | 2 +-
> drivers/gpu/drm/amd/display/dc/dml/Makefile | 3 ++-
> scripts/Kconfig.include | 2 +-
> scripts/Makefile.clang | 2 ++
> scripts/Makefile.compiler | 8 +++---
> scripts/as-version.sh | 2 +-
> 21 files changed, 74 insertions(+), 98 deletions(-)
> ---
> base-commit: 88603b6dc419445847923fcb7fe5080067a30f98
> change-id: 20221228-drop-qunused-arguments-0c5c7dae54fb
>
> Best regards,
> --
> Nathan Chancellor
>
--
Best Regards
Masahiro Yamada
# gcc-11+, clang-14+
ifeq ($(call cc-min-version, 11, 14),y)
dwarf-version-y := 5
else
dwarf-version-y := 4
endif
... can be written in a more simpler way:
dwarf-version-y := 4
dwarf-version-$(call gcc-min-version, 11) := 5
dwarf-version-$(call clang-min-version, 14) := 5
With $(call cc-min-version, 11, 14),
you never know the meaning of 11, 14
until you see the definition of this macro.
So, you feel like adding the comment "gcc-11+, clang-14+".
The latter form, the code is self-documenting.
> # ld-option
> # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)
> --
> 2.37.2.672.g94769d06f0-goog
>
--
Best Regards
Masahiro Yamada
On Wed, Jun 15, 2022 at 5:35 PM Michel Dänzer
wrote:
>
> On 2022-04-14 18:57, Michel Dänzer wrote:
> > On 2022-04-14 17:04, Masahiro Yamada wrote:
> >> On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer
> >> wrote:
> >>> On 2022-04-14 15:34, Alex Deucher wro
end it for in-tree drivers.
> >>
> >> Yes, exactly that. I'm like 95% sure that used to work, but I don't know
> >> why exactly either.
> >>
> >>> FWIW, this is pretty common in the kernel according to git grep.
> >>
> >&g
On Wed, Mar 25, 2020 at 4:42 AM Alex Deucher wrote:
>
> On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada wrote:
> >
> > Hi,
> >
> > I think this series is a good clean-up.
> >
> > Could you take a look at this please?
>
> Can you resend? I d
Hi,
I think this series is a good clean-up.
Could you take a look at this please?
On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote:
>
> A header include path without $(srctree)/ is suspicious because it does
> not work with O= builds.
>
> You can build drivers/gpu/drm/
/r300.o
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
index 480a8d4a3c82..11c97edde54d 100644
--- a/drivers/gpu/drm/radeon/Makefile
+++ b
This Makefile repeats similar build rules. Use a pattern rule.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 29 +
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
if_changed must have FORCE as a prerequisite, and the targets must be
added to 'targets'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile
t; ifdef CONFIG_DRM_AMD_DC_DCN2_1
> CFLAGS_$(AMDDALPATH)/dc/dml/dcn21/display_mode_vba_21.o := $(dml_ccflags)
> CFLAGS_$(AMDDALPATH)/dc/dml/dcn21/display_rq_dlg_calc_21.o := $(dml_ccflags)
> --
> 2.6.2
>
--
Best Regards
Masahiro Yamada
Since commit 04d5e2765802 ("drm/amdgpu: Merge amdkfd into amdgpu"),
drivers/gpu/drm/amd/amdkfd/Makefile does not contain any syntax that
is understood by the build system.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/d
Hi.
On Fri, Mar 29, 2019 at 8:37 PM Masahiro Yamada
wrote:
>
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada
Reviewed-by: Sam Ravnborg
---
I put a
On Thu, Jan 31, 2019 at 1:01 PM Masahiro Yamada
wrote:
>
> Currently, the Kbuild core manipulates header search paths in a crazy
> way [1].
>
> To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
> the search paths in the srctree. Some Makefiles are already wri
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada
---
I put all gpu/drm changes into a si
Use <...> notation to include headers located in include/linux.
While we are here, tweak the includes order a bit to sort them
alphabetically.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c| 4 ++--
drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
17 matches
Mail list logo
