Re: [PATCH v3 2/2] drm/amdgpu: add the argument description for gpu_addr

2024-11-13 Thread Paneer Selvam, Arunpravin
Reviewed-by: Arunpravin Paneer Selvam On 11/13/2024 2:37 PM, Sunil Khatri wrote: Add argument description for the input argument gpu_addr for amdgpu_seq64_alloc. Fixes the warning raised by the compiler: drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168: warning: Function parameter or struct membe

Re: [PATCH v1 2/2] drm/amdgpu: add the argument description for gpu_addr

2024-11-13 Thread Paneer Selvam, Arunpravin
On 11/13/2024 1:45 PM, Sunil Khatri wrote: Add argument description for the input argument gpu_addr for amdgpu_device_ip_set_powergating_state. for amdgpu_seq64_alloc? Fixes the warning raised by the compiler: drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168: warning: Function parameter or str

Re: [PATCH 1/2] drm/amdgpu: add userq specific kernel config for fence ioctls

2024-10-29 Thread Paneer Selvam, Arunpravin
On 10/29/2024 7:33 PM, Christian König wrote: Am 29.10.24 um 14:32 schrieb Alex Deucher: On Tue, Oct 29, 2024 at 5:38 AM Christian König wrote: Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam: Keep the user queue fence signal and wait IOCTLs in the kernel config CONFIG_DRM_AMDGPU_NAV

Re: [PATCH] drm/amdgpu: Add gpu_addr support to seq64 allocation

2024-10-21 Thread Paneer Selvam, Arunpravin
Hi Christian, I couldn't find other users except userq fence driver which are not yet pushed into amd-staging-drm-next. Should we wait and push along with userq fence patches or we can push this one separately. Thanks, Arun. On 10/18/2024 7:09 PM, Christian König wrote: Am 18.10.24 um 15:26

Re: [PATCH v4 09/09] drm/amdgpu: Add separate array of read and write for BO handles

2024-10-16 Thread Paneer Selvam, Arunpravin
On 10/16/2024 3:26 AM, Marek Olšák wrote: On Tue, Oct 15, 2024 at 3:58 AM Arunpravin Paneer Selvam wrote: Drop AMDGPU_USERQ_BO_WRITE as this should not be a global option of the IOCTL, It should be option per buffer. Hence adding separate array for read and write BO handles. Signed-off-by:

Re: [PATCH v2 01/08] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-26 Thread Paneer Selvam, Arunpravin
Hi Christian, On 9/26/2024 3:04 PM, Christian König wrote: Am 26.09.24 um 11:31 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 9/26/2024 2:57 PM, Christian König wrote: Am 25.09.24 um 21:59 schrieb Arunpravin Paneer Selvam: [SNIP] +int amdgpu_userq_wait_ioctl(struct drm_device *dev

Re: [PATCH v2 01/08] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-26 Thread Paneer Selvam, Arunpravin
Hi Christian, On 9/26/2024 2:57 PM, Christian König wrote: Am 25.09.24 um 21:59 schrieb Arunpravin Paneer Selvam: [SNIP] +int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data, +    struct drm_file *filp) +{ +    struct drm_amdgpu_userq_fence_info *fence_info = NULL; +    s

Re: [PATCH 1/6] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-10 Thread Paneer Selvam, Arunpravin
Hi Christian, On 9/5/2024 2:10 PM, Christian König wrote: Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as

Re: [PATCH 3/6] drm/amdgpu: screen freeze and userq driver crash

2024-09-10 Thread Paneer Selvam, Arunpravin
Hi Christian, On 9/5/2024 4:50 PM, Christian König wrote: Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: Screen freeze and userq fence driver crash while playing Xonotic Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 12 +++-  

Re: [PATCH] drm/amdgpu: always allocate cleared VRAM for GEM allocations

2024-09-09 Thread Paneer Selvam, Arunpravin
) than clearing with compute. Marek On Thu, Aug 29, 2024 at 2:23 PM Paneer Selvam, Arunpravin wrote: this will fix performance issues, Acked-by: Arunpravin Paneer Selvam On 8/29/2024 10:56 PM, Alex Deucher wrote: This adds allocation latency, but aligns better with user expectations. The latency

Re: [PATCH] drm/amdgpu: always allocate cleared VRAM for GEM allocations

2024-08-29 Thread Paneer Selvam, Arunpravin
this will fix performance issues, Acked-by: Arunpravin Paneer Selvam > On 8/29/2024 10:56 PM, Alex Deucher wrote: This adds allocation latency, but aligns better with user expectations. The latency should improve with the drm buddy clearing patches that

Re: [PATCH] drm/amdgpu: Add DCC GFX12 flag to enable address alignment

2024-08-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 8/19/2024 1:59 PM, Christian König wrote: Am 05.08.24 um 16:01 schrieb Arunpravin Paneer Selvam: We require this flag AMDGPU_GEM_CREATE_GFX12_DCC or any other kernel level GFX12 DCC flag to differentiate the DCC buffers and other pinned display buffers(which has TTM_PL_FLAG_CON

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-26 Thread Paneer Selvam, Arunpravin
On 7/24/2024 8:42 PM, Jani Nikula wrote: On Tue, 23 Jul 2024, Arunpravin Paneer Selvam wrote: - Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in situations like if drivers would like to do address alignment

Re: [PATCH v7 1/2] drm/buddy: Add start address support to trim function

2024-07-23 Thread Paneer Selvam, Arunpravin
Hi Matthew, Can we push this version for now as we need to mainline the DCC changes ASAP, while we continue our discussion and proceed to implement the permanent solution for address alignment? Thanks, Arun. On 7/23/2024 6:55 PM, Arunpravin Paneer Selvam wrote: - Add a new start parameter i

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-22 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 7/19/2024 4:01 PM, Matthew Auld wrote: On 17/07/2024 16:02, Paneer Selvam, Arunpravin wrote: On 7/16/2024 3:34 PM, Matthew Auld wrote: On 16/07/2024 10:50, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 7/10/2024 6:20 PM, Matthew Auld wrote: On 10/07/2024 07:03, Paneer

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-17 Thread Paneer Selvam, Arunpravin
On 7/16/2024 3:34 PM, Matthew Auld wrote: On 16/07/2024 10:50, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 7/10/2024 6:20 PM, Matthew Auld wrote: On 10/07/2024 07:03, Paneer Selvam, Arunpravin wrote: Thanks Alex. Hi Matthew, Any comments? Do we not pass the required address

Re: [PATCH v5 2/2] drm/amdgpu: Add address alignment support to DCC buffers

2024-07-17 Thread Paneer Selvam, Arunpravin
Hi Christian, Can we use the below combination flags to kick in hardware workaround while pinning BO's for this specific hw generation. if (place->flags & TTM_PL_FLAG_CONTIGUOUS) && (amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(12, 0, 0) || amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSIO

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-16 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 7/10/2024 6:20 PM, Matthew Auld wrote: On 10/07/2024 07:03, Paneer Selvam, Arunpravin wrote: Thanks Alex. Hi Matthew, Any comments? Do we not pass the required address alignment when allocating the pages in the first place? If address alignment is really useful, we can add

Re: [PATCH] drm/buddy: Add start address support to trim function

2024-07-09 Thread Paneer Selvam, Arunpravin
Thanks Alex. Hi Matthew, Any comments? Thanks, Arun. On 7/9/2024 1:42 AM, Alex Deucher wrote: On Thu, Jul 4, 2024 at 4:40 AM Arunpravin Paneer Selvam wrote: - Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in sit

Re: [PATCH v3] drm/amdgpu: Fix the BO release clear memory warning

2024-06-10 Thread Paneer Selvam, Arunpravin
Hi Christian, On 6/10/2024 11:35 PM, Christian König wrote: Am 10.06.24 um 20:04 schrieb Arunpravin Paneer Selvam: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling

Re: [PATCH] drm/amdgpu: Fix the BO release clear memory warning

2024-06-05 Thread Paneer Selvam, Arunpravin
Hi Christian, On 5/7/2024 8:21 PM, Christian König wrote: Am 06.05.24 um 15:48 schrieb Arunpravin Paneer Selvam: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling th

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Dave, Please help pull this patch into drm-next. This will fix any unnecessary warnings in memory pressure situation. Thanks for the help. Regards, Arun. On 5/17/2024 8:03 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessaril

Re: 6.10/regression/bisected - commit a68c7eaa7a8f cause *ERROR* Trying to clear memory with ring turned off in amdgpu_fill_buffer.

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 6:56 PM, Mikhail Gavrilov wrote: Hi, I am continuing to test unstable kernels. Yesterday at Fedora Rawhide arrived the new kernel 20240516git3c999d1ae3c7 and I spotted in kernel log new error message: [ 13.676117] [drm] Seamless boot condition check passed [ 13.676996] [drm:am

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
On 5/17/2024 7:30 PM, Matthew Auld wrote: On 17/05/2024 14:50, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_merge call

Re: [PATCH v2] drm/buddy: Fix the warn on's during force merge

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, This fixes the problem. Regards, Arun. On 5/17/2024 7:20 PM, Arunpravin Paneer Selvam wrote: Move the fallback and block incompatible checks above, so that we dont unnecessarily split the blocks and leaving the unmerged. This resolves the unnecessary warn on's thrown during force_me

Re: [PATCH] drm/buddy: Merge back blocks in bias range function

2024-05-17 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you help review this patch quickly. Hi Dave This patch just fixes the unnecessary warn on's triggered during the force_merge call. Regards, Arun. On 5/17/2024 6:08 PM, Arunpravin Paneer Selvam wrote: In bias range allocation, when we don't find the required blocks (i.e) on re

Re: [PATCH v2 2/2] drm/tests: Add a unit test for range bias allocation

2024-05-13 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 5/13/2024 1:49 PM, Matthew Auld wrote: On 12/05/2024 08:59, Arunpravin Paneer Selvam wrote: Allocate cleared blocks in the bias range when the DRM buddy's clear avail is zero. This will validate the bias range allocation in scenarios like system boot when no cleared blocks are av

Re: [PATCH] drm/buddy: Fix the range bias clear memory allocation issue

2024-05-12 Thread Paneer Selvam, Arunpravin
Hi Daniel, On 5/8/2024 2:11 PM, Daniel Vetter wrote: On Wed, May 08, 2024 at 12:27:20PM +0530, Arunpravin Paneer Selvam wrote: Problem statement: During the system boot time, an application request for the bulk volume of cleared range bias memory when the clear_avail is zero, we dont fallback i

Re: Splat during driver probe

2024-05-03 Thread Paneer Selvam, Arunpravin
Hi Alex, yes, this is related to memory clearing changes. This is a known issue. I am working on a fix. Thanks, Arun. On 5/3/2024 6:46 PM, Alex Deucher wrote: Possibly related to Arun's new memory clearing changes. @Arunpravin can you take a look? Alex On Fri, May 3, 2024 at 9:10 AM Tvrtko

Re: [PATCH v3] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-25 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/24/2024 2:02 PM, Christian König wrote: Am 24.04.24 um 09:13 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-17 Thread Paneer Selvam, Arunpravin
Hi Philip, On 4/17/2024 8:58 PM, Philip Yang wrote: On 2024-04-17 10:32, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 6:57 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-17 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/17/2024 6:57 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for

Re: [PATCH v2] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-17 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/17/2024 12:19 PM, Christian König wrote: Am 17.04.24 um 08:21 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS fla

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 6:24 PM, Christian König wrote: Am 16.04.24 um 14:34 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 5:47 PM, Christian König wrote: Am 16.04.24 um 14:16 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a

Re: [PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 2:35 PM, Christian König wrote: Am 15.04.24 um 20:48 schrieb Arunpravin Paneer Selvam: We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this would leads to an abnormal behaviour in the current appli

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/16/2024 1:16 PM, Christian König wrote: Am 16.04.24 um 00:02 schrieb Philip Yang: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-15 Thread Paneer Selvam, Arunpravin
On 4/16/2024 3:32 AM, Philip Yang wrote: On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-15 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/15/2024 7:33 PM, Christian König wrote: Am 14.04.24 um 16:57 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag

Re: [PATCH v11 1/3] drm/buddy: Implement tracking clear page feature

2024-04-15 Thread Paneer Selvam, Arunpravin
Hi Christian, Could you please push these patches into drm branch. Thanks, Arun. On 4/15/2024 2:53 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

2024-04-14 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 4/10/2024 6:22 PM, Matthew Auld wrote: On 08/04/2024 16:16, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each bl

Re: [PATCH v10 1/3] drm/buddy: Implement tracking clear page feature

2024-04-08 Thread Paneer Selvam, Arunpravin
Hi Matthew, Could you please review these changes as few clients are waiting for these patches. Thanks, Arun. On 4/8/2024 8:46 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in th

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-04-01 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/28/2024 10:18 PM, Matthew Auld wrote: On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-28 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each b

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-27 Thread Paneer Selvam, Arunpravin
Hi Alex, On 3/26/2024 8:23 PM, Alex Deucher wrote: On Tue, Mar 26, 2024 at 10:01 AM Alex Deucher wrote: On Tue, Mar 26, 2024 at 9:59 AM Paneer Selvam, Arunpravin wrote: Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-26 Thread Paneer Selvam, Arunpravin
Hi Alex, On 3/26/2024 7:08 PM, Alex Deucher wrote: On Mon, Mar 18, 2024 at 5:47 PM Arunpravin Paneer Selvam wrote: Add clear page support in vram memory region. v1(Christian): - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. -

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-03-25 Thread Paneer Selvam, Arunpravin
Hi Matthew, ping? Thanks, Arun. On 3/19/2024 3:10 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Tra

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 7:17 PM, Christian König wrote: Am 19.03.24 um 12:41 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian

Re: [PATCH v9 2/3] drm/amdgpu: Enable clear page functionality

2024-03-19 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/19/2024 3:58 PM, Christian König wrote: Am 18.03.24 um 22:40 schrieb Arunpravin Paneer Selvam: Add clear page support in vram memory region. v1(Christian):    - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that.    -

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-07 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/6/2024 11:19 PM, Matthew Auld wrote: On 04/03/2024 16:32, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each bl

Re: [PATCH v8 1/3] drm/buddy: Implement tracking clear page feature

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Matthew, Ping? Thanks, Arun. On 3/4/2024 10:02 PM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Tr

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-06 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/5/2024 5:41 PM, Christian König wrote: Am 05.03.24 um 12:14 schrieb Paneer Selvam, Arunpravin: On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
On 3/5/2024 4:33 PM, Paneer Selvam, Arunpravin wrote: Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu

Re: [PATCH v8 3/3] drm/buddy: Add user for defragmentation

2024-03-05 Thread Paneer Selvam, Arunpravin
Hi Christian, On 3/4/2024 10:09 PM, Christian König wrote: Am 04.03.24 um 17:32 schrieb Arunpravin Paneer Selvam: Add amdgpu driver as user for the drm buddy defragmentation. Signed-off-by: Arunpravin Paneer Selvam ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 +++--  

Re: [PATCH v7 3/3] drm/buddy: Add defragmentation support

2024-03-04 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 2/22/2024 12:12 AM, Matthew Auld wrote: On 21/02/2024 12:18, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1:    - Defragment the memory beginning from min_order till the required memory space is available. v2(Matthew):    - add amdgpu user fo

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-21 Thread Paneer Selvam, Arunpravin
On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as clea

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-21 Thread Paneer Selvam, Arunpravin
On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks each block as clea

RE: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures

2023-03-09 Thread Paneer Selvam, Arunpravin
Mailing List ; Paneer Selvam, Arunpravin Subject: Re: [PATCH] [RFC] drm/drm_buddy fails to initialize on 32-bit architectures Hi, Ping? This is actually a regression. If there is no one available to work this, maybe I can have a look in my spare time, in accordance with your suggestion. Regards

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, If this change is possible, I think it would improve the performance by eliminating the frequent BO eviction when there is a memory pressure. Thanks, Arun. Get Outlook for Android

Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed

2022-12-07 Thread Paneer Selvam, Arunpravin
eucher ; Zhang, Jesse(Jie) Cc: Zhang, Yifan ; amd-gfx ; Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: try allowed domain when pin framebuffer failed I would go a step further and just allow GTT domain on

RE: [PATCH] drm/ttm: fix bulk move handling v2

2022-06-13 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, I verified the patch, I don’t see the crashes. Reviewed-by: Arunpravin Paneer Selvam Thanks, Arun -Original Message- From: Christian König Sent: Monday, June 13, 2022 1:38 PM To: Paneer Selvam, Arunpravin ; m...@fireburn.co.uk; amd

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-28 Thread Paneer Selvam, Arunpravin
: Monday, May 16, 2022 8:36 PM To: Mike Lothian Cc: Paneer Selvam, Arunpravin ; Intel Graphics Development ; amd-gfx list ; Maling list - DRI developers ; Deucher, Alexander ; Koenig, Christian ; Matthew Auld Subject: Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu On Mon, May 16, 2022

RE: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-26 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only - General] Hi Christian, I will check this issue. Regards, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, April 26, 2022 10:06 PM To: Mike Lothian ; Paneer Selvam, Arunpravin Cc: intel-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org

RE: [drm/selftests] 39ec47bbfd: kernel_BUG_at_drivers/gpu/drm/drm_buddy.c

2022-02-28 Thread Paneer Selvam, Arunpravin
[AMD Official Use Only] Hi Christian, I will check Thanks, Arun -Original Message- From: Koenig, Christian Sent: Monday, February 28, 2022 4:29 PM To: kernel test robot ; Paneer Selvam, Arunpravin Cc: 0day robot ; Matthew Auld ; LKML ; l...@lists.01.org; dri-de

RE: [PATCH v9 1/6] drm: move the buddy allocator from i915 into common drm

2022-01-20 Thread Paneer Selvam, Arunpravin
k and forth. Let me know when there are more rbs on the rest and I will push that as well. Thanks, Christian. -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, January 19, 2022 12:54 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org;

RE: [PATCH v4 4/6] drm: implement a method to free unused pages

2021-12-09 Thread Paneer Selvam, Arunpravin
[Public] Hi Matthew, Ping? Regards, Arun -Original Message- From: Paneer Selvam, Arunpravin Sent: Wednesday, December 1, 2021 10:10 PM To: dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org Cc: matthew.a...@intel.com; dan...@ffwll.ch

RE: [PATCH v4 2/6] drm: improve drm_buddy_alloc function

2021-12-09 Thread Paneer Selvam, Arunpravin
; Paneer Selvam, Arunpravin ; jani.nik...@linux.intel.com; matthew.a...@intel.com; tzimmerm...@suse.de; Deucher, Alexander ; Koenig, Christian Subject: [PATCH v4 2/6] drm: improve drm_buddy_alloc function - Make drm_buddy_alloc a single function to handle range allocation and non-range

RE: [PATCH 1/2] Enable buddy memory manager support

2021-09-22 Thread Paneer Selvam, Arunpravin
ch public function Thanks, Arun -Original Message- From: Koenig, Christian Sent: Wednesday, September 22, 2021 12:28 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; matthew.a...@intel.com; dan...

RE: [PATCH 1/2] Enable buddy memory manager support

2021-09-22 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Alex, I will fix the name and send a document in my next version. Thanks, Arun -Original Message- From: Alex Deucher Sent: Tuesday, September 21, 2021 12:54 AM To: Paneer Selvam, Arunpravin Cc: Maling list - DRI developers ; Intel Graphics Development ; amd-gfx

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-22 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Christian, Thanks for the review, I will the send the next version fixing all issues. Regards, Arun -Original Message- From: Christian König Sent: Wednesday, September 22, 2021 12:18 PM To: Paneer Selvam, Arunpravin ; Koenig, Christian ; dri-de

RE: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-21 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Christian, Please find my comments. Thanks, Arun -Original Message- From: Koenig, Christian Sent: Tuesday, September 21, 2021 2:34 PM To: Paneer Selvam, Arunpravin ; dri-de...@lists.freedesktop.org; intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org

RE: [PATCH 1/8] drm/amdgpu: new resource cursor

2021-03-12 Thread Paneer Selvam, Arunpravin
[AMD Public Use] Hi Christian, Reviewed the changes, it looks good to me. Reviewed-by: Arunpravin Thanks, Arun -Original Message- From: Christian König Sent: Friday, March 12, 2021 4:22 PM To: Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm

RE: [PATCH] drm/amd/pm/swsmu: clean up user profile function

2021-03-01 Thread Paneer Selvam, Arunpravin
[AMD Public Use] -Original Message- From: Quan, Evan Sent: Tuesday, March 2, 2021 6:54 AM To: Paneer Selvam, Arunpravin ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Paneer Selvam, Arunpravin Subject: RE: [PATCH] drm/amd/pm/swsmu: clean up user profile