RE: [PATCH] drm/amdgpu: fix retry loop test

2023-09-06 Thread Quan, Evan
[AMD Official Use Only - General] Yeah, nice catch. But personally I would prefer to change the check as "if (retry <= 0)". Either way, the patch is reviewed-by: Evan Quan Evan > -Original Message- > From: Dan Carpenter > Sent: Wednesday, September 6, 2023 6:

RE: [V3 0/7] A new set of Linux OD interfaces

2023-09-03 Thread Quan, Evan
pport 'r' option per attribute, some redesigns to current logics will be needed to support both legacy and the new OD interfaces. That will need some extra efforts. Maybe we can put that on our TODO list? Evan > -Original Message- > From: Alex Deucher > Sent: Friday, Sep

RE: [PATCH v3] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-31 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Yifan > Sent: Thursday, August 31, 2023 2:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Ma, Li ; Zhang, > Yifan > Subject: [PATCH v3] drm/amd/pm: only poweron/off vcn/jpeg when the

RE: [PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they are valid.

2023-08-30 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Yifan > Sent: Thursday, August 31, 2023 2:10 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Ma, Li ; Zhang, > Yifan > Subject: [PATCH] drm/amd/pm: only poweron/off vcn/jpeg when they ar

RE: [V10 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Sunday, August 27, 2023 11:43 PM > To: Quan, Evan > Cc: l...@kernel.org; johan...@sipsolutions.net; da...@davemloft.net; > eduma...@google.com; k...@kernel.org; pab...@redhat.com; De

RE: [V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 25, 2023 10:13 PM > To: Quan, Evan ; l...@kernel.org; > johan...@sipsolutions.net; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; Deucher,

RE: [V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 25, 2023 10:09 PM > To: Quan, Evan ; l...@kernel.org; > johan...@sipsolutions.net; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; Deucher,

RE: [V9 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-25 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, August 18, 2023 5:12 PM > To: Quan, Evan ; gre...@linuxfoundation.org; > raf...@kernel.org; l...@kernel.org; johan...@sipsolutions.net; > da...@davemloft.net; eduma...@google.co

RE: [V9 4/9] wifi: mac80211: Add support for WBRF features

2023-08-25 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Johannes Berg > Sent: Monday, August 21, 2023 5:44 PM > To: Quan, Evan ; gre...@linuxfoundation.org; > raf...@kernel.org; l...@kernel.org; da...@davemloft.net; > eduma...@google.com; k...@kernel.org;

RE: [PATCH] drm/amd/pm: workaround for the wrong ac power detection on smu 13.0.0

2023-08-24 Thread Quan, Evan
[AMD Official Use Only - General] As discussed offline, better to document something like "this is a temporary solution and will be dropped in the future". Either way, the patch is reviewed-by: Evan Quan Evan > -Original Message- > From: Kenneth Feng > Sent: Friday,

RE: [V2 3/8] drm/amd/pm: add fan mode OD setting support for SMU13

2023-08-24 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Thursday, August 24, 2023 10:51 PM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [V2 3/8] drm/amd/pm: add fan mode OD setting support f

RE: [V2 3/8] drm/amd/pm: add fan mode OD setting support for SMU13

2023-08-23 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Wednesday, August 23, 2023 9:29 PM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [V2 3/8] drm/amd/pm: add fan mode OD setting support f

RE: [PATCH 0/8] A new set of Linux OD interfaces

2023-08-20 Thread Quan, Evan
[AMD Official Use Only - General] Ping.. > -Original Message- > From: Quan, Evan > Sent: Tuesday, August 15, 2023 4:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH 0/8] A new set of Linux OD interfaces > >

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Quan, Evan
Andrew Lunn > Sent: Wednesday, July 26, 2023 4:10 AM > To: Limonciello, Mario > Cc: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolutions.net; > da...@davemloft.

RE: [PATCH V8 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Jeff Johnson > Sent: Thursday, August 10, 2023 10:06 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V8 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Randy Dunlap > Sent: Thursday, August 10, 2023 11:41 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V8 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:35 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V8 2/9] drivers core: add ACPI based WBRF mechanism introduced by AMD

2023-08-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, August 11, 2023 5:38 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH] fix throttle_status for other than MP0 11.0.7

2023-08-08 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Umio Yasuno > Sent: Tuesday, August 8, 2023 2:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > ; Limonciello, Mario > Subject: [PATCH] fix thro

RE: [PATCH -next] drm/amd/pm: Remove many unnecessary NULL values

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Ruan Jinjie > Sent: Tuesday, August 1, 2023 8:55 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; mrip...@k

RE: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Ran > Sun > Sent: Tuesday, August 1, 2023 4:03 PM > To: Deucher, Alexander ; airl...@gmail.com; > dan...@ffwll.ch > Cc: Ran Sun ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.f

RE: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

2023-08-01 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Ran > Sun > Sent: Tuesday, August 1, 2023 10:39 AM > To: Deucher, Alexander ; airl...@gmail.com; > dan...@ffwll.ch > Cc: Ran Sun ; dri-de...@lists.freedesktop.org; > amd-gfx@lists.

RE: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran

2023-07-27 Thread Quan, Evan
Darren Sent: Friday, July 28, 2023 3:51 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Quan, Evan ; Yu, Lang ; Huang, Ray Subject: Re: [PATCH 0/8] amdgpu/pm: Implement emit_clock_levels for arcturus,aldebaran Hi all, Just looking for anyone who could RB or ACK this patch set so I can

RE: [PATCH] drm/amd/pm: correct the pcie width for smu 13.0.0

2023-07-27 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Kenneth Feng > Sent: Thursday, July 27, 2023 7:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Feng, Kenneth > > Subject: [PATCH] drm/amd/pm: correct the pcie

RE: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-25 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, July 24, 2023 9:41 PM > To: Andrew Lunn ; Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; >

RE: [PATCH V7 0/9] Enable Wifi RFI interference mitigation feature support

2023-07-23 Thread Quan, Evan
[AMD Official Use Only - General] Gentle ping on this series. Hi Rafael and Andrew, Can you help to check this latest series and share your thoughts if any? BR, Evan > -Original Message- > From: Quan, Evan > Sent: Wednesday, July 19, 2023 5:00 PM > To: raf...@k

RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Tuesday, July 18, 2023 10:16 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Quan, Evan
implementation. But I can make this AMD ACPI specific and bring a more generic version here. Evan > -Original Message- > From: Andrew Lunn > Sent: Thursday, July 13, 2023 7:12 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, C

RE: [PATCH v2] drm/amd/pm: Vangogh: Add new gpu_metrics_v2_4 to acquire gpu_metrics

2023-07-17 Thread Quan, Evan
r, Alexander > ; Limonciello, Mario > ; Koenig, Christian > ; Pan, Xinhui ; Quan, > Evan > Cc: Yuan, Perry ; Liang, Richard qi > ; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; linux-ker...@vger.kernel.org > Subject: RE: [PATCH v2] drm/amd/pm: Vangogh: A

RE: [PATCH 4/4] drm/amd: Drop amdgpu_device_aspm_support_quirk()

2023-07-09 Thread Quan, Evan
o, Mario > Sent: Saturday, July 8, 2023 10:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Limonciello, Mario > > Subject: [PATCH 4/4] drm/amd: Drop amdgpu_device_aspm_support_quirk() > > NV and VI currently set up a quirk to not enable ASPM on Alder Lake > systems, b

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-05 Thread Quan, Evan
subsystems can do necessary wbrf support check in advance and coordinate their actions accordingly. Please let us know your thoughts. BR, Evan > -Original Message- > From: Andrew Lunn > Sent: Tuesday, July 4, 2023 9:07 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kerne

RE: [RFC 1/2] drm/amd: Extend Intel ASPM quirk to all dGPUs

2023-07-05 Thread Quan, Evan
[AMD Official Use Only - General] One small nitpick: It seems there is missing a default clause for the switch statement. Will that hit the compile warning about "a switch statement must have a default clause"? With that checked, the series is reviewed-by: Evan Quan Evan >

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Simon Horman > Sent: Friday, June 30, 2023 9:39 PM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Saturday, July 1, 2023 12:41 AM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; d

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:20 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:25 AM > To: Limonciello, Mario > Cc: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; >

RE: [PATCH V5 2/9] driver core: add ACPI based WBRF mechanism introduced by AMD

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 8:51 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V5 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-07-03 Thread Quan, Evan
[AMD Official Use Only - General] Hi Andrew, > -Original Message- > From: Andrew Lunn > Sent: Saturday, July 1, 2023 9:02 AM > To: Quan, Evan > Cc: raf...@kernel.org; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com

RE: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-30 Thread Quan, Evan
June 24, 2023 1:16 AM > To: Limonciello, Mario > Cc: Rafael J. Wysocki ; Quan, Evan > ; l...@kernel.org; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; johan...@sipsolutions.net; > da...@davemloft.net; eduma...@google.com; k.

RE: [PATCH 2/2] drm/amd/pm: avoid unintentional shutdown due to temperature momentary fluctuation

2023-06-26 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, June 26, 2023 7:54 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amd/pm: avoid unintentional shutdown due to >

RE: [PATCH V3 1/7] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:04 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.o

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Limonciello, Mario > Sent: Monday, June 19, 2023 10:17 AM > To: Quan, Evan > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-de...@lists.freedesktop.o

RE: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Johannes Berg > Sent: Monday, June 19, 2023 4:24 PM > To: Limonciello, Mario ; Quan, Evan > > Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; amd- > g...@lists.freedesktop.org; dri-de...@

RE: [PATCH] drm/amd/pm: add abnormal fan detection for smu 13.0.0

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Kenneth Feng > Sent: Tuesday, June 20, 2023 11:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Feng, Kenneth > Subject: [PATCH] drm/amd/pm: add abnormal fan detection for smu 13

RE: [PATCH V3 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-20 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, June 19, 2023 10:55 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch

RE: [PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-12 Thread Quan, Evan
[AMD Official Use Only - General] Thanks Johannes. Comment in-line > -Original Message- > From: Johannes Berg > Sent: Friday, June 9, 2023 4:21 PM > To: Quan, Evan ; raf...@kernel.org; l...@kernel.org; > Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; > a

RE: [PATCH v2] drm/amdgpu: Fix memcpy() in sienna_cichlid_append_powerplay_table function.

2023-06-11 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Friday, June 9, 2023 4:45 PM > To: Deucher, Alexander ; Koenig, Christian > ; Quan, Evan ; Gui, Jack > > Cc: amd-gfx@lists.freedesktop.org;

RE: [PATCH] drm/amd/pm: Fix memory some memory corruption

2023-06-06 Thread Quan, Evan
[AMD Official Use Only - General] Thanks for catching this. Reviewed-by: Evan Quan > -Original Message- > From: Dan Carpenter > Sent: Tuesday, June 6, 2023 4:34 PM > To: Quan, Evan > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ;

RE: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for some sienna_cichlid SKUs

2023-05-31 Thread Quan, Evan
[AMD Official Use Only - General] Hi Alex, Can we land this as a temporary solution while we are seeking a more proper one? This is gating our customer and I was pushed for a solution. BR, Evan > -Original Message- > From: Quan, Evan > Sent: Friday, April 21, 2023 3:32 PM >

RE: [PATCH] drm/amd/pm: add missing NotifyPowerSource message mapping for SMU13.0.7

2023-05-21 Thread Quan, Evan
[Public] > -Original Message- > From: Chen, Guchun > Sent: Friday, May 19, 2023 8:04 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: RE: [PATCH] drm/amd/pm: add missing NotifyPowerSource message > mapping f

RE: [PATCH v4] drm/amd: Flush any delayed gfxoff on suspend entry

2023-05-18 Thread Quan, Evan
[AMD Official Use Only - General] If I understand correctly, similar job is already performed in "amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);" Maybe you just need to undo the "skip PG for GFX on S0ix"? /* skip PG for GFX, SDMA on S0ix */ if (adev->in_s0

RE: [PATCH] drm/amd/pm: Fix output of pp_od_clk_voltage

2023-05-18 Thread Quan, Evan
[AMD Official Use Only - General] Sorry for missing this. The patch seems fine to me. Reviewed-by: Evan Quan Evan > -Original Message- > From: Jonatas Esteves > Sent: Tuesday, November 15, 2022 10:33 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Subject: RE: [PA

RE: [PATCH] drm/amd/pm: avoid potential UBSAN issue on legacy asics

2023-05-08 Thread Quan, Evan
[AMD Official Use Only - General] Acked-by: Evan Quan > -Original Message- > From: Chen, Guchun > Sent: Tuesday, May 9, 2023 9:43 AM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking > ; Lazar, Lijo ; Quan, Evan > > Cc: Chen, Guchun &g

RE: [PATCH] drm/amd/pm: parse pp_handle under appropriate conditions

2023-05-05 Thread Quan, Evan
Deucher, Alexander > ; Zhang, Hawking > ; Lazar, Lijo ; Quan, Evan > ; Koenig, Christian ; > Pan, Xinhui > Cc: Chen, Guchun > Subject: [PATCH] drm/amd/pm: parse pp_handle under appropriate > conditions > > amdgpu_dpm_is_overdrive_supported is a common API across all >

RE: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for some sienna_cichlid SKUs

2023-04-24 Thread Quan, Evan
[Public] > -Original Message- > From: Limonciello, Mario > Sent: Friday, April 21, 2023 9:40 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: RE: [PATCH] drm/amd/pm: conditionally disable pcie lane switching > for som

RE: [PATCH] drm/amd/pm: conditionally disable pcie lane switching for some sienna_cichlid SKUs

2023-04-21 Thread Quan, Evan
[AMD Official Use Only - General] This seems able to address some audio noise issue observed per customer's feedback. Evan > -Original Message- > From: Quan, Evan > Sent: Friday, April 21, 2023 3:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander

RE: drm/amdgpu/gfx9: switch to golden tsc registers for raven/raven2

2023-04-12 Thread Quan, Evan
[AMD Official Use Only - General] Better to update the patch title with prefix as "drm/amdgpu:" instead of "drm/amdgpu/gfx9:". Either way, the patch is Reviewed-by: Evan Quan Evan From: Zhang, Jesse(Jie) Sent: Wednesday, April 12, 2023 9:24 AM To: amd-gfx@lists.free

RE: drm/amdgpu/gfx9: change the reference clock for raven/raven2

2023-04-12 Thread Quan, Evan
[AMD Official Use Only - General] Better to update the patch title with prefix as "drm/amdgpu:" instead of "drm/amdgpu/gfx9:". Either way, the patch is Reviewed-by: Evan Quan Evan From: Zhang, Jesse(Jie) Sent: Wednesday, April 12, 2023 9:25 AM To: amd-gfx@lists.free

RE: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-09 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Tom Rix > Sent: Saturday, April 1, 2023 12:41 AM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; nat...@ke

RE: [PATCH 3/3] drm/amdgpu: enable sysfs node vclk1 and dclk1 for NV3X

2023-03-29 Thread Quan, Evan
[AMD Official Use Only - General] Please update the patch headers for the series with the prefix "drm/amd/pm" to align with other power changes. With that fixed, the series is reviewed-by: Evan Quan Evan > -Original Message- > From: Tong Liu01 > Sent: Thursday, Marc

RE: [PATCH 1/3] drm/amdgpu: add sysfs node vclk1 and dclk1

2023-03-29 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Tong Liu01 > Sent: Wednesday, March 29, 2023 6:51 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Chen, Horace > ; Tuikov, Luben ; > Koenig, Christian ; Deucher, Alexander > ; Xiao, Jack

RE: [PATCH] drm/amdgpu: enable sysfs node pp_dpm_vclk1 for some asics

2023-03-28 Thread Quan, Evan
8, 2023 7:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Chen, Horace > ; Tuikov, Luben ; > Koenig, Christian ; Deucher, Alexander > ; Xiao, Jack ; Zhang, > Hawking ; Liu, Monk ; Xu, > Feifei ; Wang, Yang(Kevin) > ; Liu01, Tong (Esther) > Subject: [

RE: [PATCH] drm/amd/pm: re-enable the gfx imu when smu resume

2023-03-24 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Tim > Huang > Sent: Friday, March 24, 2023 3:08 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Zhang, Yifan > ; Ma, Li ; Du, Xiaojian > ; Huang, Tim > Subject: [PATCH] drm/amd/pm: re-

RE: [Resend PATCH v1 3/3] drm/amd/pm: vangogh: support to send SMT enable message

2023-03-23 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Wenyou Yang > Sent: Wednesday, March 22, 2023 5:16 PM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui > Cc: Yuan, Perry ; Li, Ying ; amd- > g...@lists.freedesktop.org; Yang, WenYou ; Liu,

RE: [Resend PATCH v1 2/3] drm/amd/pm: send the SMT-enable message to pmfw

2023-03-23 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Wenyou Yang > Sent: Wednesday, March 22, 2023 5:16 PM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui > Cc: Yuan, Perry ; Li, Ying ; amd- > g...@lists.freedesktop.org; Yang, WenYou ; Liu,

RE: [PATCH] drm/amdgpu: improve debug VRAM access performance using sdma

2023-03-20 Thread Quan, Evan
[AMD Official Use Only - General] OK, I see. Thanks for the explanations. BR Evan > -Original Message- > From: Koenig, Christian > Sent: Tuesday, March 21, 2023 1:32 AM > To: Kim, Jonathan ; Christian König > ; Quan, Evan ; > amd-gfx@lists.freedesktop.org >

RE: [PATCH 19/19] drm/amdgpu/smu11: enable TEMP_DEPENDENT_VMIN for navi1x

2023-03-20 Thread Quan, Evan
[AMD Official Use Only - General] Better to update the subject with prefix as "drm/amd/pm" to align with other power changes. Either way the patch is Reviewed-by: Evan Quan BR Evan > -Original Message- > From: amd-gfx On Behalf Of > Qingqing Zhuo > Sent: Saturday, March 18, 2023 3:56 P

RE: [PATCH] drm/amdgpu: improve debug VRAM access performance using sdma

2023-03-20 Thread Quan, Evan
[AMD Official Use Only - General] I happened to find the sdma_access_bo allocation from GTT seems performing before gart is ready. That makes the "amdgpu_gart_map" is skipped since adev->gart.ptr is still NULL. Is that done intentionally ? Evan > -Original Message- > From: amd-gfx On Be

RE: [PATCH v2] drm/amdgpu: resove reboot exception for si oland

2023-03-14 Thread Quan, Evan
[AMD Official Use Only - General] I'm OK with the drop of si_set_temperature_range() in late_init. Meanwhile, it's still not clear to me how this could lead reboot exception. Can you dig this a little bit further? For example, can you check whether the operation(si_thermal_start_thermal_controlle

RE: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Quan, Evan
[AMD Official Use Only - General] Series is acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Guchun Chen > Sent: Friday, March 10, 2023 9:02 AM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > Deucher, Alexander ; Zhang, Hawking > ; dmitry.b

RE: [PATCH 2/2] drm/amd/pm: Fix navi10 incorrect OD volage after resume

2023-03-08 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Deucher, Alexander > Sent: Wednesday, March 8, 2023 11:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Błażej Szczygieł > ; Quan, Evan > Subject: [PATCH 2/2] drm/amd/pm: Fix navi1

RE: [PATCH v2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-07 Thread Quan, Evan
Szczygieł, If you can add some descriptions about the BTC and GfxVfCurve related in the patch header/description part, it will be better. Anyway, the patch is Reviewed-by: Evan Quan BR Evan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, Ma

RE: [PATCH v2] drm/amd/pm: Fix sienna cichlid incorrect OD volage after resume

2023-03-07 Thread Quan, Evan
[AMD Official Use Only - General] Can you share more background about this? I cannot see how this can address incorrect OD voltage issue. BR Evan > -Original Message- > From: amd-gfx On Behalf Of > Blazej Szczygiel > Sent: Sunday, March 5, 2023 7:45 AM > To: amd-gfx@lists.freedesktop.or

RE: [PATCH 1/2] drm/amdgpu: fix error checking in amdgpu_read_mm_registers for soc15

2023-03-07 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Monday, March 6, 2023 11:54 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 1/2] drm/amdgpu: fix error checking in > amdgp

RE: [PATCH] drm/amdkfd: fix warning in SVM debug statement

2023-03-06 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, March 7, 2023 6:43 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdkfd: fix warning in SVM debug statemen

RE: [PATCH 0/3] enable new capped/uncapped power profiles

2023-03-05 Thread Quan, Evan
[AMD Official Use Only - General] Series is reviewed-by: Evan Quan > -Original Message- > From: Yuan, Perry > Sent: Friday, February 24, 2023 4:33 PM > To: Deucher, Alexander ; Quan, Evan > ; Lazar, Lijo ; Li, Candice > ; amd-gfx@lists.freedesktop.org > Cc: Huan

RE: [PATCH] drm/amdgpu: disable cstate properly for driver reloading scenario

2023-03-02 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, March 2, 2023 5:21 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: disable cstate properly for driver &g

RE: [PATCH] gpu: amd/pm: mark symbols static where possible for smu11

2023-03-02 Thread Quan, Evan
[AMD Official Use Only - General] Thanks. But I think there was already a patch from Kun Liu to address this issue. https://lists.freedesktop.org/archives/amd-gfx/2023-March/090029.html BR Evan > -Original Message- > From: Jeff Pang > Sent: Thursday, March 2, 2023 5:16 PM &

RE: [PATCH] drm/amdgpu: disable cstate properly for driver reloading scenario

2023-03-02 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, March 2, 2023 4:28 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: disable cstate properly for driver &g

RE: [PATCH] drm/amdgpu: fix no previous prototype warning

2023-02-28 Thread Quan, Evan
0ybgt-...@intel.com/"; BR Evan > -Original Message- > From: Kun Liu > Sent: Wednesday, March 1, 2023 10:42 AM > To: amd-gfx@lists.freedesktop.org; Quan, Evan > Cc: Liang, Richard qi ; Deucher, Alexander > ; Liu, Kun > Subject: [PATCH] drm/amdgpu: fix no previous pr

RE: [PATCH v2 3/3] drm/amd: Add special handling for system s0ix state w/ dGPUs

2023-02-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 28, 2023 12:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH v2 3/3] drm/amd: Add special handling for s

RE: [PATCH v2 0/3] Adjust dGPU handling for BACO

2023-02-27 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 28, 2023 12:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH v2 0/3] Adjust dGPU handling for BACO > >

RE: [PATCH 1/3] drm/amd: Allow dGPUs that support BACO to use smart suspend

2023-02-21 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 21, 2023 4:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH 1/3] drm/amd: Allow dGPUs that support BACO

RE: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs in all sleep modes

2023-02-21 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Mario Limonciello > Sent: Tuesday, February 21, 2023 4:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Peter Kopec ; Limonciello, Mario > > Subject: [PATCH 3/3] drm/amd: Don't always set s3 for dGPUs

RE: [PATCH 1/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: kunliu13 > Sent: Tuesday, February 14, 2023 3:54 PM > To: Limonciello, Mario ; Liang, Richard qi > ; Yuan, Perry ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander ; Du, Xiaojian >

RE: [PATCH 2/2] drm/amdgpu: added a sysfs interface for thermal throttling

2023-02-14 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: kunliu13 > Sent: Tuesday, February 14, 2023 4:03 PM > To: Limonciello, Mario ; Liang, Richard qi > ; Yuan, Perry ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander ; Du, Xiaojian >

RE: [PATCH] drm/amd/amdgpu: fix warining during suspend

2023-02-13 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-and-tested-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Jack > Xiao > Sent: Monday, February 13, 2023 6:52 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xiao, Jack ; jfale...@redhat.com > Subject: [PATCH] drm/amd/amdgpu: fix w

RE: [PATCH] drm/amd/amdgpu: implement mode2 reset on smu_v13_0_10

2023-02-09 Thread Quan, Evan
gpu_dpm_baco_reset(struct amdgpu_device *adev); > > int amdgpu_dpm_mode2_reset(struct amdgpu_device *adev); > +int amdgpu_dpm_enable_gfx_features(struct amdgpu_device *adev); > > bool amdgpu_dpm_is_baco_supported(struct amdgpu_device *adev); > bool amdgpu_dpm_is_maco_supported(s

RE: [PATCH] drm/amdgpu: only WARN freeing buffers when DMA is unavailable

2023-02-09 Thread Quan, Evan
[AMD Official Use Only - General] Hi Jack, Are you trying to fix the call trace popped up on resuming below? It seems mes created some bo for its self test and freed it up later at the final stage of the resuming process. All these happened before the in_suspend flag cleared. And that triggered

RE: gpu_metrics does not provide 'current_gfxclk', 'current_uclk', 'average_cpu_power' & 'temperature_core' on AMD Ryzen 7000 CPU

2023-02-09 Thread Quan, Evan
[AMD Official Use Only - General] For some members, "0" is a valid value. Thus "0x" is used instead to tell the output is invalid/unsupported. BR Evan > -Original Message- > From: amd-gfx On Behalf Of > sfrcorne > Sent: Wednesday, February 8, 2023 7:12 AM > To: Alex Deucher > Cc: a

RE: [PATCH] drm/amdgpu/gmc11: disable AGP aperture again

2023-02-08 Thread Quan, Evan
[AMD Official Use Only - General] Settings for gfxhub_v3_0_3.c seem missing. Evan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, February 9, 2023 12:25 PM > To: Zhang, Hawking > Cc: Deucher, Alexander ; amd- > g...@lists.freedesktop.org > Subject: Re:

RE: [PATCH] drm/amd/pm/smu7: move variables to where they are used

2023-02-06 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, February 7, 2023 1:05 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > > Subject: [PATCH] drm/amd/pm/smu7: mo

RE: [PATCH 2/2] drm/amdgpu/pm: update hwmon power documentation

2023-01-15 Thread Quan, Evan
[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, January 13, 2023 12:25 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/2] drm/amdgpu/pm: update hwmon power > do

RE: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks addition

2023-01-15 Thread Quan, Evan
[AMD Official Use Only - General] Series is reviewed-by: Evan Quan > -Original Message- > From: Deepak R Varma > Sent: Sunday, January 15, 2023 3:16 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Dan

RE: [PATCH 8/8] drm/amd/pm: drop the support for manual fan speed setting on SMU13.0.7

2023-01-11 Thread Quan, Evan
speed limit. That should be not affected by the SCPM and relevant. BR Evan > -Original Message- > From: Matt Coffin > Sent: Tuesday, January 10, 2023 9:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Quan, Evan ; Lazar, Lijo > Subject: Re: [PATCH 8/8] drm/amd/pm: drop the

RE: [PATCH 8/8] drm/amd/pm: drop the support for manual fan speed setting on SMU13.0.7

2023-01-09 Thread Quan, Evan
[AMD Official Use Only - General] Anyone else can help to review this patch series? We need these to address the fan speed setting failure reported for the new SMU13 asics. @Deucher, Alexander ? Evan > -Original Message- > From: Quan, Evan > Sent: Thursday, January 5, 2023

RE: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs interfaces support

2023-01-09 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, January 9, 2023 6:52 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs in

RE: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs interfaces support

2023-01-09 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, January 9, 2023 11:28 AM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs in

RE: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs interfaces support

2023-01-08 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 6, 2023 6:01 PM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs in

RE: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs interfaces support

2023-01-06 Thread Quan, Evan
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Friday, January 6, 2023 11:55 AM > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/8] drm/amd/pm: refine the checks for sysfs in

  1   2   3   4   5   6   7   8   9   10   >