RE: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Russell, Kent
[Public] My mistake. > -Original Message- > From: amd-gfx On Behalf Of Russell, > Kent > Sent: Friday, October 4, 2024 9:53 AM > To: Chen, Xiaogang ; Kuehling, Felix > ; amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: RE: [PATCH v2] drm/amdkfd: not r

RE: [PATCH v2] drm/amdkfd: not restore userptr buffer if kfd process has been removed

2024-10-04 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Chen, > Xiaogang > Sent: Thursday, October 3, 2024 6:11 PM > To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org > Cc: Yang, Philip > Subject: Re: [PATCH v2] drm/amdkfd: not restore

RE: [PATCH] drm/amdgpu: Retry i2c transfer once if it fails on SMU13.0.6

2024-09-11 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Fixed the typo locally. > -Original Message- > From: Russell, Kent > Sent: Wednesday, September 11, 2024 2:06 PM > To: amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: [PATCH] drm/amdgpu: Retry i2c t

RE: [PATCH] drm/amdgpu: fix spelling in amd_shared.h

2024-09-10 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Tuesday, September 10, 2024 10:50 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu:

RE: [PATCH 2/2] drm/amdgpu: Retry i2c transfer once if it fails

2024-09-10 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Sounds good, thanks for the input Lijo! I'll get that tested and verify that it works too. Kent > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, September 10, 2024 10:06 AM > To: Russel

RE: [PATCH] drm/amdkfd: Fix resource leak in riu rsetore queue

2024-09-09 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Should also probably fix rsetore -> restore as well Kent > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Monday, September 9, 2024 1:56 PM > To: Zhang, Jesse(Jie) > Cc: amd-gfx@lists.freedesktop.org; D

RE: [PATCH] drm/amdgpu: Add missing locking for MES API calls

2024-06-06 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Perfect, thanks for explaining. It's fine then Reviewed-by: Kent Russell > -Original Message- > From: Joshi, Mukul > Sent: Thursday, June 6, 2024 1:11 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.o

RE: [PATCH] drm/amdgpu: Add missing locking for MES API calls

2024-06-06 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Mukul > Joshi > Sent: Thursday, June 6, 2024 12:51 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Deucher, Alexander > ; Joshi, Mukul > Subject: [PATCH] drm/amdgpu:

RE: [PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-15 Thread Russell, Kent
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Sreekant > Somasekharan > Sent: Tuesday, May 14, 2024 8:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Somasekharan, Sreekant > ; Dan

RE: [PATCH 1/2] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-10 Thread Russell, Kent
[AMD Official Use Only - General] Never mind, we're good. This one is Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Russell, > Kent > Sent: Friday, May 10, 2024 9:16 AM > To: Somasekharan, Sreekant ; amd- > g...@lists.freedes

RE: [PATCH 1/2] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-10 Thread Russell, Kent
[AMD Official Use Only - General] Do we need to check whether bo is NULL in line 500 first? Or can it never be NULL? Kent > -Original Message- > From: amd-gfx On Behalf Of Sreekant > Somasekharan > Sent: Friday, May 10, 2024 12:56 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling,

RE: [PATCH 2/2] drm/amdkfd: Minor corrections to a previous commit

2024-05-10 Thread Russell, Kent
[AMD Official Use Only - General] You should add a Fixes tag for this patch. Kent > -Original Message- > From: amd-gfx On Behalf Of Sreekant > Somasekharan > Sent: Friday, May 10, 2024 12:56 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Somasekharan, Sreekant > > Subj

RE: [PATCH] drm/amdkfd: demote unsupported device messages to dev_info

2024-04-19 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, April 19, 2024 10:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdkfd: demote unsupported device m

RE: Re:Re: Re:RE: Why has to offer "/dev/drv/render128" fd when running ROCm demo?

2024-03-11 Thread Russell, Kent
[AMD Official Use Only - General] That flow was removed back in 5.13 timeframe, with this patch: commit f45e6b9d03ff767ff946b6fce7ed3b004ab43ba4 Author: Felix Kuehling felix.kuehl...@amd.com Date: Wed Apr 7 17:30:05 2021 -0400 drm/amdkfd: Remove legacy code n

RE: [PATCH] drm/amdkfd: Don't divide L2 cache by partition mode

2024-02-06 Thread Russell, Kent
[AMD Official Use Only - General] Oh excellent, it didn't get merged in yet. Time to squash! Kent > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, February 6, 2024 4:29 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul > S

RE: [PATCH] drm/amdgpu: Remove unnecessary NULL check

2024-01-16 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Monday, January 15, 2024 5:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Dan Carpenter > Subject: [PATCH] drm/amdgpu: Remove unnecessary NULL check

RE: [PATCH] drm/amdkfd: Align unique_id format to match amdgpu

2023-09-14 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: Kuehling, Felix > Sent: Thursday, September 14, 2023 1:25 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: Align unique_id format to match amdgpu > > > O

RE: [PATCH] drm/amdgpu: Handle null atom context in VBIOS info ioctl

2023-09-05 Thread Russell, Kent
soon anyways, we may as well start using memset now and in all future patches. Kent From: Francis, David Sent: Tuesday, September 5, 2023 11:38 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Handle null atom context in VBIOS info ioctl [AMD Official Use

RE: [PATCH] drm/amdgpu: Report Missing MES Firmware Versions with Sysfs

2023-07-28 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Ori > Messinger > Sent: Friday, July 28, 2023 12:00 PM > To: amd-gfx@lists.freedesktop.org > Cc: Messinger, Ori > Subject: [PATCH] drm/amdgpu: Report Missing MES Firmware Versions with Sysfs > > Added mis

RE: [PATCH] drm/amdgpu: Fix ENOSYS means 'invalid syscall nr' in amdgpu_device.c

2023-07-25 Thread Russell, Kent
[Public] Honestly, just updating the commit message to reflect the one {} change and the S_IRUGO change should be sufficient. Kent > -Original Message- > From: amd-gfx On Behalf Of Russell, > Kent > Sent: Tuesday, July 25, 2023 9:44 AM > To: Chen, Guchun ; SHANMU

RE: [PATCH] drm/amdgpu: Fix ENOSYS means 'invalid syscall nr' in amdgpu_device.c

2023-07-25 Thread Russell, Kent
[Public] The S_IRUGO stuff be split from the ENOSYS stuff, since they're separate. Also the S_IRUGO stuff isn't mentioned in the commit message. Kent > -Original Message- > From: amd-gfx On Behalf Of Chen, > Guchun > Sent: Tuesday, July 25, 2023 1:06 AM > To: SHANMUGAM, SRINIVASAN ; >

RE: [PATCH] drm/amdgpu: Increase hmm range get pages timeout

2023-06-06 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Philip > Yang > Sent: Tuesday, June 6, 2023 3:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Philip ; Kuehling, Felix > > Subject: [PATCH] drm/amdgpu: Increase hmm range get pages timeout > > If hm

RE: [PATCH v2] drm/amd/display: enable more strict compile checks

2023-05-24 Thread Russell, Kent
[AMD Official Use Only - General] (Adding Felix in CC) I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent From: amd-gfx On Behalf Of Ho, Kenny Sent: Wednesday, May 24, 2023 3:23 PM To: Alex Deucher ; Mahfooz, Hamza Cc: Li, Sun peng (Leo) ; Wentland, Harry ; P

RE: [PATCH v2] drm/amd/amdgpu: Fix trivial style errors

2023-04-05 Thread Russell, Kent
[AMD Official Use Only - General] Probably worth changing the commit message and headline now that you're removing the parameter instead of just fixing the code style. Kent > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Wednesday, April 5, 2023 9:24 A

RE: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics support and set CP_HQD_HQ_STATUS0[29]

2023-04-04 Thread Russell, Kent
[Public] > -Original Message- > From: Sider, Graham > Sent: Tuesday, April 4, 2023 12:00 PM > To: Russell, Kent ; Somasekharan, Sreekant > ; amd-gfx@lists.freedesktop.org > Cc: Somasekharan, Sreekant > Subject: RE: [PATCH] drm/amdkfd: On GFX11 check PCIe at

RE: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics support and set CP_HQD_HQ_STATUS0[29]

2023-04-04 Thread Russell, Kent
[AMD Official Use Only - General] Comments inline > -Original Message- > From: amd-gfx On Behalf Of > Sreekant Somasekharan > Sent: Monday, April 3, 2023 3:59 PM > To: amd-gfx@lists.freedesktop.org > Cc: Somasekharan, Sreekant > Subject: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics s

RE: [PATCH 12/34] drm/amdgpu: add configurable grace period for unmap queues

2023-03-28 Thread Russell, Kent
[AMD Official Use Only - General] 3 tiny grammar/spelling things inline (not critical) Kent > -Original Message- > From: amd-gfx On Behalf Of > Jonathan Kim > Sent: Monday, March 27, 2023 2:43 PM > To: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Kuehling, Felix

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Hamza > Mahfooz > Sent: Friday, March 17, 2023 3:58 PM > To: Sider, Graham ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: Re: [PATCH] drm/amdgpu: add print for iommu translation mode >

RE: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-16 Thread Russell, Kent
[AMD Official Use Only - General] Probably want to fix that typo from SMDA to SDMA in the subject line before pushing. Kent > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, December 15, 2022 5:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, A

RE: [PATCH] drm/amdgpu: Check if fru_addr is not NULL (v2)

2022-12-12 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Luben > Tuikov > Sent: Monday, December 12, 2022 12:18 PM > To: AMD Graphics > Cc: Deucher, Alexander ; Tuikov, Luben > ; Dan Carpenter ; kernel test > robot > Subject: [P

RE: [PATCH 3/4] drm/amdgpu: Read IPMI data for product information

2022-11-16 Thread Russell, Kent
2 3:59 PM > To: Tuikov, Luben > Cc: AMD Graphics ; Deucher, Alexander > ; Russell, Kent > Subject: Re: [PATCH 3/4] drm/amdgpu: Read IPMI data for product information > > On Wed, Nov 16, 2022 at 2:49 PM Luben Tuikov > wrote: > > > > Read and interpret IPMI data t

RE: [PATCH] drm/amdgpu: Decouple RAS EEPROM addresses from chips

2022-11-08 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Luben > Tuikov > Sent: Monday, November 7, 2022 12:44 PM > To: AMD Graphics > Cc: Zhou1, Tao ; Deucher, Alexander > ; Tuikov, Luben ; Li, > Candice > Subject: [PATCH] drm/

RE: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference

2022-08-26 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: Ghannam, Yazen > Sent: Friday, August 26, 2022 11:20 AM > To: Russell, Kent > Cc: Lazar, Lijo ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference &

RE: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference

2022-08-25 Thread Russell, Kent
still investigating what got passed in and why it wasn't valid, so I'll drop this for now. Thanks Lijo! Kent -Original Message- From: amd-gfx On Behalf Of Russell, Kent Sent: Thursday, August 25, 2022 8:52 AM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Ghannam, Yaz

RE: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference

2022-08-25 Thread Russell, Kent
s was NULL instead of the actual message in our repro situation, but I'll double-check the short-circuit side of C to confirm. I know it short circuits for &&, I don't know if it does for ||. Kent -Original Message- From: Lazar, Lijo Sent: Thursday, August 25, 2022 8:

RE: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference

2022-08-25 Thread Russell, Kent
[AMD Official Use Only - General] Friendly ping Kent -Original Message- From: Russell, Kent Sent: Monday, August 15, 2022 11:31 AM To: amd-gfx@lists.freedesktop.org Cc: Ghannam, Yazen ; Russell, Kent Subject: [PATCH] drm/amdgpu: Handle potential NULL pointer dereference If m is

RE: [PATCH] drm/amdgpu: disable FRU access on special SIENNA CICHLID card

2022-08-25 Thread Russell, Kent
[AMD Official Use Only - General] Reviewed-by: Kent Russell -Original Message- From: Chen, Guchun Sent: Wednesday, August 24, 2022 11:04 AM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Zhang, Hawking ; Russell, Kent Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu

Re: [PATCH] drm/amdkfd: Allocate doorbells only when needed

2022-08-23 Thread Russell, Kent
No one else seems to have any thoughts on it, so Reviewed-by: Kent Russell Kent From: amd-gfx on behalf of Russell, Kent Sent: Monday, August 22, 2022 10:10 AM To: Kuehling, Felix ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdkfd: Allocate

RE: [PATCH] drm/amdkfd: Allocate doorbells only when needed

2022-08-22 Thread Russell, Kent
[AMD Official Use Only - General] I can throw an Acked-by: Kent Russell since we don't have an RB yet. Kent > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Wednesday, August 3, 2022 2:56 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdkfd:

RE: [PATCH v2 1/3] Documentation/gpu: Add info table for ASICs

2022-08-11 Thread Russell, Kent
Kazlauskas, Nicholas > ; Lakha, Bhawanpreet > ; Wu, Hersen ; > Hung, Alex ; Pelloux-Prayer, Pierre-Eric eric.pelloux-pra...@amd.com>; Li, Sun peng (Leo) ; > Simon Ser ; Pekka Paalanen > ; Sean Paul ; Mark > Yacoub ; Pierre-Loup > ; Michel Dänzer > ; Russell, Kent &g

RE: [PATCH] drm/amdgpu: Enable translate_further to extend UTCL2 reach

2022-08-08 Thread Russell, Kent
Joseph ; amd- > g...@lists.freedesktop.org > Cc: Russell, Kent ; Koenig, Christian > > Subject: Re: [PATCH] drm/amdgpu: Enable translate_further to extend UTCL2 > reach > > On 2022-08-04 12:01, Joseph Greathouse wrote: > > Enable translate_further on Arcturus and Aldebar

RE: [PATCH 2/2] drm/amdgpu: use the same HDP flush registers for all nbio 2.3.x

2022-07-13 Thread Russell, Kent
[AMD Official Use Only - General] Series is Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Wednesday, July 13, 2022 2:01 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/2] drm/amdgpu: use the sam

RE: [PATCH 2/2] drm/amdgpu: fix documentation warning

2022-06-28 Thread Russell, Kent
[AMD Official Use Only - General] Not sure why no one responded, but this is something even I can RB. Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Monday, June 27, 2022 5:41 PM > To: Deucher, Alexander > Cc: Stephen Rothwell ; am

RE: [PATCH] drm/amdgpu: Fix error handling in amdgpu_amdkfd_gpuvm_free_memory_of_gpu

2022-06-13 Thread Russell, Kent
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Friday, June 10, 2022 4:54 PM > To: Errabolu, Ramesh ; amd- > g...@lists.freedesktop.org; Francis, David > Subject: Re: [PATCH] drm/amdgpu: Fix error handling in > amdgpu_amdkfd

RE: [PATCH] drm/amdgpu: Adjust logic around GTT size (v3)

2022-05-20 Thread Russell, Kent
[AMD Official Use Only - General] I'll defer to Felix/Christian for the actual change, but a small typo in a comment: > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, May 20, 2022 11:09 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Su

RE: [PATCH 4/4] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-29 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Tuesday, March 29, 2022 11:28 AM > To: Russell, Kent > Cc: amd-gfx list > Subject: Re: [PATCH 4/4] drm/amdgpu: Add unique_id support for sienna cichlid > > On Tue, Mar 29, 2022 at 11:1

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-29 Thread Russell, Kent
Sent: Tuesday, March 29, 2022 12:34 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > > > > On 3/28/2022 10:37 PM, Kent Russell wrote: > > This is being added to

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Monday, March 28, 2022 1:02 PM > To: Russell, Kent > Cc: amd-gfx list ; Deucher, Alexander > > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > > On Mo

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
ontinue to work, but it's been a while since it was first confirmed by the PMFW dev I was working with. Kent From: Lazar, Lijo Sent: Monday, March 28, 2022 12:08 PM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_i

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 28, 2022 11:48 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid > &g

RE: [PATCH 2/2] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-28 Thread Russell, Kent
[AMD Official Use Only] Responses inline > -Original Message- > From: Lazar, Lijo > Sent: Monday, March 28, 2022 11:18 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH 2/2] drm/amdgpu: Add unique_id support

RE: [PATCH 1/2] drm/amdgpu: Change unique_id to use IP_VERSION

2022-03-28 Thread Russell, Kent
[Public] Thanks Alex. Sending out a 3rd version shortly with a couple style fixes due to rebasing onto Lijo's work. Kent From: Deucher, Alexander Sent: Monday, March 28, 2022 9:45 AM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Change unique_id t

RE: [PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

2022-03-25 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Friday, March 25, 2022 9:26 AM > To: Russell, Kent > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amdgpu: Add unique_id support for sienna cichlid > > On Fri, Mar 25, 2022 at 9:0

RE: [PATCH] drm/amdgpu: Add unique_id support for sienna cichlid

2022-02-11 Thread Russell, Kent
I can add a guard to be safe. When I checked previously it just returned zeroes, but that might have just been good luck. And I'll remove the mutex too. Thanks! Kent > -Original Message- > From: Quan, Evan > Sent: Thursday, February 10, 2022 11:46 PM > To: Russel

RE: [PATCH v1 3/3] drm/amdgpu: Prevent random memory access in FRU code

2022-02-04 Thread Russell, Kent
One tiny thing to fix before merging > -Original Message- > From: Kasiviswanathan, Harish > Sent: Friday, February 4, 2022 10:01 AM > To: Tuikov, Luben ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Tuikov, Luben > ; Russell, Kent > Subject: RE: [PAT

RE: [PATCH v1 0/3] AMDGPU FRU fixes

2022-02-04 Thread Russell, Kent
ov, Luben ; Deucher, Alexander > ; Russell, Kent ; Grodzovsky, > Andrey > Subject: [PATCH v1 0/3] AMDGPU FRU fixes > > Reordered the patches; fixed some bugs. > > Luben Tuikov (3): > drm/amdgpu: Nerf "buff" to "buf" > drm/amdgpu: Don't offset

RE: [PATCH] drm/amdgpu: Disable FRU EEPROM access for SRIOV

2022-01-20 Thread Russell, Kent
[AMD Official Use Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, January 20, 2022 11:51 AM > To: Liu, Shaoyun > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amdgpu: Disable FRU EEPROM access for SRIOV > > On Thu, Ja

RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Huang, JinHuiEric > Sent: Wednesday, January 19, 2022 10:01 AM > To: Russell, Kent ; Kuehling, Felix > ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arctur

RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, January 18, 2022 7:16 PM > To: Russell, Kent ; Huang, JinHuiEric > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus > &g

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Russell, Kent
One question inline KENT RUSSELL Sr. Software Engineer | Linux Compute Kernel 1 Commerce Valley Drive East Markham, ON L3T 7X6 O +(1) 289-695-2122 | Ext 72122 From: amd-gfx on behalf of Felix Kuehling Sent: Tuesday, January 18, 2022 6:36 PM To: Huang, JinHuiEr

RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Russell, Kent
[AMD Official Use Only] I think what he means is that if we are using SDMA v17, this will cause issues, won't it? Should we check that SDMA version is >=18 before enabling it? Or am I misunderstanding the fix? Kent > -Original Message- > From: amd-gfx On Behalf Of Eric Huang > Sent:

RE: [PATCH 1/2] drm/amdkfd: Fix DQM asserts on Hawaii

2022-01-11 Thread Russell, Kent
[AMD Official Use Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Monday, January 10, 2022 7:13 PM > To: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amdkfd: Fix DQM asserts on Hawaii > > Ping. > > On 2021-12-0

RE: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to have only read premission in ONEVF mode

2021-12-20 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: amd-gfx On Behalf Of Marina > Nikolic > Sent: Monday, December 20, 2021 11:09 AM > To: amd-gfx@lists.freedesktop.org > Cc: Mitrovic, Milan ; Nikolic, Marina > ; Kitchen, Greg > Subject: [PATCH] amdgpu/pm: Modify sysfs pp_dpm_sclk to h

RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

2021-12-20 Thread Russell, Kent
That's fine, I can do that change and submit the series per Alex's RB. Kent > -Original Message- > From: Chen, Guchun > Sent: Friday, December 17, 2021 9:49 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: RE: [PATCH 4/4

RE: [PATCH 1/4] drm/amdgpu: Increase potential product_name to 64 characters

2021-12-20 Thread Russell, Kent
[AMD Official Use Only] Will do. Thanks! Kent > -Original Message- > From: Christian König > Sent: Saturday, December 18, 2021 9:36 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/4] drm/amdgpu: Increase potential product_name to 6

RE: [PATCH 1/4] drm/amdgpu: Increase potential product_name to 64 characters

2021-12-14 Thread Russell, Kent
Yeah that would make things a little clearer, and make it easier to change going forward. Thanks! Kent > -Original Message- > From: Chen, Guchun > Sent: Monday, December 13, 2021 10:33 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Sub

RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

2021-12-14 Thread Russell, Kent
I'm not aware of any Aldebaran SKUs that don't have the FRU, but I can look into it before submitting this patch. Kent > -Original Message- > From: Chen, Guchun > Sent: Monday, December 13, 2021 10:39 PM > To: Chen, Guchun ; Russell, Kent ; > amd-gfx@l

RE: [PATCH 2/2] drm/amdkfd: Make KFD support on Hawaii experimental

2021-12-08 Thread Russell, Kent
[AMD Official Use Only] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Wednesday, December 8, 2021 3:26 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 2/2] drm/amdkfd: Make KFD support on Hawaii experimental > > Hawaii s

RE: [PATCH] drm/amdgpu: Make sure to reserve BOs before adding or removing

2021-11-01 Thread Russell, Kent
ch. Kent > -Original Message- > From: Errabolu, Ramesh > Sent: Monday, November 1, 2021 4:43 PM > To: Kuehling, Felix ; Russell, Kent > ; > amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH] drm/amdgpu: Make sure to reserve BOs before adding or > removing >

RE: [PATCH] drm/amdgpu: Restore information reporting in RAS

2021-10-25 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Monday, October 25, 2021 1:30 PM > To: Tuikov, Luben ; amd-gfx@lists.freedesktop.org > Cc: Russell, Kent ; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: Restore information rep

RE: [PATCH] drm/amdgpu: Restore information reporting in RAS

2021-10-25 Thread Russell, Kent
[AMD Official Use Only] Thanks Luben Reviewed-by: Kent Russell Kent > -Original Message- > From: Tuikov, Luben > Sent: Monday, October 25, 2021 12:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Russell, Kent > ; > Deucher, Alexander > Sub

RE: [PATCH 2/2] drm/amdgpu: Add kernel parameter support for ignoring bad page threshold

2021-10-21 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Tuikov, Luben > Sent: Thursday, October 21, 2021 12:47 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > > Subject: Re: [PATCH 2/2] drm/amdgpu: Add kernel

RE: [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% threshold

2021-10-21 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Tuikov, Luben > Sent: Thursday, October 21, 2021 12:45 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: Re: [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% > thre

RE: [PATCH 2/2] drm/amdgpu: Add kernel parameter support for ignoring bad page threshold

2021-10-21 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Tuikov, Luben > Sent: Thursday, October 21, 2021 12:21 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > ; > Tuikov, Luben > Subject: Re: [PATCH 2/2] drm/amdg

RE: [PATCH 1/2] drm/amdgpu: Warn when bad pages approaches 90% threshold

2021-10-21 Thread Russell, Kent
sistencies. I agree that device is useful for this kind of error/warning/info Kent From: Lazar, Lijo Sent: Thursday, October 21, 2021 12:31 PM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Cc: Russell, Kent ; Tuikov, Luben ; Joshi, Mukul Subject: Re: [PATCH 1/2] drm/amdgpu: Warn when bad pages a

RE: [PATCH 1/3] drm/amdgpu: Warn when bad pages approaches 90% threshold

2021-10-21 Thread Russell, Kent
ay, October 20, 2021 5:48 PM To: Russell, Kent ; amd-gfx@lists.freedesktop.org Cc: Joshi, Mukul Subject: Re: [PATCH 1/3] drm/amdgpu: Warn when bad pages approaches 90% threshold On 2021-10-20 12:35, Kent Russell wrote: Currently dmesg doesn't warn when the number of bad pages approaches th

RE: [PATCH 3/3] drm/amdgpu: Implement bad_page_threshold = -2 case

2021-10-21 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Tuikov, Luben > Sent: Wednesday, October 20, 2021 6:01 PM > To: Kuehling, Felix ; Russell, Kent > ; > amd-gfx@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: Re: [PATCH 3/3] drm/amdgpu: Implement bad_

RE: [PATCH 3/3] drm/amdgpu: Implement bad_page_threshold = -2 case

2021-10-21 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, October 21, 2021 1:25 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Joshi, Mukul > Subject: Re: [PATCH 3/3] drm/amdgpu: Implement bad_page_t

RE: [PATCH 3/4] drm/amdgpu: Add kernel parameter for ignoring bad page threshold

2021-10-20 Thread Russell, Kent
so that they can plan for HW replacement accordingly. Kent > -Original Message- > From: Christian König > Sent: Wednesday, October 20, 2021 6:55 AM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Joshi, Mukul > Subject: Re: [PATCH 3/4] drm/amdgp

RE: [PATCH 3/4] drm/amdgpu: Add kernel parameter for ignoring bad page threshold

2021-10-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, October 19, 2021 2:13 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Joshi, Mukul > Subject: Re: [PATCH 3/4] drm/amdgpu: Add kernel parameter for ig

RE: [PATCH 1/4] drm/amdgpu: Warn when bad pages approaches threshold

2021-10-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, October 19, 2021 2:09 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Joshi, Mukul > Subject: Re: [PATCH 1/4] drm/amdgpu: Warn when bad pages approaches

RE: [PATCH 0/5] 0 MHz is not a valid current frequency

2021-10-19 Thread Russell, Kent
, 2021 12:27 AM To: Russell, Kent ; Deucher, Alexander ; Quan, Evan ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish Subject: Re: [PATCH 0/5] 0 MHz is not a valid current frequency Kent, What is the command which fails? I can try to duplicate it here. So far, things

RE: [PATCH 0/5] 0 MHz is not a valid current frequency

2021-10-18 Thread Russell, Kent
ent clocks" and uses the * to determine which one is active Kent From: amd-gfx On Behalf Of Russell, Kent Sent: Monday, October 18, 2021 9:05 PM To: Tuikov, Luben ; Deucher, Alexander ; Quan, Evan ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish Subject: RE: [PATC

RE: [PATCH 0/5] 0 MHz is not a valid current frequency

2021-10-18 Thread Russell, Kent
[AMD Official Use Only] +Harish, rocm-smi falls under his purview now. Kent From: Tuikov, Luben Sent: Monday, October 18, 2021 4:30 PM To: Deucher, Alexander ; Quan, Evan ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org; Russell, Kent Subject: Re: [PATCH 0/5] 0 MHz is not a valid current

RE: [PATCH 1/5] drm/amd/pm: Slight function rename

2021-10-13 Thread Russell, Kent
[AMD Official Use Only] Pedantic tiny thing: > -Original Message- > From: amd-gfx On Behalf Of Luben > Tuikov > Sent: Tuesday, October 12, 2021 11:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Tuikov, Luben > > Subject: [PATCH 1/5] drm/amd/pm: Slight function ren

RE: [PATCH v2] drm/amdkfd: Account for SH/SE count when setting up cu masks.

2021-08-24 Thread Russell, Kent
[AMD Official Use Only] Minor comment inline > -Original Message- > From: amd-gfx On Behalf Of Sean Keely > Sent: Monday, August 23, 2021 8:37 PM > To: amd-gfx@lists.freedesktop.org > Cc: Keely, Sean > Subject: [PATCH v2] drm/amdkfd: Account for SH/SE count when setting up cu > masks.

RE: [PATCH] drm/amdkfd: Disallow debugfs to hang hws when GPU is resetting

2021-07-07 Thread Russell, Kent
[AMD Official Use Only] Some slight grammar > -Original Message- > From: amd-gfx On Behalf Of Oak Zeng > Sent: Wednesday, July 7, 2021 12:28 PM > To: amd-gfx@lists.freedesktop.org > Cc: Bai, Zoy (zoybai) ; Xu, Feifei ; > Kuehling, Felix > ; Lazar, Lijo ; Zeng, Oak > > Subject: [PATCH]

RE: [PATCH] drm/amdgpu: use ratelimited print in sdma4 interrupt

2021-04-15 Thread Russell, Kent
[AMD Public Use] Acked-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Feifei Xu > Sent: Thursday, April 15, 2021 2:11 AM > To: amd-gfx@lists.freedesktop.org > Cc: Xu, Feifei > Subject: [PATCH] drm/amdgpu: use ratelimited print in sdma4 interrupt > > dev_*_ratelim

RE: [PATCH] drm/amdkfd: Update L1 and add L2/3 cache information

2021-03-29 Thread Russell, Kent
[AMD Public Use] Some comments inline. Don't address them yet until someone else reviews this more thoroughly though > -Original Message- > From: amd-gfx On Behalf Of Mike Li > Sent: Monday, March 29, 2021 12:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Lazar, Lijo

RE: [PATCH] drm/amdgpu: Set amdgpu.noretry=1 for Arcturus

2021-03-24 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Philip Cox > Sent: Wednesday, March 24, 2021 9:24 AM > To: amd-gfx@lists.freedesktop.org > Cc: Cox, Philip > Subject: [PATCH] drm/amdgpu: Set amdgpu.noretry=1 for Arcturus > > Setting amdg

RE: [PATCH 1/1] drm/amdgpu: Mark Albebaran HW support as experimental

2021-03-18 Thread Russell, Kent
[AMD Public Use] Sorry, just realized a typo in the headline. Albebaran->Aldebaran. With that fixed, Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Russell, > Kent > Sent: Thursday, March 18, 2021 12:32 PM > To: Kuehlin

RE: [PATCH 1/1] drm/amdgpu: Mark Albebaran HW support as experimental

2021-03-18 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Thursday, March 18, 2021 12:06 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/1] drm/amdgpu: Mark Albebaran HW support as experimental > > The HW is not

RE: [PATCH 1/1] drm/amdkfd: Bump KFD API version

2021-03-09 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Tuesday, March 9, 2021 3:07 PM > To: amd-gfx@lists.freedesktop.org > Cc: Keely, Sean > Subject: [PATCH 1/1] drm/amdkfd: Bump KFD API version > > Indicate the availabi

RE: [PATCH 1/1] drm/amdkfd: Use a new capability bit for SRAM ECC

2021-03-03 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Friday, February 26, 2021 5:46 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/1] drm/amdkfd: Use a new capability bit for SRAM ECC > > Existing, buggy user

RE: [PATCH] drm/amdkfd: Print unique_id as hex instead of decimal

2021-02-03 Thread Russell, Kent
[AMD Public Use] Indeed it will. Consider this dropped, as no one was asking for it anyways. Kent > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, February 3, 2021 1:38 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] dr

RE: [PATCH] amdgpu: Add Missing Sienna Cichlid DID

2021-01-29 Thread Russell, Kent
[AMD Public Use] Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Ori > Messinger > Sent: Friday, January 29, 2021 7:43 AM > To: amd-gfx@lists.freedesktop.org > Cc: Messinger, Ori > Subject: [PATCH] amdgpu: Add Missing Sienna Cichlid DID > > The purpose of

RE: [PATCH 1/1] drm/amdkfd: Fix leak in dmabuf import

2020-12-08 Thread Russell, Kent
[AMD Public Use] Seems logical to me. Reviewed-by: Kent Russell > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Tuesday, December 8, 2020 12:31 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/1] drm/amdkfd: Fix leak in dmabuf import > > Release dm

RE: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format

2020-10-28 Thread Russell, Kent
Wednesday, October 28, 2020 12:11 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format > > So rocm-smi reads the decimal and converts it to hex? Then changing KFD > will break rocm-smi. If you want to fix

RE: [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology

2020-10-28 Thread Russell, Kent
[AMD Public Use] Right, will do! Kent > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, October 28, 2020 12:16 PM > To: Russell, Kent ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 1/2] drm/amdkfd: Fix getting unique_id in topology > > P

RE: [PATCH 2/2] drm/amdkfd: Change unique_id to print hex format

2020-10-28 Thread Russell, Kent
id is 16" . Probably too late to try to change it now though, as you pointed out. Kent > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, October 28, 2020 11:55 AM > To: amd-gfx@lists.freedesktop.org; Russell, Kent > Subject: Re: [PATCH 2/2] drm/amdk

  1   2   3   >