Hi Zhan,
I tested your patch, and it fixed the issue. I have some notes:
1. Your patch does not apply smoothly, try to rebase your branch (I
manually fix it for testing your patch).
2. In the commit message, I recommend you to describe the "pink" color
issue when using HDMI. It is going to make e
Commit d7cd0e05 introduced a change at DP_DSC_THROUGHPUT_MODE_0_170
which is not aligned with the spec. This commit replace 15 << 4 by
15 << 0 for DP_DSC_THROUGHPUT_MODE_0_170 in order to make it follow the
specification.
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: Nikola Cornij
Cc: Jan
DP 1.4 specification defines Link Training Tunable PHY Repeater (LTTPR)
which is required to add support for systems with Thunderbolt or other
repeater devices.
Cc: Abdoulaye Berthe
Cc: Harry Wentland
Cc: Leo Li
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Abdoulaye Berthe
---
include/drm/
Hi Harry,
Thanks for your feedback, I'll prepare a V2.
On 08/23, Wentland, Harry wrote:
> On 2019-08-22 6:46 p.m., Siqueira, Rodrigo wrote:
> > DP 1.4 specification defines Link Training Tunable PHY Repeater (LTTPR)
> > which is required to add support for systems with
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR)
which is required to add support for systems with Thunderbolt or other
repeater devices.
Changes since V1:
- Adjusts registers names to be aligned with spec and the rest of the
file
- Update spec comment from 1.4 to 1.4a
C
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR)
which is required to add support for systems with Thunderbolt or other
repeater devices.
Changes since V2:
- Drop the kernel-doc comment
- Reorder LTTPR according to register offset
Changes since V1:
- Adjusts registers names
On 08/27, Jani Nikula wrote:
> On Mon, 26 Aug 2019, "Siqueira, Rodrigo" wrote:
> > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR)
> > which is required to add support for systems with Thunderbolt or other
> > repeater devices.
> >
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR)
which is required to add support for systems with Thunderbolt or other
repeater devices.
Changes since V3:
- Replace spaces by tabs
Changes since V2:
- Drop the kernel-doc comment
- Reorder LTTPR according to register offset
Hi Ville,
First of all, thank you very much for the review.
I added some comments below.
On 09/05, Wentland, Harry wrote:
> On 2019-09-05 1:29 p.m., Ville Syrjälä wrote:
> > On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote:
> >> DP 1.4a specification def
DP 1.3 specification introduces the Link Training-tunable PHY Repeater,
and DP 1.4* supplemented it with new features. In the 1.4a spec, it was
introduced some innovations to make handy to add support for systems
with Thunderbolt or other repeater devices.
It is important to highlight that DP spec
Please, ignore this patch.
I just noticed that I sent the wrong version. I resend the correct patch
with the title:
[PATCH V5] drm: Add definitions for link training repeaters
Sorry for this mistake.
On 09/09, Siqueira, Rodrigo wrote:
> DP 1.3 specification introduces the Link Training-tuna
This change adds definitions required for Link Training-tunable PHY
Repeater, which was introduced in the DP 1.3 specification, and
incremented with new features in the DP 1.4*.
Changes since V4:
- Update commit message
- Fix misleading comments related to the spec version
Changes since V3:
- Repl
The 'debug_data' variable gets printed in debug statements without a
prior initialization in the function
hubbub1_verify_allow_pstate_change_high, as reported when building with
gcc 9.1.0:
warning: ‘debug_data’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
290 | printk##on
13 matches
Mail list logo
