RE: [PATCH v2 10/10] Revert "drm/amdgpu: Queue KFD reset workitem in VF FED"

2024-05-28 Thread Skvortsov, Victor
[AMD Official Use Only - AMD Internal Distribution Only] Nack to the revert. The FLR sequence is defined as the following (host-initiated reset): 1) host sends FLR_NOTIFICATION 2) Guest gets interrupt and queues FLR work item 3) Guest sends READY_TO_RESET 4) Host sends

RE: [PATCH] drm/amdgpu: trigger flr_work if reading pf2vf data failed

2024-03-16 Thread Skvortsov, Victor
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Lazar, > Lijo > Sent: Friday, March 15, 2024 6:47 AM > To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Saye, Sashank > ; Chan, Hing Pong > Subject: Re: [PATCH] drm/amdgpu: trigger

RE: [PATCH v2] drm/amdgpu: Modify for_each_inst macro

2023-06-20 Thread Skvortsov, Victor
[AMD Official Use Only - General] Acked-by: Victor Skvortsov -Original Message- From: Lazar, Lijo Sent: Monday, June 19, 2023 3:30 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kuehling, Felix ; Skvortsov, Victor Subject: [PATCH v2] drm/amdgpu

RE: [PATCH] drm/amdgpu: Fix wait for RLCG command completion

2022-02-15 Thread Skvortsov, Victor
[AMD Official Use Only] +Shaoyun -Original Message- From: Zhang, Bokun Sent: Monday, February 14, 2022 4:09 PM To: Skvortsov, Victor ; amd-gfx@lists.freedesktop.org Cc: Skvortsov, Victor Subject: RE: [PATCH] drm/amdgpu: Fix wait for RLCG command completion [AMD Official Use Only

RE: [PATCH] drm/amdgpu: no rlcg legacy read in SRIOV case

2022-02-11 Thread Skvortsov, Victor
[AMD Official Use Only] Reviewed-by: Victor Skvortsov Thanks, Victor -Original Message- From: Zhang, Hawking Sent: Friday, February 11, 2022 1:42 AM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander ; Skvortsov, Victor

RE: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

2022-02-10 Thread Skvortsov, Victor
[AMD Official Use Only] Hi Guchun, RLCG read is available on Aldebaran if amdgpu_sriov_reg_indirect_gc() flag is set. Instead of adding a new function, I think we should simply add a check inside amdgpu_virt_get_rlcg_reg_access_flag(): diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

RE: [PATCH v3] drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV

2022-01-13 Thread Skvortsov, Victor
[AMD Official Use Only] +Shaoyun -Original Message- From: Chen, JingWen Sent: Thursday, January 13, 2022 11:09 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Chen, Horace ; Skvortsov, Victor ; Chen, JingWen Subject: [PATCH v3] drm/amd/amdgpu: fixing read wrong pf2vf data

RE: [PATCH v3 4/5] drm/amdgpu: get xgmi info before ip_init

2021-12-16 Thread Skvortsov, Victor
-Original Message- From: Alex Deucher Sent: Thursday, December 16, 2021 3:18 PM To: Skvortsov, Victor Cc: amd-gfx list ; Deng, Emily ; Liu, Monk ; Ming, Davis ; Liu, Shaoyun ; Zhou, Peng Ju ; Chen, JingWen ; Chen, Horace ; Nieto, David M Subject: Re: [PATCH v3 4/5] drm/amdgpu: get xgmi info

RE: [PATCH 4/5] drm/amdgpu: Initialize Aldebaran RLC function pointers

2021-12-16 Thread Skvortsov, Victor
[AMD Official Use Only] Gotcha, I will skip this patch for drm-next -Original Message- From: Alex Deucher Sent: Thursday, December 16, 2021 8:53 AM To: Skvortsov, Victor Cc: amd-gfx list ; Deng, Emily ; Liu, Monk ; Ming, Davis ; Liu, Shaoyun ; Zhou, Peng Ju ; Chen, JingWen ; Chen

RE: [PATCH 4/5] drm/amdgpu: Initialize Aldebaran RLC function pointers

2021-12-15 Thread Skvortsov, Victor
is kind of ugly. I don't know where else to put it if we do need to call get_xgmi_info() in early_init. Thanks, Victor -Original Message- From: Alex Deucher Sent: Wednesday, December 15, 2021 4:38 PM To: Skvortsov, Victor Cc: amd-gfx list ; Deng, Emily ; Liu, Monk ; Ming, Davis ; Liu

RE: [PATCH 5/5] drm/amdgpu: Modify indirect register access for gfx9 sriov

2021-12-15 Thread Skvortsov, Victor
[AMD Official Use Only] This was a bug in the original definition, but it functionally it makes no difference (in both cases the macros resolve to the same value). From: Nieto, David M Sent: Wednesday, December 15, 2021 2:16 PM To: Skvortsov, Victor ; amd-gfx@lists.freedesktop.org; Deng

RE: [PATCH] drm/amdgpu: SRIOV flr_work should use down_write

2021-12-09 Thread Skvortsov, Victor
[AMD Official Use Only] I wanted to keep the order the same as in amdgpu_device_lock_adev() (Set flag then acquire lock) to prevent any weird race conditions. Thanks, Victor -Original Message- From: Liu, Shaoyun Sent: Thursday, December 9, 2021 1:25 PM To: Skvortsov, Victor ; amd-gfx