[PATCH 21/21] drm/amd/display: Ignore First MST Sideband Message Return Error

2022-07-12 Thread Solomon Chiu
AUX_RET_ERROR_HPD_DISCON detected on the first sideband message. Cc: sta...@vger.kernel.org # 4.18+ Signed-off-by: Fangzhi Zuo Acked-by: Solomon Chiu Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 27 +++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 8

[PATCH 20/21] drm/amd/display: 3.2.194

2022-07-12 Thread Solomon Chiu
From: Aric Cyr This version brings along following fixes: - Fixes for MST, MPO, PSRSU, DP 2.0, Freesync and others - Add register offsets of NBI and DCN. - Improvement of ALPM - Removing assert statement for Linux DM - Re-implementing ARGB16161616 pixel format Acked-by: Solomon Chiu Signed

[PATCH 19/21] drm/amd/display: Fix wrong reference

2022-07-12 Thread Solomon Chiu
Kazlauskas Acked-by: Solomon Chiu Signed-off-by: Rodrigo Siqueira Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/displ

[PATCH 18/21] drm/amd/display: Fix lag when moving windowed MPO across display using ODM 2:1 combine

2022-07-12 Thread Solomon Chiu
-by: Solomon Chiu Signed-off-by: Samson Tam Tested-by: Daniel Wheeler --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 32 +-- .../gpu/drm/amd/display/dc/inc/core_types.h | 27 2 files changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 17/21] drm/amd/display: Add NBIO reg offsets to DC

2022-07-12 Thread Solomon Chiu
From: Aurabindo Pillai [Why] Add a field to store the NBIO IP offset for use with runtime offset calculation Reviewed-by: Rodrigo Siqueira Acked-by: Solomon Chiu Signed-off-by: Aurabindo Pillai Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers

[PATCH 16/21] drm/amd/display: Add DCN reg offsets to DC

2022-07-12 Thread Solomon Chiu
her runtime or compile time initialization of offsets. The computation of offset is done for registers all at once during driver load and hence it does not introduce any performance overhead during normal operation. Reviewed-by: Rodrigo Siqueira Acked-by: Solomon Chiu Signed-off-by: Harry Wentl

[PATCH 15/21] drm/amd/display: add system info table log

2022-07-12 Thread Solomon Chiu
From: Charlene Liu [why] insert log for debug use. Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu Signed-off-by: Charlene Liu Tested-by: Daniel Wheeler --- .../drm/amd/display/dc/bios/bios_parser2.c| 30 +++ 1 file changed, 30 insertions(+) diff --git

[PATCH 14/21] drm/amd/display: Grab dc_lock before detecting link

2022-07-12 Thread Solomon Chiu
From: Wayne Lin [Why & How] There is chance we change dc state while calling dc_link_detect(). As the result of that, grab the dm.dc_lock before detecting link. Reviewed-by: Hersen Wu Acked-by: Solomon Chiu Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler --- .../gpu/drm/amd/dis

[PATCH 13/21] drm/amd/display: Re-implementing ARGB16161616 pixel format as 22

2022-07-12 Thread Solomon Chiu
for dcn10/20/30. Reviewed-by: Reza Amini Acked-by: Solomon Chiu Signed-off-by: Wellenreiter Ethan Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 2 ++ drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 3 +++ drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c

[PATCH 12/21] drm/amd/display: 3.2.193

2022-07-08 Thread Solomon Chiu
From: Aric Cyr Acked-by: Solomon Chiu Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index a0812849794e..1dca016b5782 100644

[PATCH 11/21] drm/amd/display: update DML1 logic for unbounded req handling

2022-07-08 Thread Solomon Chiu
req in HW according to unbounded req enablement output from DML, as opposed to DML input Second, port in DML1 update which disables unbounded req in some scenarios to fix an issue with poor stutter performance Reviewed-by: Nevenko Stupar Reviewed-by: Dmytro Laktyushkin Acked-by: Solomon Chiu

[PATCH 10/21] drm/amd/display: Reduce SCDC Status Flags Definition

2022-07-08 Thread Solomon Chiu
From: Chris Park [Why] Status flags definition is reduced to read less bytes in SCDC transaction for status update. [How] Reduce definition of reserved bytes from 3 to 1 for status update. Reviewed-by: Charlene Liu Acked-by: Solomon Chiu Signed-off-by: Chris Park --- drivers/gpu/drm/amd

[PATCH 09/21] drm/amd/display: make enable link independent from verified link caps

2022-07-08 Thread Solomon Chiu
bandwidth. Remove the reference of verified link cap during enable link process and use link config in pipe ctx instead. Reviewed-by: George Shen Acked-by: Solomon Chiu Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_debug.c| 2 + drivers/gpu/drm/amd/display/dc/core

[PATCH 08/21] drm/amd/display: Fix black screen when disabling Freesync in OSD

2022-07-08 Thread Solomon Chiu
From: Ilya Bakoulin [Why] Black screen encountered when disabling Freesync through OSD on some displays. [How] Set the should_disable flag when new top pipe has no plane state to ensure that pipes get cleaned up. Reviewed-by: Chris Park Acked-by: Solomon Chiu Signed-off-by: Ilya Bakoulin

[PATCH 05/21] drm/amd/display: Fix windowed MPO video with ODM combine for DCN32

2022-07-08 Thread Solomon Chiu
config.enable_windowed_mpo_odm to true when we have the debug.enable_single_display_2to1_odm_policy set to true. Don't fail validating ODM with windowed MPO if config.enable_windowed_mpo_odm is true. Reviewed-by: Aric Cyr Acked-by: Solomon Chiu Signed-off-by: Samson Tam --- drivers/gpu/drm/amd

[PATCH 06/21] drm/amd/display: Clear edid when unplug mst connector

2022-07-08 Thread Solomon Chiu
d when unplug mst connector. Reviewed-by: Hersen Wu Acked-by: Solomon Chiu Signed-off-by: Wayne Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/d

[PATCH 07/21] drm/amd/display: Disable PSRSU when DSC enabled on the specific sink

2022-07-08 Thread Solomon Chiu
From: Robin Chen [Why] Some specific sink is not able to support PSRSU when DSC is turned on. For this case, fall-back to use PSR1. Reviewed-by: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Robin Chen --- .../amd/display/modules/power/power_helpers.c | 33 ++- 1 file

[PATCH 04/21] drm/amd/display: Removing assert statements for Linux

2022-07-08 Thread Solomon Chiu
From: Saaem Rizvi [WHY] Assert statements causing several bugs on Linux DM [HOW] Removing assert statement for Linux DM (ASSERT(result == VBIOSSMC_Result_OK)). Also adding logging statements for setting dcfclk. Reviewed-by: Gabe Teeger Acked-by: Solomon Chiu Signed-off-by: Saaem Rizvi

[PATCH 03/21] drm/amd/display: Helper function for ALPM initialization

2022-07-08 Thread Solomon Chiu
From: muansari [WHY] Needed a helper function for ALPM DPCD initialization [HOW] Refactoring to put ALPM initialization in a helper function Reviewed-by: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Muhammad Ansari --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 27

[PATCH 02/21] drm/amd/display: Check for DP2.0 when checking ODM combine

2022-07-08 Thread Solomon Chiu
From: Wesley Chalmers [WHY] Certain DP 2.0 modes may fail validation if DP 2.0 is not considered for ODM combine. Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c | 1 + 1 file changed, 1

[PATCH 01/21] drm/amd/display: Exit SubVP if MPO in use

2022-07-08 Thread Solomon Chiu
Also don't program K1 / K2 = 0xF ever since the field is only 1 / 2 bits wide. Reviewed-by: Jun Lei Acked-by: Solomon Chiu Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 27 +-- drivers/gpu/drm/amd/display/dc/dc.h | 2 + .../amd/displa

[PATCH 00/21] DC Patches July 11, 2022

2022-07-08 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fixes for MST, MPO, PSRSU, DP 2.0, Freesync and others - Add register offsets of NBI and DCN. - Improvement of ALPM - Removing assert statement for Linux DM - Re-implementing ARGB16161616 pixel format Aric Cyr

[PATCH 12/12] drm/amd/display: 3.2.174

2022-02-18 Thread Solomon Chiu
wrong resolution with DP/VGA adapter - Refactor PSR DPCD caps detection - Set compbuf size to min at prep prevent overbook crb - lock/un-lock cursor if odm pipe split used - OVT Update on InfoFrame and Mode Management Acked-by: Solomon Chiu Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display

[PATCH 11/12] drm/amd/display: add debug option to bypass ssinfo from bios.

2022-02-18 Thread Solomon Chiu
From: Charlene Liu [Why] add debug option to bypass ssinfo from bios. Reviewed-by: Chris Park Acked-by: Solomon Chiu Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c | 2 ++ drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 2

[PATCH 10/12] drm/amd/display: [FW Promotion] Release 0.0.105.0

2022-02-18 Thread Solomon Chiu
From: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 09/12] drm/amd/display: Refactor fixed VS logic for non-transparent mode

2022-02-18 Thread Solomon Chiu
arent mode into a separate function. Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu Signed-off-by: George Shen --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 102 +- 1 file changed, 97 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/d

[PATCH 08/12] drm/amd/display: add cable ID support for usb c connector

2022-02-18 Thread Solomon Chiu
From: Wenjing Liu [how] Call to DMUB to retrieve usb c cable ID data from PD firmware. If cable id is retrieved from DMUB, skip reading cable ID from RX. Reviewed-by: George Shen Acked-by: Solomon Chiu Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4

[PATCH 07/12] drm/amd/display: clear remote dc_sink when stop mst

2022-02-18 Thread Solomon Chiu
at dm_helpers_dp_mst_stop_top_mgr() was removed by previous patch. Restore it. Reviewed-by: Jerry Zuo Acked-by: Solomon Chiu Signed-off-by: Wayne Lin --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 06/12] drm/amd/display: Ignore Transitional Invalid Link Rate Error Message

2022-02-18 Thread Solomon Chiu
to DEBUG. Reviewed-by: Wayne Lin Acked-by: Solomon Chiu Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c

[PATCH 05/12] drm/amd/display: Fix wrong resolution with DP/VGA adapter

2022-02-18 Thread Solomon Chiu
if the SINK_COUNT DPCD register is read more than once. [How] To work around the adapter behavior, remove the sink if link is detected, but EDID cannot be read. Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu Signed-off-by: Ilya --- drivers/gpu/drm/amd/display/dc/core/dc_link.c| 16

[PATCH 04/12] drm/amd/display: Refactor PSR DPCD caps detection

2022-02-18 Thread Solomon Chiu
From: Po Ting Chen [Why] To move the PSR DPCD caps detection into detect_edp_sink_caps() Reviewed-by: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Po Ting Chen --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 58

[PATCH 03/12] drm/amd/display: Set compbuf size to min at prep prevent overbook crb

2022-02-18 Thread Solomon Chiu
er size. When it is to optimize BW, set compbuf size back to maximum possible size. Reviewed-by: Charlene Liu Reviewed-by: Charlene Liu Acked-by: Solomon Chiu Signed-off-by: Duncan Ma --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 12 ++-- .../drm/amd/display/dc/dml/display_m

[PATCH 02/12] drm/amd/display: lock/un-lock cursor if odm pipe split used

2022-02-18 Thread Solomon Chiu
-by: Dmytro Laktyushkin Acked-by: Solomon Chiu Signed-off-by: Paul Hsieh --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c

[PATCH 01/12] drm/amd/display: OVT Update on InfoFrame and Mode Management

2022-02-18 Thread Solomon Chiu
From: Chris Park [Why] Integrate OVT timing from DM to DC logic to update info frame and mode management to report the resolution to the OS. [How] Reflect RID and Frame Rate to AVI InfoFrame Version 5. Define new Timing Standard for OVT timing. Reviewed-by: Charlene Liu Acked-by: Solomon Chiu

[PATCH 00/12] DC Patches February 21, 2022

2022-02-18 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: * add debug option to bypass ssinfo from bios. * Refactor fixed VS logic for non-transparent mode * add cable ID support for usb c connector * clear remote dc_sink when stop mst * Ignore Transitional Invalid Link

[PATCH 14/14] drm/amd/display: Fix error in dmesg at boot

2021-10-01 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [Why] During DQE's promotion test, error appears in dmesg at boot on dcn3.1; [How] Add NULL pointor check for the pointor to the amdgpu_dm_connector; Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu Signed-off-by: Leo (Hanghong) Ma --- drivers/g

[PATCH 13/14] drm/amd/display: Fix concurrent dynamic encoder assignment.

2021-10-01 Thread Solomon Chiu
the assignment algorithm is executed. It should not be necessary for fast state validation. Reviewed-by: Jun Lei Acked-by: Solomon Chiu Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH 12/14] drm/amd/display: Add helper for blanking all dp displays

2021-10-01 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [Why & How] The codes to blank all dp display have been called many times, so add a helper in dc_link to make it more concise. Reviewed-by: Aric Cyr Acked-by: Solomon Chiu Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/display/dc/core/

[PATCH 11/14] drm/amd/display: 3.2.156

2021-10-01 Thread Solomon Chiu
dcn3 failure due to dmcbu_abm not created - Limit display scaling to up to 4k for DCN 3.1 - Add helper for blanking all dp displays Acked-by: Solomon Chiu Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 10/14] drm/amd/display: [FW Promotion] Release 0.0.87

2021-10-01 Thread Solomon Chiu
From: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 09/14] drm/amd/display: Fix detection of 4 lane for DPALT

2021-10-01 Thread Solomon Chiu
From: Hansen [Why] DPALT detection for B0 PHY has its own set of RDPCSPIPE registers [How] Use RDPCSPIPE registers to detect if DPALT lane is 4 lane Reviewed-by: Charlene Liu Acked-by: Solomon Chiu Signed-off-by: Hansen --- .../display/dc/dcn31/dcn31_dio_link_encoder.c | 33

[PATCH 08/14] drm/amd/display: Limit display scaling to up to 4k for DCN 3.1

2021-10-01 Thread Solomon Chiu
From: Nikola Cornij [why] The existing limit was mistakenly bigger than 4k for DCN 3.1 Reviewed-by: Zhan Liu Acked-by: Solomon Chiu Signed-off-by: Nikola Cornij --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/14] drm/amd/display: Added root clock optimization flags

2021-10-01 Thread Solomon Chiu
From: Jake Wang [Why & How] Added root clock optimization debug flags for future debugging. Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu Signed-off-by: Jake Wang --- drivers/gpu/drm/amd/display/dc/dc.h | 18 ++ 1 file changed, 18 insertions(+) diff -

[PATCH 06/14] drm/amd/display: dcn3 failed due to dmcbu_abm not created

2021-10-01 Thread Solomon Chiu
From: Charlene Liu [why] dc->config.disable_dmcu set to true, but it still need create dmcub based abm. [how] check to dc->caps.dmcub_support check. Reviewed-by: Aric Cyr Acked-by: Solomon Chiu Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 2 +-

[PATCH 05/14] drm/amd/display: Fix 3DLUT skipped programming

2021-10-01 Thread Solomon Chiu
From: Aric Cyr [Why] 3DLUT not updated due to missing condition [How] Check if 3DLUT update is needed Reviewed-by: Anthony Koo Acked-by: Solomon Chiu Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/core/dc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu

[PATCH 04/14] drm/amd/display: Re-arrange FPU code structure for dcn2x

2021-10-01 Thread Solomon Chiu
From: Qingqing Zhuo [Why] Current FPU code for DCN2x is located under dml/dcn2x. This is not aligned with DC's general source tree structure. [How] Move FPU code for DCN2x to dml/dcn20. Reviewed-by: Rodrigo Siqueira Acked-by: Solomon Chiu Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm

[PATCH 03/14] drm/amd/display: Skip override for preferred link settings during link training

2021-10-01 Thread Solomon Chiu
. [How] Since preferred link settings are already considered inside decide_link_settings, skip the check in override_training_settings to avoid infinite link training loops. Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu Signed-off-by: George Shen --- drivers/gpu/drm/amd/display/dc/core

[PATCH 02/14] drm/amd/display: update irq_service and other required change part 2.

2021-10-01 Thread Solomon Chiu
From: Charlene Liu [why] fix NULL pointer in irq_service_dcn201 [how] initialize proper num of irq source for linu Reviewed-by: Sung joon Kim Acked-by: Solomon Chiu Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dc.h| 1 + drivers/gpu/drm/amd/display/dc/dce

[PATCH 01/14] drm/amd/display: Prevent using DMUB rptr that is out-of-bounds

2021-10-01 Thread Solomon Chiu
Acked-by: Solomon Chiu Signed-off-by: Wyatt Wood --- drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1 + drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/dmub_srv.h b/drivers/gpu

[PATCH 00/14] DC Patches October 1, 2021

2021-10-01 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: - New firmware version - Fix DMUB problems on stress test. - Improve link training by skip overrride for preferred link - Refinement of FPU code structure for DCN2 - Fix 3DLUT skipped programming - Fix detection

[PATCH 12/14] drm/amd/display: ensure dentist display clock update finished in DCN20

2021-07-24 Thread Solomon Chiu
DENTIST_DISPCLK_CHG_DONE to ensure display clock has been update to target value before driver do other clock related actions. Reviewed-by: Cyr Aric Acked-by: Solomon Chiu Signed-off-by: Dale Zhao --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 13/14] drm/amd/display: [FW Promotion] Release 0.0.76

2021-07-24 Thread Solomon Chiu
From: Anthony Koo Reviewed-by: Cyr Aric Acked-by: Solomon Chiu Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display

[PATCH 11/14] drm/amd/display: refactor riommu invalidation wa

2021-07-24 Thread Solomon Chiu
From: Eric Yang [Why] A cleaner solution, only done once on boot. [How] Remove previous workaround and configure an extra vmid one time on boot Reviewed-by: Kazlauskas Nicholas Acked-by: Solomon Chiu Signed-off-by: Eric Yang --- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 6

[PATCH 10/14] drm/amd/display: Always wait for update lock status

2021-07-24 Thread Solomon Chiu
From: Eric Bernstein Remove code that would skip wait for lock status for Diags FPGA case Reviewed-by: Laktyushkin Dmytro Acked-by: Solomon Chiu Signed-off-by: Eric Bernstein --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions

[PATCH 14/14] drm/amd/display: 3.2.146

2021-07-24 Thread Solomon Chiu
Mike Acked-by: Solomon Chiu Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 2f3810f0510c..a948f4f48935 100644 --- a/drivers/gpu/drm

[PATCH 08/14] drm/amd/display: add update authentication interface

2021-07-24 Thread Solomon Chiu
are creating a dedicated interface that does the same thing as remove and add back the display without changing DTM state. Acked-by: Solomon Chiu Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 64 +-- .../drm/amd/display/modules/inc/mod_hdcp.h| 11 +++- 2

[PATCH 09/14] drm/amd/display: remove unused functions

2021-07-24 Thread Solomon Chiu
-by: Solomon Chiu Signed-off-by: Wenjing Liu --- .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 4 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 6 --- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 2 - .../display/modules/hdcp/hdcp1_execution.c| 6 --- .../display/modules/hdcp

[PATCH 07/14] drm/amd/display: fix missing reg offset

2021-07-24 Thread Solomon Chiu
From: Eric Yang [Why] Initializing was missing reg offsets for the dmcub test debug registers causing assert [How] Add initialization Reviewed-by: Kazlauskas Nicholas Acked-by: Solomon Chiu Signed-off-by: Eric Yang --- drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 5 - 1 file

[PATCH 04/14] drm/amd/display: Add ETW logging for AUX failures

2021-07-24 Thread Solomon Chiu
From: Wyatt Wood [Why] Would like to identify the cause of AUX transactions failing via ETW logs. [How] Add ETW logging for AUX failures. Reviewed-by: Pavic Josip Acked-by: Solomon Chiu Signed-off-by: Wyatt Wood --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 8 1 file changed

[PATCH 06/14] drm/amd/display: Fixed EdidUtility build errors

2021-07-24 Thread Solomon Chiu
Martin Acked-by: Solomon Chiu Signed-off-by: Mark Morra --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 108 +++-- drivers/gpu/drm/amd/display/dc/dc.h | 118 +++--- drivers/gpu/drm/amd/display/dc/dc_types.h | 81 ++-- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 393

[PATCH 05/14] drm/amd/display: Add ETW log to dmub_psr_get_state

2021-07-24 Thread Solomon Chiu
From: Wyatt Wood [Why] GPINT commands have the lowest priority in DMCUB, so it's possible that the command isn't processed in time. [How] Add a log to help identify this case. Reviewed-by: Koo Anthony Acked-by: Solomon Chiu Signed-off-by: Wyatt Wood --- drivers/gpu/drm/amd/display/dc/dce

[PATCH 03/14] drm/amd/display: Fix PSR command version

2021-07-24 Thread Solomon Chiu
From: Mikita Lipski [why] For dual eDP when setting the new settings we need to set command version to DMUB_CMD_PSR_CONTROL_VERSION_1, otherwise DMUB will not read panel_inst parameter. [how] Instead of PSR_VERSION_1 pass DMUB_CMD_PSR_CONTROL_VERSION_1 Reviewed-by: Wood Wyatt Acked-by: Solomon

[PATCH 01/14] drm/amd/display: Guard DST_Y_PREFETCH register overflow in DCN21

2021-07-24 Thread Solomon Chiu
From: Victor Lu [why] DST_Y_PREFETCH can overflow when DestinationLinesForPrefetch values are too large due to the former being limited to 8 bits. [how] Set the maximum value of DestinationLinesForPrefetch to be 255 * refclk period. Reviewed-by: Laktyushkin Dmytro Acked-by: Solomon Chiu

[PATCH 02/14] drm/amd/display: Add missing DCN21 IP parameter

2021-07-24 Thread Solomon Chiu
From: Victor Lu [why] IP parameter min_meta_chunk_size_bytes is read for bandwidth calculations but it was never defined. [how] Define min_meta_chunk_size_bytes and initialize value to 256. Reviewed-by: Laktyushkin Dmytro Acked-by: Solomon Chiu Signed-off-by: Victor Lu --- drivers/gpu/drm

[PATCH 00/14] DC Patches July 26, 2021

2021-07-24 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Guard DST_Y_PREFETCH register overflow in DCN21 * Add missing DCN21 IP parameter * Fix PSR command version * Add ETW logging for AUX failures * Add ETW log to dmub_psr_get_state * Fixed EdidUtility build errors *

[PATCH 00/14] DC Patches July 26, 2021

2021-07-24 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Guard DST_Y_PREFETCH register overflow in DCN21 * Add missing DCN21 IP parameter * Fix PSR command version * Add ETW logging for AUX failures * Add ETW log to dmub_psr_get_state * Fixed EdidUtility build errors *

[PATCH 14/14] drm/amd/display: 3.2.128

2021-03-19 Thread Solomon Chiu
-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index d163007e057c..55f3c76823d8 100644 --- a/drivers/gpu/drm/amd/display/dc/dc.h +++ b/drivers/gpu

[PATCH 13/14] drm/amd/display: Use pwrseq instance to determine eDP instance

2021-03-19 Thread Solomon Chiu
From: Jake Wang [Why & How] Link index doesn't always correspond to the appropriate eDP instance. We can assume lower link index is a lower eDP instance and set panel control instance accordingly. Signed-off-by: Jake Wang Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo ---

[PATCH 12/14] drm/amd/display: Change input parameter for set_drr

2021-03-19 Thread Solomon Chiu
-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ++--- .../display/dc/dce110/dce110_hw_sequencer.c | 9 ++--- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 14 +++ .../amd/display/dc/dcn10/dcn10_hw_sequencer.h | 3 +- .../gpu/drm/amd/display/dc/inc/hw_sequencer.h

[PATCH 11/14] drm/amd/display: [FW Promotion] Release 0.0.57

2021-03-19 Thread Solomon Chiu
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd

[PATCH 10/14] drm/amd/display: Fix UBSAN: shift-out-of-bounds warning

2021-03-19 Thread Solomon Chiu
Laktyushkin Reviewed-by: Jun Lei Acked-by: Solomon Chiu --- .../dc/dml/dcn20/display_rq_dlg_calc_20.c | 28 +++ .../dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 28 +++ .../dc/dml/dcn21/display_rq_dlg_calc_21.c | 28 +++ .../

[PATCH 09/14] drm/amd/display: Fixed Clock Recovery Sequence

2021-03-19 Thread Solomon Chiu
is requested for either voltage swing or pre-emphasis. Signed-off-by: Calvin Hou Signed-off-by: David Galiffi Reviewed-by: Jun Lei Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH 08/14] drm/amd/display: Deallocate IRQ handlers on amdgpu_dm_irq_fini

2021-03-19 Thread Solomon Chiu
From: Victor Lu [why] The amdgpu_dm IRQ handlers are not freed during the IRQ teardown. [how] Add function to deallocate IRQ handlers on amdgpu_dm_irq_fini step. Signed-off-by: Victor Lu Reviewed-by: Roman Li Acked-by: Solomon Chiu --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 51

[PATCH 06/14] drm/amd/display: Fix debugfs link_settings entry

2021-03-19 Thread Solomon Chiu
From: Fangzhi Zuo 1. Catch invalid link_rate and link_count settings 2. Call dc interface to overwrite preferred link settings, and wait until next stream update to apply the new settings. Signed-off-by: Fangzhi Zuo Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- .../drm/amd

[PATCH 07/14] drm/amd/display: revert max lb use by default for n10

2021-03-19 Thread Solomon Chiu
From: Dmytro Laktyushkin This is causing a pstate change underflow regression for unknown reason Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 2 -- drivers/gpu/drm/amd/display/dc/dcn20

[PATCH 04/14] drm/amd/display: revert max lb lines change

2021-03-19 Thread Solomon Chiu
From: Dmytro Laktyushkin Some hardware revisions do have a max number of lines limitation not honouring which can cause pstate switch underflow. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c

[PATCH 03/14] drm/amd/display: Add kernel doc to crc_rd_wrk field

2021-03-19 Thread Solomon Chiu
Lin Reviewed-by: Rodrigo Siqueira Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h index 2c9eed78f6df

[PATCH 05/14] drm/amd/display: Log DMCUB trace buffer events

2021-03-19 Thread Solomon Chiu
m DMCUB FW. Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Harry Wentland Acked-by: Solomon Chiu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 48 +++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 9 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 12 - .../drm/a

[PATCH 02/14] drm/amd/display: hide VGH asic specific structs

2021-03-19 Thread Solomon Chiu
From: Dmytro Laktyushkin The pmfw structs are specific to the asic and should not be present in base clk_mgr struct Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Yang Acked-by: Solomon Chiu --- .../gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 116 +- .../display/dc

[PATCH 01/14] drm/amd/display: Populate socclk entries for dcn2.1

2021-03-19 Thread Solomon Chiu
From: Roman Li [Why] Dcn2.1 socclk entries in bandwidth params are not initialized. They are not used now, but will be needed for dml validation. [How] Populate socclk bw params from dpm clock table Signed-off-by: Roman Li Reviewed-by: Dmytro Laktyushkin Acked-by: Solomon Chiu --- .../drm

[PATCH 00/14] DC Patches March 22, 2021

2021-03-19 Thread Solomon Chiu
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Populate socclk entries for dcn2.1 * hide VGH asic specific structs * Add kernel doc to crc_rd_wrk field * revert max lb lines change * Log DMCUB trace buffer events * Fix debugfs link_settings entry * revert

[PATCH 23/23] drm/amd/display: Fix potential memory leak

2021-03-15 Thread Solomon Chiu
From: Qingqing Zhuo [Why] vblank_workqueue is never released. [How] Free it upon dm finish. Signed-off-by: Qingqing Zhuo Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 22/23] drm/amd/display: add a func to disable accelerated mode

2021-03-15 Thread Solomon Chiu
should to be 1 again, but dmub fw can’t update the register to 1 due to the mpll is not off [How] Adds an interface to disable accelerated mode bit, which allows DM to decide to call during driver disable/unload scenarios. Signed-off-by: Yao Wang1 Reviewed-by: Anthony Koo Acked-by: Solomon Chiu

[PATCH 21/23] drm/amd/display: fix dcn3+ bw validation soc param update sequence

2021-03-15 Thread Solomon Chiu
From: Dmytro Laktyushkin SOC needs to be updated to the WM set A values before validation happens. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 17 - .../drm/amd/display/dc/dcn30

[PATCH 20/23] drm/amd/display: fix dml prefetch validation

2021-03-15 Thread Solomon Chiu
From: Dmytro Laktyushkin Incorrect variable used, missing initialization during validation. Signed-off-by: Dmytro Laktyushkin Reviewed-by: Eric Bernstein Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dml/dcn20/display_mode_vba_20.c | 1 + drivers/gpu/drm/amd/display/dc/dml

[PATCH 19/23] drm/amd/display: 3.2.127

2021-03-15 Thread Solomon Chiu
From: Aric Cyr Signed-off-by: Aric Cyr Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index d26472ef1572

[PATCH 18/23] drm/amd/display: DCHUB underflow counter increasing in some scenarios

2021-03-15 Thread Solomon Chiu
Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn30

[PATCH 17/23] drm/amd/display: [FW Promotion] Release 0.0.56

2021-03-15 Thread Solomon Chiu
From: Anthony Koo More updates to the comments to better describe the function of different cmds and parameters in the dmub interface. Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 668 ++ 1 file

[PATCH 16/23] drm/amd/display: Add debugfs to control DMUB trace buffer events

2021-03-15 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [Why] We want to have a debugfs interface to enable or disable DMCUB trace buffer events. [How] Add debugfs interface to enable or disable trace buffer events. Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Harry Wentland Acked-by: Solomon Chiu --- .../g

[PATCH 15/23] drm/amd/display: Separate caps for maximum RGB and YUV plane counts

2021-03-15 Thread Solomon Chiu
From: Atufa Khan Not all ASICs have same plane capabilities so need to split them out for proper support handling. Signed-off-by: Atufa Khan Reviewed-by: Aric Cyr Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc.h | 2 ++ drivers/gpu/drm/amd/display/dc/dce110

[PATCH 14/23] drm/amd/display: Fix no previous prototype warning

2021-03-15 Thread Solomon Chiu
5580 #endif 5581 [How] Fix it with declaration as "static" Reported-by: kernel test robot Signed-off-by: Wayne Lin Reviewed-by: Rodrigo Siqueira Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 13/23] drm/amd/display: Fix secure display lock problems

2021-03-15 Thread Solomon Chiu
] Fix above problems. Signed-off-by: Wayne Lin Reviewed-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 10 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6 ++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 12/23] drm/amd/display: Fix typo for helpers function name

2021-03-15 Thread Solomon Chiu
From: "Leo (Hanghong) Ma" [why] Word "helper" was misspelled as "helpes" in dm_helpes_dmub_outbox0_interrupt_control function. [how] Fix the spelling. Signed-off-by: Leo (Hanghong) Ma Reviewed-by: Yongqiang Sun Acked-by: Solomon Chiu --- drivers

[PATCH 11/23] drm/amd/display: Remove MPC gamut remap logic for DCN30

2021-03-15 Thread Solomon Chiu
ked-by: Solomon Chiu --- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 34 ++- 1 file changed, 2 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c index 0d3c7e42204f..6a10daec15cc 100

[PATCH 10/23] drm/amd/display: Correct algorithm for reversed gamma

2021-03-15 Thread Solomon Chiu
From: Calvin Hou [Why] DCN30 needs to correctly program reversed gamma curve, which DCN20 already has. Also needs to fix a bug that 252-255 values are clipped. [How] Apply two fixes into DCN30. Signed-off-by: Calvin Hou Reviewed-by: Jun Lei Reviewed-by: Krunoslav Kovac Acked-by: Solomon

[PATCH 09/23] drm/amd/display: Add changes for dsc bpp in 16ths and unify bw calculations

2021-03-15 Thread Solomon Chiu
inputs in 16ths of a bit. Use dc function to calculate bandwidth from timing, and make dsc bw calculation a part of dsc.c. Signed-off-by: Dillon Varone Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 9 +- drivers/gpu/drm/amd/display/dc/dc_dsc.h

[PATCH 08/23] drm/amd/display: Increase precision for bpp in DSC calculations

2021-03-15 Thread Solomon Chiu
From: Jun Lei [Why?] Many DSC variables and related functions use whole bits for bpp. [How?] Change variables and related functions to use 16ths of a bit for bpp. Signed-off-by: Dillon Varone Reviewed-by: Wenjing Liu Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/dc_hw_types.h

[PATCH 07/23] drm/amd/display: Bypass sink detect when there are no eDPs connected

2021-03-15 Thread Solomon Chiu
From: Jake Wang [How & Why] Check DC config to determine if there are any eDPs connected. If there are no eDPs connected, bypass sink detect when querying eDP presence. Signed-off-by: Jake Wang Reviewed-by: Nicholas Kazlauskas Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dc/

[PATCH 06/23] drm/amd/display: Fix for outbox1 ring buffer typecasting issue

2021-03-15 Thread Solomon Chiu
masundaram Reviewed-by: Jun Lei Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c b/drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c index 1ee2000ad099..8ba0a9e2d

[PATCH 05/23] drm/amd/display: Fix UBSAN warning for not a valid value for type '_Bool'

2021-03-15 Thread Solomon Chiu
update before calling get_cursor_position. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1471 Reported-by: Lyude Paul Signed-off-by: Anson Jacob Reviewed-by: Aurabindo Jayamohanan Pillai Acked-by: Solomon Chiu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +- 1 file chan

  1   2   >