[PATCH v2] drm/ttm: Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-06 Thread Somalapuram Amaranath
, mem_type to res_start, res_end, res_type. Change the unsigned to u64. Fix the dependence in all the DRM drivers and clean up PAGE_SHIFT operation. v1 -> v2: fix the bug reviewed by Michel, addressing Stanislaw missing justification. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/

[PATCH] Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-02 Thread Somalapuram Amaranath
Change the ttm_place structure member fpfn, lpfn, mem_type to res_start, res_end, res_type. Change the unsigned to u64. Fix the dependence in all the DRM drivers and clean up PAGE_SHIFT operation. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 11

[PATCH 6/6] drm/amdgpu: Cleanup the GDS, GWS and OA allocations

2023-02-08 Thread Somalapuram Amaranath
Change the size of GDS, GWS and OA from pages to bytes. The initialized gds_size, gws_size and oa_size in bytes, remove PAGE_SHIFT in amdgpu_ttm_init_on_chip(). : Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 12 ++-- drivers/gpu/drm/amd/amdgpu

[PATCH 5/6] drm/ttm: Change the meaning of the fields in the drm_mm_nodes structure from pfn to bytes

2023-02-08 Thread Somalapuram Amaranath
Change the ttm_range_man_alloc() allocation from pages to size in bytes. Fix the dependent drm_mm_nodes start and size from pages to bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/i915_scatterlist.c | 6 +++--- drivers/gpu/drm/ttm/ttm_range_manager.c | 15

[PATCH 4/6] drm/ttm: Change the parameters of ttm_range_man_init() from pages to bytes

2023-02-08 Thread Somalapuram Amaranath
Change the parameters of ttm_range_man_init_nocheck() size from page size to byte size. Cleanup the PAGE_SHIFT operation on the depended caller functions. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/drm_gem_vram_helper.c | 2

[PATCH 3/6] drm/ttm: Change the meaning of resource->start from pfn to bytes

2023-02-08 Thread Somalapuram Amaranath
tart. Change amdgpu_gtt_mgr_new() allocation from pfn to bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 13 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor

[PATCH 2/6] drm/amdgpu: Remove TTM resource->start visible VRAM condition

2023-02-08 Thread Somalapuram Amaranath
Use amdgpu_bo_in_cpu_visible_vram() instead. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

[PATCH 1/6] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-02-08 Thread Somalapuram Amaranath
ttm_resource can allocate size in bytes to support less than page size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 59a0bb5ebd85..ee8b5c2b6c60 100644

[PATCH v4 4/4] drm/amdgpu: Cleanup PAGE_SHIFT operation

2023-01-25 Thread Somalapuram Amaranath
Cleaning up page shift operations. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index a97e8236bde9

[PATCH v4 3/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. Change the GTT manager init and allocate from pages to bytes v1 -> v2: reorder patch sequence v3 -> v4: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/g

[PATCH v4 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_mana

[PATCH v4 1/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 v3 -> v4: addressing review comment v3 Signed-off-by: Somalapuram Amaranath --- drivers

[PATCH v3 4/4] drm/amdgpu: Support allocate of amdgpu_gtt_mgr from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
Change the GTT manager init and allocate from pages to bytes v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH v3 3/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 8 1 file changed, 4 insertions(+), 4 deleti

[PATCH v3 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_mana

[PATCH v3 1/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence v2 -> v3: addressing review comment v2 Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +++-

[PATCH v2 4/4] drm/amdgpu: Support allocate of amdgpu_gtt_mgr from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
Change the GTT manager init and allocate from pages to bytes v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH v2 2/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 - 1 file changed, 4 insertions

[PATCH v2 3/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 8 1 file changed, 4 insertions(+), 4 deleti

[PATCH v2 1/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. v1 -> v2: reorder patch sequence Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH v4 4/4] drm/i915: Clean up page shift operation

2023-01-25 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/i915_scatterlist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scatterlist.c b

[PATCH v4 3/4] drm/amdgpu: GDS/GWS/OA cleanup the page shift operation

2023-01-25 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 – v4: adding missing related to amdgpu_ttm_init_on_chip Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 12 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

[PATCH v4 2/4] drm/ttm: Clean up page shift operation

2023-01-25 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn v2 -> v3: separate patches based on driver module Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_range_manager.c | 13 ++

[PATCH v4 1/4] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-01-25 Thread Somalapuram Amaranath
ttm_resource can allocate size in bytes to support less than page size Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 59a0bb5ebd85..ee8b5c2b6c60 100644

[PATCH 4/4] drm/amdkfd: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 3/4] drm/amdgpu: Use cursor start instead of ttm resource start

2023-01-25 Thread Somalapuram Amaranath
cleanup PAGE_SHIFT operation and replacing ttm_resource resource->start with cursor start using amdgpu_res_first API. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 10 +++--- 2 files chan

[PATCH 2/4] drm/amdgpu: Support allocate of amdgpu_gtt_mgr from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
Change the GTT manager init and allocate from pages to bytes Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd

[PATCH 1/4] drm/amdgpu: Movie the amdgpu_gtt_mgr start and size from pages to bytes

2023-01-25 Thread Somalapuram Amaranath
To support GTT manager amdgpu_res_first, amdgpu_res_next from pages to bytes and clean up PAGE_SHIFT operation. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v3 4/4] drm/i915: Clean up page shift operation

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/i915_scatterlist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_scatterlist.c b

[PATCH v3 3/4] drm/amdgpu: Clean up page shift operation and GWS and OA

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 12 ++-- 2 files changed, 7 insertions(+), 9

[PATCH v3 1/4] drm/ttm: Clean up page shift operation

2023-01-10 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn v2 -> v3: separate patch’s based on driver module Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_range_manager.c | 13 ++

[PATCH v3 2/4] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-01-10 Thread Somalapuram Amaranath
ttm_resource allocate size in bytes to support less than page size Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 59a0bb5ebd85..ee8b5c2b6c60 100644 --- a/drivers

[PATCH v1] drm/ttm: Clean up page shift operation

2022-11-21 Thread Somalapuram Amaranath
Remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. v1 -> v2: fix missing page shift to fpfn and lpfn Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c|

Re: [PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-21 Thread Somalapuram, Amaranath
On 11/16/2022 2:50 PM, Arunpravin Paneer Selvam wrote: Hi Amar, On 11/16/2022 2:20 PM, Somalapuram Amaranath wrote: ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/drm_gem.c | 2 +-   1 file changed, 1 insertion(+), 1

[PATCH 2/2] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2022-11-16 Thread Somalapuram Amaranath
ttm_resource allocate size in bytes i.e less than page size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index b8db675e7fb5..a346e3b7f9a8 100644

[PATCH 1/2] drm/ttm: Clean up page shift operation

2022-11-16 Thread Somalapuram Amaranath
remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c| 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff

[PATCH v3] drm/ttm: rework on ttm_resource to use size_t type

2022-10-27 Thread Somalapuram Amaranath
() v2 -> v3: adding missing PFN_UP in ttm_bo_vm_fault_reserved Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 4 ++-- drivers/gpu

[PATCH v2] drm/ttm: rework on ttm_resource to use size_t type

2022-10-25 Thread Somalapuram Amaranath
smaller_first() Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- drivers/gpu/drm/amd/amdg

[PATCH 6/6] drm/vmwgfx: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c| 6 +++--- drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 2 +- drivers/gpu/drm/vmwgfx

[PATCH 5/6] drm/radeon: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/radeon/radeon_cs.c | 4 ++-- drivers/gpu/drm/radeon/radeon_object.c | 4 ++-- drivers/gpu/drm/radeon/radeon_trace.h | 2 +- drivers/gpu/drm/radeon/radeon_ttm.c| 4 ++-- 4 files

[PATCH 4/6] drm/nouveau: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo0039.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo5039.c | 2 +- drivers/gpu/drm/nouveau/nouveau_bo74c1.c | 2

[PATCH 3/6] drm/i915: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- drivers/gpu/drm/i915/i915_scatterlist.c | 4 ++-- drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 12 ++-- drivers/gpu/drm/i915

[PATCH 2/6] drm/amd: fix’s on ttm_resource rework to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Fix the ttm_resource from num_pages to size_t size. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 4 ++-- drivers/gpu/drm/amd/amdgpu

[PATCH 1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-19 Thread Somalapuram Amaranath
Change ttm_resource structure from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/ttm/ttm_bo.c| 4 ++-- drivers/gpu/drm/ttm/ttm_bo_util.c | 6 +++--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm

Re: [PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-08 Thread Somalapuram, Amaranath
On 8/2/2022 7:25 PM, Shashank Sharma wrote: This patch adds: - A new input parameter "flags" in the amdgpu_ctx_create2 call. - Some new flags defining workload type hints. - Some change in the caller function of amdgpu_ctx_create2, to accomodate this new parameter. The idea is to pass the

Re: [PATCH -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-07-15 Thread Somalapuram, Amaranath
On 7/14/2022 9:13 PM, André Almeida wrote: Às 12:06 de 14/07/22, Sebin Sebastian escreveu: On Tue, Jul 12, 2022 at 12:14:27PM -0300, André Almeida wrote: Hi Sebin, Às 10:29 de 10/07/22, Sebin Sebastian escreveu: Fix two coverity warning's double free and and an uninitialized pointer read.

[PATCH v3 2/2] drm/amdgpu: adding device coredump support

2022-06-02 Thread Somalapuram Amaranath
sk_info to zero v2 -> v3: add CONFIG_DEV_COREDUMP for variables v2 -> v3: remove NULL check on amdgpu_devcoredump_read Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 5 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 64 ++

[PATCH v3 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-06-02 Thread Somalapuram Amaranath
Allocate memory for register value and use the same values for devcoredump. v1 -> v2: Change krealloc_array() to kmalloc_array() v2 -> v3: Fix alignment Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs

Re: [PATCH v2 2/2] drm/amdgpu: adding device coredump support

2022-05-31 Thread Somalapuram, Amaranath
On 5/26/2022 3:56 PM, Wang, Yang(Kevin) wrote: [AMD Official Use Only - General] *From:* amd-gfx on behalf of Somalapuram Amaranath *Sent:* Thursday, May 26, 2022 5:48 PM *To:* amd-gfx@lists.freedesktop.org *Cc

Re: [PATCH v2 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-31 Thread Somalapuram, Amaranath
On 5/26/2022 3:24 PM, Sharma, Shashank wrote: Hey Amar, On 5/26/2022 11:48 AM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump. v1 -> V2: Change krealloc_array() to kmalloc_array() Signed-off-by: Somalapuram Amaranath ---   driv

[PATCH v2 2/2] drm/amdgpu: adding device coredump support

2022-05-26 Thread Somalapuram Amaranath
sk_info to zero Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67 ++ 2 files changed, 70 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu

[PATCH v2 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-26 Thread Somalapuram Amaranath
Allocate memory for register value and use the same values for devcoredump. v1 -> V2: Change krealloc_array() to kmalloc_array() Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 7 +++ drivers/gpu/

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Somalapuram, Amaranath
On 5/24/2022 8:34 PM, Sharma, Shashank wrote: On 5/24/2022 3:18 PM, Somalapuram, Amaranath wrote: On 5/24/2022 6:20 PM, Sharma, Shashank wrote: On 5/24/2022 2:10 PM, Somalapuram, Amaranath wrote: On 5/24/2022 3:23 PM, Sharma, Shashank wrote: On 5/24/2022 8:42 AM, Somalapuram

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Somalapuram, Amaranath
On 5/24/2022 6:20 PM, Sharma, Shashank wrote: On 5/24/2022 2:10 PM, Somalapuram, Amaranath wrote: On 5/24/2022 3:23 PM, Sharma, Shashank wrote: On 5/24/2022 8:42 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:52 PM, Sharma, Shashank wrote: On 5/20/2022 3:49 PM, Somalapuram

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Somalapuram, Amaranath
On 5/24/2022 3:23 PM, Sharma, Shashank wrote: On 5/24/2022 8:42 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:52 PM, Sharma, Shashank wrote: On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty

Re: [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-24 Thread Somalapuram, Amaranath
On 5/24/2022 3:25 PM, Sharma, Shashank wrote: On 5/24/2022 8:12 AM, Somalapuram, Amaranath wrote: On 5/20/2022 7:36 PM, Sharma, Shashank wrote: Hey Amar, On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump

Re: [PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-24 Thread Somalapuram, Amaranath
On 5/20/2022 7:52 PM, Sharma, Shashank wrote: On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm

Re: [PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-24 Thread Somalapuram, Amaranath
On 5/20/2022 7:36 PM, Sharma, Shashank wrote: Hey Amar, On 5/20/2022 3:49 PM, Somalapuram Amaranath wrote: Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd

[PATCH v1 2/2] drm/amdgpu: adding device coredump support

2022-05-20 Thread Somalapuram Amaranath
Added device coredump information: - Kernel version - Module - Time - VRAM status - Guilty process name and PID - GPU register dumps Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 59

[PATCH v1 1/2] drm/amdgpu: save the reset dump register value for devcoredump

2022-05-20 Thread Somalapuram Amaranath
Allocate memory for register value and use the same values for devcoredump. Remove dump_stack reset register dumps. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 9 - drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: schedule GPU reset event work function

2022-03-10 Thread Somalapuram Amaranath
Schedule work function with valid PID, process name and vram lost status during a GPU reset/recovery. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Re: [PATCH 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-08 Thread Somalapuram, Amaranath
On 3/8/2022 10:00 PM, Sharma, Shashank wrote: Hello Andrey On 3/8/2022 5:26 PM, Andrey Grodzovsky wrote: On 2022-03-07 11:26, Shashank Sharma wrote: From: Shashank Sharma This patch adds a work function, which will get scheduled in event of a GPU reset, and will send a uevent to user with

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Somalapuram, Amaranath
of Andrey Grodzovsky *Sent:* Tuesday, March 8, 2022 9:55:03 PM *To:* Shashank Sharma ; amd-gfx@lists.freedesktop.org *Cc:* Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian ; Sharma, Shashank *Subject:* Re: [PATCH 1/2] drm: Add GPU reset sysfs event On 2022-03-07 11:26

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Somalapuram, Amaranath
On 3/8/2022 5:26 PM, Sharma, Shashank wrote: On 3/8/2022 11:32 AM, Christian König wrote: Am 08.03.22 um 10:31 schrieb Sharma, Shashank: On 3/8/2022 8:06 AM, Christian König wrote: Am 07.03.22 um 17:26 schrieb Shashank Sharma: From: Shashank Sharma This patch adds a new sysfs event,

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-07 Thread Somalapuram, Amaranath
On 3/7/2022 9:56 PM, Shashank Sharma wrote: From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - which PID was involved in the GPU reset - what was the GPU status (using flags) This patch

Re: [PATCH 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-07 Thread Somalapuram, Amaranath
On 3/7/2022 9:56 PM, Shashank Sharma wrote: From: Shashank Sharma This patch adds a work function, which will get scheduled in event of a GPU reset, and will send a uevent to user with some reset context infomration, like a PID and some flags. The userspace can do some recovery and

[PATCH v13 2/2] drm/amdgpu: add reset register dump trace on GPU

2022-02-22 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 33 insertions(+) diff --git a/drivers/gpu

[PATCH v13 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-22 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 82 + 2 files changed, 86 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v12 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-22 Thread Somalapuram, Amaranath
On 2/22/2022 9:08 PM, Christian König wrote: Am 22.02.22 um 16:34 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  4 +   drivers/gpu/drm/amd/amdgpu

[PATCH v12 2/2] drm/amdgpu: add reset register dump trace on GPU

2022-02-22 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 33 insertions(+) diff --git a/drivers/gpu

[PATCH v12 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-22 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 83 + 2 files changed, 87 insertions(+) diff --git a/drivers/gpu

[PATCH v11 2/2] drm/amdgpu: add reset register dump trace on GPU

2022-02-22 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 33 insertions(+) diff --git a/drivers/gpu

[PATCH v11 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-22 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 81 + 2 files changed, 85 insertions(+) diff --git a/drivers/gpu

[PATCH v10 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-22 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 32 insertions(+) diff --git a/drivers/gpu

[PATCH v10 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-22 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 92 + 2 files changed, 96 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 7:58 PM, Christian König wrote: Am 21.02.22 um 15:19 schrieb Somalapuram, Amaranath: [AMD Official Use Only] On 2/21/2022 7:09 PM, Christian König wrote: Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: List of register populated for dump collection

Re: [PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 7:09 PM, Christian König wrote: > > > Am 21.02.22 um 14:34 schrieb Somalapuram Amaranath: >> List of register populated for dump collection during the GPU reset. >> >> Signed-off-by: Somalapuram Amaranath >> --- >>

[PATCH v9 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-21 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 32 insertions(+) diff --git a/drivers/gpu

[PATCH v9 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 96 + 2 files changed, 100 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-21 Thread Somalapuram, Amaranath
[AMD Official Use Only] On 2/21/2022 2:45 PM, Christian König wrote: > > > Am 21.02.22 um 08:15 schrieb Somalapuram Amaranath: >> List of register populated for dump collection during the GPU reset. >> >> Signed-off-by: Somalapuram Amaranath >> --- >>

[PATCH v8 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-20 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 30 insertions(+) diff --git a/drivers/gpu

[PATCH v8 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-20 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 114 2 files changed, 118 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v7 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-17 Thread Somalapuram, Amaranath
On 2/17/2022 8:36 PM, Christian König wrote: Am 17.02.22 um 15:29 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |   4 +   drivers/gpu/drm/amd/amdgpu

[PATCH v7 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-17 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 30 insertions(+) diff --git a/drivers/gpu

[PATCH v7 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-17 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 112 2 files changed, 116 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram, Amaranath
On 2/16/2022 8:26 PM, Christian König wrote: Am 16.02.22 um 14:11 schrieb Somalapuram, Amaranath: On 2/16/2022 3:41 PM, Christian König wrote: Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off

Re: [PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram, Amaranath
On 2/16/2022 6:47 PM, Lazar, Lijo wrote: On 2/16/2022 4:39 PM, Somalapuram, Amaranath wrote: On 2/16/2022 4:13 PM, Lazar, Lijo wrote: On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote: On 2/16/2022 3:45 PM, Lazar, Lijo wrote: On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote

Re: [PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram, Amaranath
On 2/16/2022 3:41 PM, Christian König wrote: Am 16.02.22 um 10:49 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  5 ++   drivers/gpu/drm/amd/amdgpu

Re: [PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram, Amaranath
On 2/16/2022 4:13 PM, Lazar, Lijo wrote: On 2/16/2022 4:04 PM, Somalapuram, Amaranath wrote: On 2/16/2022 3:45 PM, Lazar, Lijo wrote: On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram

Re: [PATCH v4 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-16 Thread Somalapuram, Amaranath
On 2/15/2022 10:09 PM, Andrey Grodzovsky wrote: On 2022-02-15 05:12, Somalapuram Amaranath wrote: Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 -   drivers/gpu/drm/amd

Re: [PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram, Amaranath
On 2/16/2022 3:45 PM, Lazar, Lijo wrote: On 2/16/2022 3:19 PM, Somalapuram Amaranath wrote: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  5 ++   drivers/gpu/drm/amd/amdgpu

[PATCH v6 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-16 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 34 insertions(+), 1 deletion(-) diff

[PATCH v6 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-16 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 + 2 files changed, 100 insertions(+) diff --git a/drivers/gpu

[PATCH v5 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-15 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 + 2 files changed, 99 insertions(+) diff --git a/drivers/gpu

[PATCH v5 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-15 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 95 + 2 files changed, 99 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v4 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-15 Thread Somalapuram, Amaranath
On 2/15/2022 3:46 PM, Christian König wrote: Am 15.02.22 um 11:12 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  4 +   drivers/gpu/drm/amd/amdgpu

[PATCH v4 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-15 Thread Somalapuram Amaranath
List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 89 + 2 files changed, 93 insertions(+) diff --git a/drivers/gpu

[PATCH v4 2/2] drm/amdgpu: add reset register dump trace on GPU reset

2022-02-15 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 32 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 1/2] drm/amdgpu: add debugfs for reset registers list

2022-02-14 Thread Somalapuram, Amaranath
On 2/14/2022 2:59 PM, Christian König wrote: Am 14.02.22 um 10:16 schrieb Somalapuram Amaranath: List of register populated for dump collection during the GPU reset. Signed-off-by: Somalapuram Amaranath ---   drivers/gpu/drm/amd/amdgpu/amdgpu.h |  4 ++   drivers/gpu/drm/amd/amdgpu

[PATCH v3 2/2] drm/amdgpu: add reset register dump trace function on GPU reset

2022-02-14 Thread Somalapuram Amaranath
Dump the list of register values to trace event on GPU reset. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 32 insertions(+), 1 deletion(-) diff

  1   2   >