[PATCH] drm/amd/display: Remove duplicate header.

2022-07-07 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" kernel test robot throws below warning -> includecheck warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/display/dc/os_types.h: drm/drm_print.h is included more than once. Remove duplicate header. Reported-by: kernel test robot

[PATCH] drm/amd/display: Removed unused variable ret

2022-06-27 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function 'dc_link_reduce_mst_payload': drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3782:32: warning: variable 'ret

[PATCH] drm/amd/display: Remove unused variable 'abo'

2022-06-18 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9143:27: warning: variable 'abo' set but not used [-Wunused-but-set-variable] Remove the unused variable. Reported-by: Kernel test robot

Re: [linux-next:master] BUILD REGRESSION 6d0c806803170f120f8cb97b321de7bd89d3a791

2022-06-13 Thread Souptick Joarder
On Sat, Jun 11, 2022 at 2:16 AM kernel test robot wrote: > > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 6d0c806803170f120f8cb97b321de7bd89d3a791 Add linux-next > specific files for 20220610 > > Error/Warning reports: > > https://lore

[PATCH] drm/amdgpu: Initialize value of r in amdgpu_fill_buffer()

2022-02-18 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot reported warning -> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2129:2: warning: Undefined or garbage value returned to caller [clang-analyzer-core. uninitialized.UndefReturn] Initialize r inside amdgpu_fill_buffer(). Reported-by: kern

Re: [PATCH] drm/amdgpu: Added missing prototype

2021-04-26 Thread Souptick Joarder
On Sat, Apr 24, 2021 at 5:03 AM Felix Kuehling wrote: > > Am 2021-04-23 um 5:39 p.m. schrieb Souptick Joarder: > > Kernel test robot throws below warning -> > > > >>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:125:5: warning: > >>> no previ

[PATCH v2] drm/amdgpu: Added missing prototype

2021-04-26 Thread Souptick Joarder
vers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c:246:5: warning: >> no previous prototype for 'kgd_arcturus_hqd_sdma_destroy' >> [-Wmissing-prototypes] 246 | int kgd_arcturus_hqd_sdma_destroy(struct kgd_dev *kgd, void *mqd, | ^~~~~ Added prototype

[PATCH] drm/amdgpu: Added missing prototype

2021-04-23 Thread Souptick Joarder
| ^ Added prototype for these functions. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/

[PATCH] drm/amd/display: Remove condition which is always set to True

2021-04-23 Thread Souptick Joarder
if (!(aconnector->port && &aconnector->mst_port->mst_mgr)) ~~ ~~^~~ Remove the condition which is always set to True. Reported-by: kernel test robot Signed-off-by: Souptick Joarder ---

[PATCH] drm/amdgpu: Mark mmhub_v1_7_setup_vm_pt_regs() as static

2021-03-13 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c:56:6: warning: no previous prototype for 'mmhub_v1_7_setup_vm_pt_regs' [-Wmissing-prototypes] Mark mmhub_v1_7_setup_vm_pt_regs() as static. Reported-by: kernel test robot Signed-off-by: Sou

[PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Souptick Joarder
^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9714:7: note: initialize the variable 'i' to silence this warning int i; ^ = 0 1 warning generated. Initialize the variable 'i'. Reported-by: kernel te

[PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static

2021-01-12 Thread Souptick Joarder
prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes] Mark vangogh_clk_dpm_is_enabled() as static. Reported-by: kernel test robot Signed-off-by: Souptick Joarder --- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH linux-next] drm/amd/display: Adding prototype for dccg21_update_dpp_dto()

2020-12-14 Thread Souptick Joarder
Kernel test robot throws below warning -> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_dccg.c:46:6: warning: no previous prototype for 'dccg21_update_dpp_dto' [-Wmissing-prototypes] Adding prototype for dccg21_update_dpp_dto(). Reported-by: kernel test robot Signed-off

[PATCH] drm/amd/display: Fixed kernel test robot warning

2020-12-11 Thread Souptick Joarder
m/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5373:5: warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes] As these functions are only used inside amdgpu_dm.c, these can be made static. Reported-by: kernel test robot Signed-off-by: Souptic

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-06-08 Thread Souptick Joarder
On Fri, May 29, 2020 at 12:58 PM John Hubbard wrote: > > On 2020-05-28 23:49, Souptick Joarder wrote: > ... > >> This is what case 3 was *intended* to cover, but it looks like case 3 > >> needs to > >> be written a little better. I'll attempt that, and

Re: [PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread Souptick Joarder
On Thu, May 28, 2020 at 12:37 AM John Hubbard wrote: > > On 2020-05-27 01:51, Daniel Vetter wrote: > > On Wed, May 27, 2020 at 10:48:52AM +0200, Daniel Vetter wrote: > >> On Tue, May 26, 2020 at 03:57:45PM -0700, John Hubbard wrote: > >>> On 2020-05-26 14:00, So

[PATCH] drm/radeon: Convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread Souptick Joarder
ically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/ Signed-off-by: Souptick

Re: [PATCH v2 hmm 10/11] mm/hmm: Do not use list*_rcu() for hmm->ranges

2019-06-10 Thread Souptick Joarder
On Fri, Jun 7, 2019 at 12:15 AM Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > This list is always read and written while holding hmm->lock so there is > no need for the confusing _rcu annotations. > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Jérôme

Re: [PATCH v2 hmm 07/11] mm/hmm: Use lockdep instead of comments

2019-06-10 Thread Souptick Joarder
On Fri, Jun 7, 2019 at 12:15 AM Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > So we can check locking at runtime. Little more descriptive change log would be helpful. Acked-by: Souptick Joarder > > Signed-off-by: Jason Gunthorpe > Reviewed-by: Jérôme Glisse >

Re: [PATCH] drm/amd/powerplay: Remove duplicate header

2018-12-21 Thread Souptick Joarder
On Fri, Dec 21, 2018 at 2:49 PM Brajeswar Ghosh wrote: > > Remove hwmgr_ppt.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- Acked-by: Souptick Joarder > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 - > 1 file changed, 1 deletion(-) > &g

Re: [PATCH] drm/amd/display: Remove duplicate header

2018-12-19 Thread Souptick Joarder
On Wed, Dec 19, 2018 at 1:27 PM Brajeswar Ghosh wrote: > > Remove custom_float.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- Acked-by: Souptick Joarder > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 - > 1 file changed, 1