RE: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10

2020-05-12 Thread Tao, Yintian
Ping... -Original Message- From: Yintian Tao Sent: 2020年5月12日 18:17 To: Deucher, Alexander ; Liu, Monk ; Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amdgpu: turn back rlcg write for gfx_v10 There is no need to use amdgpu_mm_wreg_mmio_rlc

RE: [PATCH] drm/amdgpu: protect ring overrun

2020-04-23 Thread Tao, Yintian
Hi Christian Thanks. I will remove the initialization of r. Best Regards Yintian Tao -Original Message- From: Christian König Sent: 2020年4月23日 20:22 To: Tao, Yintian ; Koenig, Christian ; Liu, Monk ; Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH 2/2] drm/amdgpu: drop the unused local variable

2020-04-23 Thread Tao, Yintian
Hi Hawking Can you help also remove the same local variable kiq for gfx_v10_0_ring_emit_rreg? Thanks in advance. After that , Reviewed-by: Yintian Tao Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Hawking Zhang Sent: 2020年4月23日 17:02 To:

RE: [PATCH 1/8] drm/amdgpu: ignore TA ucode for SRIOV

2020-04-23 Thread Tao, Yintian
Series is Acked-by: Yintian Tao -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: 2020年4月23日 15:02 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH 1/8] drm/amdgpu: ignore TA ucode for SRIOV Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c

RE: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Tao, Yintian
Sent: 2020年4月23日 2:43 To: Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: protect kiq overrun Am 22.04.20 um 16:50 schrieb Yintian Tao: > Wait for the oldest sequence on the kiq ring to be signaled in order > to mak

RE: [PATCH] drm/amdgpu: request reg_val_offs each kiq read reg

2020-04-22 Thread Tao, Yintian
Hi Shaoyun Yes, you are right. It is the rare corner case. Best Regards Yintian Tao -Original Message- From: Liu, Shaoyun Sent: 2020年4月22日 23:51 To: Tao, Yintian ; Koenig, Christian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: request reg_val_offs each kiq read reg

2020-04-22 Thread Tao, Yintian
Add more Especially for the multi-VF environment, we have to wait through msleep() instead udeay. Because the max udelay time is 15VF * 6ms(world-switch) = 90ms. -Original Message- From: amd-gfx On Behalf Of Tao, Yintian Sent: 2020年4月22日 23:43 To: Liu, Shaoyun ; Koenig, Christian

RE: [PATCH] drm/amdgpu: request reg_val_offs each kiq read reg

2020-04-22 Thread Tao, Yintian
ing(ring, seq, MAX_KIQ_REG_WAIT); } spin_lock_irqrestore(>ring_lock, flags); Best Regards Yintian Tao -Original Message- From: Liu, Shaoyun Sent: 2020年4月22日 23:35 To: Tao, Yintian ; Koenig, Christian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: requ

RE: [PATCH] drm/amdgpu: request reg_val_offs each kiq read reg

2020-04-22 Thread Tao, Yintian
the new write command will overwrite the Slot-A contents. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年4月22日 22:52 To: Liu, Shaoyun ; Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: request

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Thanks, I got it. I will send another patch for the KIQ overrun problem Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年4月22日 20:33 To: Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Please see inline commetns. -Original Message- From: Koenig, Christian Sent: 2020年4月22日 19:57 To: Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq access register Am 22.04.20 um 13:49 schrieb Tao

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Can you help answer the questions below? Thanks in advance. -Original Message- From: Koenig, Christian Sent: 2020年4月22日 19:03 To: Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq access register Am

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Please see inline comments. -Original Message- From: Koenig, Christian Sent: 2020年4月22日 16:23 To: Tao, Yintian ; Liu, Monk ; Liu, Shaoyun ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq access register Am 22.04.20 um 10

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Please see inline comments -Original Message- From: Koenig, Christian Sent: 2020年4月22日 15:54 To: Tao, Yintian ; Liu, Monk ; Liu, Shaoyun ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq access register Am 22.04.20 um 09:49

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Hi Christian Please see inline comments. -Original Message- From: Christian König Sent: 2020年4月22日 15:40 To: Tao, Yintian ; Koenig, Christian ; Liu, Monk ; Liu, Shaoyun ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq access register

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
the wb area. Since we run in an atomic context we can have at most the number of CPU in the system + interrupt context here. Regards, Christian. Am 22.04.20 um 09:11 schrieb Tao, Yintian: > Add Felix and Shaoyun > > -Original Message- > From: Yintian Tao > Sent: 2020年4月2

RE: [PATCH] drm/amdgpu: refine kiq access register

2020-04-22 Thread Tao, Yintian
Add Felix and Shaoyun -Original Message- From: Yintian Tao Sent: 2020年4月22日 12:42 To: Koenig, Christian ; Liu, Monk Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amdgpu: refine kiq access register According to the current kiq access register method

RE: [PATCH] drm/amdgpu: change how we update mmRLC_SPM_MC_CNTL

2020-04-21 Thread Tao, Yintian
Acked-by: Yintian Tao -Original Message- From: Christian König Sent: 2020年4月21日 22:23 To: Liu, Monk ; He, Jacob ; Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: change how we update mmRLC_SPM_MC_CNTL In pp_one_vf mode avoid the extra overhead and read/write

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Tao, Yintian
Hi Christian Great. Then can you modify the patch according to Monk's suggestion? We need this patch for one important project. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年4月21日 21:38 To: Liu, Monk ; Tao, Yintian ; He, Jacob ; amd-gfx

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Tao, Yintian
-Original Message- From: Christian König Sent: 2020年4月21日 17:10 To: Liu, Monk ; Tao, Yintian ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: [PATCH] drm/amdgpu: cleanup SPM VMID update The RLC SPM configuration register contains the information how the memory

RE: why we need to do infinite RLC_SPM register setting during VM flush

2020-04-20 Thread Tao, Yintian
: Koenig, Christian Sent: 2020年4月20日 20:42 To: Tao, Yintian ; Liu, Monk ; He, Jacob Cc: amd-gfx@lists.freedesktop.org Subject: Re: why we need to do infinite RLC_SPM register setting during VM flush Monk needs to answer this, but I don't think that this will work. This explanation even sounds like

RE: [PATCH] drm/amdgpu: update spm register through mmio

2020-04-20 Thread Tao, Yintian
Add Monk -Original Message- From: Yintian Tao Sent: 2020年4月20日 20:37 To: Koenig, Christian ; monk@amd.co Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amdgpu: update spm register through mmio According to UMD design, only running performance analysis

RE: why we need to do infinite RLC_SPM register setting during VM flush

2020-04-20 Thread Tao, Yintian
Hi Monk, Christian According to the discussion with Jacob offline, UMD will only enable SPM feature when testing RGP. And under virtualization , only pp_one_vf mode can test RGP. Therefore, whether we can directly use MMIO to READ/WRITE register for RLC_SPM_MC_CNTL? Best Regards Yintian Tao

RE: [PATCH] drm/amdgpu: refine kiq read register

2020-04-20 Thread Tao, Yintian
4月20日 15:19 To: Liu, Monk ; Kuehling, Felix ; Tao, Yintian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: refine kiq read register Hi Monk, > Can we first get the first problem done ? Please absolutely not! See the problem introduced here is quite worse than the actual

RE: [PATCH] drm/amdgpu: refine kiq read register

2020-04-19 Thread Tao, Yintian
Hi Felix Many thanks for your review. I have modified it according to your comments and suggestion. Best Regards Yintian Tao -Original Message- From: Kuehling, Felix Sent: 2020年4月17日 23:39 To: Tao, Yintian ; Liu, Monk Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: refine kiq read register

2020-04-17 Thread Tao, Yintian
of first gfx job write to mmRLC_SPM_MC_CNTL may be overwritten by the second gfx job vmid. I am not sure whether it will raise problem. Best Regards Yintian Tao -Original Message- From: Liu, Monk Sent: 2020年4月17日 17:40 To: Koenig, Christian ; Tao, Yintian ; Kuehling, Felix ; Deucher

RE: [PATCH] drm/amdgpu: restrict debugfs register access under SR-IOV

2020-04-13 Thread Tao, Yintian
Hi Monk Thanks for your review. I have changed the code according to your comments. Please help have a review again Best Regards Yintian Tao -Original Message- From: Liu, Monk Sent: 2020年4月11日 16:59 To: Tao, Yintian ; Alex Deucher Cc: Deucher, Alexander ; Koenig, Christian ; amd

RE: [PATCH] drm/amdgpu: restrict debugfs register access under SR-IOV

2020-04-09 Thread Tao, Yintian
Hi Alex Many thanks for your review. -Original Message- From: Alex Deucher Sent: 2020年4月9日 23:21 To: Tao, Yintian Cc: Koenig, Christian ; Deucher, Alexander ; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: restrict debugfs register access under SR-IOV On Thu, Apr 9, 2020 at 10:54

RE: [PATCH] drm/amdgpu: restrict debugfs register access under SR-IOV

2020-04-09 Thread Tao, Yintian
Hi Christian Many thanks for your review. I will submit one new patch according to your suggestion. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年4月9日 20:42 To: Tao, Yintian ; Deucher, Alexander ; Deng, Emily Cc: amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: skip access sdma_v5_0 registers under SRIOV

2020-03-30 Thread Tao, Yintian
Hi Emily Many thanks -Original Message- From: Deng, Emily Sent: 2020年3月30日 19:57 To: Tao, Yintian ; Koenig, Christian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: RE: [PATCH] drm/amdgpu: skip access sdma_v5_0 registers under SRIOV [AMD Official Use

RE: [PATCH] drm/amdgpu: hold the reference of finished fence

2020-03-23 Thread Tao, Yintian
amdgpu] [ 732.945398] amdgpu_irq_dispatch+0xaf/0x1d0 [amdgpu] [ 732.946317] amdgpu_ih_process+0x8c/0x110 [amdgpu] [ 732.947206] amdgpu_irq_handler+0x24/0xa0 [amdgpu] Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年3月23日 20:06 To: Tao, Yintian ; Deucher, Ale

RE: [PATCH v4 2/2] drm/amdgpu: unref pt bo after job submit

2020-03-16 Thread Tao, Yintian
Hi Xinhui Sure, can you submit one patch for it? I want to test it on my local server. Thanks in advance. Best Regards Yintian Tao From: Pan, Xinhui Sent: 2020年3月16日 17:51 To: Koenig, Christian ; Tao, Yintian Cc: Deucher, Alexander ; Kuehling, Felix ; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: miss PRT case when bo update

2020-03-16 Thread Tao, Yintian
Hi Christian Many thanks for your review Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年3月16日 17:38 To: Tao, Yintian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: miss PRT case when bo update Am 16.03.20 um

RE: [PATCH v4 2/2] drm/amdgpu: unref pt bo after job submit

2020-03-16 Thread Tao, Yintian
Hi Xinhui I encounter the same problem(page fault) when test vk_example benchmark. I use your first option which can fix the problem. Can you help submit one patch? - if (flags & AMDGPU_PTE_VALID) { - struct amdgpu_bo *root = vm->root.base.bo; - if

RE: [refactor RLCG wreg path 1/2] drm/amdgpu: refactor RLCG access path part 1

2020-03-11 Thread Tao, Yintian
Reviewed-by: Yintian Tao -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: 2020年3月11日 13:58 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [refactor RLCG wreg path 1/2] drm/amdgpu: refactor RLCG access path part 1 what changed: 1)provide new implementation

RE: [refactor RLCG wreg path 2/2] drm/amdgpu: refactor RLCG access path part 2

2020-03-11 Thread Tao, Yintian
Reviewed-by: Yintian Tao -Original Message- From: amd-gfx On Behalf Of Monk Liu Sent: 2020年3月11日 13:58 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [refactor RLCG wreg path 2/2] drm/amdgpu: refactor RLCG access path part 2 switch to new RLCG access path, and drop the

RE: [PATCH] drm/amdgpu: release drm_device after amdgpu_driver_unload_kms

2020-02-27 Thread Tao, Yintian
Many thanks. I will put it after pci_* functions. -Original Message- From: Christian König Sent: 2020年2月27日 22:21 To: Tao, Yintian ; Koenig, Christian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: release drm_device after

RE: [PATCH] drm/amdgpu: miss to remove pp_sclk file

2020-02-27 Thread Tao, Yintian
Hi Christian Thanks a lot for your review Hi Alex Can you help to review it? Thanks in advance. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年2月27日 22:18 To: Tao, Yintian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re

RE: [PATCH] drm/amdgpu: no need to clean debugfs at amdgpu

2020-02-27 Thread Tao, Yintian
Hi Christian Thanks for your suggestion. I will remove all cleanup/fini code as well. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2020年2月27日 19:54 To: Tao, Yintian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu/sriov: Tonga sriov also need load firmware with smu

2019-12-16 Thread Tao, Yintian
Reviewd-by Yintian Tao -Original Message- From: amd-gfx On Behalf Of Emily Deng Sent: 2019年12月16日 17:17 To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: [PATCH] drm/amdgpu/sriov: Tonga sriov also need load firmware with smu Fix Tonga sriov load driver fail issue.

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Tao, Yintian
Ping... -Original Message- From: Yintian Tao Sent: 2019年12月10日 17:36 To: Deucher, Alexander ; Feng, Kenneth Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10 Originally, due to the restriction from PSP and SMU, VF

RE: [PATCH] drm/amdgpu: not remove sysfs if not create sysfs

2019-11-29 Thread Tao, Yintian
Hi Christian Thanks a lot. I got it. Can I get your RB? Best Regards Yintian Tao -Original Message- From: Christian König Sent: 2019年11月29日 17:30 To: Tao, Yintian ; Koenig, Christian ; Das, Nirmoy ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: not remove sysfs if not create sysfs

2019-11-29 Thread Tao, Yintian
Hi Christian Do you mean we can remove sysfs_remove_group() for pm_sysfs and ucode_sysfs at amdgpu_device_fini()? If so , I think the sysfs directories will not be removed automatically. When I remove sysfs_remove_group() at amdgpu_device_fini() and reload amdgpu, then it will report the error

RE: [PATCH] drm/amdgpu: put cancel dealyed work at first

2019-11-18 Thread Tao, Yintian
Hi Christian Thanks, I got it, I will use flush_delayed_work to replace canceling. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: 2019年11月18日 19:32 To: Tao, Yintian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: put cancel dealyed work

RE: [PATCH] drm/amdgpu: register pm sysfs for sriov

2019-06-05 Thread Tao, Yintian
Hi Alex Many thanks for your review. Best Regards Yintian Tao -Original Message- From: Alex Deucher Sent: Thursday, June 06, 2019 10:28 AM To: Tao, Yintian Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: register pm sysfs for sriov On Wed, Jun 5, 2019 at 9:54 AM Yintian Tao

RE: [PATCH] drm/amdgpu: register pm sysfs for sriov

2019-06-05 Thread Tao, Yintian
Hi Alex Can you help have a review? Thanks in advance. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Wednesday, June 05, 2019 10:09 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu

答复: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov

2019-06-04 Thread Tao, Yintian
Yes, you are right the error message is at wrong place. May I just remove this message? Best Regards Yintian Tao 发件人: Koenig, Christian 发送时间: 2019年6月4日 23:22:00 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org 主题: Re: 答复: [PATCH] drm/amdgpu: no need fbcon

答复: [PATCH] drm/amdgpu: no need fbcon under sriov

2019-06-04 Thread Tao, Yintian
: 2019年6月4日 21:57:37 收件人: Tao, Yintian; amd-gfx@lists.freedesktop.org 主题: Re: [PATCH] drm/amdgpu: no need fbcon under sriov Am 04.06.19 um 15:43 schrieb Yintian Tao: > Under Sriov, there is no need of the support for fbcon. NAK, that error message is not related to fbcon but means that PCIe dev

RE: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov

2019-05-20 Thread Tao, Yintian
Hi Alex So sorry for my missing of you patch because the outlook on website didn’t show it. Your patch seems cleaner and better. Can you help submit it ? Thanks in advance. Reviewed-by: Yintian Tao Can From: Deucher, Alexander Sent: Saturday, May 18, 2019 1:07 AM To: Tao, Yintian ; Alex

RE: [PATCH] drm/amdgpu: no read DF register under SRIOV and set correct vram width

2019-05-20 Thread Tao, Yintian
Please ignore it. I miss the patch which Alex attached. -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Monday, May 20, 2019 5:21 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Trigger ; Liu, Monk ; Tao, Yintian Subject: [PATCH] drm/amdgpu: no read DF register under

答复: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov

2019-05-17 Thread Tao, Yintian
Hi Alex Many thanks for your review. I will merge these two patches into one and submit again. Best Regards Yintian Tao 发件人: Alex Deucher 发送时间: 2019年5月17日 22:34:30 收件人: Tao, Yintian 抄送: amd-gfx@lists.freedesktop.org; Koenig, Christian; Deucher, Alexander

答复: 答复: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV

2019-05-17 Thread Tao, Yintian
Hi Chrisitian Yes, of course. Thanks for your reminder. Best Regards Yintian Tao 发件人: Christian König 发送时间: 2019年5月17日 15:20:54 收件人: Tao, Yintian; Koenig, Christian 抄送: amd-gfx@lists.freedesktop.org; Liu, Monk 主题: Re: 答复: [PATCH] drm/amdgpu: skip fw pri bo

答复: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV

2019-05-17 Thread Tao, Yintian
Tao 发件人: Koenig, Christian 发送时间: 2019年5月17日 14:53:35 收件人: Tao, Yintian 抄送: Liu, Monk; amd-gfx@lists.freedesktop.org 主题: Re: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV Looks good to me now, but I don't know the technical background why this BO is not needed

RE: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV

2019-05-16 Thread Tao, Yintian
Hi Christian I have modified it according to your suggestion. Can you help review this again? Thanks in advance. Best Regards Yintian Tao -Original Message- From: Yintian Tao Sent: Thursday, May 16, 2019 7:54 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian ; Liu, Monk

RE: [PATCH] drm/amdgpu: don't read DF register for SRIOV

2019-05-16 Thread Tao, Yintian
Ping... Hi Christian and Alex Can you help review this? Thanks in advance. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Thursday, May 16, 2019 8:11 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk ; Tao, Yintian Subject: [PATCH] drm

RE: [PATCH] drm/amdgpu: set correct vram_width for vega10 under sriov

2019-05-16 Thread Tao, Yintian
Ping... Hi Christian and Alex Can you help review this? Thanks in advance. Best Regards Yintian Tao -Original Message- From: Yintian Tao Sent: Thursday, May 16, 2019 8:03 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian ; Huang, Trigger Subject: [PATCH] drm/amdgpu: set

RE: [PATCH] drm/amdgpu: disable DRIVER_ATOMIC under SRIOV

2019-04-16 Thread Tao, Yintian
Ping... Hi Christian and Alex Can you help have a review on it? Thanks in advance. Best Regards Yintian Tao -Original Message- From: Yintian Tao Sent: Tuesday, April 16, 2019 2:09 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: disable

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Tao, Yintian
Hi Alex Many thanks for your review. Best Regards Yintian Tao -Original Message- From: Alex Deucher Sent: Wednesday, April 10, 2019 11:32 PM To: Tao, Yintian Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3 On Wed, Apr 10

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks for your review. I will correct the patch by v3 Best Regards Yintian Tao -Original Message- From: Christian König Sent: Wednesday, April 10, 2019 10:02 PM To: Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Sent: Wednesday, April 10, 2019 8:23 PM To: Tao, Yintian ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization Hi Yintian, yeah, kzalloc would obvious work. But why do you need such a large buffer in the first place

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Sent: Wednesday, April 10, 2019 6:32 PM To: Quan, Evan ; Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization Am 10.04.19 um 11:58 schrieb Quan, Evan: > >> -Original Message- >> From: amd

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Evan Many thanks for your review. I will submit v2 patch according to your comments. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Quan, Evan Sent: Wednesday, April 10, 2019 5:58 PM To: Tao, Yintian ; amd-gfx@lists.freedesktop.org Cc: Tao, Yintian

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks. I got it. Hi Alex Can you help review on it? Many thanks in advance. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: Wednesday, April 10, 2019 4:44 PM To: Tao, Yintian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Ping Hi Christian Can you help have review on it? Thanks in advance. Best Regards Yintian Tao -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Tuesday, April 09, 2019 11:18 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: move set pg state to suspend phase2

2018-08-22 Thread Tao, Yintian
Please ignore this patch. I will re-submit patch with better solution. -Original Message- From: Yintian Tao [mailto:yt...@amd.com] Sent: Wednesday, August 22, 2018 2:50 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: move set pg state to suspend phase2

RE: [PATCH] drm/amd/powerplay: fix typo error for '3be7be08ac'

2018-01-04 Thread Tao, Yintian
Hi Christian Thanks for your review. I have submit it. Best Regards Yintian Tao -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Thursday, January 04, 2018 5:35 PM To: Zhu, Rex <rex@amd.com>; Tao, Yintian <yintian@amd.com&g

RE: [PATCH] drm/amd/powerplay: fix memory leakage when reload

2018-01-03 Thread Tao, Yintian
Hi Alex Thanks a lot. I got it. Best Regards Yintian Tao From: Deucher, Alexander Sent: Wednesday, January 03, 2018 10:32 PM To: Tao, Yintian <yintian@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: fix memory leakage when reload Did you see my

RE: [PATCH] drm/amd/powerplay: fix memory leakage when reload

2018-01-02 Thread Tao, Yintian
Add Alex -Original Message- From: Yintian Tao [mailto:yt...@amd.com] Sent: Monday, January 01, 2018 11:16 AM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian <yintian@amd.com> Subject: [PATCH] drm/amd/powerplay: fix memory leakage when reload add smu_free_memory when sm

RE: [PATCH] drm/amdgpu: Fix no irq process when evict vram

2017-12-13 Thread Tao, Yintian
6e4> is the word-around for the issue. And I think the varible “shutdown” assignment is better to be located after amdgpu_fini() to ensure no irq miss. Best Regards Yintian Tao From: Mike Lothian [mailto:m...@fireburn.co.uk] Sent: Wednesday, December 13, 2017 7:23 PM To: Tao, Yintian &l

RE: [virtual display] code review

2017-01-24 Thread Tao, Yintian
Hi Christian Thanks for your guidance. I will follow it next time. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: Tuesday, January 24, 2017 5:31 PM To: Tao, Yintian <yintian@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>

[virtual display] code review

2017-01-24 Thread Tao, Yintian
Hi Christian Please help to review this patch. The whole story is as follows: For pass-through case, amdgpu module driver may be included into one image with specified BDF parameter, which will cause the failure of virtual display creation when the slot where GPU is put into is modified.

remove static integer at uvd power gate to fix two gpu core boot up

2016-12-21 Thread Tao, Yintian
Hi Alex Please help have a review. Thanks a lot. Best Regards Yintian Tao 0001-drm-amdgpu-remove-static-integer-for-uvd-pp-state.patch Description: 0001-drm-amdgpu-remove-static-integer-for-uvd-pp-state.patch ___ amd-gfx mailing list