[PATCH v2 0/2] drm/{amdgpu,radeon}: convert bios_hardcoded_edid to drm_edid

2024-07-27 Thread Thomas Weißschuh
this series provides the foundation. Only compile-tested. Signed-off-by: Thomas Weißschuh --- Changes in v2: - Rebase onto current amdgpu/drm-next and recent changes to hardcoded bios handling - Add patch for drm/radeon - Link to v1: https://lore.kernel.org/r/20240616-amdgpu-edid-bios-v1-1

[PATCH v2 2/2] drm/radeon: convert bios_hardcoded_edid to drm_edid

2024-07-27 Thread Thomas Weißschuh
' and using 'max_t(int, ...)' instead of manual casts. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/radeon/radeon_atombios.c | 17 ++--- drivers/gpu/drm/radeon/radeon_combios.c| 26 +- drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++-- drivers/gpu

[PATCH v2 1/2] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-07-27 Thread Thomas Weißschuh
' and using 'max_t(int, ...)' instead of manual casts. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 +- drivers/gpu/drm/amd/amdgpu

Re: [PATCH 1/2 V2] drm/amdgpu: properly handle vbios fake edid sizing

2024-07-24 Thread Thomas Weißschuh
were actually any boards out there with a non-128 byte > EDID, but align the code with the comment. > > Reported-by: Thomas Weißschuh > Link: https://lists.freedesktop.org/archives/amd-gfx/2024-June/109964.html > Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") > Sig

Re: [PATCH 2/2 V2] drm/radeon: properly handle vbios fake edid sizing

2024-07-24 Thread Thomas Weißschuh
were actually any boards out there with a non-128 byte > EDID, but align the code with the comment. > > Reported-by: Thomas Weißschuh > Link: https://lists.freedesktop.org/archives/amd-gfx/2024-June/109964.html > Fixes: c324acd5032f ("drm/radeon/kms: parse the extended LCD info

Re: [PATCH 1/2] drm/amdgpu: properly handle vbios fake edid sizing

2024-07-24 Thread Thomas Weißschuh
On 2024-07-23 20:30:08+, Deucher, Alexander wrote: > > -Original Message- > > From: Thomas Weißschuh > > Sent: Tuesday, July 23, 2024 1:58 PM > > To: Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org > > Subject: Re: [PATCH 1/2] drm/amd

Re: [PATCH 1/2] drm/amdgpu: properly handle vbios fake edid sizing

2024-07-23 Thread Thomas Weißschuh
were actually any boards out there with a non-128 byte > EDID, but align the code with the comment. > > Reported-by: Thomas Weißschuh Afaik Reported-by: should also have a Link:. And IMO a Fixes: would also be fitting. > Signed-off-by: Alex Deucher > --- > .../gpu/drm/am

Re: [PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-07-20 Thread Thomas Weißschuh
Hi amdgpu maintainers, did you get a chance to look at the patch and the suspected bug? Thanks, Thomas On 2024-06-16 20:14:45+, Thomas Weißschuh wrote: > On 2024-06-16 11:12:03+0000, Thomas Weißschuh wrote: > > Instead of manually passing around 'struct edid *' and its size, > &

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-07-20 Thread Thomas Weißschuh
Hi Hans, On 2024-07-18 10:25:18+, Hans de Goede wrote: > On 6/24/24 6:15 PM, Thomas Weißschuh wrote: > > On 2024-06-24 11:11:40+, Hans de Goede wrote: > >> On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > >>> The value of "min_input_signal"

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-06-25 Thread Thomas Weißschuh
Hi Hans! thanks for your feedback! On 2024-06-24 11:11:40+, Hans de Goede wrote: > On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > > is "12". This leads to a fairly bright mini

[PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-24 Thread Thomas Weißschuh
with newer panels. Add a quirk infrastructure with which the valid backlight ranges can be maintained as part of the kernel. Signed-off-by: Thomas Weißschuh --- Documentation/gpu/drm-kms-helpers.rst| 3 ++ drivers/gpu/drm/Kconfig | 4 ++ drivers/gpu/drm/Makefile

[PATCH v2 2/3] drm: panel-backlight-quirks: Add Framework 13 matte panel

2024-06-24 Thread Thomas Weißschuh
isible. Tested on a Framework AMD 13 BIOS 3.05 with the matte panel. Link: https://community.frame.work/t/25711/9 Link: https://community.frame.work/t/47036 Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/drm_panel_backlight_quirks.c | 9 + 1 file changed, 9 insertions(+)

[PATCH v2 3/3] drm/amd/display: Add support backlight quirks

2024-06-24 Thread Thomas Weißschuh
Not all platforms provide correct PWM backlight capabilities through ATIF. Use the generic drm backlight quirk infrastructure to override the capabilities where necessary. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/Kconfig| 1 + drivers/gpu/drm/amd/display

[PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-06-24 Thread Thomas Weißschuh
3 matte panel - Link to v1: https://lore.kernel.org/r/20240610-amdgpu-min-backlight-quirk-v1-1-8459895a5...@weissschuh.net --- Thomas Weißschuh (3): drm: Add panel backlight quirks drm: panel-backlight-quirks: Add Framework 13 matte panel drm/amd/display: Add support backlight qu

Re: [PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-06-17 Thread Thomas Weißschuh
On 2024-06-16 11:12:03+, Thomas Weißschuh wrote: > Instead of manually passing around 'struct edid *' and its size, > use 'struct drm_edid', which encapsulates a validated combination of > both. > > As the drm_edid_ can handle NULL gracefully, the explicit checks can be >

[PATCH] drm/amdgpu: convert bios_hardcoded_edid to drm_edid

2024-06-17 Thread Thomas Weißschuh
' and using 'max_t(int, ...)' instead of manual casts. Signed-off-by: Thomas Weißschuh --- While this patch introduces a new user for drm_edid_raw(), if amdgpu proper gets migrated to 'struct drm_edid', that usage will go away. This is only compile-tested. I have some more patches for the rest

[PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-11 Thread Thomas Weißschuh
still readable even in daylight. Tested on a Framework AMD 13 BIOS 3.05 and Framework AMD 16. Link: https://community.frame.work/t/25711/9 Link: https://community.frame.work/t/47036 Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 35

Re: [PATCH] drm/amd: force min_input_signal to 0 on Framework AMD 13/16

2024-06-11 Thread Thomas Weißschuh
On 2024-06-10 14:58:02+, Mario Limonciello wrote: > +Kieran > > On 6/10/2024 14:26, Thomas Weißschuh wrote: > > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > > is "12". This leads to a fairly bright minimum display backligh

[PATCH] drm/amdgpu: make kobj_type structures constant

2023-02-15 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/

[PATCH] drm/amdkfd: Make kobj_type structures constant

2023-02-15 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/