[PATCH 0/6] gpu: convert to use new I2C API

2020-03-27 Thread Wolfram Sang
We are deprecating calls which return NULL in favor of new variants which return an ERR_PTR. Only build tested. Wolfram Sang (6): drm/amdgpu: convert to use i2c_new_client_device() drm/gma500: convert to use i2c_new_client_device() drm/i2c/sil164: convert to use i2c_new_client_device

[PATCH 1/6] drm/amdgpu: convert to use i2c_new_client_device()

2020-03-27 Thread Wolfram Sang
Move away from the deprecated API. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c index ba1bb95a3cf9..0e8018c9aa8e

[PATCH 6/6] drm/radeon: convert to use i2c_new_client_device()

2020-03-27 Thread Wolfram Sang
Move away from the deprecated API. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_combios.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm

Re: [PATCH 6/6] drm/radeon: convert to use i2c_new_client_device()

2020-03-27 Thread Wolfram Sang
> > > > Move away from the deprecated API. > > > > > > > > Signed-off-by: Wolfram Sang > > > > > > patches 1,6, are: > > > Acked-by: Alex Deucher > > Should we commit all to drm-misc-next? > > I'm fine to see it go

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> Preferably this series should be applied via the i2c tree. Are we in a hurry here, i.e. does it block further development of the i801 smbus driver? My gut feeling says the patches should rather go via drm and fbdev trees, but I may be convinced otherwise. signature.asc Description: PGP signa

Re: [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-13 Thread Wolfram Sang
> We're not in a hurry. It's just my experience with patch series' affecting > multiple subsystems that typically the decision was to apply the full > series via one tree. Also to avoid inquires from maintainers like: > Shall I take it or are you going to take it? > Of course there may be differen

Re: [PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-11-23 Thread Wolfram Sang
On Thu, Nov 23, 2023 at 10:40:20AM +0100, Heiner Kallweit wrote: > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-29 Thread Wolfram Sang
Hi Alex, On Thu, May 09, 2024 at 01:15:32PM -0400, Alex Deucher wrote: > On Thu, May 9, 2024 at 8:02 AM Heiner Kallweit wrote: > > > > Support for I2C_CLASS_SPD is currently being removed from the kernel. > > Only remaining step is to remove the definition of I2C_CLASS_SPD. > > Setting I2C_CLASS

[PATCH] MAINTAINERS: update email for Evan Quan

2024-05-29 Thread Wolfram Sang
The old email address bounced. I found the newer one in recent git history, update MAINTAINERS accordingly. Cc: Evan Quan Signed-off-by: Wolfram Sang --- Against v6.10-rc1. Still needs ack from Evan Quan MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] MAINTAINERS: update email for Evan Quan

2024-05-30 Thread Wolfram Sang
> Evan no longer maintains the SWSMU code, it should be changed to Kenneth and > Jun (CCed). Thanks for the heads up! Kenneth, Jun, will you send a patch or shall I? If you send one, please add: Reported-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-30 Thread Wolfram Sang
> > remove I2C_CLASS_SPD without further dependencies? If you prefer to push > > it through your tree, can you send it to Linus soon? > > Yes, I'll include the patch in my PR for this week. Awesome, thank you! signature.asc Description: PGP signature

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Wolfram Sang
Hello Easwar, On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of the >

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Wolfram Sang
Hi Easwar, > Sorry, got excited. :) There were drivers I'd been part of that I specifically > wanted to fixup, but then the scope grew to other users of algobit. Well, you got some positive feedback, so that is good. > > It is true that I changed quite some controller drivers within the i2c > >

Re: [PATCH v5 00/20] remove I2C_CLASS_DDC support

2023-12-19 Thread Wolfram Sang
> I created an immutable branch for this which the buildbots will > hopefully check over night. I will reply with comments tomorrow when I > got the buildbot results. Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support

2023-12-19 Thread Wolfram Sang
On Mon, Nov 13, 2023 at 12:37:15PM +0100, Heiner Kallweit wrote: > I2C_CLASS_SPD was used to expose the EEPROM content to user space, > via the legacy eeprom driver. Now that this driver has been removed, > we can remove I2C_CLASS_SPD support. at24 driver with explicit > instantiation should be use

Re: Bug: amdgpu stutter and spam `Fence fallback timer expired` after suspend

2022-01-06 Thread Wolfram Sang
> Should I send a revert, or is there a way to fix this? You are the second one to report this problem and so far, there has been no response from the authors. I will prepare a revert and CC all involved people. Thank you for the nagging! signature.asc Description: PGP signature

[PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-01-06 Thread Wolfram Sang
ex.ru BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1850 Signed-off-by: Wolfram Sang --- So far, I tested it on a Renesas R-Car M3-N board verifying that I2C still works. I'll apply it to my for-next branch right away to get the buildbots involved as well. But I am still open for comments u

Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-01-07 Thread Wolfram Sang
> Tested-by: Konstantin Kharlamov Thanks! > By the way, shouldn't the patch include a field > > Cc: # 5.14+ Yes, but I add such lines only when applying to my tree. If I add it when sending out patches, the mail gets CCed to stable although the patch is not upstream yet. sign

Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-01-07 Thread Wolfram Sang
On Thu, Jan 06, 2022 at 01:24:52PM +0100, Wolfram Sang wrote: > This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It > breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So, > let's remove the code and go back to the drawing board. W

Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-01-12 Thread Wolfram Sang
Hi everyone, On Thu, Jan 06, 2022 at 01:24:52PM +0100, Wolfram Sang wrote: > This largely reverts commit 5a7b95fb993ec399c8a685552aa6a8fc995c40bd. It > breaks suspend with AMD GPUs, and we couldn't incrementally fix it. So, > let's remove the code and go back to the drawing

Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter"

2022-02-11 Thread Wolfram Sang
On Fri, Feb 04, 2022 at 07:22:44PM +, Tareque Md.Hanif wrote: > The issue still exists. It takes very long time to suspend (10-12s). > `DRI_PRIME=1 glxgears` is a black window. > > journalctl attached > Looking forward to any testing. Any new ideas which Tareque could test? signature.asc

[PATCH] gpu: move from strlcpy with unused retval to strscpy

2022-08-19 Thread Wolfram Sang
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/ Signed-off-by: Wo