Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-16 Thread Yann Dirson
> > On 2022-06-15 10:34, Yann Dirson wrote: > > Nice! > > > >> diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv > >> b/Documentation/gpu/amdgpu/apu-asic-info-table.csv > > ... > >> +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1*

Re: [PATCH 1/3] Documentation/gpu: Add info table for ASICs

2022-06-15 Thread Yann Dirson
Nice! > diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv > b/Documentation/gpu/amdgpu/apu-asic-info-table.csv ... > +Ryzen 3000 series / AMD Ryzen Embedded V1*/R1* with Radeon Vega Gfx, > RAVEN/PICASSO, DCN 1.0, 9.1.0, VCN 1.0, 4.1.0 ... > +Ryzen 3000 series / AMD Ryzen Embedded V1*/R

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2022-01-09 Thread Yann Dirson
Alex wrote: > On Thu, Jan 6, 2022 at 10:38 AM Yann Dirson wrote: > > > > Alex wrote: > > > > How is the stolen memory communicated to the driver ? That > > > > host > > > > physical > > > > memory probably has to be mapped at the sa

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2022-01-06 Thread Yann Dirson
physical memory that the driver directly > maps. > > > > > The other is that, when dom0 cannot use efifb, entering a luks key > > is > > suddenly less user-friendly. But in theory I'd think we could > > overcome > > this by letting dom0

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-29 Thread Yann Dirson
Alex wrote: > On Wed, Dec 29, 2021 at 11:59 AM Yann Dirson wrote: > > > > Alex wrote: > > > On Tue, Dec 21, 2021 at 6:09 PM Yann Dirson > > > wrote: > > > > > > > > > > > > > > > > - Mail original - > &g

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-29 Thread Yann Dirson
Alex wrote: > On Tue, Dec 21, 2021 at 6:09 PM Yann Dirson wrote: > > > > > > > > - Mail original - > > > De: "Alex Deucher" > > > À: "Yann Dirson" > > > Cc: "Christian König" , > > > "amd

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Yann Dirson
- Mail original - > De: "Alex Deucher" > À: "Yann Dirson" > Cc: "Christian König" , "amd-gfx list" > > Envoyé: Mardi 21 Décembre 2021 23:31:01 > Objet: Re: Various problems trying to vga-passthrough a Renoir iGPU to a &g

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-21 Thread Yann Dirson
Alex wrote: > > On Sun, Dec 19, 2021 at 11:41 AM Yann Dirson wrote: > > > > Christian wrote: > > > Am 19.12.21 um 17:00 schrieb Yann Dirson: > > > > Alex wrote: > > > >> Thinking about this more, I think the problem might be related >

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-19 Thread Yann Dirson
Christian wrote: > Am 19.12.21 um 17:00 schrieb Yann Dirson: > > Alex wrote: > >> Thinking about this more, I think the problem might be related to > >> CPU > >> access to "VRAM". APUs don't have dedicated VRAM, they use a > >> reserved

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-19 Thread Yann Dirson
Mon, Dec 13, 2021 at 3:29 PM Alex Deucher > wrote: > > > > On Sun, Dec 12, 2021 at 5:19 PM Yann Dirson > > wrote: > > > > > > Alex wrote: > > > > On Mon, Dec 6, 2021 at 4:36 PM Yann Dirson > > > > wrote: > > >

[PATCH v3 1/4] Documentation/gpu: include description of AMDGPU hardware structure

2021-12-13 Thread Yann Dirson
This describes in broad lines the how an AMD GPU is organized, in terms of hardware blocks. This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Original text: https://www.spinics.net/lists/amd-gfx/msg71543.html Originally-by: Alex Deucher Sign

[PATCH v3 4/4] amdgpu: fix some comment typos

2021-12-13 Thread Yann Dirson
Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- include/uapi/drm/amdgpu_drm.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd

[PATCH v3 3/4] amdgpu: fix some kernel-doc markup

2021-12-13 Thread Yann Dirson
Those are not today pulled by the sphinx doc, but better be ready. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 6 +++--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 ++-- 3 files changed

[PATCH v3 2/4] Documentation/gpu: include description of some of the GC microcontrollers

2021-12-13 Thread Yann Dirson
This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Original text: https://www.spinics.net/lists/amd-gfx/msg71383.html Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland Reviewed-by: R

[PATCH v3 0/4] Enrich amdgpu docs from recent threads

2021-12-13 Thread Yann Dirson
nsion in intro (Rodrigo Siqueira) * new commits for kerneldoc content fixes Changes in v2: * fix typos (Harry Wentland) * get rid of double headings Yann Dirson (4): Documentation/gpu: include description of AMDGPU hardware structure Documentation/gpu: include description of some of t

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-12 Thread Yann Dirson
Alex wrote: > On Mon, Dec 6, 2021 at 4:36 PM Yann Dirson wrote: > > > > Hi Alex, > > > > > We have not validated virtualization of our integrated GPUs. I > > > don't > > > know that it will work at all. We had done a bit of testing but &

[PATCH] amdgpu: fix some kernel-doc markup

2021-12-10 Thread Yann Dirson
Those are not today pulled by the sphinx doc, but better be ready. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu

Re: Looking for clarifications around gfx/kcq/kiq

2021-12-10 Thread Yann Dirson
> > amdgpu_ring_alloc() itself is unconditionally setting count_dw, > > which looked > > suspicious to me -- so I added the check shown below, and it does > > look like > > ring_alloc() gets called again too soon. Am I right in thinking > > this could be > > the cause of amdgpu_ring_test_helper()

[PATCH v2 1/3] Documentation/gpu: split amdgpu/index for readability

2021-12-10 Thread Yann Dirson
This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 ++ Documentation/gpu/amdgpu/index.rst| 342

[PATCH v2 2/3] Documentation/gpu: include description of AMDGPU hardware structure

2021-12-10 Thread Yann Dirson
This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 81 1 file changed, 81 insertions(+

[PATCH v2 3/3] Documentation/gpu: include description of some of the GC microcontrollers

2021-12-10 Thread Yann Dirson
This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson Acked-by: Harry Wentland --- Documentation/gpu/amdgpu/driver-core.rst | 35 1 f

[PATCH v2 0/3] Enrich amdgpu docs from recent threads

2021-12-10 Thread Yann Dirson
This series starts by splitting the amdgpu/index file to make some room for additional contents. The rest is basically bringing Alex' descriptions of the hardware and driver internals into the doc. Changes in v2: * fix typos (Harry Wentland) * get rid of double headings Yann Dirs

[PATCH 2/3] Documentation/gpu: include description of AMDGPU hardware structure

2021-12-09 Thread Yann Dirson
This is Alex' description from the "gpu block diagram" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 81 1 file changed, 81 insertions(+) diff --git a/Documenta

[PATCH 3/3] Documentation/gpu: include description of some of the GC microcontrollers

2021-12-09 Thread Yann Dirson
This is Alex' description from the "Looking for clarifications around gfx/kcq/kiq" thread, edited to fit as ReST. Originally-by: Alex Deucher Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 35 1 file changed, 35 insertions(+

[PATCH 1/3] Documentation/gpu: split amdgpu/index for readability

2021-12-09 Thread Yann Dirson
This starts to make the formated index much more manageable to the reader. Signed-off-by: Yann Dirson --- Documentation/gpu/amdgpu/driver-core.rst | 65 Documentation/gpu/amdgpu/driver-misc.rst | 112 +++ Documentation/gpu/amdgpu/index.rst| 298

[PATCH 0/3] Enrich amdgpu docs from recent threads

2021-12-09 Thread Yann Dirson
This series starts by splitting the amdgpu/index file to make some room for additional contents, but I'm not really happy with the result, we can certainly do better. The rest is basically bringing Alex' descriptions of the hardware and driver internals into the doc. Yann

Re: [PATCH v4 0/6] Expand display core documentation

2021-12-09 Thread Yann Dirson
> Thanks for this. It's really good to see this. > > Reviewed-by: Harry Wentland Hearfully seconded, let's get this rolling :) Reviewed-by: Yann Dirson > > Harry > > On 2021-12-09 09:20, Rodrigo Siqueira wrote: > > Display Core (DC) is one of th

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-08 Thread Yann Dirson
Hi Alex, > > On Mon, Dec 6, 2021 at 4:36 PM Yann Dirson wrote: > > > > Hi Alex, > > > > > We have not validated virtualization of our integrated GPUs. I > > > don't > > > know that it will work at all. We had done a bit of testing bu

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

2021-12-08 Thread Yann Dirson
Hi Rodrigo, > On 2021-12-07 2:49 p.m., Yann Dirson wrote: > > > >> On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: > >>> In the DC driver, we have multiple acronyms that are not obvious > >>> most of > >>> th

gpu block diagram

2021-12-07 Thread Yann Dirson
Thanks for the details Alex! Here is an attempt to formalize the decomposition of a (mostly Renoir) APU, using plantuml. That's highly preliminary, focusing on blocks/sub-blocks/firmware, based on my current partial (and surely incorrect at places) understanding. I focused on getting contents qui

Re: [PATCH v2 6/6] Documentation/gpu: Add amdgpu and dc glossary

2021-12-07 Thread Yann Dirson
> On Thu, Dec 02, 2021 at 11:01:32AM -0500, Rodrigo Siqueira wrote: > > In the DC driver, we have multiple acronyms that are not obvious > > most of > > the time; the same idea is valid for amdgpu. This commit introduces > > a DC > > and amdgpu glossary in order to make it easier to navigate thro

Re: Various problems trying to vga-passthrough a Renoir iGPU to a xen/qubes-os hvm

2021-12-06 Thread Yann Dirson
Hi Alex, > We have not validated virtualization of our integrated GPUs. I don't > know that it will work at all. We had done a bit of testing but ran > into the same issues with the PSP, but never had a chance to debug > further because this feature is not productized. ... > You need a functiona

Looking for clarifications around gfx/kcq/kiq

2021-12-06 Thread Yann Dirson
Hello, Context: trying to understand what happens with my Renoir passed through to a Xen domu [0] (starting with the "VCN disabled" because I don't need it now (so let's postpone the problem with its _fini) and with "PSP disabled" because the alternative issue seems easier to solve -- so ip_block_

Re: [PATCH v2 5/6] Documentation/gpu: Add basic overview of DC pipeline

2021-12-03 Thread Yann Dirson
> De: "Rodrigo Siqueira" > Objet: [PATCH v2 5/6] Documentation/gpu: Add basic overview of DC pipeline > > This commit describes how DCN works by providing high-level diagrams > with an explanation of each component. In particular, it details the > Global Sync signals. > > Signed-off-by: Rodrigo

Re: [PATCH 1/6] Documentation/gpu: Reorganize DC documentation

2021-11-30 Thread Yann Dirson
> On 2021-11-30 10:48 a.m., Harry Wentland wrote: > > On 2021-11-30 10:46, Rodrigo Siqueira Jordao wrote: > >> > >> > >> On 2021-11-29 7:06 a.m., Jani Nikula wrote: > >>> On Fri, 26 Nov 2021, Daniel Vetter wrote: > On Thu, Nov 25, 2021 at 10:38:25AM -0500, Rodrigo Siqueira > wrote: > >>>

Re: [PATCH 6/6] Documentation/gpu: Add DC glossary

2021-11-30 Thread Yann Dirson
- Mail original - > De: "Rodrigo Siqueira Jordao" > À: ydir...@free.fr, "Rodrigo Siqueira" , "Christian > König" , > "Alex Deucher" > Cc: "Harry Wentland" , "Linux Doc Mailing List" > , "Mark Yacoub" > , "Michel Dänzer" , "Bas > Nieuwenhuizen" , > "Roman Li" , "amd-gfx list" > , "R

[PATCH v2] drm/amdgpu: update fw_load_type module parameter doc to match code

2021-11-29 Thread Yann Dirson
the parameter is ignored. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index ecdec75fdf69..64881068b115 100644

[PATCH] drm/amdgpu: update fw_load_type module parameter doc to match code

2021-11-28 Thread Yann Dirson
the parameter is ignored. Signed-off-by: Yann Dirson --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index ecdec75fdf69..8ab12368b3b6 100644