Re: [PATCH] drm/amd/powerplay: skip enable mgpu fan boost in SRIOV

2024-09-24 Thread Yin, ZhenGuo (Chris)
On 9/24/2024 8:24 PM, Lazar, Lijo wrote: On 9/24/2024 9:10 AM, ZhenGuo Yin wrote: SMU_MSG_SetMGpuFanBoostLimitRpm is unsupported for VF, skip enabling mgpu fan boost in SRIOV. Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+)

RE: [PATCH v2] drm/amdgpu: reset vm state machine after gpu reset(vram lost)

2024-07-23 Thread Yin, ZhenGuo (Chris)
riginal Message- From: Christian König Sent: Tuesday, July 23, 2024 3:13 PM To: Yin, ZhenGuo (Chris) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian Subject: Re: [PATCH v2] drm/amdgpu: reset vm state machine after gpu reset(vram lost) Am 23.07.24 um 05:05 schrieb ZhenGuo Yin: > [Why

RE: [PATCH] drm/amdgpu: reset vm state machine after gpu reset(vram lost)

2024-07-19 Thread Yin, ZhenGuo (Chris)
f a gpu reset triggered by a GFX job, and there has no SDMA job in the pending list, the entity won't be set as error. Best, Zhenguo Cloud-GPU Core team, SRDC -Original Message- From: Koenig, Christian Sent: Friday, July 19, 2024 5:22 PM To: Yin, ZhenGuo (Chris) ;

RE: [PATCH] drm/amdgpu: clear set_q_mode_offs when VM changed

2024-04-02 Thread Yin, ZhenGuo (Chris)
[AMD Official Use Only - General] Yeah, I agree. But I have no idea which place is better. Best, Zhenguo Cloud-GPU Core team, SRDC -Original Message- From: Koenig, Christian Sent: Tuesday, April 2, 2024 4:14 PM To: Yin, ZhenGuo (Chris) ; amd-gfx@lists.freedesktop.org Cc: Deucher

RE: [PATCH] drm/amd/amdgpu: add pipe1 hardware support

2024-03-26 Thread Yin, ZhenGuo (Chris)
[AMD Official Use Only - General] Hi, Alex Could you please help to review this patch? This should fix the bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2117. Thx. Best, Zhenguo Cloud-GPU Core team, SRDC -Original Message- From: Yin, ZhenGuo (Chris) Sent: Friday, March 15

Re: [PATCH] drm/amdgpu: Skip access gfx11 golden registers under SRIOV

2023-11-26 Thread Yin, ZhenGuo (Chris)
Add potential reviewers. On 11/23/2023 4:57 PM, ZhenGuo Yin wrote: [Why] Golden registers are PF-only registers on gfx11. RLCG interface will return "out-of-range" under SRIOV VF. [How] Skip access gfx11 golden registers under SRIOV. Signed-off-by: ZhenGuo Yin --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH v2] drm/amdgpu doorbell range should be set when gpu recovery

2023-10-30 Thread Yin, ZhenGuo (Chris)
Acked-by: ZhenGuo Yin On 10/30/2023 5:57 PM, Lin.Cao wrote: GFX doorbell range should be set after flr otherwise the gfx doorbell range will be overlap with MEC. v2: remove "amdgpu_sriov_vf" and "amdgpu_in_reset" check, and add grbm select for the case of 2 gfx rings. Signed-off-by: Lin.Cao

RE: [PATCH 1/8] drm/scheduler: properly forward fence errors

2023-08-23 Thread Yin, ZhenGuo (Chris)
* Best, Zhenguo Cloud-GPU Core team, SRDC -Original Message- From: Yin, ZhenGuo (Chris) Sent: Thursday, August 17, 2023 4:17 PM To: Christian König ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Chen, JingWen (Wayne) ; Liu, Monk ; Li, Chong(Alan) ; cao, lin Subject: RE: [PATCH 1/8] drm

RE: [PATCH 1/8] drm/scheduler: properly forward fence errors

2023-08-17 Thread Yin, ZhenGuo (Chris)
- From: Christian König Sent: Thursday, April 27, 2023 8:05 PM To: Yin, ZhenGuo (Chris) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Chen, JingWen (Wayne) ; Liu, Monk Subject: Re: [PATCH 1/8] drm/scheduler: properly forward fence errors Well good point, but as part of the effort of the Intel

RE: [PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute

2023-06-07 Thread Yin, ZhenGuo (Chris)
, Felix Sent: Wednesday, June 7, 2023 9:35 PM To: Li, Chong(Alan) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Yin, ZhenGuo (Chris) Subject: Re: [PATCH v2 06/07] drm/amdgpu: add option params to enforce process isolation between graphics and compute I can't see the other patch

RE: [PATCH 1/8] drm/scheduler: properly forward fence errors

2023-04-27 Thread Yin, ZhenGuo (Chris)
[AMD Official Use Only - General] Hi, Christian diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index fcd4bfef7415..649fac2e1ccb 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -533,12 +533,12 @@ voi

Re: [PATCH] drm/amdgpu: Stop clearing kiq position during fini

2023-02-28 Thread Yin, ZhenGuo (Chris)
Acked-by: ZhenGuo Yin On 2/27/2023 2:45 PM, Yaoyao Lei wrote: Do not clear kiq position in RLC_CP_SCHEDULER so that CP could perform IDLE-SAVE after VF fini. Otherwise it could cause GFX hang if another Win guest is rendering. Signed-off-by: Yaoyao Lei --- drivers/gpu/drm/amd/amdgpu/gfx_v10

Re: [PATCH 1/5] drm/amd/amdgpu revert "implement tdr advanced mode"

2023-01-28 Thread Yin, ZhenGuo (Chris)
Hi, Christian A later bad compute job can block a good gfx job, so the original TDR design find a wrong guilty job(good gfx job). Advanced TDR re-submits jobs in order to find the real guilty job(bad compute job). After reverting this commit, how does the new gang-submit promise the isolat

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-05 Thread Yin, ZhenGuo (Chris)
Inside the function ttm_bo_set_bulk_move, it calls ttm_resource_del_bulk_move to remove the old resource from the bulk_move list. If we set the bulk_move to NULL manually as suggested, the old resource attached in the ghost BO seems won't be removed from the bulk_move. On 9/1/2022 7:13 PM, C