Re: drm/amdgpu: remove the redundant null check

2019-09-05 Thread zhong jiang
gt; Was the script “ifnullfree.cocci” applied here? Yep > Will it be helpful to add attribution for such tools > to any more descriptions in your patches? Sometimes, I will add the description in my patches. Not always. Thanks, zhong jiang > Regards, > Markus > > . >

[PATCH] drm/amdgpu: remove the redundant null check

2019-09-03 Thread zhong jiang
debugfs_remove and kfree has taken the null check in account. hence it is unnecessary to check it. Just remove the condition. No functional change. Signed-off-by: zhong jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] drm: amd: Use kmemdup instead of duplicating its function

2018-09-21 Thread zhong jiang
+cc amd-gfx@lists.freedesktop.org Thanks, zhong jiang On 2018/9/18 23:35, zhong jiang wrote: > kmemdup has implemented the function that kmalloc() + memcpy(). > We prefer to kmemdup rather than code opened implementation. > > Signed-off-by: zhong jiang > --- > drivers/

Re: [PATCH] drm/amd/display: remove redundant null pointer check before kfree

2018-09-21 Thread zhong jiang
On 2018/9/21 21:56, Harry Wentland wrote: > On 2018-09-21 09:12 AM, zhong jiang wrote: >> kfree has taken the null pointer into account. hence it is safe >> to remove the redundant null pointer check before kfree. >> > Please send patches for drivers/gpu/drm/amd to amd-g