Re: [PATCH] Fix crash when page flipping in multi-X-Screen/Zaphod mode

2018-12-19 Thread Michel Dänzer
On 2018-12-18 8:09 p.m., Mario Kleiner wrote: > On Tue, Dec 18, 2018 at 3:42 PM Michel Dänzer wrote: >> >> Good catch, thanks! Pushed with >> >> Fixes: 740f0850f1e4 "Store FB for each CRTC in drmmode_flipdata_rec" >> Reviewed-by: Michel Dänzer >> >> >> Do you want to make an xf86-video-amdgpu mer

Re: [PATCH] Fix crash when page flipping in multi-X-Screen/Zaphod mode

2018-12-18 Thread Mario Kleiner
On Tue, Dec 18, 2018 at 3:42 PM Michel Dänzer wrote: > Do you want to make an xf86-video-amdgpu merge request as well? If not, > I can take care of porting the fix. If you do it, please enable the Ok Michel, spent some more time. Patch for amdgpu-ddx should be out as well via good ol' e-mail. Th

Re: [PATCH] Fix crash when page flipping in multi-X-Screen/Zaphod mode

2018-12-18 Thread Mario Kleiner
On Tue, Dec 18, 2018 at 3:42 PM Michel Dänzer wrote: > > > Good catch, thanks! Pushed with > > Fixes: 740f0850f1e4 "Store FB for each CRTC in drmmode_flipdata_rec" > Reviewed-by: Michel Dänzer > > > Do you want to make an xf86-video-amdgpu merge request as well? If not, > I can take care of porti

Re: [PATCH] Fix crash when page flipping in multi-X-Screen/Zaphod mode

2018-12-18 Thread Michel Dänzer
On 2018-12-18 11:40 a.m., Mario Kleiner wrote: > radeon_do_pageflip() indexed the flipdata->fb[] array > indexing over config->num_crtc, but the flip completion > routines, e.g., drmmode_flip_handler(), index that array > via the crtc hw id from drmmode_get_crtc_id(crtc). > > This is mismatched an

[PATCH] Fix crash when page flipping in multi-X-Screen/Zaphod mode

2018-12-18 Thread Mario Kleiner
radeon_do_pageflip() indexed the flipdata->fb[] array indexing over config->num_crtc, but the flip completion routines, e.g., drmmode_flip_handler(), index that array via the crtc hw id from drmmode_get_crtc_id(crtc). This is mismatched and causes indexing into the wrong array slot at flip complet