Re: [PATCH] Revert "drm/amdgpu: remove ctx->lock"

2022-07-11 Thread Luben Tuikov
On 2022-07-11 23:22, Tales Lelo da Aparecida wrote: > On 21/06/2022 11:42, Luben Tuikov wrote: >> This reverts commit e68efb27647f2106d6b545667f35b2ea39746b57. >> >> We see that the bo validate list gets corrupted, in >> amdgpu_cs_list_validate(), the lobj->tv.bo is NULL. Then getting usermm on >>

Re: [PATCH] Revert "drm/amdgpu: remove ctx->lock"

2022-07-11 Thread Tales Lelo da Aparecida
On 21/06/2022 11:42, Luben Tuikov wrote: This reverts commit e68efb27647f2106d6b545667f35b2ea39746b57. We see that the bo validate list gets corrupted, in amdgpu_cs_list_validate(), the lobj->tv.bo is NULL. Then getting usermm on the next line, references a NULL bo and we get a koops.

Re: [PATCH] Revert "drm/amdgpu: remove ctx->lock"

2022-06-27 Thread Alex Deucher
On Tue, Jun 21, 2022 at 10:42 AM Luben Tuikov wrote: > > This reverts commit e68efb27647f2106d6b545667f35b2ea39746b57. > > We see that the bo validate list gets corrupted, in > amdgpu_cs_list_validate(), the lobj->tv.bo is NULL. Then getting usermm on > the next line, references a NULL bo and we

[PATCH] Revert "drm/amdgpu: remove ctx->lock"

2022-06-21 Thread Luben Tuikov
This reverts commit e68efb27647f2106d6b545667f35b2ea39746b57. We see that the bo validate list gets corrupted, in amdgpu_cs_list_validate(), the lobj->tv.bo is NULL. Then getting usermm on the next line, references a NULL bo and we get a koops. Bisecting leads to the commit being reverted as the