Reviewed-by: Andrey Grodzovsky
Andrey
On 01/07/2019 12:31 PM, StDenis, Tom wrote:
> v2: Move locks around in other functions so that this
> function can stand on its own. Also only hold the hive
> specific lock for add/remove device instead of the driver
> global lock so you can't add/remove
v2: Move locks around in other functions so that this
function can stand on its own. Also only hold the hive
specific lock for add/remove device instead of the driver
global lock so you can't add/remove devices in parallel from
one hive.
v3: add reset_lock
Signed-off-by: Tom St Denis
---
gt;> The changes is acked-by Shaoyun.liu < shaoyun@amd.com>
>>>>>>>
>>>>>>> -Original Message-
>>>>>>> From: amd-gfx On Behalf Of
>>>>>>> StDenis, Tom
>>>>>>> Se
amd.com>
>>>>>>
>>>>>> -Original Message-
>>>>>> From: amd-gfx On Behalf Of
>>>>>> StDenis, Tom
>>>>>> Sent: Monday, January 7, 2019 10:16 AM
>>>>>> To: amd-gfx@lists.freedesktop.o
From: amd-gfx On Behalf Of
>>>>> StDenis, Tom
>>>>> Sent: Monday, January 7, 2019 10:16 AM
>>>>> To: amd-gfx@lists.freedesktop.org
>>>>> Cc: StDenis, Tom
>>>>> Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive(
>> Sent: Monday, January 7, 2019 10:16 AM
>>>> To: amd-gfx@lists.freedesktop.org
>>>> Cc: StDenis, Tom
>>>> Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)
>>>>
>>>> v2: Move locks around in other functions so th
changes is acked-by Shaoyun.liu < shaoyun@amd.com>
>>>
>>> -Original Message-
>>> From: amd-gfx On Behalf Of StDenis,
>>> Tom
>>> Sent: Monday, January 7, 2019 10:16 AM
>>> To: amd-gfx@lists.freedesktop.org
>>> Cc:
m>
>>
>> -Original Message-
>> From: amd-gfx On Behalf Of StDenis,
>> Tom
>> Sent: Monday, January 7, 2019 10:16 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: StDenis, Tom
>> Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v
Tom
> Sent: Monday, January 7, 2019 10:16 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: StDenis, Tom
> Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)
>
> v2: Move locks around in other functions so that this function can stand on
> its own. Also only h
org
Cc: StDenis, Tom
Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)
v2: Move locks around in other functions so that this function can stand on its
own. Also only hold the hive specific lock for add/remove device instead of
the driver global lock so you can't add/remove d
v2: Move locks around in other functions so that this
function can stand on its own. Also only hold the hive
specific lock for add/remove device instead of the driver
global lock so you can't add/remove devices in parallel from
one hive.
Signed-off-by: Tom St Denis
---
Self NAK this ... calling functions take the same lock
We should remove the locks from the callers so this function is thread
safe on its own...
Tom
On 2019-01-07 10:00 a.m., StDenis, Tom wrote:
> Signed-off-by: Tom St Denis
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 8a8bc60cb6b4..587a5f73ae8c 100644
---
13 matches
Mail list logo
