RE: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-17 Thread Liu, Monk
ecking Prior to your path, although I didn't encourage such ugly actions... -Original Message- From: Marek Olšák [mailto:mar...@gmail.com] Sent: Tuesday, December 12, 2017 11:02 PM To: Liu, Monk Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] amdgpu: disable GPU reset if amdgpu

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Marek Olšák
On Tue, Dec 12, 2017 at 5:36 PM, Christian König wrote: > Am 12.12.2017 um 15:57 schrieb Marek Olšák: >> >> On Tue, Dec 12, 2017 at 10:01 AM, Christian König >> wrote: >>> >>> Am 11.12.2017 um 22:29 schrieb Marek Olšák: From: Marek Olšák Signed-off-by: Marek Olšák --- >

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Christian König
Am 12.12.2017 um 15:57 schrieb Marek Olšák: On Tue, Dec 12, 2017 at 10:01 AM, Christian König wrote: Am 11.12.2017 um 22:29 schrieb Marek Olšák: From: Marek Olšák Signed-off-by: Marek Olšák --- Is this really correct? I have no easy way to test it. It's a step in the right direction, but

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Marek Olšák
On Tue, Dec 12, 2017 at 4:18 AM, Liu, Monk wrote: > NAK, you change break SRIOV logic: > > Without lockup_timeout set, this gpu_recover() won't get called at all , > unless your IB triggered invalid instruct and that IRQ invoked > Amdgpu_gpu_recover(), by this cause you should disable the logic t

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Marek Olšák
On Tue, Dec 12, 2017 at 10:01 AM, Christian König wrote: > Am 11.12.2017 um 22:29 schrieb Marek Olšák: >> >> From: Marek Olšák >> >> Signed-off-by: Marek Olšák >> --- >> >> Is this really correct? I have no easy way to test it. > > > It's a step in the right direction, but I would rather vote fo

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Andrey Grodzovsky
On 12/12/2017 04:01 AM, Christian König wrote: Am 11.12.2017 um 22:29 schrieb Marek Olšák: From: Marek Olšák Signed-off-by: Marek Olšák --- Is this really correct? I have no easy way to test it. It's a step in the right direction, but I would rather vote for something else: Instead of

Re: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-12 Thread Christian König
Am 11.12.2017 um 22:29 schrieb Marek Olšák: From: Marek Olšák Signed-off-by: Marek Olšák --- Is this really correct? I have no easy way to test it. It's a step in the right direction, but I would rather vote for something else: Instead of disabling the timeout by default we only disable

RE: [PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-11 Thread Liu, Monk
tself because For SRIOV we need gpu_recover() even lockup_timeout is zero -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Marek Ol?ák Sent: 2017年12月12日 5:30 To: amd-gfx@lists.freedesktop.org Subject: [PATCH] amdgpu: disable GPU res

[PATCH] amdgpu: disable GPU reset if amdgpu.lockup_timeout=0

2017-12-11 Thread Marek Olšák
From: Marek Olšák Signed-off-by: Marek Olšák --- Is this really correct? I have no easy way to test it. drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c i