Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-27 Thread kbuild test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.16-rc7 next-20180327] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Daniel Vetter
On Mon, Mar 26, 2018 at 12:47:01PM +0200, Christian König wrote: > Am 26.03.2018 um 10:36 schrieb Daniel Vetter: > > On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: > [SNIP] > > > - attach->dev = dev; > > > + attach->dev = info->dev; > > > attach->dmabuf = dmabuf; > > > +

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Christian König
Am 26.03.2018 um 10:36 schrieb Daniel Vetter: On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: [SNIP] - attach->dev = dev; + attach->dev = info->dev; attach->dmabuf = dmabuf; + attach->priv = info->priv; The ->priv field is for the exporter, not the im

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Christian König
Am 26.03.2018 um 10:36 schrieb Daniel Vetter: On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: [SNIP] - attach->dev = dev; + attach->dev = info->dev; attach->dmabuf = dmabuf; + attach->priv = info->priv; The ->priv field is for the exporter, not the im

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-26 Thread Daniel Vetter
On Sun, Mar 25, 2018 at 01:34:51PM +0200, Christian König wrote: > Move the parameters into a structure to make it simpler to extend it in > follow up patches. > > This also adds the importer private as parameter so that we can directly > work with a completely filled in attachment structure. > >

Re: [PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-25 Thread kbuild test robot
Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

[PATCH] dma-buf: use parameter structure for dma_buf_attach

2018-03-25 Thread Christian König
Move the parameters into a structure to make it simpler to extend it in follow up patches. This also adds the importer private as parameter so that we can directly work with a completely filled in attachment structure. Signed-off-by: Christian König --- drivers/dma-buf/dma-buf.c