Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread Christian König
@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) If there are two threads using the same fd, I don't see anything that prevent this order set_state (T1) // State1 set_state (T2) // State2 read (T1

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread StDenis, Tom
To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) Does that really need a lock? Can't local variables solve it? Thanks, Lijo On 8/26/2021 5:52 PM, StDenis, Tom wrote: > [AMD Official Use Only] > > The issue i

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread Lazar, Lijo
: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) If there are two threads using the same fd, I don't see anything that prevent this order set_state (T1) // State1 set_state (T2) // State2 read (T1) write (T2) If there are separate fds, I guess

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread StDenis, Tom
is fine. Tom From: Lazar, Lijo Sent: Thursday, August 26, 2021 08:19 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) If there are two threads using the same fd, I don't

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread Lazar, Lijo
: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) On 8/25/2021 10:56 PM, Tom St Denis wrote: This new debugfs interface uses an IOCTL interface in order to pass along state information like SRBM and GRBM bank switching. This new interface also allows a full 32-bit MMIO

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread StDenis, Tom
is the only likely user of this it's still ideal to avoid potential race conditions as a matter of correctness. Tom From: Lazar, Lijo Sent: Thursday, August 26, 2021 08:12 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread Lazar, Lijo
On 8/25/2021 10:56 PM, Tom St Denis wrote: This new debugfs interface uses an IOCTL interface in order to pass along state information like SRBM and GRBM bank switching. This new interface also allows a full 32-bit MMIO address range which the previous didn't. With this new design we have

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-26 Thread Christian König
Am 25.08.21 um 19:26 schrieb Tom St Denis: This new debugfs interface uses an IOCTL interface in order to pass along state information like SRBM and GRBM bank switching. This new interface also allows a full 32-bit MMIO address range which the previous didn't. With this new design we have

[PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

2021-08-25 Thread Tom St Denis
This new debugfs interface uses an IOCTL interface in order to pass along state information like SRBM and GRBM bank switching. This new interface also allows a full 32-bit MMIO address range which the previous didn't. With this new design we have room to grow the flexibility of the file as need