RE: [PATCH] drm/amd/display: Don't fail atomic check in MST S3 topology change

2019-01-10 Thread Zuo, Jerry
; Wentland, Harry Subject: Re: [PATCH] drm/amd/display: Don't fail atomic check in MST S3 topology change JFYI: In the future patches like this should also be sent to dri-de...@lists.freedesktop.org Anyway, sorry but NAK It's usually OK to set crtc_state->mode_changed = true, but it's never o

Re: [PATCH] drm/amd/display: Don't fail atomic check in MST S3 topology change

2019-01-10 Thread Lyude Paul
JFYI: In the future patches like this should also be sent to dri-de...@lists.freedesktop.org Anyway, sorry but NAK It's usually OK to set crtc_state->mode_changed = true, but it's never okay to set it to false from atomic check code. This is because atomic helpers will sometimes force modesets

[PATCH] drm/amd/display: Don't fail atomic check in MST S3 topology change

2019-01-10 Thread Jerry (Fangzhi) Zuo
In MST S3 topology change, dc_sink is created in .get_mode hook later than the resume sequence. No stream created in atomic check is normal in MST S3 resume. In such case, mark false to mode_changed flag to skip the check in dm_crtc_helper_atomic_check(), instead of returning error.