Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Alex Deucher
On Mon, Nov 6, 2017 at 6:51 AM, Christian König wrote: > Am 06.11.2017 um 12:43 schrieb Dan Carpenter: >> >> backlight_device_register() never returns NULL, it returns error >> pointers on error so the check here is wrong. >> >> Signed-off-by: Dan Carpenter > > > Acked-by: Christian König Appli

Re: [PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Christian König
Am 06.11.2017 um 12:43 schrieb Dan Carpenter: backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Signed-off-by: Dan Carpenter Acked-by: Christian König diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu

[PATCH] drm/amd/display: checking for NULL instead of IS_ERR()

2017-11-06 Thread Dan Carpenter
backlight_device_register() never returns NULL, it returns error pointers on error so the check here is wrong. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 33a15a1d818c..75f9383f5b9b 100644