Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-07 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Apr 4, 2022 at 11:57 AM Harry Wentland wrote: > > > > On 2022-04-04 11:43, Tom Rix wrote: > > > > On 4/4/22 8:22 AM, Harry Wentland wrote: > >> > >> On 2022-04-03 10:21, Tom Rix wrote: > >>> Smatch reports this issue > >>> hdcp1_execution.c:500:29: warning: functio

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Tom Rix
On 4/4/22 8:22 AM, Harry Wentland wrote: On 2022-04-03 10:21, Tom Rix wrote: Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition Which branch are you using? linux-next from 4/1 Tom I don't see t

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-04 11:43, Tom Rix wrote: > > On 4/4/22 8:22 AM, Harry Wentland wrote: >> >> On 2022-04-03 10:21, Tom Rix wrote: >>> Smatch reports this issue >>> hdcp1_execution.c:500:29: warning: function >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage >>>    has definition >>> >> Which

Re: [PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Harry Wentland
On 2022-04-03 10:21, Tom Rix wrote: > Smatch reports this issue > hdcp1_execution.c:500:29: warning: function > 'mod_hdcp_hdcp1_dp_execution' with external linkage > has definition > Which branch are you using? I don't see the 'extern' on https://gitlab.freedesktop.org/agd5f/linux/-/blob/

[PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-04 Thread Tom Rix
Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition The storage-class-specifier extern is not needed in a definition, so remove it. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_