Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-20 Thread Christian König
, Jiawei *From:* Christian König *Sent:* Wednesday, May 19, 2021 9:23 PM *To:* Deucher, Alexander ; Gu, JiaWei (Will) ; Nieto, David M ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; mar...@gmail.com *Cc:* Deng, Emily *Subject:* Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Alex Deucher
On Wed, May 19, 2021 at 10:59 PM Jiawei Gu wrote: > > Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. > > Provides a way for the user application to get the VBIOS > information without having to parse the binary. > It is useful for the user to be able to display in a simple way

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the user to be able to display in a simple way the VBIOS version in their system if they happen to encounter an

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Gu, JiaWei (Will)
; mar...@gmail.com Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface Good point. If you want to double check the alignment you can use something like "pahole drivers/gpu/drm/amd/amdgpu/amdgpu.ko -C drm_amdgpu_info_vbios" after building the kernel module

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Christian König
tr[32]; > + __u8 date[32]; > +}; *From:* Gu, JiaWei (Will) *Sent:* Tuesday, May 18, 2021 1:58 AM *To:* Nieto, David M ; Koenig, Christian ; amd-gfx@lists.freedesktop.org ; mar...@gmail.com ; Deucher, Alexander *Cc:* Deng, Emily *Subject:* RE: [PATCH] drm/amdgpu: Add vbios info

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Deucher, Alexander
t; + __u8 date[32]; > +}; From: Gu, JiaWei (Will) Sent: Tuesday, May 18, 2021 1:58 AM To: Nieto, David M ; Koenig, Christian ; amd-gfx@lists.freedesktop.org ; mar...@gmail.com ; Deucher, Alexander Cc: Deng, Emily Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] Hi

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Nieto, David M
, Alexander Cc: Deng, Emily Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] Not sure about this one – vbios version : 285409288 Windows driver reports VBIOS version from atom_firmware_info_v3_1 / firmware_revision. Thanks, Lijo From: amd-gfx On Behalf Of Gu, JiaWei

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Marek Olšák
t; Sent: Tuesday, May 18, 2021 9:26 PM > To: Koenig, Christian ; Gu, JiaWei (Will) < > jiawei...@amd.com>; amd-gfx@lists.freedesktop.org; Nieto, David M < > david.ni...@amd.com>; mar...@gmail.com; Deucher, Alexander < > alexander.deuc...@amd.com> > Cc: Deng, Emily > Sub

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Gu, JiaWei (Will)
- From: StDenis, Tom Sent: Tuesday, May 18, 2021 9:26 PM To: Koenig, Christian ; Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org; Nieto, David M ; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread StDenis, Tom
: Tuesday, May 18, 2021 09:17 To: Gu, JiaWei (Will); amd-gfx@lists.freedesktop.org; Nieto, David M; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface Well not an expert on that stuff, but looks like that should work for me. Question

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Christian König
-gfx@lists.freedesktop.org; Koenig, Christian ; Nieto, David M ; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily ; Gu, JiaWei (Will) Subject: [PATCH] drm/amdgpu: Add vbios info ioctl interface Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Gu, JiaWei (Will)
: Add vbios info ioctl interface Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the user to be able to display in a simple way the VBIOS version

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the user to be able to display in a simple way the VBIOS version in their system if they happen to encounter an

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Lazar, Lijo
-gfx@lists.freedesktop.org; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] [Public] Hi all, Then the struct looks like: > +struct drm_amdgpu_info_vbios { > + __u8 name[64]; > + __u8 vb

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-18 Thread Nieto, David M
Best regards, Jiawei From: Nieto, David M Sent: Tuesday, May 18, 2021 12:40 PM To: Gu, JiaWei (Will) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] Y

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Gu, JiaWei (Will)
esday, May 18, 2021 12:40 PM To: Gu, JiaWei (Will) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] Yes, let's remove that too, Thanks, David

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Nieto, David M
Jiawei From: Nieto, David M Sent: Tuesday, May 18, 2021 10:45 AM To: Gu, JiaWei (Will) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Intern

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Gu, JiaWei (Will)
, 2021 10:45 AM To: Gu, JiaWei (Will) ; Koenig, Christian ; amd-gfx@lists.freedesktop.org; mar...@gmail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] The serial number is ASIC informa

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Nieto, David M
: Monday, May 17, 2021 7:11 PM To: Koenig, Christian ; amd-gfx@lists.freedesktop.org ; Nieto, David M ; mar...@gmail.com ; Deucher, Alexander Cc: Deng, Emily Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] So I guess the dbdf

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Gu, JiaWei (Will)
ail.com; Deucher, Alexander Cc: Deng, Emily Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface I'm not very familiar with the technical background why we have the fields here once more. But of hand we should at least remove everything which is also available from the PCI inform

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Christian König
cher, Alexander Cc: Deng, Emily ; Gu, JiaWei (Will) Subject: [PATCH] drm/amdgpu: Add vbios info ioctl interface Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is us

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Gu, JiaWei (Will)
Cc: Deng, Emily ; Gu, JiaWei (Will) Subject: [PATCH] drm/amdgpu: Add vbios info ioctl interface Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-17 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the user to be able to display in a simple way the VBIOS version in their system if they happen to encounter an

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-09 Thread Kees Cook
Hi! This patch needs some fixing. On Thu, Apr 22, 2021 at 10:34:48AM +0800, Jiawei Gu wrote: > + case AMDGPU_INFO_VBIOS_INFO: { > + struct drm_amdgpu_info_vbios vbios_info = {}; > + struct atom_context *atom_context; > + > +

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-09 Thread Kees Cook
Gu, JiaWei (Will) ; Deucher, Alexander > > Cc: StDenis, Tom ; Deucher, Alexander > ; Christian König > ; Gu, JiaWei (Will) ; > amd-gfx@lists.freedesktop.org; Nieto, David M ; > linux-n...@vger.kernel.org > Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-08 Thread Nieto, David M
From: Kees Cook Sent: Saturday, May 8, 2021 2:51 AM To: Gu, JiaWei (Will) Cc: Deucher, Alexander ; StDenis, Tom ; Christian König ; amd-gfx@lists.freedesktop.org ; Nieto, David M ; linux-n...@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface On Sat, May 08

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-08 Thread Gu, JiaWei (Will)
Sent: Saturday, May 8, 2021 12:28 PM To: Gu, JiaWei (Will) ; Deucher, Alexander Cc: StDenis, Tom ; Deucher, Alexander ; Christian König ; Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org; Nieto, David M ; linux-n...@vger.kernel.org Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread StDenis, Tom
: [PATCH] drm/amdgpu: Add vbios info ioctl interface Please revert the patch in umr until the kernel side lands in upstream drm-next. Alex On Wed, Apr 28, 2021 at 7:30 AM StDenis, Tom wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Hi Will, > > I've merged in

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Alex Deucher
f it was reverted before? > > Thanks in advance! > Jiawei > > From: Gu, JiaWei (Will) > Sent: Wednesday, April 28, 2021 4:21 PM > To: Christian König ; Nieto, David M > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; StDenis, Tom > > Subject: RE: [PATCH] d

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread StDenis, Tom
, David M; amd-gfx@lists.freedesktop.org; StDenis, Tom Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] Hi @StDenis, Tom<mailto:tom.stde...@amd.com>, We have merged vbios info ioctl patch. Could you h

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Gu, JiaWei (Will)
, 2021 4:21 PM To: Christian König ; Nieto, David M ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; StDenis, Tom Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] Thanks Christian, I amended the commit message and

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Gu, JiaWei (Will)
; Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; StDenis, Tom Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface Yeah, makes sense. Please note that in the commit message. With that feel free to put an Acked-by: Christian König <mailto:christian.

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Provides a way for the user application to get the VBIOS information without having to parse the binary. It is useful for the user to be able to display in a simple way the VBIOS version in their system if they happen to encounter an

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Christian König
.freedesktop.org> <mailto:amd-gfx@lists.freedesktop.org> *Cc: *"Deucher, Alexander" <mailto:alexander.deuc...@amd.com>, "StDenis, Tom" <mailto:tom.stde...@amd.com>, "Nieto, David M" <mailto:david.ni...@amd.com&g

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Nieto, David M
sts.freedesktop.org" Cc: "Deucher, Alexander" , "StDenis, Tom" Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface Well displaying the VBIOS information along with the other firmware in userspace is certainly useful. We should just avoid making strong dep

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Christian König
uot; *Cc: *"Deucher, Alexander" , "StDenis, Tom" , "Nieto, David M" *Subject: *RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] Hi Christian, It will be used by a user space SMI-lib for GPU status query.

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-28 Thread Nieto, David M
ot;Gu, JiaWei (Will)" Date: Thursday, April 22, 2021 at 8:25 PM To: Christian König , "amd-gfx@lists.freedesktop.org" Cc: "Deucher, Alexander" , "StDenis, Tom" , "Nieto, David M" Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD O

RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-22 Thread Gu, JiaWei (Will)
, 2021 9:27 PM To: Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; StDenis, Tom Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface Is that useful to Vulkan/OpenGL/other clients in any way? Christian. Am 22.04.21 um 15:18 schrieb Gu, JiaWei (Will): CC

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-22 Thread Christian König
Is that useful to Vulkan/OpenGL/other clients in any way? Christian. Am 22.04.21 um 15:18 schrieb Gu, JiaWei (Will): CC Tom. On Apr 22, 2021, at 21:09, Gu, JiaWei (Will) wrote: <[v2][umr]add-vbios-info-query.patch> UMR patch which calls this new IOCTL attached. Best regards, Jiawei On

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-22 Thread Gu, JiaWei (Will)
CC Tom. > On Apr 22, 2021, at 21:09, Gu, JiaWei (Will) wrote: > > <[v2][umr]add-vbios-info-query.patch> > UMR patch which calls this new IOCTL attached. > > Best regards, > Jiawei > >> On Apr 22, 2021, at 10:34, Jiawei Gu wrote: >> >> Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-22 Thread Gu, JiaWei (Will)
UMR patch which calls this new IOCTL attached. Best regards, Jiawei > On Apr 22, 2021, at 10:34, Jiawei Gu wrote: > > Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. > > Signed-off-by: Jiawei Gu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++ >

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-21 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++ drivers/gpu/drm/amd/amdgpu/atom.c | 158 + drivers/gpu/drm/amd/amdgpu/atom.h | 11 ++

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-14 Thread Alex Deucher
On Wed, Apr 14, 2021 at 5:09 AM Jiawei Gu wrote: > > Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Please provide a link to patches for an open source tool which uses this new query. > > Signed-off-by: Jiawei Gu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++ >

[PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-04-14 Thread Jiawei Gu
Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info. Signed-off-by: Jiawei Gu --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++ drivers/gpu/drm/amd/amdgpu/atom.c | 158 + drivers/gpu/drm/amd/amdgpu/atom.h | 11 ++