problem
quickly, we ended up to not overwrite the VM size for all Raven VMs.
Regards,
Yong
From: Christian König
Sent: Monday, December 18, 2017 4:22:43 AM
To: Felix Kühling; Zhao, Yong; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix a bug that
The problem was a merge conflict.
No idea what exactly went wrong, but Yong ended up with a branch where
the vm_size was always overwritten with the value 64.
So we can completely drop this patch and yes when an user overrides the
vm_size value he/she should know what the consequences are.
Is there a way to override the VM size for KFD VMs only? Only they
depend on ATS, so only they need to be forced to be 48-bits.
On the other hand, it could be argued that a user who manually sets the
VM size with a module parameter knows what they're doing. So let them
break ATS.
Regards,
Felix
Hi Yong,
How should deal with that or can you come up with a fix?
well that is the expected effect. So I don't see much we can do here.
Support for the parameter was added to be able to intentionally break
support for HMM/SVM for testing the fall back paths.
Didn't thought about ATC while e
Change-Id: Id522c1cbadb8c069720f4e64a31cff42cd014733
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 709587d..93500e6 1006
Hi Christian,
I don't know much about the background. But according to my experiments,
as long as we change the vm size to 64G, ATC memory access on Raven will
fall apart. How should deal with that or can you come up with a fix?
Regards,
Yong
On 2017-12-14 03:47 AM, Christian König wrote:
NAK, that really circumvents the intention of the patch to adjust the
number of levels based on the vm_size.
Christian.
Am 14.12.2017 um 03:25 schrieb Yong Zhao:
Change-Id: Id522c1cbadb8c069720f4e64a31cff42cd014733
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
Change-Id: Id522c1cbadb8c069720f4e64a31cff42cd014733
Signed-off-by: Yong Zhao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 709587d..3b9eb1a 1006
