Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-04-17 Thread Christian König
Am 14.04.23 um 18:22 schrieb Alan Liu: [Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During gpu-reset, we will disable and enable vblank irq in dm_suspend() and dm_resume(). Later on in

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-04-16 Thread Liu, HaoPing (Alan)
Hi André Thanks for your comment, please see inline. On 2023/4/15 上午 05:11, André Almeida wrote: Hi Alan, Em 14/04/2023 13:22, Alan Liu escreveu: [Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-04-14 Thread André Almeida
Hi Alan, Em 14/04/2023 13:22, Alan Liu escreveu: [Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During gpu-reset, we will disable and enable vblank irq in dm_suspend() and dm_resume(). Later on in

[PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-04-14 Thread Alan Liu
[Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During gpu-reset, we will disable and enable vblank irq in dm_suspend() and dm_resume(). Later on in amdgpu_irq_gpu_reset_resume_helper(), we will check irqs' refcount

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-31 Thread Christian König
- From: Christian König Sent: Tuesday, March 28, 2023 7:16 PM To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org Cc: Lakha, Bhawanpreet Subject: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset Am 27.03.23 um 17:20 schrieb Alan Liu: [Why] After gpu-reset, sometimes

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-31 Thread Christian König
, March 28, 2023 3:00 AM To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org Cc: Lakha, Bhawanpreet Subject: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset Hi, That's a good fix. Some questions and comments below: On 2023-03-27 11:20, Alan Liu wrote: [Why] After gpu

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Harry Wentland
;>> Hi Christian, >>> >>>   >>> >>> Thanks for the review. Please see inline. >>> >>>   >>> >>> Best Regards, >>> >>> Alan >>> >>>   >>> >>> -Original Message----- >

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Alex Deucher
t; > Alan > > > > -Original Message- > From: Christian König > Sent: Tuesday, March 28, 2023 7:16 PM > To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org > Cc: Lakha, Bhawanpreet > Subject: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset > >

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Luben Tuikov
view. Please see inline. >> >>   >> >> Best Regards, >> >> Alan >> >>   >> >> -Original Message- >> From: Christian König >> Sent: Tuesday, March 28, 2023 7:16 PM >> To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org >>

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Luben Tuikov
> -Original Message- > From: Tuikov, Luben > Sent: Tuesday, March 28, 2023 3:00 AM > To: Liu, HaoPing (Alan) ; amd-gfx@lists.freedesktop.org > Cc: Lakha, Bhawanpreet > Subject: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset > >   > > Hi, >

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Christian König
@lists.freedesktop.org Cc: Lakha, Bhawanpreet Subject: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset Am 27.03.23 um 17:20 schrieb Alan Liu: > [Why] > After gpu-reset, sometimes the driver would fail to enable vblank irq, > causing flip_done timed out and the desktop freezed. &g

RE: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Liu, HaoPing (Alan)
: Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset Am 27.03.23 um 17:20 schrieb Alan Liu: > [Why] > After gpu-reset, sometimes the driver would fail to enable vblank irq, > causing flip_done timed out and the desktop freezed. > > During gpu-reset, we will disable an

RE: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-30 Thread Liu, HaoPing (Alan)
: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset Hi, That's a good fix. Some questions and comments below: On 2023-03-27 11:20, Alan Liu wrote: > [Why] > After gpu-reset, sometimes the driver would fail to enable vblank irq, > causing flip_done timed out and the deskto

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-28 Thread Christian König
Am 27.03.23 um 17:20 schrieb Alan Liu: [Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During gpu-reset, we will disable and enable vblank irq in dm_suspend() and dm_resume(). Later on in

Re: [PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-27 Thread Luben Tuikov
Hi, That's a good fix. Some questions and comments below: On 2023-03-27 11:20, Alan Liu wrote: > [Why] > After gpu-reset, sometimes the driver would fail to enable vblank irq, > causing flip_done timed out and the desktop freezed. > > During gpu-reset, we will disable and enable vblank irq in

[PATCH] drm/amdgpu: Fix desktop freezed after gpu-reset

2023-03-27 Thread Alan Liu
[Why] After gpu-reset, sometimes the driver would fail to enable vblank irq, causing flip_done timed out and the desktop freezed. During gpu-reset, we will disable and enable vblank irq in dm_suspend() and dm_resume(). Later on in amdgpu_irq_gpu_reset_resume_helper(), we will check irqs' refcount