Às 01:56 de 22/07/22, Roy Sun escreveu:
> The comments say that the product number is a 16-digit HEX string so the
> buffer needs to be at least 17 characters to hold the NUL terminator. Expand
> the buffer size to 20 to avoid the alignment issues.
>
> The comment:Product number should only be 16
Reviewed-by: Alex Deucher
On Mon, Jul 25, 2022 at 3:29 AM Sun, Roy wrote:
>
> [AMD Official Use Only - General]
>
> Ping
>
> -Original Message-
> From: Roy Sun
> Sent: Friday, July 22, 2022 12:57 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Sun, Roy
>
[AMD Official Use Only - General]
Ping
-Original Message-
From: Roy Sun
Sent: Friday, July 22, 2022 12:57 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sun, Roy
Subject: [PATCH] drm/amdgpu: Fix the incomplete product number
The comments say that the product number is a 16-digit HEX string
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator. Expand
the buffer size to 20 to avoid the alignment issues.
The comment:Product number should only be 16 characters. Any
more,and something could be
Às 05:26 de 20/07/22, Roy Sun escreveu:
> The comments say that the product number is a 16-digit HEX string so the
> buffer needs to be at least 17 characters to hold the NUL terminator.
>
> Signed-off-by: Roy Sun
> ---
Reviewed-by: André Almeida
...but I would appreciate a more detailed
Am 20.07.22 um 16:26 schrieb André Almeida:
Às 05:26 de 20/07/22, Roy Sun escreveu:
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
Which comment?
In internal documentation of the eeprom layout I
Às 05:26 de 20/07/22, Roy Sun escreveu:
> The comments say that the product number is a 16-digit HEX string so the
> buffer needs to be at least 17 characters to hold the NUL terminator.
>
Which comment?
> Signed-off-by: Roy Sun
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
> 1 file
Am 20.07.22 um 10:26 schrieb Roy Sun:
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
Signed-off-by: Roy Sun
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file
[AMD Official Use Only - General]
Double checked.
BR
Roy
From: Roy Sun
Sent: Wednesday, July 20, 2022 4:26 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sun, Roy
Subject: [PATCH] drm/amdgpu: Fix the incomplete product number
The comments say that the product
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
Signed-off-by: Roy Sun
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Am 18.07.22 um 14:08 schrieb yehonsun:
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
The comments say that the product number is a 16-digit HEX string so the
buffer needs to be at least 17 characters to hold the NUL terminator.
12 matches
Mail list logo
