Re: [PATCH] drm/amdgpu: Forbid kfd using cpu to update pt if vm is shared with gfx

2023-06-22 Thread Christian König
I have no problem dropping the AMDGPU_GEM_CREATE_NO_CPU_ACCESS flag from page tables no matter if we have large BAR or not. That should only be necessary when BOs are pinned and since we never pin page tables it shouldn't matter. Just set AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED after switching

Re: [PATCH] drm/amdgpu: Forbid kfd using cpu to update pt if vm is shared with gfx

2023-06-21 Thread Felix Kuehling
Can we change the flags if needed. E.g. see what amdgpu_bo_pin_restricted does: if (!(bo->flags & AMDGPU_GEM_CREATE_NO_CPU_ACCESS)) bo->flags |= AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED; amdgpu_bo_placement_from_domain(bo, domain); This shouldn't really change anyth

[PATCH] drm/amdgpu: Forbid kfd using cpu to update pt if vm is shared with gfx

2023-06-21 Thread YuBiao Wang
If a same GPU VM is shared by kfd and graphic operations, we must align the vm update mode to sdma, or cpu kmap will fail and cause null pointer issue. Signed-off-by: YuBiao Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm