Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-21 Thread Christian König
Am 17.05.24 um 17:46 schrieb Alex Deucher: On Fri, May 17, 2024 at 2:35 AM Christian König wrote: Am 16.05.24 um 19:57 schrieb Tim Van Patten: From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-19 Thread Tim Van Patten
> Fair enough, but this is also the only gfx9 APU which defaults to > noretry=1, all of the rest are dGPUs. I'd argue it should align with > the other GFX9 APUs or they should all enable noretry=1. Do you mean we should remove all IP_VERSION(9, X, X) entries from amdgpu_gmc_noretry_set(),

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-19 Thread Tim Van Patten
On Fri, May 17, 2024 at 12:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 1:27 PM Tim Van Patten wrote: > > > Fair enough, but this is also the only gfx9 APU which defaults to > > noretry=1, all of the rest are dGPUs. I'd argue it should align with > > the other GFX9 APUs or they should all enable noretry=1. > > Do you mean we should remove all

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Alex Deucher
On Fri, May 17, 2024 at 2:35 AM Christian König wrote: > > Am 16.05.24 um 19:57 schrieb Tim Van Patten: > > From: Tim Van Patten > > > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > > 9.3.0: > > > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > >

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-17 Thread Christian König
Am 16.05.24 um 19:57 schrieb Tim Van Patten: From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is

Re: [PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Alex Deucher
Applied. Thanks! Alex On Thu, May 16, 2024 at 3:46 PM Tim Van Patten wrote: > > From: Tim Van Patten > > The following commit updated gmc->noretry from 0 to 1 for GC HW IP > 9.3.0: > > commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") > > This causes the device to hang when

[PATCH] drm/amdgpu: Remove GC HW IP 9.3.0 from noretry=1

2024-05-16 Thread Tim Van Patten
From: Tim Van Patten The following commit updated gmc->noretry from 0 to 1 for GC HW IP 9.3.0: commit 5f3854f1f4e2 ("drm/amdgpu: add more cases to noretry=1") This causes the device to hang when a page fault occurs, until the device is rebooted. Instead, revert back to gmc->noretry=0 so