rted defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Your patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKP
op.org; Zhang, Bokun
; Deucher, Alexander
Cc: Xiao, Jack ; Wang, Yang(Kevin) ;
Xu, Feifei ; Chen, Horace ; Tuikov,
Luben ; Sohail, Rashid ; Quan,
Evan ; Liu, Monk ; Zhang, Hawking
Subject: RE: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
[AMD Official Use
.org; Zhang, Bokun
Cc: Quan, Evan ; Chen, Horace
; Tuikov, Luben ; Deucher,
Alexander ; Xiao, Jack ;
Zhang, Hawking ; Liu, Monk ;
Xu, Feifei ; Wang, Yang(Kevin)
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code l
: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Feel free to add my Acked-by: Christian König to the
patch.
Luben might have some additional comments, but in general I think the biggest
problem here is the mail settings.
Somehow either the mail client or the
; Zhang, Bokun
Cc: Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Deucher,
Alexander ; Xiao, Jack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin) ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code
; Chen, Horace ; Tuikov,
Luben ; Deucher, Alexander ;
Xiao, Jack ; Zhang, Hawking ; Liu,
Monk ; Xu, Feifei ; Wang, Yang(Kevin)
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Yeah, I mean the code looks correct.
It's just
fei ; Wang, Yang(Kevin) ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi,
Applying this patch to amd-staging-drm-next, with checkpatch.pl enabled,
generates the following output. Perhaps those issues should be address and
fix
> Thanks,
> Christian.
>
> Am 08.11.22 um 14:49 schrieb Chang, HaiJun:
>> [AMD Official Use Only - General]
>>
>> + Bokun to help addressing the coding style problem in MKM side.
>>
>> -Original Message-
>> From: Koenig, Christian
>> S
ssage-
From: Bokun Zhang
Sent: Tuesday, November 8, 2022 12:29 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Bokun ; Liu01, Tong (Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
- Move TMR region from top of FB to 2MB for FFBM, so we ne
vram reservation logic based on
vram_usagebyfirmware_v2_2
- Move TMR region from top of FB to 2MB for FFBM, so we need to
reserve TMR region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
Signed-off-by: Bokun Zhang
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
- Move TMR region from top of FB to 2MB for FFBM, so we need to
reserve TMR region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
Signed-off-by: Bokun Zhang
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd/amdgpu/amdgp
hang, HaiJun:
>> [AMD Official Use Only - General]
>>
>> + Bokun to help addressing the coding style problem in MKM side.
>>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Tuesday, November 8, 2022 8:53 PM
>> To: Liu01, Tong (Esther)
ander ; Xiao, Jack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin) ; Chang, HaiJun
; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi Esther
well there are a couple of things which you need to address before getting
; Deucher, Alexander ;
Xiao, Jack ; Zhang, Hawking ; Liu,
Monk ; Xu, Feifei ; Wang, Yang(Kevin)
; Chang, HaiJun ; Sohail, Rashid
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Hi Esther
well there are a couple of things which you need to address
van ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian
; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking
; Liu, Monk ; Xu, Feifei ; Wang, Yang(Kevin)
; Liu01, Tong (Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Move TMR region from top of FB to 2MB
ck ;
Zhang, Hawking ; Liu, Monk ; Xu,
Feifei ; Wang, Yang(Kevin) ; Liu01,
Tong (Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR
region firstly to make sure TMR can
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR
region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 50 +
d
Am 08.11.22 um 03:46 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR
region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd
@lists.freedesktop.org
Cc: Andrey Grodzovsky ; Quan, Evan
; Chen, Horace ; Tuikov, Luben
; Koenig, Christian ; Deucher,
Alexander ; Xiao, Jack ; Zhang,
Hawking ; Liu, Monk ; Xu, Feifei
; Wang, Yang(Kevin) ; Liu01, Tong
(Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR
region firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 50 +
d
Am 07.11.22 um 04:32 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
At few coding style things below, but looks good to me from the
technically side.
Please use the checkpatch.pl script, it
g
Cc: Andrey Grodzovsky ; Quan, Evan
; Chen, Horace ; Tuikov, Luben
; Koenig, Christian ; Deucher,
Alexander ; Xiao, Jack ; Zhang,
Hawking ; Liu, Monk ; Xu, Feifei
; Wang, Yang(Kevin) ; Liu01, Tong
(Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 51 +
d
; Tuikov, Luben
; Koenig, Christian ; Deucher,
Alexander ; Xiao, Jack ; Zhang,
Hawking ; Liu, Monk ; Xu, Feifei
; Wang, Yang(Kevin) ; Liu01, Tong
(Esther)
Subject: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Move TMR region from top of FB to 2MB for FFBM, so
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 106 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 52 +
d
; Xu, Feifei ; Wang, Yang(Kevin)
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Am 04.11.22 um 09:52 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve
TMR region firstly to make sure TMR can be allocated a
ack ; Zhang, Hawking ; Liu, Monk
; Xu, Feifei ; Wang, Yang(Kevin)
Subject: Re: [PATCH] drm/amdgpu: add vram reservation logic based on
vram_usagebyfirmware_v2_2
Am 04.11.22 um 09:52 schrieb Tong Liu01:
> Move TMR region from top of FB to 2MB for FFBM, so we need to reserve
> TMR region first
Am 04.11.22 um 09:52 schrieb Tong Liu01:
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
If I understand it correctly the two methods are mutual exclusive. So I
think you can just extend the existing function in
Move TMR region from top of FB to 2MB for FFBM, so we need to reserve TMR region
firstly to make sure TMR can be allocated at 2MB
Signed-off-by: Tong Liu01
---
.../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 84 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 52
29 matches
Mail list logo
