RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Liu, Monk
ao, Yintian Sent: Tuesday, April 21, 2020 9:46 PM To: Koenig, Christian ; Liu, Monk ; He, Jacob ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: cleanup SPM VMID update Hi Christian Great. Then can you modify the patch according to Monk's suggestion? We need this patch fo

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Tao, Yintian
d-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: cleanup SPM VMID update > The problem is some fields are increased by hardware What are you talking about? The bits control what is used in the MC interface, there is no increment or anything here. > I think at least we should apply one chan

Re: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Christian König
: Re: [PATCH] drm/amdgpu: cleanup SPM VMID update Hi Monk, at least on Vega that should be fine. If the RLC should use anything else than 0 here we should update that together with the VMID. Regards, Christian. Am 21.04.20 um 11:54 schrieb Liu, Monk: Could only be that the firmware updates the

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Liu, Monk
PM To: Liu, Monk ; Koenig, Christian ; Tao, Yintian ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: Re: [PATCH] drm/amdgpu: cleanup SPM VMID update Hi Monk, at least on Vega that should be fine. If the RLC should use anything else than 0 here we should update that together

Re: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Christian König
ation Team |AMD -Original Message- From: Christian König Sent: Tuesday, April 21, 2020 5:52 PM To: Tao, Yintian ; Liu, Monk ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: Re: [PATCH] drm/amdgpu: cleanup SPM VMID update Am 21.04.20 um 11:45 schrieb Tao, Yi

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Liu, Monk
Gu, Frans Subject: Re: [PATCH] drm/amdgpu: cleanup SPM VMID update Am 21.04.20 um 11:45 schrieb Tao, Yintian: > > -Original Message- > From: Christian König > Sent: 2020年4月21日 17:10 > To: Liu, Monk ; Tao, Yintian ; > He, Jacob ; amd-gfx@lists.freedesktop.org >

Re: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Christian König
Am 21.04.20 um 11:45 schrieb Tao, Yintian: -Original Message- From: Christian König Sent: 2020年4月21日 17:10 To: Liu, Monk ; Tao, Yintian ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: [PATCH] drm/amdgpu: cleanup SPM VMID update The RLC SPM configuration register

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Liu, Monk
o, Yintian ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: [PATCH] drm/amdgpu: cleanup SPM VMID update The RLC SPM configuration register contains the information how the memory access is made (VMID, MTYPE, etc) which should always be consistent. So instead of a read modify w

RE: [PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Tao, Yintian
-Original Message- From: Christian König Sent: 2020年4月21日 17:10 To: Liu, Monk ; Tao, Yintian ; He, Jacob ; amd-gfx@lists.freedesktop.org Cc: Gu, Frans Subject: [PATCH] drm/amdgpu: cleanup SPM VMID update The RLC SPM configuration register contains the information how the memory

[PATCH] drm/amdgpu: cleanup SPM VMID update

2020-04-21 Thread Christian König
The RLC SPM configuration register contains the information how the memory access is made (VMID, MTYPE, etc) which should always be consistent. So instead of a read modify write cycle of the VMID always update the whole register. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu